From d247b8042e2ccc4f1e54e308887737c41259ee6e Mon Sep 17 00:00:00 2001
From: ekrctb <ekrctb@gmail.com>
Date: Mon, 5 Jul 2021 20:05:08 +0900
Subject: [PATCH] Fix default skin catcher not flipping catcher plate

When legacy beatmap skin is present but catcher is not provided, it was using the legacy setting (always false).
---
 .../Skinning/Legacy/CatchLegacySkinTransformer.cs          | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/osu.Game.Rulesets.Catch/Skinning/Legacy/CatchLegacySkinTransformer.cs b/osu.Game.Rulesets.Catch/Skinning/Legacy/CatchLegacySkinTransformer.cs
index b6f6e91c29..5e744ec001 100644
--- a/osu.Game.Rulesets.Catch/Skinning/Legacy/CatchLegacySkinTransformer.cs
+++ b/osu.Game.Rulesets.Catch/Skinning/Legacy/CatchLegacySkinTransformer.cs
@@ -108,8 +108,11 @@ namespace osu.Game.Rulesets.Catch.Skinning.Legacy
                     switch (config)
                     {
                         case CatchSkinConfiguration.FlipCatcherPlate:
-                            // Always return `false` (don't flip catcher plate contents) for a legacy skin.
-                            return (IBindable<TValue>)new Bindable<bool>();
+                            // Don't flip catcher plate contents if the catcher is provided by this legacy skin.
+                            if (GetDrawableComponent(new CatchSkinComponent(CatchSkinComponents.Catcher)) != null)
+                                return (IBindable<TValue>)new Bindable<bool>();
+
+                            break;
                     }
 
                     break;