Dan Balasescu
e6eea73b8b
Merge branch 'master' into basic-compose-checks
2021-04-30 23:41:46 +09:00
Dean Herbert
5b009c21bb
Merge branch 'master' into abstract-blueprint-handling
2021-04-29 16:10:22 +09:00
dependabot[bot]
1b3b07d6a9
Bump NUnit from 3.13.1 to 3.13.2
...
Bumps [NUnit](https://github.com/nunit/nunit ) from 3.13.1 to 3.13.2.
- [Release notes](https://github.com/nunit/nunit/releases )
- [Changelog](https://github.com/nunit/nunit/blob/v3.13.2/CHANGES.md )
- [Commits](https://github.com/nunit/nunit/compare/v3.13.1...v3.13.2 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-04-29 03:51:12 +00:00
Dean Herbert
6cadbd48dc
Merge pull request #12603 from smoogipoo/fix-score-processor-base-score
...
Fix bonus-only maps having only 700K base score
2021-04-28 17:30:58 +09:00
Dean Herbert
f3c7694eeb
Rename methods to match generally how these find-methods are named elsewhere
2021-04-28 16:57:52 +09:00
Dan Balasescu
53d93fecd1
Merge branch 'master' into fix-download-button-import-cancel-state
2021-04-28 16:51:31 +09:00
Dean Herbert
48d6c9ac4b
Move snap/divisor helper methods to inside ControlPointInfo
2021-04-28 16:47:30 +09:00
Dean Herbert
74bf4323d1
Merge pull request #12602 from smoogipoo/setting-source-custom-control
...
Add support for custom controls to SettingSourceAttribute
2021-04-28 16:39:17 +09:00
Dean Herbert
e71dbfd730
Add inline comment regarding remaining issues with classic scoring
2021-04-28 16:37:48 +09:00
Dean Herbert
8598a0968f
Update calculations in comments to match new logic
...
Mostly look to be errors that existed before this PR.
Co-authored-by: Endrik <enduslittlecomputer@gmail.com>
2021-04-28 16:29:23 +09:00
Dean Herbert
ac1534cda2
Add test covering existing button actually changing to LocallyAvailable
state
2021-04-28 15:54:40 +09:00
smoogipoo
61b7dc1e06
Fix bonus-only maps having 700K base score
2021-04-28 03:42:29 +09:00
smoogipoo
4e3ee77396
Add support for custom controls to SettingSourceAttribute
2021-04-28 02:51:24 +09:00
Dan Balasescu
5fc731967b
Merge pull request #12592 from ekrctb/fix-entry-lifetime
...
Fix Setting DHO's lifetime doesn't update its entry lifetime
2021-04-28 01:38:19 +09:00
Naxess
b8b6d0e861
Add tests for ClosestBeatDivisor
...
Used https://github.com/ppy/osu/pull/12558/files#diff-5c1f04c5b262ca3abbaf867aa91b62a60b66691323c286ad5aa0b75c153cc6ca as reference.
2021-04-27 16:54:47 +02:00
smoogipoo
baa6e845aa
Change to fluent assertions
2021-04-27 22:43:52 +09:00
smoogipoo
3b04aed491
Add failing test
2021-04-27 22:42:58 +09:00
Naxess
200352b750
Rename unsnap check templates
2021-04-27 13:56:05 +02:00
Dean Herbert
f2e56bd306
Refactor editor selection/blueprint components to be generic
2021-04-27 19:01:29 +09:00
ekrctb
003553aba3
Add test of HitObjectLifetimeEntry.KeepAlive behavior
2021-04-27 18:10:44 +09:00
ekrctb
7980d16b4c
Add failing test showing the issue of DHO lifetime
2021-04-27 14:26:12 +09:00
Naxess
0f0870c8b8
Sort objects by time in concurrent check test
2021-04-27 00:36:26 +02:00
Naxess
ce258febf6
Rename CheckUnsnaps
-> CheckUnsnappedObjects
...
Will potentially have `CheckUnsnappedKiai` or similar later, so this is worth specifying.
Also consistent with `CheckConcurrentObjects`, which will likely have a `CheckConcurrentLines` later.
2021-04-26 20:32:44 +02:00
Naxess
b8cdcf56c0
Add concurrent object check tests
2021-04-26 20:22:24 +02:00
Naxess
71f880aa94
Fix duplicate code in unsnap test
2021-04-26 17:44:46 +02:00
Naxess
9178aa1d7d
Add unsnap check tests
2021-04-26 04:48:56 +02:00
smoogipoo
0ee73b8e53
Add failing test
2021-04-22 23:22:44 +09:00
Dan Balasescu
be8fe47f2c
Merge branch 'master' into editor-add-nudge-shortcuts
2021-04-22 20:38:34 +09:00
Dan Balasescu
b774f5b72b
Merge pull request #12526 from peppy/fix-system-message-ordering
...
Fix system messages always being displayed above standard messages
2021-04-22 18:51:25 +09:00
Dan Balasescu
0e24f2eb59
Merge pull request #12529 from peppy/editor-placement-right-click-delete
...
Allow shift+right-click deletion when in placement mode
2021-04-22 18:50:20 +09:00
Dean Herbert
a5364b224f
Add simple key based time nudging support to editor
2021-04-22 18:47:04 +09:00
Dean Herbert
daafa41dc1
Merge branch 'master' into fix-initial-spectator-state-callback
2021-04-22 16:22:04 +09:00
Dean Herbert
cf1e3ea988
Add failing test covering quick shift-rightclick deletion in placement mode
2021-04-22 15:44:12 +09:00
Dean Herbert
ea3bb07924
Add test that fails on incorrect system/info message ordering
2021-04-22 14:51:14 +09:00
smoogipoo
31c5fb350f
Merge branch 'master' into gcc-abstraction
2021-04-21 16:33:36 +09:00
Bartłomiej Dach
a2afa38a3f
Merge branch 'master' into fix-mod-customisation-input-blocking-padding
2021-04-20 19:41:25 +02:00
Bartłomiej Dach
881043bc5d
Fix failing test after mod settings layout changes
...
The slight hack which was used in the test to ensure that the mod
settings overlay covered the entire width of the mod overlay broke after
adjustments to the layout in the previous commit.
Locally adjust the hack to use the parent of the `ModSettingsContainer`
rather than the container itself.
2021-04-20 19:38:25 +02:00
Dean Herbert
26430e3cb5
Merge pull request #12492 from Naxesss/bg-audio-quality-checks
...
Add background and audio checks
2021-04-21 00:10:32 +09:00
smoogipoo
156a518068
Merge branch 'master' into fix-initial-spectator-state-callback
2021-04-20 21:16:05 +09:00
Naxess
c0318a4d3e
Fix usage of _ in Moq lambdas
2021-04-20 13:29:14 +02:00
Naxess
6a1e4ff99f
Add file hash to file presence test
...
Necessary because we now find the storage path of the file rather than just the file itself.
2021-04-20 13:28:32 +02:00
smoogipoo
c5d6b6ea8d
Fix tests failing intermittently
...
This was due to this code happening in UpdateAfterChildren(), after the
GCC has processed one frame. During this time, the clock could have
advanced an arbitrary amount.
The cause of this is the removal of the Task.Run() to set the clock in
Restart() (now called Reset()) which changed the timing, so it only worked before due to pure
luck.
2021-04-20 18:41:09 +09:00
smoogipoo
f144661c31
Fix storyboard sample test scene
2021-04-20 18:26:30 +09:00
smoogipoo
5da18c51a4
Fix compile error
2021-04-20 17:27:37 +09:00
smoogipoo
80473a356e
Merge branch 'fix-pre-seek-sample-lifetime' into gcc-abstraction
2021-04-20 17:27:01 +09:00
smoogipoo
281c2041b2
Add failing test
2021-04-20 16:51:00 +09:00
smoogipoo
88ded95e75
Ensure clock is set in GCC.Start()
2021-04-20 13:56:13 +09:00
Naxess
0e6b66f457
Merge branch 'master' into bg-audio-quality-checks
2021-04-20 02:36:13 +02:00
Naxess
2bb079ea14
Add audio quality check tests
2021-04-20 01:36:15 +02:00
Naxess
be6a02a17e
Simplify background quality test names
2021-04-20 01:32:22 +02:00