Salman Ahmed
69dac018c7
Make OsuModSpinIn as incompatible with other IHidesApproachCircles mods
...
Respecting the TODO comment above it, mark `OsuModSpinIn` as
incompatible with other `IHidesApproachCircles` mods as well.
2021-06-28 21:20:07 +03:00
Salman Ahmed
baf736026b
Mark IHidesApproachCircles mods as incompatible with IRequiresApproachCircles
2021-06-28 21:20:07 +03:00
Salman Ahmed
01478d780d
Generalize IHasSpinnerApproachCircle from being spinner-specifc
2021-06-21 03:43:11 +03:00
Salman Ahmed
c04b09520d
Replace spinner approach circle proxying logic with hooking up to OnSkinChange in mod
2021-06-19 20:06:28 +03:00
Salman Ahmed
843c8bd7a4
Move spinner approach circle to its own SkinnableDrawable
2021-06-18 20:33:50 +03:00
Salman Ahmed
f7b5341663
Merge branch 'master' into legacy-spinner-approach-circle
2021-06-18 19:50:52 +03:00
Dean Herbert
860626152a
Mark all mods which adjust approach circle as incompatible with each other
...
Closes https://github.com/ppy/osu/issues/13543 .
2021-06-18 13:21:53 +09:00
Salman Ahmed
c9458fd9ce
Hide spinner approach circle in "Hidden" mod
2021-06-18 06:23:54 +03:00
PercyDan54
63ac430386
Rename startTime in parameters
2021-05-15 11:26:16 +08:00
PercyDan54
a4c1b9a1a7
Rename startTime to fadeStartTime
2021-05-14 21:56:13 +08:00
PercyDan54
a86a4bab91
Remove empty override
2021-05-14 21:55:32 +08:00
PercyDan54
393ac4fdd1
Destruct declaration
2021-05-14 21:30:58 +08:00
PercyDan54
67dfeeb1b7
Cleanup code in ModHidden
2021-05-14 21:29:13 +08:00
Bartłomiej Dach
4d739f11a8
Fix spinner ticks getting increased visibility state
...
Regressed in #10696 . The old `IsFirstHideableObject()` method did not
consider nested hitobjects, while its replacement -
`IsFirstAdjustableObject()` - did. Therefore, spinner ticks could be
considered first adjustable objects, breaking the old logic.
There is no need to match over `SpinnerBonusTick`, as it inherits from
`SpinnerTick`.
2020-12-03 22:51:59 +01:00
smoogipoo
e3bbc2b128
Rework osu! hidden mod to avoid storing hitobjects
2020-12-03 14:45:56 +09:00
smoogipoo
1e05fd48e2
Fix hidden mod crash
2020-11-13 23:08:27 +09:00
Bartłomiej Dach
0ae6f82291
Fix incorrect fade of slider ends after a rewind
2020-11-12 09:33:39 +01:00
smoogipoo
5d55af5818
Fix hitobjects sometimes not fading in completely with HD mod
2020-11-11 16:35:48 +09:00
smoogipoo
d1fa391d25
Make OsuModHidden apply fadein adjustment on custom state update
2020-11-05 16:12:55 +09:00
smoogipoo
628b8be15d
Implement ModWithVisibilityAdjustment
2020-11-05 15:40:25 +09:00
Dean Herbert
febfe9cdd0
Don't fade the approach circle on increased visibility
2020-10-09 18:43:16 +09:00
Dean Herbert
2d0275ba95
Fix first hitobject in osu! hidden mod not getting correct fade applied
2020-10-09 03:07:01 +09:00
Dean Herbert
5a6c45e2ff
Fix hidden mod support for sliderendcircle
2020-10-02 18:41:28 +09:00
Dean Herbert
023feaf438
Refactor to centralise implementation into a single component
...
Turns out this is a better way forward.
2020-07-29 22:31:52 +09:00
Dean Herbert
9dda7da489
Fix spinners being considered the "first object" for increased visibility in hidden
2020-04-16 14:11:38 +09:00
Huo Yaoyuan
c0fe91a84c
Merge branch 'master' into sharpen
2019-11-26 18:21:50 +08:00
Dean Herbert
709ec1404f
Centralise End/StartTime retrieval to extension method
2019-11-25 19:09:14 +09:00
Huo Yaoyuan
144812669d
Use static local functions.
2019-11-12 19:56:54 +08:00
Dean Herbert
9c9cb8e217
Merge remote-tracking branch 'upstream/master' into traceable-mod
2019-09-18 19:36:07 +09:00
Dean Herbert
4204ba6014
Merge branch 'master' into spin-in
2019-07-28 22:51:09 +09:00
MaxOhn
5b4640d3ea
Traceable no longer inherits from OsuModHidden and is no longer multi mod
2019-07-03 21:40:14 +02:00
MaxOhn
664257fbbe
Sliders no longer modified by HD but have transparent body now
2019-07-03 18:42:02 +02:00
MaxOhn
4145173ac9
Combined hidden with traceable as multi mod
2019-07-02 04:04:07 +02:00
MaxOhn
5496b8bc58
Rewrote traceable mod to inherit from hidden
2019-07-01 20:11:50 +02:00
Dean Herbert
c39c37a18d
Apply more missed cases
2019-04-01 12:44:46 +09:00
Dean Herbert
8617aaa2a7
Update licence header (and remove year)
2019-01-24 17:43:03 +09:00
Kyle Chang
51d26fb648
Now spin in mod; circles spin in
2018-09-20 19:09:58 -04:00
Dean Herbert
1d6609d9f3
Add common custom words to dotsettings dictionary
...
Also fixes some typos and reduces spelling suggestions to hints.
2018-07-05 15:54:41 +09:00
Dean Herbert
f253828d49
Fix regressions
2018-06-06 13:51:51 +09:00
Vidalee
16bcd6c3ed
Appvtests ( #1 )
...
* Resolving AppVeyor's errors
2018-05-08 14:33:26 +02:00
Vidalee
393c01ba90
Made the changes requested
2018-05-06 12:38:25 +02:00
Dean Herbert
76e58a51b9
Merge remote-tracking branch 'upstream/master' into Vidalee-osu-hd-setting
2018-04-25 17:28:21 +09:00
Dean Herbert
32a74f95a5
Normalize all the line endings
2018-04-13 18:26:38 +09:00
Vidalee
505a7c14fc
was persuaded I changed the if statement...
2018-03-21 21:14:17 +01:00
Vidalee
8159e219fd
increaseFirstObjectVisibility now cannot be null
2018-03-20 22:23:27 +01:00
Vidalee
cdbe6bf22d
cleared comment
2018-03-20 21:55:35 +01:00
Vidalee
4068be1293
cleared comment
2018-03-20 21:54:44 +01:00
Vidalee
9252203916
build fix
2018-03-20 18:23:41 +01:00
Vidalee
fea8f868d7
Fixing hidden test bug
2018-03-17 13:22:58 +01:00
Joseph Madamba
d122aa80e4
Edit mods description, multiplier, and code
2018-03-13 20:07:03 -07:00
