Bartłomiej Dach
ba1f6439bf
Disable redundant verbatim string prefix inspections
...
For some reason this started flaring up recently all over for me and
showing inspections all over, which are _technically_ valid, but
interfere with our convention of using verbatim string prefixes to
denote non-localisable strings. This, as a result, led to circular
inspections (addressing the r# inspection results in getting the
osu-localisation-analyser one, addresssing that one results in
getting the r# inspection back, etc. ad nauseam).
2023-08-28 12:44:57 +02:00
Bartłomiej Dach
97d1c6e9fc
Merge branch 'master' into carousel-difficulty-split
2023-08-28 11:07:43 +02:00
Bartłomiej Dach
b9795eb3d4
Fix changes to beatmap sets being undone on switching sort mode
2023-08-28 11:02:22 +02:00
Bartłomiej Dach
80ec18d117
Fix incorrect selection restore code in split case
...
The fallback to "any of the added sets" needs to be applied after
they've all been added, rather than with every added one. Otherwise, in
flows that expect a particular difficulty to be selected in the end
(such as exiting from editor) would end up switching away from the
edited beatmap.
2023-08-28 10:06:26 +02:00
Bartłomiej Dach
0af6cc1394
Fix online ID not being propagated in split difficulty mode
...
Would result in failures to re-download the beatmap in update flows, for
instance.
2023-08-28 10:05:59 +02:00
Bartłomiej Dach
6251803868
Add failing test coverage of selection not being retained on song select
2023-08-28 10:05:59 +02:00
Bartłomiej Dach
3a6920c306
Add failing test coverage of beatmap update flow w/ split diffs
2023-08-28 09:51:44 +02:00
Dean Herbert
10b1450138
Rename remove method to better explain return type being IEnumerable
2023-08-25 18:10:54 +09:00
Dean Herbert
84f4fab9cf
Adjust test to actually test diff splitting
2023-08-25 18:09:51 +09:00
Dean Herbert
d70df88fa0
Merge pull request #24645 from Dreamurrrr/Dreamurrrr-patch-1
...
Update README.md to include VS Code plugin prerequisites
2023-08-25 13:48:26 +09:00
Dreamurrrr
4fd165c0a7
Update README.md to include VS Code plugin prerequisites
2023-08-24 13:28:17 -05:00
Dean Herbert
1efd557b96
Merge pull request #24576 from nekodex/new-overlay-sfx
...
Update overlay pop-in/pop-out sample usage
2023-08-25 01:47:55 +09:00
Dean Herbert
bf0f4fddad
Localise non-overridden samples
2023-08-25 01:08:22 +09:00
Dean Herbert
35cdd6d866
Use string.Empty
2023-08-25 01:07:07 +09:00
Dean Herbert
89eeff515b
Reduce complexity of selection restore
2023-08-25 00:52:54 +09:00
Dean Herbert
9e94f38091
Fix typo in local variable
2023-08-24 18:33:15 +09:00
Dean Herbert
b471ab07a6
Fix typo in test step
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-08-24 18:30:59 +09:00
Dean Herbert
081fb308e1
Merge branch 'master' into new-overlay-sfx
2023-08-24 18:29:00 +09:00
Jamie Taylor
f4415a5bab
Add more detail to comment
2023-08-24 18:20:36 +09:00
Jamie Taylor
7ef5a71e91
Move PopIn/PopOut sample playback from WaveOverlayContainer to WaveContainer (so Multiplayer/Lounge plays the samples)
2023-08-24 18:13:23 +09:00
Jamie Taylor
2e27a476bb
Re-enable sample playback for PasswordEntryPopover and remove sampleJoin playback instead
2023-08-24 18:04:47 +09:00
Bartłomiej Dach
38e3459391
Fix broken assertion
2023-08-24 08:54:38 +02:00
Bartłomiej Dach
7f215f163f
Use reduced hittable range with autopilot active
2023-08-24 08:52:49 +02:00
Bartłomiej Dach
a316036460
Add failing test case for special autopilot hittable range
2023-08-24 08:52:49 +02:00
Bartłomiej Dach
ed2b1a0754
Contain entirety of legacy notelock badness inside the hit policy
2023-08-24 08:52:49 +02:00
Bartłomiej Dach
64b36a73b1
Rename test scene to match tested class
2023-08-24 08:52:49 +02:00
Bartłomiej Dach
48b3f7dced
Add test case covering stacks not shaking
2023-08-24 08:52:49 +02:00
Bartłomiej Dach
9ffc6cdd61
Add test case covering overlapping slider fail case
2023-08-24 08:52:49 +02:00
Bartłomiej Dach
a045cb71fc
Add assertions checking action type taken by legacy hit policy
2023-08-24 08:52:49 +02:00
Bartłomiej Dach
1f3121bdf2
Merge branch 'master' into stable-notelock
2023-08-24 08:52:43 +02:00
Bartłomiej Dach
b777b34cc0
Merge branch 'master' into stable-notelock
2023-08-24 08:43:59 +02:00
Bartłomiej Dach
90dfef2bb9
Merge pull request #24628 from bdach/export-note-lock-test-cases
...
Add capability to export ordered object policy test cases for stable crosscheck
2023-08-24 08:42:27 +02:00
Dean Herbert
981e0c1ad7
Rename export test step to better fit purpose
2023-08-24 14:26:26 +09:00
Bartłomiej Dach
7312d1147d
Merge branch 'master' into export-note-lock-test-cases
2023-08-24 07:17:38 +02:00
Dean Herbert
d01b065b4a
Merge pull request #24627 from bdach/no-custom-hitwindows
...
Rewrite `TestSceneObjectOrderedHitPolicy` to not rely on custom hitwindows
2023-08-24 13:50:06 +09:00
Dean Herbert
ba70d48d2c
Fix one more test probably going off-screen
2023-08-24 13:31:33 +09:00
Dan Balasescu
c8f42f73e8
Adjust mania hit windows with gameplay rate
2023-08-24 11:17:41 +09:00
Bartłomiej Dach
9ef0ae53d1
Merge pull request #24634 from peppy/enable-sentry-global-mode
...
Enable sentry "global mode" as per recommendation
2023-08-23 20:58:48 +02:00
Dean Herbert
4881130cae
Limit set/diff count in test to better fit on screen
2023-08-24 03:32:12 +09:00
Dean Herbert
a8e4237e34
Enable sentry "global mode" as per recommendation
...
Sentry documentation suggests this should be on for a client-facing app.
We haven't run into issues without it until now, but might as well set it correctly?
2023-08-24 03:23:18 +09:00
Bartłomiej Dach
8d24bf5049
Merge pull request #24632 from peppy/mod-bool-display-improvement
...
Show mod settings as "on" or "off" rather than "True" or "False"
2023-08-23 19:47:55 +02:00
Bartłomiej Dach
052bf2a6e0
Use alternative solution for timing offset woes on export
2023-08-23 13:54:34 +02:00
Dean Herbert
72d2715222
Show mod settings as "on" or "off" rather than "True" or "False"
2023-08-23 20:21:43 +09:00
Dean Herbert
d6aded3ac3
Update framework
2023-08-23 20:11:55 +09:00
Bartłomiej Dach
b1979954f5
Merge pull request #24631 from peppy/add-colon-mod-settings
...
Add missing colon in mod settings tooltip
2023-08-23 12:46:33 +02:00
Dean Herbert
5eac604f8b
Add coverage of selection retention when difficulties are split out
2023-08-23 19:44:42 +09:00
Dean Herbert
a64381f855
Add test coverage of add/remove when difficulties are split out
2023-08-23 19:43:08 +09:00
Dean Herbert
5555f73e97
Update test to match new behaviour
2023-08-23 19:38:18 +09:00
Dean Herbert
91c2cadb47
Add missing colon in mod settings tooltip
2023-08-23 19:13:32 +09:00
Bartłomiej Dach
64786aaee8
Adjust test cases slightly to avoid running into hitwindow edge issue
...
Some note lock test cases do not play out correctly when exported out
to stable due to a completely separate issue, namely #11311 .
Adjust the test cases for now to isolate failure vectors.
2023-08-23 10:43:48 +02:00
