Bartłomiej Dach
a5d515dd0c
Merge branch 'master' into editor-new-control-point-is-bettert
2022-06-01 19:48:17 +02:00
Dean Herbert
97bbbe6424
Merge pull request #18519 from ThePooN/sentry-release-prefix-fix
...
🚑 Fix use of illegal character in Sentry's release name scheme
2022-06-02 01:24:36 +09:00
Hugo "ThePooN" Denizart
384cdcbc40
🚑 Fix use of illegal character in Sentry's release name scheme
2022-06-01 18:12:29 +02:00
Dean Herbert
e4faeb677d
Merge pull request #18518 from ThePooN/sentry-release-prefix
...
🔧 Add prefix to Sentry release name
2022-06-02 01:06:08 +09:00
Hugo "ThePooN" Denizart
cb37dd74c1
🔧 Add prefix to Sentry release name
2022-06-01 17:19:33 +02:00
Dean Herbert
c55c3325a4
Remove unused using statements
2022-06-01 17:43:40 +09:00
Dean Herbert
7da302d707
Merge pull request #18444 from frenzibyte/editor-bottom-bar-shadow
...
Add shadow effect to bottom bar in editor
2022-06-01 16:00:08 +09:00
Dean Herbert
eac014738f
Merge branch 'master' into editor-bottom-bar-shadow
2022-06-01 14:55:50 +09:00
Dean Herbert
25941f6187
Use DeepClone
instead of reflection call
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-06-01 10:47:45 +09:00
Bartłomiej Dach
655a8fb4a2
Merge pull request #18504 from peppy/editor-waveform-main-row-background
...
Add background to main waveform row
2022-05-31 21:25:18 +02:00
Dean Herbert
8240b645b4
Copy attribute types from currently selected control point to new placements
2022-05-31 21:50:12 +09:00
Dean Herbert
f99bcb23a0
Automatically make first control point added to beatmap have timing data
2022-05-31 21:50:08 +09:00
Dean Herbert
c0804803fd
Add background to main waveform row
2022-05-31 18:35:52 +09:00
Dean Herbert
79a17fc86a
Merge pull request #17591 from hlysine/random-mod-slider-rotation
...
Allow object generation algorithm to rotate sliders
2022-05-31 15:57:26 +09:00
Dan Balasescu
0141958be6
Merge pull request #18497 from peppy/zip-archive-reader-avoid-memcpy
...
Use pooled memory for memory copies performed by `ZipArchiveReader`
2022-05-31 11:01:57 +09:00
Dean Herbert
1d5a156c15
Merge pull request #18427 from sw1tchbl4d3r/currently_playing_search
...
Add search bar for the `CurrentlyPlayingDisplay`
2022-05-30 23:03:00 +09:00
Dean Herbert
d6b18d87b8
Update framework
2022-05-30 20:22:26 +09:00
Dean Herbert
82a1ba1d46
Use pooled memory for memory copies performed by ZipArchiveReader
2022-05-30 20:22:26 +09:00
Dan Balasescu
98fe0cf3d5
Merge pull request #18495 from peppy/rename-chat-overlay
...
Remove "V2" suffix from `ChatOverlay` components
2022-05-30 18:45:02 +09:00
Dean Herbert
f65d2db77f
Remove "V2" suffix from ChatOverlay
components
2022-05-30 17:54:09 +09:00
Dean Herbert
9e678101cf
Merge pull request #18442 from jai-x/new-chat-announce-channel
...
Display Announce type channels separately in new chat overlay
2022-05-30 16:53:15 +09:00
Dean Herbert
5478ac21ea
Merge branch 'master' into currently_playing_search
2022-05-30 16:48:53 +09:00
Dan Balasescu
be998cdb0a
Merge pull request #18477 from frenzibyte/fix-timeline-context-menu
...
Fix context menu no longer opening for hitobjects in timeline
2022-05-30 11:49:06 +09:00
Dan Balasescu
779ec7d9db
Merge pull request #18487 from jai-x/remove-old-chat
...
Remove old chat overlay components
2022-05-30 11:04:05 +09:00
Bartłomiej Dach
ba0771f864
Merge pull request #18488 from peppy/more-chat-test-fixes
...
Fix some more chat tests failing intermittently
2022-05-29 22:24:52 +02:00
Dean Herbert
03deb336b2
Fix some more chat tests failing intermittently
...
```
TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : Channel 1 ready
--TearDown
at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
at osu.Framework.Threading.Scheduler.Update()
at osu.Framework.Graphics.Drawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
at osu.Framework.Platform.GameHost.UpdateFrame()
at osu.Framework.Threading.GameThread.processFrame()
at osu.Framework.Threading.GameThread.RunSingleFrame()
at osu.Framework.Threading.GameThread.<createThread>g__runWork|66_0()
at System.Threading.Thread.StartHelper.Callback(Object state)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
-----
One or more child tests had errors
Exception doesn't have a stacktrace
[runtime] 2022-05-29 19:29:09 [verbose]: 💨 Class: TestSceneChatOverlayV2
[runtime] 2022-05-29 19:29:09 [verbose]: 🔶 Test: TestSlowLoadingChannel
[runtime] 2022-05-29 19:29:09 [verbose]: Chat is now polling every 60000 ms
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #1 Setup request handler
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #2 Add test channels
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #3 Show overlay (slow-loading)
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #4 Join channel 1
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #5 Select channel 1
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #6 Channel 1 loading
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #7 Join channel 2
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #8 Select channel 2
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #9 Channel 2 loading
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #10 Finish channel 1 load
[runtime] 2022-05-29 19:29:09 [verbose]: 🔸 Step #11 Channel 1 ready
[runtime] 2022-05-29 19:29:09 [verbose]: 💥 Failed
[runtime] 2022-05-29 19:29:09 [verbose]: ⏳ Currently loading components (2)
[runtime] 2022-05-29 19:29:09 [verbose]: TestSceneChatOverlayV2+SlowLoadingDrawableChannel
[runtime] 2022-05-29 19:29:09 [verbose]: - thread: ThreadedTaskScheduler (LoadComponentsAsync (standard))
[runtime] 2022-05-29 19:29:09 [verbose]: - state: Loading
[runtime] 2022-05-29 19:29:09 [verbose]: TestSceneChatOverlayV2+SlowLoadingDrawableChannel
[runtime] 2022-05-29 19:29:09 [verbose]: - thread: ThreadedTaskScheduler (LoadComponentsAsync (standard))
[runtime] 2022-05-29 19:29:09 [verbose]: - state: Ready
[runtime] 2022-05-29 19:29:09 [verbose]: 🧵 Task schedulers
[runtime] 2022-05-29 19:29:09 [verbose]: LoadComponentsAsync (standard) concurrency:4 running:1 pending:0
[runtime] 2022-05-29 19:29:09 [verbose]: LoadComponentsAsync (long load) concurrency:4 running:0 pending:0
[runtime] 2022-05-29 19:29:09 [verbose]: 🎱 Thread pool
[runtime] 2022-05-29 19:29:09 [verbose]: worker: min 32 max 32,767 available 32,765
[runtime] 2022-05-29 19:29:09 [verbose]: completion: min 32 max 1,000 available 1,000
```
2022-05-30 04:34:10 +09:00
Jai Sharma
8f596520f3
Remove old chat overlay components
2022-05-29 20:08:43 +01:00
Dean Herbert
f53593553d
Merge pull request #18485 from bdach/fix-tick-display
...
Fix wrong sizing of editor timeline ticks
2022-05-30 04:03:48 +09:00
Bartłomiej Dach
c892ec83ef
Fix wrong sizing of editor timeline ticks
2022-05-29 20:15:17 +02:00
Bartłomiej Dach
e329c160b3
Simplify channel retrieval expression
2022-05-29 18:58:27 +02:00
Bartłomiej Dach
e69f8716cd
Fix incorrect indent size
2022-05-29 18:56:37 +02:00
Bartłomiej Dach
f9f8a32380
Merge branch 'master' into new-chat-announce-channel
2022-05-29 18:55:43 +02:00
Bartłomiej Dach
83c2b27b69
Merge pull request #18480 from peppy/fix-chat-overlay-v2-tests
...
Fix multiple intermittent failures in chat overlay tests
2022-05-29 16:51:13 +02:00
Dean Herbert
caee9e67b6
Centralise DrawableChannel
checks and account for async load delays
2022-05-29 23:16:26 +09:00
Bartłomiej Dach
cee66c51d6
Merge branch 'master' into fix-timeline-context-menu
2022-05-29 16:06:05 +02:00
Bartłomiej Dach
18f75d8c58
Remove redundant initialiser
2022-05-29 16:06:01 +02:00
Dean Herbert
c078c06902
Fix unsafe config fetching
2022-05-29 22:55:53 +09:00
Dean Herbert
186999c4eb
Merge pull request #18473 from peppy/fix-skin-changed-disposal
...
Fix potential `ObjectDisposedException` on realm notification in `SkinSection`
2022-05-29 22:43:47 +09:00
Dean Herbert
70c8a43961
Update framework
2022-05-29 21:31:20 +09:00
Dean Herbert
7c97719db1
Move Schedule
to only drawable pieces
2022-05-29 21:28:09 +09:00
Salman Ahmed
9cc5df9b13
Fix context menu no longer open on hitobjects in timeline
2022-05-29 15:23:32 +03:00
Salman Ahmed
12d5b355e4
Add failing test coverage
2022-05-29 15:23:32 +03:00
Dean Herbert
c7570fbce5
Fix potential ObjectDisposedException
on realm notification in SkinSection
2022-05-29 15:15:03 +09:00
Dean Herbert
20701edc23
Merge pull request #18459 from bdach/unobserved/convert-slider
...
Fix unobserved exceptions in multiple tests due to constructing `GameplayState` instances with unconverted beatmaps
2022-05-29 00:54:11 +09:00
Bartłomiej Dach
a8e1c5ba87
Fix remaining cases of incorrect GameplayState
construction in tests
...
Manual attempts to initialise replaced by a new `TestGameplayState`
helper for ease of use.
2022-05-28 15:23:29 +02:00
Bartłomiej Dach
dcf3d76954
Fix unobserved exceptions due to using unconverted beatmap
...
`TestSceneBeatmapSkinFallbacks` was locally caching a `GameplayState`
instance to fulfill dependencies of a
`SkinnableTargetComponentsContainer`. However, it was doing so using
`new TestBeatmap()`, which is a raw decoded beatmap that hasn't been
converted to any ruleset yet, which was causing failures in
`BeatmapDifficultyCache.GetTimedDifficultyAttributesAsync()` as that
method is expecting to receive a post-conversion, ready-for-gameplay
beatmap.
Resolve by proxying forward dependency instances from the
already-known-to-be-working `actualComponentsContainer`.
2022-05-28 15:23:29 +02:00
Bartłomiej Dach
1641918c51
Revert "Avoid throwing unobserved exception when PerformancePointsCounter
requests timed attributes"
...
This reverts commit 19b655d75b
.
2022-05-28 15:23:28 +02:00
Dean Herbert
10d0238e39
Merge pull request #18457 from bdach/unobserved/not-implemented
...
Fix unobserved exceptions in `TestSceneStatisticsPanel` due to unimplemented beatmap converter
2022-05-28 22:22:25 +09:00
Bartłomiej Dach
e18fec3d89
Fix unobserved exceptions due to unimplemented beatmap converter
...
`TestSceneStatisticsPanel` intends to check the operation of statistics
panels using dummy ruleset classes. However, `StatisticsPanel` relies on
being able to retrieve the playable beatmap, which requires a converter.
One was not provided by the dummy rulesets, therefore the retrieval
would fail with an unobserved exception.
To fix, add a barebones converter implementation that is enough for the
test to pass.
2022-05-28 14:10:57 +02:00
sw1tchbl4d3
ede3ab9dc0
Add OnFocus handler to CurrentlyPlayingDisplay
2022-05-28 12:04:44 +02:00