73838 Commits

This Branch

This Branch

All Branches

• Merge pull request #33586 from smoogipoo/fix-intermittent-mod-select-tests

  Fix intermittent online play mod select tests

  Dean Herbert · 2025-06-10 12:47:35 +09:00
  a5a3bd4eae
• Merge pull request #33579 from peppy/fix-beatmap-save-filename-discrepancy
  Bartłomiej Dach · 2025-06-09 16:26:52 +02:00
  d7d2fc884b
• Fix intermittent online play mod select tests
  Dan Balasescu · 2025-06-09 23:15:48 +09:00
  55a3ec5026
• Merge pull request #33584 from smoogipoo/fix-flaky-collections-test

  Fix flaky collections test

  Dan Balasescu · 2025-06-09 22:47:29 +09:00
  34cbfca157
• Merge pull request #33578 from bdach/solo-results-bad-conditional

  Fix presenting another user's score hiding local user's score on results screen

  Dan Balasescu · 2025-06-09 22:00:47 +09:00
  deb10e0cab
• Fix flaky collections test
  Dan Balasescu · 2025-06-09 21:53:19 +09:00
  83ce468c57
• Correct xmldoc of GetValidFilename() and make it intentionally scary
  Bartłomiej Dach · 2025-06-09 14:34:41 +02:00
  257fec8795
• Change lazer's valid filename method to match stable

  On revisiting the issue at hand, this honestly seems like the best way
  forward. It also addresses my concerns that with the method we were
  using, filenames could end up being half underscores.
  
  The main reason for choosing to change the lazer end is that stable's
  difficulty update process is based on sending the beatmap's filename to
  the server. This means that if we use a proposed fix of checking online
  ID, it will still mean beatmaps cannot be updated on stable (for all
  users which have downloaded the beatmap) if a mapper updates once on
  lazer.
  
  Implementation inspired by:
  
  - https://referencesource.microsoft.com/#mscorlib/system/io/path.cs,1144ad3c4eff3f24
  - https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameplayElements/Beatmaps/Beatmap.cs#L1575-L1590
  
  Closes #33060.

  Dean Herbert · 2025-06-09 19:44:12 +09:00
  81aaddca34
• Merge pull request #33577 from peppy/ssv2-sizing-adjust

  Adjust max sizing at song select slightly

  Bartłomiej Dach · 2025-06-09 11:35:04 +02:00
  fd5dc01220
• Fix presenting another user's score hiding local user's score on results screen

  Closes https://github.com/ppy/osu/issues/33567.

  Bartłomiej Dach · 2025-06-09 11:11:16 +02:00
  19114c7415
• Fix oversight in other test
  Bartłomiej Dach · 2025-06-09 11:01:45 +02:00
  348c727264
• Add failing test coverage
  Bartłomiej Dach · 2025-06-09 10:52:10 +02:00
  9707fd43f4
• Adjust max sizing at song select slightly
  Dean Herbert · 2025-06-09 17:31:58 +09:00
  4895f678a9
• Merge pull request #33312 from chris-ehmann/fix-drag-delete-bug

  Fix undo/redo being locked up when a MouseUp event occurs while an object is being dragged

  Bartłomiej Dach · 2025-06-09 10:26:01 +02:00
  909440ab7a
• Merge branch 'master' into fix-drag-delete-bug
  Bartłomiej Dach · 2025-06-09 09:17:52 +02:00
  44563c03f0
• Fix up test

  - Use constraints for better assert messages
  - Use `Editor.Undo()` rather than manual input manager synthesizing
    ctrl-z (ctrl-z is not a platform agnostic binding, see macOS)

  Bartłomiej Dach · 2025-06-09 09:16:19 +02:00
  35ff330e85
• Merge pull request #33570 from EVAST9919/selectv2-no-buffers

  Song Select V2: Fix GPU overhead on carousel scroll

  Dean Herbert · 2025-06-09 15:37:50 +09:00
  b323edefc8
• Merge pull request #33564 from tsunyoku/add-touch-device-ssv2

  Song Select V2: Use touch input detector

  Dean Herbert · 2025-06-09 15:31:32 +09:00
  69dc596779
• Remove BufferedContainers from songselectv2
  Andrei Zavatski · 2025-06-08 23:08:09 +03:00
  a03448af7f
• Use touch device detector in song select V2
  tsunyoku · 2025-06-08 14:08:26 +01:00
  be0c43b4ab
• Merge pull request #33545 from nobbele/selectv2-33524

  SongSelectV2: Calculate PP for leaderboard tooltip if missing

  Salman Alshamrani · 2025-06-08 10:35:09 +03:00
  0c479b625c
• Merge branch 'master' into selectv2-33524
  Salman Alshamrani · 2025-06-08 10:05:26 +03:00
  20c2b8d153
• Merge pull request #33553 from Joehuu/fix-ssv2-leaderboard-mods-input

  Fix mods blocking drag and right-click input on leaderboards

  Salman Alshamrani · 2025-06-08 09:48:55 +03:00
  cb8276f714
• Fix mods blocking drag and right-click input on leaderboards
  Joseph Madamba · 2025-06-07 19:10:17 -07:00
  4e97731161
• Move PerformanceStatisticRow into tooltip class
  nobbele · 2025-06-08 00:32:10 +02:00
  a89b7d27ad
• SongSelectV2: Calculate PP for leaderboard tooltip if missing
  nobbele · 2025-06-08 00:27:15 +02:00
  45c8891975
• Merge pull request #33514 from peppy/fix-potential-sets-changed-overhead

  Ensure `beatmapSetsChanged` code doesn't run during gameplay

  Dean Herbert · 2025-06-07 03:15:37 +09:00
  2025.607.1 2025.607.0 cb082da063
• Merge pull request #33509 from Joehuu/fix-loading-spinner-clipping

  Fix loading spinner without a box clipping

  Dean Herbert · 2025-06-07 03:06:36 +09:00
  4fef1e10e3
• Merge branch 'master' into fix-potential-sets-changed-overhead
  Dean Herbert · 2025-06-07 02:30:20 +09:00
  f183496d19
• Merge pull request #33515 from peppy/fix-selection-when-selected

  Fix clicking beatmap header causing leaderboard to refresh

  Dean Herbert · 2025-06-07 02:28:54 +09:00
  bc8d158dde
• Adjust loading spinner to not use masking as all when no box
  Dean Herbert · 2025-06-07 02:19:15 +09:00
  c25396c7d6
• Ensure beatmapSetsChanged code doesn't run during gameplay
  Dean Herbert · 2025-06-07 01:28:49 +09:00
  b3bda6a560
• Merge pull request #33504 from bdach/ssv2-leaderboard-friend-highlighting

  SongSelectV2: Add back highlighting friend scores on the leaderboard

  Dean Herbert · 2025-06-07 00:58:08 +09:00
  c4c0457377
• Fix loading spinner without a box clipping
  Joseph Madamba · 2025-06-06 08:47:32 -07:00
  15be762f71
• Fix clicking beatmap header causing leaderboard to refresh
  Dean Herbert · 2025-06-06 23:30:36 +09:00
  ed2889c983
• Use equality when updated current carousel selection
  Dean Herbert · 2025-06-06 23:20:38 +09:00
  6ab9ee76b7
• Merge pull request #33502 from smoogipoo/fix-simplified-rhythm

  Fix simplified rhythm mod not working on some beatmaps

  Dean Herbert · 2025-06-06 21:48:16 +09:00
  3a1bbf9b39
• Merge pull request #33503 from bdach/rank-change-sample-toggling

  Prevent rank display shown in skin editor toolbox from playing samples

  Dean Herbert · 2025-06-06 21:38:49 +09:00
  99f57d29e3
• SongSelectV2: Add back highlighting friend scores on the leaderboard
  Bartłomiej Dach · 2025-06-06 13:53:32 +02:00
  90084e27e5
• Prevent rank display shown in skin editor toolbox from playing samples

  Closes https://github.com/ppy/osu/issues/33456.

  Bartłomiej Dach · 2025-06-06 13:18:20 +02:00
  e02cd28df6
• Add toggle for rank change sound playback to default rank display

  Because some people don't seem to like it. Defaults to on still.

  Bartłomiej Dach · 2025-06-06 12:51:56 +02:00
  6835d7659d
• Merge pull request #33498 from bdach/ssv2-leaderboard-cut-off

  Fix several issues with leaderboard score display

  Dean Herbert · 2025-06-06 19:43:27 +09:00
  3335b99064
• Fix simplified rhythm mod not working on some beatmaps
  Dan Balasescu · 2025-06-06 19:37:01 +09:00
  558aacfed5
• Refactor slightly
  Dan Balasescu · 2025-06-06 19:37:01 +09:00
  03c3cce761
• Add failing tests
  Dan Balasescu · 2025-06-06 19:37:01 +09:00
  bef07c4b73
• Avoid transform churn due to every frame AccentColour updates
  Dean Herbert · 2025-06-06 19:33:57 +09:00
  37315d589e
• Merge pull request #33497 from Stedoss/ssv2-tag-overflow-song-select-search

  SongSelectV2: Fix `TagsOverflowPopover` not applying tag search to song select

  Bartłomiej Dach · 2025-06-06 11:52:42 +02:00
  0de732082b
• Merge pull request #33499 from bdach/leaderboard-score-tooltip

  Fix leaderboard score display not respecting local timezone & user 12/24hr settings

  Dean Herbert · 2025-06-06 18:49:30 +09:00
  7cfd7499f9
• Fix leaderboard score display not respecting local timezone & user 12/24hr settings

  Closes https://github.com/ppy/osu/issues/33473.
  
  Cross-reference previous implementation:
  
  	https://github.com/ppy/osu/blob/828e8da7726109888aa1a6a41921daad254b75c0/osu.Game/Online/Leaderboards/LeaderboardScoreTooltip.cs#L140-L141

  Bartłomiej Dach · 2025-06-06 11:44:56 +02:00
  7ea9db1b72
• Fix several issues with leaderboard score display

  - Enforces minimum width on accuracy / max combo displays which could
    previously look broken in CJK languages, thus fixing
    https://github.com/ppy/osu/issues/33434. Minimum sizes were chosen to
    accomodate what could be considered reasonably possible with some
    leeway on top.
  
  - Fixes hilariously broken logic that was supposed to highlight perfect
    / FC / max combo scores in green but instead did nothing due to two
    disparate bugs in a single line of code.
  
  - Extends the highlighting logic to also apply to 100% accuracy because
    web does this and I think it's nice.

  Bartłomiej Dach · 2025-06-06 11:25:02 +02:00
  b61688596b