Bartłomiej Dach
3178865cd3
Fix playfield skinnable layer bounds being incorrectly calculated with multiple stages
...
Closes #24514 .
The original PR was _supposed_ to be handling this, and had code that
_looked_ like it would handle it, but was in fact subtly wrong, as the
union of `RectangleF.Empty` (initial value of `area`) and an arbitrary
other rectangle is _not_ the second rectangle, but rather a rectangle
that contains _both_ the second rectangle and the point (0,0),
thus leading to the bound calculation fail.
2023-08-12 21:55:20 +02:00
Pasi4K5
8912a0e91e
Fix sliders being reversed incorrectly in the editor.
2023-08-12 20:30:48 +02:00
QuantumSno
a0543d97bd
Merge branch 'master' into leaderboard-toggle
2023-08-12 11:21:02 -04:00
Bartłomiej Dach
d2baffa0e7
Merge pull request #24518 from peppy/update-framework
...
Update framework
2023-08-12 11:44:25 +02:00
Dean Herbert
0eaa383120
Update framework
2023-08-12 17:54:05 +09:00
Dean Herbert
7fa3508a0b
Merge pull request #24511 from bdach/legacy-exporter-not-converting
...
Fix legacy beatmap exporter not converting beatmap between decode and re-encode
2023-08-12 14:28:08 +09:00
QuantumSno
e9bb9434e9
Merge remote-tracking branch 'origin/leaderboard-toggle' into leaderboard-toggle
2023-08-12 00:19:48 -04:00
QuantumSno
562af8b46d
Updated test TestSceneGameplayChatDisplay.cs. Now uses new default bind for toggle chat (enter)
2023-08-12 00:18:10 -04:00
Bartłomiej Dach
253392409e
Fix LegacyBeatmapExporter not converting beatmap between decode and re-encode
2023-08-12 00:50:31 +02:00
Bartłomiej Dach
37361cd683
Repurpose Flat{File -> }WorkingBeatmap
2023-08-12 00:49:42 +02:00
OliBomby
90f2acaf0a
Fix typo
2023-08-11 23:50:00 +02:00
OliBomby
5d1ccc2601
Ensure invariant of monotone time
2023-08-11 23:39:28 +02:00
OliBomby
d2f5e696e7
Fix DrawableHitObject state not synchronizing with hitobject edits
2023-08-11 22:34:04 +02:00
Dean Herbert
896cbb0ba0
Update framework
2023-08-11 21:34:59 +09:00
Bartłomiej Dach
2b738edb93
Reword / fix comments
2023-08-10 22:55:02 +02:00
Bartłomiej Dach
1b3806539a
Merge branch 'master' into leaderboard-toggle
2023-08-10 22:50:55 +02:00
QuantumSno
5d6ebb4df9
Removed comments organizing GlobalActionContainer.cs, since they were incorrectly grouping actions
2023-08-10 10:18:15 -04:00
QuantumSno
71c42167e7
Updated wording on realm comments
2023-08-10 10:17:12 -04:00
Dean Herbert
5b44124ecf
Merge pull request #24409 from cdwcgt/tournament-nullable
...
Remove #nullable disable in tournament
2023-08-10 19:38:16 +09:00
Bartłomiej Dach
3501b7c22b
Fix some more nullability inspections
2023-08-09 21:32:46 +02:00
Dean Herbert
4e83245acf
Apply nullability to all remaining tests where it wasn't applied
2023-08-10 00:24:57 +09:00
Dean Herbert
6549ca5304
Revert some usages of AsNonNull() in tests
...
We generally prefer `!` when it is unambiguous usage (ie. direct access).
2023-08-10 00:20:37 +09:00
cdwcgt
5ad80879b7
let MatchIPCInfo .Beatmap be nullable
2023-08-09 19:13:49 +09:00
cdwcgt
5898a9986b
Revert "use no null when true"
...
This reverts commit 6ad8339c66
2023-08-09 19:11:36 +09:00
Dean Herbert
c88045dfc7
Fix weird usage of Cast
2023-08-09 18:21:57 +09:00
Bartłomiej Dach
66e404f289
Merge pull request #24467 from Joehuu/block-exit-if-save-failed
...
Block beatmap editor from testing/exiting/exporting when saving fails
2023-08-09 00:14:23 +02:00
Bartłomiej Dach
2698ec9206
Merge branch 'master' into block-exit-if-save-failed
2023-08-08 23:41:03 +02:00
Bartłomiej Dach
c56ca40635
Merge pull request #24406 from Joehuu/fix-break-info-decimal-separator
...
Fix accuracy break info decimal separator being incorrect in certain languages
2023-08-08 23:20:00 +02:00
Bartłomiej Dach
500a1363ec
Merge branch 'master' into fix-break-info-decimal-separator
2023-08-08 22:49:00 +02:00
Bartłomiej Dach
d91798271d
Add test case covering exit block
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2023-08-08 22:06:49 +02:00
Joseph Madamba
49f5d6813e
Block beatmap editor from testing/exiting/exporting when saving fails
2023-08-04 22:08:25 -07:00
Dean Herbert
e13eb7588d
Merge pull request #24461 from Joehuu/changelog-entry-links
2023-08-04 19:45:07 +08:00
Joseph Madamba
d179fe3d96
Add support for changelog entries with url attached
2023-08-03 23:24:37 -07:00
Bartłomiej Dach
270c03235d
Merge pull request #24448 from peppy/multi-spectator-better-start-time
...
Improve choice of where to start playback of multiplayer spectator
2023-08-03 22:42:09 +02:00
Bartłomiej Dach
785d2ed9b1
Merge branch 'master' into multi-spectator-better-start-time
2023-08-03 22:07:47 +02:00
Bartłomiej Dach
bd8b9c8e63
Merge pull request #24387 from peppy/playfield-skin-layer
...
Add new skin layer to allow components anchored to the playfield
2023-08-03 22:06:17 +02:00
Bartłomiej Dach
52b1073d93
Fix playfield skin layer not rotating correctly with barrel roll mod
2023-08-03 21:08:00 +02:00
Bartłomiej Dach
dde03b7d46
Merge branch 'master' into playfield-skin-layer
2023-08-03 20:42:15 +02:00
Dean Herbert
d39ef48b71
Return null intead of FileNotFoundException on missing file in ZipArchiveReader
2023-08-03 09:01:11 +09:00
Dean Herbert
71f6e5731d
Fix potential null reference if no frames found
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-08-03 08:58:19 +09:00
Dean Herbert
f38b21110f
Add missing parenthesis to comment
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-08-03 08:57:43 +09:00
Bartłomiej Dach
e475a74a3a
Merge pull request #24443 from peppy/fix-transparent-player-background
...
Fix storyboard being see-through in some contexts
2023-08-03 01:20:28 +02:00
Bartłomiej Dach
f48b1ebdbf
Merge branch 'master' into fix-transparent-player-background
2023-08-03 00:41:42 +02:00
Bartłomiej Dach
9da1de84b5
Merge pull request #24449 from peppy/fix-fucked-everything-fucking-clock-fuckkkkkkkkkkkk
...
Fix global beatmap clock potentially getting into bad state
2023-08-02 22:39:41 +02:00
Joseph Madamba
aab462fd95
Fix valueText being replaced even if current is not binding to anything
2023-08-02 09:40:22 -07:00
Dean Herbert
87fee001c7
Fix multiplayer spectator potentially taking too long to start
...
When watching from the middle of gameplay, due to a series of failures,
`SpectatorClock` would not get seeked to the current time, causing all
clients to look like they were out of sync.
This is a hotfix for the issue. A better fix will require framework
changes or considerable restructuring.
I'd recommend testing this works in practice and agreeing that while it
is a hack, it's likely not going to cause issues and is something we
want to see fixed sooner rather than later.
2023-08-02 19:05:43 +09:00
Dean Herbert
75c1d5ad7f
Add lenience to FramedBeatmapClock workaround
2023-08-02 18:49:24 +09:00
Dean Herbert
14d87e49c7
Improve choice of where to start playback of multiplayer spectator
2023-08-02 18:46:35 +09:00
Dean Herbert
0e510088f9
Ensure background of gameplay is black when storyboard is overriding background display
2023-08-02 15:50:15 +09:00
Dean Herbert
a618ed140e
Move StoryboardReplacesBackground bindable more local to usage
2023-08-02 15:29:18 +09:00
