64775 Commits

This Branch

This Branch

All Branches

• simplify the code even more
  wooster0 · 2024-01-15 20:58:43 +09:00
  9bc9db9138
• make each test bind the handler only once, depending on its need
  wooster0 · 2024-01-09 21:44:05 +09:00
  d5fdd0c0f9
• apply suggestion
  wooster0 · 2024-01-09 21:34:40 +09:00
  ea37c70e0b
• apply some suggestions/corrections
  wooster0 · 2024-01-09 21:28:46 +09:00
  8ad697ff4c
• Use already existing message placeholder + localized string
  wooster0 · 2024-01-04 12:15:48 +09:00
  2c64db0628
• Don't leave scores screen empty if no scores are present yet

  Addresses https://github.com/ppy/osu/discussions/23787
  
  I originally wanted to set `allowShowingResults` to false if there are
  no results but because this involves an API request to fetch the scores
  that would mean all the scores would have to be fetched all at once so
  that it knows whether to hide or show the "View results" button on a
  beatmap.
  Because that would slow things down and be very inefficient, this still
  allows the user to view the scores screen but if there aren't any
  scores, it shows a text, which I think is at least for now better than
  nothing.
  
  As for the testing of this, I wasn't sure how to not generate scores
  only for one specific test so I opted into not using `SetUpSteps` and
  doing it that way.

  wooster0 · 2023-12-31 22:42:32 +09:00
  0c85fd496f
• Merge pull request #26201 from iminlikewithyou/menu-button-tweaks

  Adjust menu buttons

  Dean Herbert · 2023-12-31 16:58:55 +09:00
  2024.101.0-test 2023.1231.0 e10733834b
• Merge pull request #26267 from frenzibyte/fix-audio-offset-adjust-control

  Fix suggested value in audio offset adjust control being opposite in signs

  Dean Herbert · 2023-12-31 16:32:13 +09:00
  68b1455257
• Merge pull request #26276 from Gabixel/update-user-profile-interests-icon

  Fix interests icon no longer visible in user profile

  Dean Herbert · 2023-12-31 16:31:27 +09:00
  0834f0b2f5
• Merge pull request #26235 from frenzibyte/fix-argon-miss-judgement-mania

  Fix argon miss judgement on mania placed on a different position

  Dan Balasescu · 2023-12-31 11:14:21 +09:00
  8a40fa51f0
• Use FontAwesome solid heart icon instead of OsuIcon's
  Gabriel Del Nero · 2023-12-31 00:36:55 +01:00
  922b6ccb83
• Merge pull request #26271 from Joehuu/remove-main-menu-version-reference

  Remove outdated main menu version reference on issue template

  Bartłomiej Dach · 2023-12-30 20:49:57 +01:00
  58ea8f9920
• Remove outdated main menu version reference on issue template
  Joseph Madamba · 2023-12-30 11:44:11 -08:00
  535177ab97
• Merge branch 'master' of https://github.com/ppy/osu into menu-button-tweaks
  iminlikewithyou · 2023-12-30 12:58:10 -06:00
  45f6c78314
• use margins isntead of moving the position of the sprite
  iminlikewithyou · 2023-12-30 12:56:38 -06:00
  452f201f06
• Fix suggested value in audio offset adjust control being opposite in signs
  Salman Ahmed · 2023-12-30 21:34:37 +03:00
  e6fe631625
• Add failing test cases
  Salman Ahmed · 2023-12-30 21:33:22 +03:00
  68dd103c89
• Expose SuggestedOffset bindable for testing purposes
  Salman Ahmed · 2023-12-30 21:33:03 +03:00
  cc89390ea8
• Add back initial position transform to ensure correctness
  Salman Ahmed · 2023-12-29 20:47:18 +03:00
  08d88ec2fa
• Fix argon miss judgement on mania placed on a different position
  Salman Ahmed · 2023-12-29 20:43:03 +03:00
  8df9a1ee1f
• Merge pull request #26225 from peppy/new-menu-tips

  Add some new menu tips (and reword some others)

  Dean Herbert · 2023-12-29 22:27:47 +09:00
  2023.1229.1 0fa4cd5dfe
• Update MenuTip.cs

  Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>

  Dean Herbert · 2023-12-29 22:24:16 +09:00
  61c46b78bd
• Fix common typos

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-12-29 22:20:29 +09:00
  9f0fe6c6ca
• Add some new menu tips (and reword some others)
  Dean Herbert · 2023-12-29 22:14:51 +09:00
  d00b7c9cdf
• Merge pull request #26207 from frenzibyte/fix-dropdown-colour

  Fix dropdown colour not updating correctly on enabled state changes

  Bartłomiej Dach · 2023-12-29 14:07:09 +01:00
  f80f6a8c5b
• Merge pull request #26224 from bdach/delete-toolbar-user-button-background

  Remove opaque background from toolbar user button

  Dean Herbert · 2023-12-29 22:01:45 +09:00
  4437e2198a
• Remove opaque background from toolbar user button

  Would close https://github.com/ppy/osu/issues/26223, and generally seems
  more consistent with the rest of toolbar anyhow?

  Bartłomiej Dach · 2023-12-29 13:49:11 +01:00
  17753b8235
• Merge pull request #26222 from bdach/i-cannot-into-offsets

  Fix global audio offset suggestion feature not taking previous offset value into account

  Dean Herbert · 2023-12-29 21:14:52 +09:00
  490c584982
• Merge pull request #26221 from bdach/system-title-only-on-top-level-menu

  Do not display system title in inital menu state

  Dean Herbert · 2023-12-29 21:13:40 +09:00
  2b81f4f557
• Fix global audio offset suggestion feature not taking previous offset value into account

  See https://osu.ppy.sh/comments/2989193 etc.

  Bartłomiej Dach · 2023-12-29 12:20:58 +01:00
  cdcb3ef4aa
• Merge pull request #26220 from bdach/no-version-manager-on-deployed-builds

  Do not show main menu version display on deployed builds

  Dan Balasescu · 2023-12-29 19:54:30 +09:00
  9548818a1b
• Do not display system title in inital menu state

  Addresses https://github.com/ppy/osu/discussions/26199.

  Bartłomiej Dach · 2023-12-29 11:50:30 +01:00
  db78d73fa5
• Merge pull request #26219 from bdach/editor-timeline-crash

  Fix crash after changing audio track in editor

  Bartłomiej Dach · 2023-12-29 11:41:45 +01:00
  a9cf909937
• Do not show main menu version display on deployed builds

  See https://discord.com/channels/188630481301012481/188630652340404224/1190028102525530202.

  Bartłomiej Dach · 2023-12-29 11:14:28 +01:00
  25fa76a1b2
• Use alternative workaround
  Bartłomiej Dach · 2023-12-29 11:07:45 +01:00
  99cddb6317
• Fix crash after changing audio track in editor

  Closes https://github.com/ppy/osu/issues/26213.
  
  Reproduction scenario: switch audio track in editor after timeline
  loads.
  
  Happens because `beatmap.Value.Track.Length` is 0 immediately after a
  track switch, until BASS computes the actual track length on the audio
  thread.
  
  Yes this is a hack. No I have no better immediate ideas how to address
  this otherwise.

  Bartłomiej Dach · 2023-12-29 10:37:36 +01:00
  cd1f6b46c4
• Add test coverage of failure case
  Bartłomiej Dach · 2023-12-29 10:36:53 +01:00
  9bb0663b3b
• Merge pull request #26216 from smoogipoo/expose-mod-property

  Expose `Mod.UsesDefaultConfiguration`

  Dean Herbert · 2023-12-29 18:03:25 +09:00
  f7a4a2b098
• Expose Mod.UsesDefaultConfiguration
  Dan Balasescu · 2023-12-29 17:16:16 +09:00
  a6313c4ee8
• Merge pull request #26203 from LeNitrous/fix/menu-tip-mod-select

  Make the menu tip about mod select's fun mods more up to date.

  Dean Herbert · 2023-12-29 13:41:58 +09:00
  2023.1229.0-test b163df42c2
• Update dropdown disabled state to match with other components
  Salman Ahmed · 2023-12-29 05:31:13 +03:00
  c147ec0a98
• Fix dropdown colour not updating correctly on enabled state changes
  Salman Ahmed · 2023-12-29 05:30:50 +03:00
  150bf67064
• Make menu tip about mod select more up to date.
  Nitrous · 2023-12-29 08:51:54 +08:00
  c68a850325
• make the hover scale bigger

  as a consequence, the rotation needs to be tweaked to be lower

  iminlikewithyou · 2023-12-28 17:20:44 -06:00
  51d26d2d71
• move text left to be visually centered in the skewed rectangle
  iminlikewithyou · 2023-12-28 17:18:41 -06:00
  f1f1221e0e
• move icon upwards to be visually centered
  iminlikewithyou · 2023-12-28 17:17:24 -06:00
  4760c6aaee
• increase the base size of button icons
  iminlikewithyou · 2023-12-28 17:15:23 -06:00
  637119f7d4
• Merge pull request #26196 from bdach/fix-system-title-crash

  Fix crash when retrieval of system title image fails

  Dean Herbert · 2023-12-29 05:07:13 +09:00
  91f0603507
• Fix crash when retrieval of system title image fails

  Closes https://github.com/ppy/osu/issues/26194.

  Bartłomiej Dach · 2023-12-28 20:39:13 +01:00
  7a10e132ea
• Add test coverage of failure scenario
  Bartłomiej Dach · 2023-12-28 20:39:11 +01:00
  68402bfd11