41 Commits

• Ban culture-unsafe taglib APIs
  Bartłomiej Dach · 2025-04-28 09:26:39 +02:00
  dad04d1661
• Mark MathHelper.Clamp() as banned API

  See previous commit for partial rationale.
  
  There's an argument to be made about the `NaN`-spreading semantics being
  desirable because at least something will loudly fail in that case, but
  I'm not so sure about that these days. It feels like either way if
  `NaN`s are produced, then things are outside of any control, and chances
  are the game can probably continue without crashing. And, this move
  reduces our dependence on osuTK, which has already been living on
  borrowed time for years now and is only awaiting someone brave to go
  excise it.

  Bartłomiej Dach · 2025-02-28 13:48:22 +01:00
  35b0ff80bb
• Appease message pack new inspections
  Dean Herbert · 2025-01-08 03:13:29 +09:00
  d5f2bdf6cd
• Put globalconfig into seperated folder and reference explicitly
  Huo Yaoyuan · 2024-12-05 18:00:42 +08:00
  68e400dd0c
• Enable recommended rules for globalization
  Huo Yaoyuan · 2024-11-28 20:41:35 +08:00
  cd9b5927eb
• Convert legacy ruleset to globalconfig
  Huo Yaoyuan · 2024-11-28 19:34:56 +08:00
  8f6e5c4754
• Update HasFlag usages
  Dean Herbert · 2024-07-03 00:19:04 +09:00
  5350945340
• Ban char.ToLower()/char.ToUpper() as well for better safety
  Salman Ahmed · 2022-10-21 20:56:34 +03:00
  678bfb2caa
• Remove all entity framework code and migrations
  Dean Herbert · 2022-09-15 16:58:58 +09:00
  40a60f7145
• Replace calls to defective Humanizer methods with correct version
  Bartłomiej Dach · 2022-07-18 22:34:58 +02:00
  6f37487528
• Replace usages of string.To{Lower,Upper}()
  Bartłomiej Dach · 2022-06-24 11:57:45 +02:00
  26c5b59f6d
• Ban usage of ManualResetEventSlim.Wait() without a timeout value
  Dean Herbert · 2022-06-23 14:45:58 +09:00
  ed9c55a776
• Correctify recommended method and property
  Salman Ahmed · 2022-05-18 20:38:13 +03:00
  f5235f6a56
• Add new Guid bannedsymbols rule
  Dean Herbert · 2022-05-18 21:20:14 +09:00
  df4968a55b
• Update usages to new naming
  Dean Herbert · 2022-01-06 22:54:43 +09:00
  00177a3ae1
• Replace usage of .Result with .WaitSafelyForResult
  Dean Herbert · 2022-01-04 11:51:41 +09:00
  73b40e6833
• Replace usages of Wait with WaitSafely
  Dean Herbert · 2022-01-04 11:51:41 +09:00
  031a40af6a
• Add BannedSymbols rules for SubscribeForNotifications variants we use
  Dean Herbert · 2021-12-01 15:23:28 +09:00
  a439209535
• Add BannedSymbols entry for NuGet.Packaging
  Dean Herbert · 2021-11-23 15:04:44 +09:00
  a8c4fd694f
• Add IDeepCloneable interface and update existing CreateCopy methods to use it
  Dean Herbert · 2021-07-19 12:54:17 +09:00
  3c028ce05c
• Apply ConfigureAwait changes to game side
  Dean Herbert · 2021-03-08 14:36:35 +09:00
  b1cd01ceb8
• Fix incorrect banned symbol
  smoogipoo · 2021-02-25 16:10:27 +09:00
  dcda7f62df
• Add Enum.HasFlag to banned symbols
  smoogipoo · 2021-02-25 15:38:43 +09:00
  996b6a1e57
• Add IBindableList.GetBoudCopy to banned symbols for now
  Dean Herbert · 2020-11-04 15:21:23 +09:00
  9343f84a68
• Also avoid using internal TypeExtensions
  Dean Herbert · 2020-04-28 17:02:10 +09:00
  c3a41c8476
• Add to banned symbols
  Dean Herbert · 2020-04-28 16:49:43 +09:00
  f3fbb3cdc6
• CA1715: use prefix for generic parameters.
  Huo Yaoyuan · 2019-12-17 13:00:25 +08:00
  40b43b85f1
• CA2200: don't explictly throw caught exception.
  Huo Yaoyuan · 2019-12-17 13:00:23 +08:00
  61a6106e52
• CA1309: compare strings correctly.
  Huo Yaoyuan · 2019-12-17 13:00:15 +08:00
  caf3f774ba
• CA1052: make type static.
  Huo Yaoyuan · 2019-12-17 13:00:13 +08:00
  e46f6627e4
• CA2208: create exceptions correctly.
  Huo Yaoyuan · 2019-12-17 13:00:10 +08:00
  d5994ed484
• CA1820: use IsNullOrEmpty.
  Huo Yaoyuan · 2019-12-17 13:00:08 +08:00
  09257b0c6d
• CA1065: throw NotSupportedException in properties.
  Huo Yaoyuan · 2019-12-17 13:00:05 +08:00
  3c39fde7ff
• CA2201: throw correct exception type.
  Huo Yaoyuan · 2019-12-17 13:00:02 +08:00
  d7b3578cc6
• CA1825: use Array.Empty.
  Huo Yaoyuan · 2019-12-17 12:59:48 +08:00
  ecfc6dfa3d
• Add fxcop with every violated rule off.
  Huo Yaoyuan · 2019-12-17 12:44:29 +08:00
  46dc2251e8
• Don't use Equals(object) on T?.
  Huo Yaoyuan · 2019-12-03 20:07:22 +08:00
  a42f9447e6
• Correct BannedSymbols.txt.
  Huo Yaoyuan · 2019-11-25 23:42:59 +08:00
  41fd3f6749
• Fix false warnings
  Dean Herbert · 2019-11-25 11:31:03 +09:00
  4904346814
• Fix usage of SpriteText instead of OsuSpriteText
  Dean Herbert · 2019-11-22 18:21:40 +09:00
  66e2a259f0
• Add BannedApiAnalyzer
  Huo Yaoyuan · 2019-11-13 22:29:44 +08:00
  f90a9db2b2