1034 Commits

• Remove redundant public specfications in interfaces

  Rider EAP being noisy about this now (smoogi will be happy :D).

  Dean Herbert · 2025-05-26 17:14:41 +09:00
  cb0592d711
• Fix editor player sometimes crashing because of instantiating wrong judgement result type for object

  Closes https://github.com/ppy/osu/issues/33231.
  
  I'm not sure how to reproduce the instances of this reported to sentry
  with `Drawable{Slider,Spinner}`, but this bug is about to be made worse
  by `DrawableHoldNote` in mania getting its own `JudgementResult` subtype
  in https://github.com/ppy/osu/pull/33194 - for that one to reproduce
  just start gameplay test while editor is seeked to a time instant where
  a hold note is mid-hold.
  
  There's possibly an argument here that `CreateResult()` should live on
  `HitObject` and not `DrawableHitObject`, and I'd even be partial to such
  an argument, but doing that would be a rather hard ruleset API break
  (albeit trivial one to resolve), and also may dredge up past
  conversations about `Judgement` and `JudgementResult` (cf.
  https://github.com/ppy/osu/pull/26563) that I would rather not get into
  again.
  
  Notably this is not source-breaking for rulesets. It may be
  binary-breaking, I haven't tested.

  Bartłomiej Dach · 2025-05-22 10:20:39 +02:00
  70c6ddbe30
• Remove obsoleted overload of ApplyResult
  Dean Herbert · 2025-04-08 15:47:30 +09:00
  5d572e1ab2
• Remove left-over scheduling thing
  Dean Herbert · 2025-04-03 16:17:29 +09:00
  b471750812
• Avoid large sample depool overhead on drawable hitobjects with many nested objects

  Closes https://github.com/ppy/osu/issues/32588.

  Dean Herbert · 2025-03-26 18:45:12 +09:00
  78de898f7f
• Fix edge case allowing almost-zero-length sliders to be placed during distance snapping
  Dean Herbert · 2025-03-11 16:17:44 +09:00
  23891b1994
• Cancel ApplyDefaults() when requested

  Also didn't notice a particular case here, but if all code passes up
  until we get to the `foreach (var h in nestedHitObjects)` below, then we
  could end up stuck here for quite a while.

  Dan Balasescu · 2025-03-03 14:46:13 +09:00
  033952029e
• Cancel slider generation when requested

  Didn't notice a particular case with this one, just came up as I was
  looking through code.

  Dan Balasescu · 2025-03-03 14:19:43 +09:00
  52dad09b20
• Exit loop when cancellation requested

  The following manages to create all hitobjects but proceeds to get stuck
  in this method:
  
  `dotnet run -- difficulty 1607040 -r:2`

  Dan Balasescu · 2025-03-03 14:19:19 +09:00
  ad9a963bd0
• Refactor IDistanceSnapProvider to accept slider velocity objects as a reference

  Method signatures are also changed to be a lot more explicit as to what
  inputs they expect.

  Bartłomiej Dach · 2025-02-03 14:00:57 +01:00
  a1185df2eb
• Merge pull request #31446 from EVAST9919/new-combo-editor

  Fix performance degradation while trying to place object with a new combo in the editor.

  Dean Herbert · 2025-01-15 12:56:06 +09:00
  ef7982fbfa
• Add combo colour override control to editor

  Closes https://github.com/ppy/osu/issues/25608.
  
  Logic mostly matching stable. All operations are done on `ComboOffset`
  which still makes overridden combo colours weirdly relatively dependent
  on each other rather than them be an "absolute" choice, but alas...
  
  As per stable, two consecutive new combos can use the same colour only
  if they are separated by a break:
  
      https://github.com/peppy/osu-stable-reference/blob/52f3f75ed7efd7b9eb56e1e45c95bb91504337be/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L4564-L4571
  
  This control is only available once the user has changed the combo
  colours from defaults; additionally, only a single new combo object
  must be selected for the colour selector to show up.

  Bartłomiej Dach · 2025-01-10 13:40:56 +01:00
  48196949e0
• Fix combo properties multiple reassignments
  Andrei Zavatski · 2025-01-07 14:00:31 +03:00
  8f4eafea4e
• Merge pull request #31306 from bdach/aspire-slider-breakage

  Fix slider event generator incorrectly not generating repeats when tick distance is zero

  Dan Balasescu · 2025-01-07 11:50:18 +09:00
  77d9c955ea
• Fix slider event generator incorrectly not generating repeats when tick distance is zero

  RFC. This closes https://github.com/ppy/osu/issues/31186.
  
  To explain why: The issue occurs on
  https://osu.ppy.sh/beatmapsets/594828#osu/1258033, specifically on the
  slider at time 128604. The failure site is
  
  	https://github.com/ppy/osu/blob/fa0d2f4af22fb9319e2a8773bf635368d86360be/osu.Game.Rulesets.Osu/Edit/Blueprints/Sliders/SliderCircleOverlay.cs#L65-L66
  
  wherein `LastRepeat` is `null`, even though the slider's `RepeatCount`
  is 1 and thus `SpanCount` is 2.
  
  In this case, `SliderEventGenerator` is given a non-zero `tickDistance`
  but a zero `length`. The former is clamped to the latter:
  
  	https://github.com/ppy/osu/blob/fa0d2f4af22fb9319e2a8773bf635368d86360be/osu.Game/Rulesets/Objects/SliderEventGenerator.cs#L34
  
  Because of this, a whole block of code pertaining to tick generation
  gets turned off, because of zero tick spacing - however, that block also
  includes within it *repeat* generation, for seemingly very little reason
  whatsoever:
  
  	https://github.com/ppy/osu/blob/fa0d2f4af22fb9319e2a8773bf635368d86360be/osu.Game/Rulesets/Objects/SliderEventGenerator.cs#L47-L77
  
  While a zero tick distance would indeed cause `generateTicks()` to loop
  forever, it should have absolutely no effect on repeats.
  
  While this *is* ultimately an aspire-tier bug caused by people pushing
  things to limits, I do believe that in this case a fix is warranted
  because of how hard the current behaviour violates invariants. I do not
  like the possibility of having a slider with multiple spans and no
  repeats.

  Bartłomiej Dach · 2024-12-27 12:38:31 +01:00
  e7225399a2
• Add setters to hitobject coordinate interfaces
  Bartłomiej Dach · 2024-12-27 11:01:47 +01:00
  0d16ed028b
• Merge pull request #30984 from smoogipoo/fix-mania-spinner-conversion

  Fix "spinner" conversion for mania-specific beatmaps

  Bartłomiej Dach · 2024-12-19 15:30:10 +01:00
  1057aa867f
• Populate default LegacyType value on convert hitobjects

  Normally not an issue, but some tests create their own hitobjects
  deriving from `ConvertHitObject`.

  Dan Balasescu · 2024-12-06 17:47:14 +09:00
  8dda5aada8
• Apply minor performance rules
  Huo Yaoyuan · 2024-11-28 20:41:44 +08:00
  f5a7716509
• Remove unused params
  Dan Balasescu · 2024-11-11 16:10:15 +09:00
  8c68db0a36
• Add IHasLegacyHitObjectType to ConvertHitObject
  Dan Balasescu · 2024-11-11 16:10:15 +09:00
  7206e97b7b
• Merge implementations of ConvertHitObjectParser

  Having these be separate implementations sounded awesome at the time,
  but it only ever led to confusion. There's no practical difference if,
  for example, catch sees hitobjects with `IHasPosition` instead of
  `IHasXPosition`.

  Dan Balasescu · 2024-11-11 15:09:13 +09:00
  e1d93a7d9c
• Fix hitobjects without custom sample banks parsing as not auto sample bank
  OliBomby · 2024-10-01 12:11:44 +02:00
  2381c2c72c
• Implement auto additions editor-only
  OliBomby · 2024-10-01 16:40:48 +09:00
  0a78eb9628
• Fix distance spacing grid displaying incorrectly for unsnapped objects with duration
  Bartłomiej Dach · 2024-09-30 13:36:16 +02:00
  75fc57c34b
• add back protection against perfect curve segments with > 3 points
  OliBomby · 2024-08-21 12:03:15 +02:00
  eefd7cf083
• Fix perfect curve anchors losing type between reloads
  OliBomby · 2024-08-16 14:24:55 +02:00
  a2e26ba9ff
• Fix hit object coordinates being truncated to int values

  Closes https://github.com/ppy/osu/issues/29340.

  Dean Herbert · 2024-08-09 16:34:39 +09:00
  d072c6a743
• Respect pre-empt time when auto-generating breaks

  Closes https://github.com/ppy/osu/issues/28703.

  Bartłomiej Dach · 2024-07-23 13:30:13 +02:00
  088e8ad0a2
• Update HasFlag usages
  Dean Herbert · 2024-07-03 00:19:04 +09:00
  5350945340
• Adjust behaviour of hit animations toggle to match user expectations
  Bartłomiej Dach · 2024-06-20 13:42:32 +02:00
  ad2cd0ba8f
• Merge pull request #23443 from OliBomby/edit-nodesample

  Make NodeSamples editable

  Dean Herbert · 2024-06-18 11:12:02 +09:00
  316125d47a
• Use more descriptive HitObject names for debugger displays
  Dan Balasescu · 2024-06-13 15:18:39 +09:00
  91f2cf8cc3
• Merge branch 'master' into edit-nodesample
  Bartłomiej Dach · 2024-06-06 13:42:25 +02:00
  86b13074a0
• Updated comments
  Aurelian · 2024-05-31 08:20:19 +02:00
  9111da81d2
• Reduced subpoints limit to be a more practical value
  Aurelian · 2024-05-29 09:39:46 +02:00
  542809a748
• Added check for infinite subpoints for PerfectCurve
  Aurelian · 2024-05-27 20:32:18 +02:00
  6c4def1c09
• Reworked linear line check, and optimized scaled flat slider test
  Aurelian · 2024-05-24 14:05:56 +02:00
  b2c4e0e951
• Addressed code quality issues
  Aurelian · 2024-05-24 09:30:24 +02:00
  fff52be59a
• Nearly straight sliders are treated as linear
  Aurelian · 2024-05-24 08:26:17 +02:00
  d948e0fc5c
• Revert "Temporary rollback of framework / SDL3"

  This reverts commit d7d569cf4e.

  Dean Herbert · 2024-05-22 16:29:39 +08:00
  d0b1ebff5a
• Temporary rollback of framework / SDL3
  Dean Herbert · 2024-05-21 14:36:16 +08:00
  d7d569cf4e
• Apply required changes after framework masking updates
  Dan Balasescu · 2024-05-09 20:18:53 +09:00
  3b8b56cbcb
• Merge branch 'master' into fix-catmull-bulbs
  Bartłomiej Dach · 2024-04-10 11:25:02 +02:00
  518addf323
• Replace usages of is null with == null
  Dean Herbert · 2024-04-03 01:50:39 +08:00
  94cbe1838f
• Only optimise Catmull segments in osu ruleset
  Dan Balasescu · 2024-04-01 17:22:50 +09:00
  4806ea54f1
• Fix bulbs on Catmull sliders
  Dan Balasescu · 2024-03-27 04:05:04 +09:00
  600098d845
• Merge branch 'master' into convert-path-string-new
  Salman Ahmed · 2024-03-19 02:51:24 +03:00
  bbdcb38f5d
• Use Slice method instead of index range operators for readability
  Salman Ahmed · 2024-03-19 02:43:36 +03:00
  a8ce6a0bba
• Use ArgumentOutOfRangeException throw helper methods
  Berkan Diler · 2024-03-05 10:20:30 +01:00
  a891303484