73608 Commits

This Branch

This Branch

All Branches

• Add failing tests showing carousel incorrectly requesting start when traversing single items
  Dean Herbert · 2025-05-30 15:50:19 +09:00
  9b77b958e0
• Merge pull request #33322 from bdach/song-select-v2-detail-tab-state

  SongSelectV2: Read/write last active tab in details area from/to local configuration

  Dean Herbert · 2025-05-30 14:37:54 +09:00
  efbdd3fffb
• Merge pull request #33283 from peppy/last-played-split-out

  Split out difficulties when sorting and grouping by "last played"

  Bartłomiej Dach · 2025-05-29 14:48:48 +02:00
  d29ecbe76e
• Merge pull request #33317 from peppy/song-select-v2-polish

  SongSelectV2: Various polish

  Bartłomiej Dach · 2025-05-29 14:30:47 +02:00
  a4545d56db
• SongSelectV2: Read/write last active tab in details area from/to local configuration
  Bartłomiej Dach · 2025-05-29 14:16:41 +02:00
  8a3d979032
• Merge pull request #33320 from bdach/song-select-v2-difficulty-display-stuff

  SongSelectV2: fix title wedge difficulty display tooltip not displaying correct changes to difficulty

  Dean Herbert · 2025-05-29 20:52:46 +09:00
  a017c8155b
• Fix oversight in date handling
  Dean Herbert · 2025-05-29 20:50:50 +09:00
  66e2c5c287
• Also apply realtime colour updates to icon
  Dean Herbert · 2025-05-29 20:43:04 +09:00
  27ce549606
• Add very slight background dim
  Dean Herbert · 2025-05-29 20:31:48 +09:00
  4f38f9f486
• Highlight beatmap set header when expanded as if it was selected
  Dean Herbert · 2025-05-29 20:20:09 +09:00
  69b047d72b
• Use realtime difficulty colouring for other relevant areas
  Dean Herbert · 2025-05-29 20:19:54 +09:00
  035541bab2
• Adjust panel selection glow and background
  Dean Herbert · 2025-05-29 20:12:32 +09:00
  c8389a8683
• Fix personal best being cut off weirdly
  Dean Herbert · 2025-05-29 20:12:00 +09:00
  1af39b6b5b
• Make leaderboard scores more compact
  Dean Herbert · 2025-05-29 20:12:00 +09:00
  fc66af3b9a
• Make leaderboard scores semi-transparent
  Dean Herbert · 2025-05-29 20:12:00 +09:00
  8c6a414737
• Fix panels flashing white on first display
  Dean Herbert · 2025-05-29 20:11:59 +09:00
  f9a3c57f03
• Fix leaderboard not showing last portion near bottom footer
  Dean Herbert · 2025-05-29 20:11:30 +09:00
  88062d0a30
• Reduce maximum sizing of left/right component areas
  Dean Herbert · 2025-05-29 20:11:30 +09:00
  3da4651ea2
• Merge pull request #33319 from peppy/song-select-v2-standalone-panel-design-update

  SongSelectV2: Update general metrics and design of standalone beatmap panel

  Dean Herbert · 2025-05-29 20:11:17 +09:00
  5c0c78d1b1
• Fix code quality
  Bartłomiej Dach · 2025-05-29 12:50:29 +02:00
  3589dfe803
• Adjust sizing slightly
  Dean Herbert · 2025-05-29 19:28:18 +09:00
  17285db53e
• Split out difficulties when sorting and grouping by "last played"
  Dean Herbert · 2025-05-29 19:23:06 +09:00
  a8eff6b096
• Refactor grouping filter to also handle aggregate cases correctly

  This also fixes *another* inefficient case of full items iteration for
  no reason.

  Dean Herbert · 2025-05-29 19:22:35 +09:00
  be688fd350
• Merge pull request #33318 from bdach/song-select-v2-footer-buttons-stupid

  SongSelectV2: Disable footer buttons when transitioning to another screen

  Dean Herbert · 2025-05-29 18:43:24 +09:00
  9e6d657ec8
• Merge pull request #33316 from bdach/song-select-v2-do-not-start-on-default-beatmap

  SongSelectV2: Fix being able to progress to player loader when no beatmap is selected

  Dean Herbert · 2025-05-29 18:40:31 +09:00
  0a355529b3
• Standardise metrics and variable naming between PanelBeatmap and PanelBeatmapStandalone
  Dean Herbert · 2025-05-29 18:30:46 +09:00
  92ed964627
• Add hack to avoid spacing being added to flow when local rank is not visible
  Dean Herbert · 2025-05-29 18:30:16 +09:00
  185f55a7e6
• Decrease height of set headers and standalone beatmap panels

  They felt too chunky.

  Dean Herbert · 2025-05-29 18:28:35 +09:00
  129dc2e173
• Unify order of displaying map attributes on mod overlay with SongSelectV2
  Bartłomiej Dach · 2025-05-29 11:28:11 +02:00
  b20139e9dd
• SongSelectV2: fix title wedge difficulty display tooltip not displaying correct changes to difficulty

  Closes https://github.com/ppy/osu/issues/33286.

  Bartłomiej Dach · 2025-05-29 11:26:58 +02:00
  933d9e9f16
• Add precautionary assertion guarding against song select messing with logo while not current

  I considered having this just be a straight guard followed by an
  early-return, but if that guard ever actually gets hit, things are going
  to be severely broken all over, and un-breaking them at that point will
  be very annoying, so just going to cross fingers and hope this can be an
  assertion forevermore instead.

  Bartłomiej Dach · 2025-05-29 10:38:42 +02:00
  cfa0a49e59
• Disable footer buttons when transitioning to another screen
  Bartłomiej Dach · 2025-05-29 10:35:51 +02:00
  36628e24f9
• Add failing test case for mod select becoming visible after suspending song select
  Bartłomiej Dach · 2025-05-29 10:34:46 +02:00
  d328d3d6ed
• Refactor sorting filter to better handle cases of beatmap set grouping

  Previously the logic would fall over under various scenarios due to
  applying aggregate logic where it shouldn't be, or vice-versa.
  
  Now the sorting filter explicitly checks the grouping mode and reacts
  accordingly. I was hoping we could avoid the sorting filter having any
  knowledge of grouping, but I don't see a way around this.

  Dean Herbert · 2025-05-29 17:11:40 +09:00
  3e240cbade
• Centralise current screen check
  Bartłomiej Dach · 2025-05-29 09:59:50 +02:00
  26aca19af4
• SongSelectV2: Fix being able to progress to player loader when no beatmap is selected
  Bartłomiej Dach · 2025-05-29 09:47:43 +02:00
  dabe28045e
• Add failing test coverage for osu! cookie attempting to start gameplay with nothing selected
  Bartłomiej Dach · 2025-05-29 09:32:38 +02:00
  d1d9749de5
• Merge pull request #33307 from peppy/song-select-v2-fix-incorrect-split-out-conditional

  SongSelectV2: Fix incorrect conditional being used for "split out" check

  Bartłomiej Dach · 2025-05-29 09:21:24 +02:00
  6a7e9b9375
• Merge pull request #33304 from peppy/song-select-v2-retain-selection-on-filter-all

  SongSelectV2: Fix filtering all results away nuking user's selection

  Bartłomiej Dach · 2025-05-29 08:37:10 +02:00
  295ec74761
• SongSelectV2: Select random instead of fixed item when recovering from no selection
  Dean Herbert · 2025-05-29 01:53:10 +09:00
  b4a6803236
• Fix multiple issues causing song select to retain a deleted or hidden selection
  Dean Herbert · 2025-05-29 01:53:10 +09:00
  8f18336b2c
• SongSelectV2: Fix incorrect conditional being used for "split out" check

  🤦
  
  Have inlined the v1 usage so we don't accidentally do this again.

  Dean Herbert · 2025-05-29 01:22:22 +09:00
  ef8fd7b5d7
• SongSelectV2: Fix filtering all results away nuking user's selection
  Dean Herbert · 2025-05-29 00:44:48 +09:00
  5d5a569523
• Add failing test showing selected beatmap is reset on zero result filter
  Dean Herbert · 2025-05-29 00:44:48 +09:00
  5d6868cdae
• Merge pull request #33306 from peppy/song-select-v2-select-single-result

  SongSelectV2: If only one results is visible after filter, select it automatically

  Bartłomiej Dach · 2025-05-28 14:05:33 +02:00
  f1b6814ff3
• Merge pull request #33302 from peppy/song-select-v2-fix-loading-overlay

  SongSelectV2: Fix carousel loading state looking out of place

  Bartłomiej Dach · 2025-05-28 14:05:13 +02:00
  5cdd1f99be
• Merge branch 'master' into song-select-v2-fix-loading-overlay
  Bartłomiej Dach · 2025-05-28 13:16:30 +02:00
  bbeb1be295
• Update existing test assertions in line with new selection logic
  Dean Herbert · 2025-05-28 20:07:44 +09:00
  99ab76ba27
• SongSelectV2: If only one results is visible after filter, select it automatically
  Dean Herbert · 2025-05-28 20:07:44 +09:00
  731a4968f5
• Merge pull request #33298 from peppy/song-select-v2-random

  SongSelectV2: Add back basic random selection support

  Dean Herbert · 2025-05-28 20:07:04 +09:00
  dd4fe7d844