Dan Balasescu
e703d9e814
NRT refactorings + rename generators to match usage
...
In particular, "EndTimeObject" is no longer correct - it's strictly used
for spinners and not holds.
2024-12-06 17:16:04 +09:00
Dan Balasescu
1bbf32d567
Add some explanatory comments
...
In particular, the spinner one is the most relevant to this batch of
changes.
2024-12-06 16:40:29 +09:00
Dan Balasescu
e8728abc00
Rename LegacyPatternGenerator to stop naming conflicts
2024-12-06 16:40:29 +09:00
Dan Balasescu
e65f8ba7a0
Simplify implementation
2024-12-06 16:40:29 +09:00
Dan Balasescu
8e1bd98386
Split out + rename PassThroughPatternGenerator
...
Better symbolises the intent of this generator which is to convert
hitobjects in their most simple forms - anything with an end time
converts to a hold or otherwise converts to a normal note.
2024-12-06 16:40:29 +09:00
Dan Balasescu
8b456e1379
Always convert mania spinners
...
A big part of these changes is refactoring, which is somewhat necessary
because it was previously implemented as two separate pathways which
in-fact need to be joined at the hip when handling spinners.
I've chosen to use `IHasLegacyHitObjectType` here because there's no
other flag that allows us to tell `ConvertHold` apart from
`ConvertSpinner`.
2024-12-06 16:40:28 +09:00
Dan Balasescu
62ea4e0970
Add failing test
2024-12-06 16:40:25 +09:00
Dean Herbert
7592813e56
Merge pull request #30910 from nekodex/improve-menu-sample-playback
...
Improve menu/context-menu sample playback
2024-12-05 20:50:14 -08:00
Dean Herbert
69014550b5
Remove unnecessary null checks
2024-12-06 12:48:06 +09:00
Dean Herbert
49f4b0e6ef
Update resources
2024-12-05 21:07:13 +09:00
Dean Herbert
84a85000af
Update framework
2024-12-05 21:07:08 +09:00
Dean Herbert
8d0e1f9d18
Merge branch 'master' into improve-menu-sample-playback
2024-12-05 21:07:03 +09:00
Huo Yaoyuan
68e400dd0c
Put globalconfig into seperated folder and reference explicitly
2024-12-05 18:00:42 +08:00
Huo Yaoyuan
d92ea910cf
Merge branch 'master' into netcore-analyzer
2024-12-05 17:18:56 +08:00
Dean Herbert
3d6e766b32
Merge pull request #30976 from frenzibyte/hide-some-settings
...
Hide debug settings in release builds
2024-12-05 00:24:26 -08:00
Salman Alshamrani
1b1e7b63e9
Clean up code slightly
2024-12-05 02:48:51 -05:00
Dean Herbert
791416c8f1
Merge pull request #30937 from frenzibyte/fix-quick-restart-not-saving-score
...
Fix score no longer being saved when quick-restarting after pass
2024-12-04 23:48:18 -08:00
Salman Alshamrani
7c1be5eca2
Remove unnecessary localisations
2024-12-05 02:45:43 -05:00
Salman Alshamrani
7ab16a55e5
Make debug section only visible on debug builds
2024-12-05 02:42:08 -05:00
Salman Alshamrani
f83ec721fb
Move latency certifier and import files button outside debug section
2024-12-05 02:42:08 -05:00
Dean Herbert
72aa65206d
Merge pull request #30965 from Susko3/use-GetLocalisedString
...
Use `LocalisationManager.GetLocalisedString()` instead of bindable hack
2024-12-04 23:34:32 -08:00
Salman Alshamrani
aa0ee5cf3a
Merge pull request #30970 from peppy/results-screen-quick-retry-transition
...
Fix quick retry transition from results screen
2024-12-04 07:12:38 -05:00
Salman Alshamrani
a7586c52d0
Merge branch 'master' into results-screen-quick-retry-transition
2024-12-04 06:31:14 -05:00
Salman Alshamrani
fa87df6c6a
Move non-current handling to PerformExit
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-12-04 04:55:55 -05:00
Salman Alshamrani
8e0f6fc12d
Re-encode difficulties on resource change
2024-12-04 04:36:00 -05:00
Salman Alshamrani
60d91bada8
Merge branch 'master' into editor-multiple-background-audio-files
2024-12-04 04:31:15 -05:00
Salman Alshamrani
06824c1658
Add failing test case
2024-12-04 04:20:09 -05:00
Dean Herbert
e555131b39
Merge pull request #30971 from smoogipoo/improve-multi-search
...
Improve multiplayer listing search by making it fuzzy
2024-12-04 00:11:32 -08:00
Salman Alshamrani
e3abbf1177
Copy effect points across on blank difficulty creation
2024-12-04 02:32:00 -05:00
Salman Alshamrani
2a6fbb59ff
Add failing test case
2024-12-04 02:32:00 -05:00
Dan Balasescu
ad4df82593
Improve multiplayer listing search by making it fuzzy
2024-12-04 16:26:36 +09:00
Dan Balasescu
a8963cf317
Merge pull request #30969 from peppy/buttons-search-term
...
Add "buttons" as a search term for key bindings
2024-12-04 15:52:12 +09:00
Dean Herbert
a4d58648e2
Fix quick retry transition from results screen
2024-12-04 14:31:39 +09:00
Dean Herbert
296fa69edd
Add "buttons" as a search term for key bindings
2024-12-04 14:30:59 +09:00
Susko3
837744b0aa
Use LocalisationManager.GetLocalisedString() instead of bindable hack
...
Made possible by https://github.com/ppy/osu-framework/pull/6377 .
2024-12-03 23:29:39 +00:00
Bartłomiej Dach
d60b7f4798
Implement basic bookmark support in editor
2024-12-03 15:14:22 +01:00
Bartłomiej Dach
808934581f
Move bookmarks out of BeatmapInfo
...
Not sure why I didn't do that in https://github.com/ppy/osu/pull/28473 ...
2024-12-03 14:17:14 +01:00
Dan Balasescu
f09d8f097a
Merge pull request #30953 from peppy/notification-while-chedcking-for-updates
...
Show an ongoing operation when checking for updates
2024-12-03 17:27:10 +09:00
Dean Herbert
75781e3436
Update usages of IPC in line with framework changes
2024-12-03 16:34:23 +09:00
Dan Balasescu
be05f2a1c2
Merge pull request #30929 from timschumi/rate-change-ready
...
Account for rate changing mods when disabling the "Ready" button
2024-12-03 16:30:16 +09:00
Dan Balasescu
6ff1dec7b2
Add tests
2024-12-03 15:45:58 +09:00
Dean Herbert
457957d3b8
Refactor check-update flow to better handle unobserved exceptions
2024-12-03 14:23:10 +09:00
Dean Herbert
2ceb3f6f85
Show an ongoing operation when checking for updates
...
Addresses https://github.com/ppy/osu/discussions/30950 .
2024-12-03 13:43:20 +09:00
Dean Herbert
ce4aac4184
Merge pull request #30917 from bdach/fix-incorrect-taiko-legacy-combo
...
Fix strong drum rolls being counted for double the combo in legacy scoring attributes
2024-12-02 20:08:49 -08:00
Tim Schumacher
e920cfa187
Move rate-changing TODO to a common place in CalculateRateWithMods
2024-12-02 23:49:51 +01:00
Huo Yaoyuan
7ece8ec1dc
Update for suggestions
2024-12-03 00:03:59 +08:00
Huo Yaoyuan
68f4fa5a57
Turn off CA1507
2024-12-03 00:00:31 +08:00
Dean Herbert
ce8e4120b7
Merge pull request #30947 from bdach/undesirable-deselect-on-control-click
...
Do not deselect objects when control-clicking without hitting anything
2024-12-02 07:17:27 -08:00
Bartłomiej Dach
b505ecc7ba
Do not deselect objects when control-clicking without hitting anything
...
As per feedback in
https://discord.com/channels/90072389919997952/1259818301517725707/1310270647187935284 .
2024-12-02 13:51:43 +01:00
Bartłomiej Dach
b14dde937d
Add failing test case
2024-12-02 13:51:41 +01:00
