65936 Commits

This Branch

This Branch

All Branches

• Update github actions to resolve most node deprecation warnings

  As is github tradition, workflows started yelling about running on a
  node version that was getting sunset, so here we go again.
  
  Relevant bumps:
  
  - https://github.com/actions/checkout/releases/tag/v4.0.0
  - https://github.com/actions/setup-dotnet/releases/tag/v4.0.0
  - https://github.com/actions/cache/releases/tag/v4.0.0
  - https://github.com/actions/setup-java/releases/tag/v4.0.0
  - https://github.com/peter-evans/create-pull-request/releases/tag/v6.0.0
  - https://github.com/dorny/test-reporter/releases/tag/v1.8.0
  
  Notably, `actions/upload-artifact` is _not_ bumped to v4, although it
  should be to resolve the node deprecation warnings, because it has more
  breaking changes and bumping would break `dorny/test-reporter`
  (see https://github.com/dorny/test-reporter/issues/363).

  Bartłomiej Dach · 2024-02-22 17:18:10 +01:00
  99bbbf810b
• Merge pull request #26149 from rushiiMachine/fix-skin-editor-init-fail

  Fix `SkinEditorOverlay` freezing when `ReplayPlayer` screen exits early

  Bartłomiej Dach · 2024-02-22 14:36:35 +01:00
  9018579ecd
• Merge branch 'master' into fix-skin-editor-init-fail
  Bartłomiej Dach · 2024-02-22 14:08:38 +01:00
  f9e92c69a8
• Merge pull request #26769 from EVAST9919/results-clean

  Rework `AccuracyCircle` to not use `BufferedContainer`s

  Bartłomiej Dach · 2024-02-22 13:46:28 +01:00
  82b2edd4b7
• Merge pull request #26531 from smallketchup82/multiplayer-difficulty-tooltip

  Implement difficulty tooltips for multiplayer lobbies

  Bartłomiej Dach · 2024-02-22 12:57:35 +01:00
  49b7f0e3a7
• Swap AR and OD on tooltips

  Matches everything else.

  Bartłomiej Dach · 2024-02-22 12:11:49 +01:00
  7861125e7a
• Merge branch 'master' into multiplayer-difficulty-tooltip
  Bartłomiej Dach · 2024-02-22 12:08:29 +01:00
  46c8560ca5
• Fix test scene not properly setting tooltip type on all icons
  Bartłomiej Dach · 2024-02-22 12:05:52 +01:00
  3740064360
• Substitute two jank interdependent bool flags for single tri-state enums
  Bartłomiej Dach · 2024-02-22 12:05:50 +01:00
  d06c67ad8f
• Enable NRT in TestSceneDifficultyIcon
  Bartłomiej Dach · 2024-02-22 11:45:57 +01:00
  47db317df8
• Merge pull request #27192 from smoogipoo/mod-search-ignore-whitespace

  Adjust search terms for mods

  Bartłomiej Dach · 2024-02-22 11:41:31 +01:00
  6770b73e4e
• Merge pull request #27232 from maromalo/fix-bpm-differences

  Fix visual BPM difference between beatmap wedge and mod selection

  Bartłomiej Dach · 2024-02-22 11:11:05 +01:00
  7388576b5b
• Adjust tests to new behaviour
  Bartłomiej Dach · 2024-02-22 11:02:49 +01:00
  b08fcbd4e9
• Remove description from mod search terms

  Closes https://github.com/ppy/osu/issues/27111.

  Bartłomiej Dach · 2024-02-22 11:02:08 +01:00
  84fdcd24ef
• Merge branch 'master' into fix-bpm-differences
  Bartłomiej Dach · 2024-02-22 10:41:22 +01:00
  1a831145ce
• Merge pull request #27299 from BoudewijnPopkema/27272-clear-remembered-username

  Clear stored username/token from config when relevant checkboxes are unticked on login panel

  Dean Herbert · 2024-02-22 17:29:36 +08:00
  8b24c6a905
• Extract common helper for BPM rounding
  Bartłomiej Dach · 2024-02-22 10:27:37 +01:00
  81a9908c60
• Use more correct implementation
  Bartłomiej Dach · 2024-02-22 09:44:59 +01:00
  01f6ab0336
• Revert "clear remembered username when checkbox is unticked"

  This reverts commit d01421b951.

  Bartłomiej Dach · 2024-02-22 09:40:27 +01:00
  a1046f0a86
• Add test coverage
  Bartłomiej Dach · 2024-02-22 09:39:49 +01:00
  2831ff60e1
• Merge pull request #27107 from Joehuu/rank-highest-tooltip

  Add highest rank tooltip to global rank display

  Bartłomiej Dach · 2024-02-22 09:08:22 +01:00
  57bb0b85a1
• Merge pull request #27297 from EVAST9919/timeline-alloc

  Reduce allocations in `TimelineBlueprintContainer`

  Dean Herbert · 2024-02-22 09:16:16 +08:00
  d82b398752
• clear remembered username when checkbox is unticked
  Boudewijn Popkema · 2024-02-21 23:15:37 +01:00
  d01421b951
• Reduce allocations in TimelineBlueprintContainer
  Andrei Zavatski · 2024-02-21 23:13:10 +03:00
  4cefa8bb8d
• Merge pull request #27293 from peppy/update-framework

  Update framework

  Dean Herbert · 2024-02-21 22:19:37 +08:00
  2024.221.0 901bb01f57
• Remove unused using directive
  Bartłomiej Dach · 2024-02-21 14:55:10 +01:00
  805f0b6a29
• Merge branch 'slider-input-alloc' into update-framework
  Dean Herbert · 2024-02-21 21:45:14 +08:00
  1f4ab7a0e8
• Merge branch 'indented-code-block' into update-framework
  Dean Herbert · 2024-02-21 21:44:25 +08:00
  fc30abc7b0
• Merge branch 'remove-legacy-gl' into update-framework
  Dean Herbert · 2024-02-21 21:44:19 +08:00
  9d732bd9b1
• Update framework
  Dean Herbert · 2024-02-21 21:39:33 +08:00
  6d32cfb7ee
• Merge pull request #27292 from bdach/carousel-sorting-again

  Fix beatmap carousel string carousel not matching expectations

  Dean Herbert · 2024-02-21 21:09:28 +08:00
  67626e55cb
• Use DEFAULT instead of INSTANCE or static field

  Matches other similar comparers.

  Dean Herbert · 2024-02-21 21:02:20 +08:00
  fb593470d5
• Use custom comparer in beatmap carousel for expected sort behaviour
  Bartłomiej Dach · 2024-02-21 12:43:18 +01:00
  929858226a
• Add benchmarking for custom string comparer
  Bartłomiej Dach · 2024-02-21 12:43:17 +01:00
  04a2ac3df3
• Implement custom comparer for expected carousel sort behaviour

  Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>

  Bartłomiej Dach · 2024-02-21 12:43:17 +01:00
  59235d6c50
• Adjust test to fail
  Bartłomiej Dach · 2024-02-21 11:42:34 +01:00
  259be976e8
• Merge pull request #27288 from peppy/fix-follow-circle-animation

  Fix classic skin follow circles animating from incorrect starting point

  Bartłomiej Dach · 2024-02-21 10:53:56 +01:00
  cd1acf1ef9
• Merge pull request #27278 from EVAST9919/grid-update

  Apply padding to `GridContainer`s directly where possible

  Dean Herbert · 2024-02-21 17:29:21 +08:00
  9c40ff2911
• Merge pull request #27286 from peppy/fix-approach-circle

  Fix `LegacyApproachCircle` incorrectly applying scaling factor

  Dan Balasescu · 2024-02-21 17:22:55 +09:00
  0c359502af
• Fix classic skin follow circles animating from incorrect starting point
  Dean Herbert · 2024-02-21 15:43:53 +08:00
  a137fa5480
• Merge pull request #27275 from EVAST9919/mania-editor-alloc

  Reduce mania editor allocations with many objects selected

  Dean Herbert · 2024-02-21 15:05:59 +08:00
  949ea29eef
• Improve comment regarding scale adjust of approach circles
  Dean Herbert · 2024-02-21 13:44:04 +08:00
  a11a83ac48
• Fix LegacyApproachCircle incorrectly applying scaling factor
  Dean Herbert · 2024-02-21 13:18:51 +08:00
  86e3b597b4
• Apply padding to GridContainers directly
  Andrei Zavatski · 2024-02-20 23:18:37 +03:00
  2543a48ac8
• Reduce allocations in ManiaSelectionBlueprint
  Andrei Zavatski · 2024-02-20 20:47:41 +03:00
  b92cff9a8e
• Reduce string allocations in TimeInfoContainer
  Andrei Zavatski · 2024-02-20 20:31:18 +03:00
  871bdb9cf7
• Fix PlaybackControl string allocations
  Andrei Zavatski · 2024-02-20 19:31:28 +03:00
  6678c4783b
• Reduce allocations in ManiaPlayfield.TotalColumns
  Andrei Zavatski · 2024-02-20 19:10:03 +03:00
  e9aca9226a
• Merge pull request #27249 from EVAST9919/editor-alloc

  Reduce osu editor allocations with many objects selected

  Dean Herbert · 2024-02-20 15:06:25 +08:00
  ef413c08f1
• Remove legacy OpenGL renderer option, it's now just OpenGL
  Dan Balasescu · 2024-02-20 15:14:30 +09:00
  40d6e8ce85