Bartłomiej Dach
96b6780e0c
Merge pull request #30101 from bdach/menu-padding-left
...
Do not add checkbox padding to the left of menu items if no item actually needs it
2024-10-04 12:22:35 +02:00
Dean Herbert
4fc0aae486
Merge pull request #30108 from bdach/default-combo-colours-in-editor
...
Initialise colours section with default combo colours if none present
2024-10-04 18:57:25 +09:00
Dean Herbert
24227b4d02
Merge pull request #30109 from bdach/editor/setup-screen-better-background-selector
...
Move setup screen background preview to appropriate form control
2024-10-04 18:57:15 +09:00
Bartłomiej Dach
e136568a18
Remove linq usage to kill allocations
2024-10-04 11:25:21 +02:00
Bartłomiej Dach
61103cc712
Remove redundant initialiser
2024-10-04 11:18:09 +02:00
Bartłomiej Dach
7cd724f342
Move setup screen background preview to appropriate form control
...
See
https://discord.com/channels/188630481301012481/188630652340404224/1291361342971707463 .
2024-10-04 11:09:14 +02:00
Bartłomiej Dach
6e5a38c6c8
Initialise colours section with default combo colours if none present
...
Closes https://github.com/ppy/osu/issues/30100 .
2024-10-04 10:01:24 +02:00
Bartłomiej Dach
114e53f8b2
Add failing test
2024-10-04 10:00:37 +02:00
Dean Herbert
2914a5b93b
Merge pull request #30099 from bdach/editor/setup-screen
...
Redesign editor setup screen with new "form" controls
2024-10-04 01:32:25 +09:00
Bartłomiej Dach
29418226c0
Do not add checkbox padding to the left of menu items if no item actually needs it
...
RFC. As per
https://discord.com/channels/188630481301012481/188630652340404224/1291346164976980009 .
The diff is extremely dumb but I tried a few smarter methods and they're
either not fully correct or don't work. Primary problem is that menu
items are mutable externally and there's no hook provided by the
framework to know that items changed. One could probably be made but I'd
prefer that this change be examined visually first before I engage in
too much ceremony and start changing framework around.
2024-10-03 15:36:53 +02:00
Bartłomiej Dach
1280d7ea15
Fix tests again
2024-10-03 15:05:15 +02:00
Bartłomiej Dach
1bab2236fe
Ensure columns collapse into one correctly if no space
2024-10-03 15:01:23 +02:00
Bartłomiej Dach
090c8ee602
Make colour palette things circular again
2024-10-03 14:35:03 +02:00
Bartłomiej Dach
2c0a7d4c18
Adjust slider bar padding
...
https://discord.com/channels/188630481301012481/188630652340404224/1291374650256916482
2024-10-03 14:32:46 +02:00
Bartłomiej Dach
99eb26b7d5
Redo the layout of sections based on discord feedback
...
See
https://discord.com/channels/188630481301012481/188630652340404224/1291358770064130140
and everything after.
2024-10-03 13:53:21 +02:00
Bartłomiej Dach
8a650deab6
Fix tests
2024-10-03 13:11:02 +02:00
Bartłomiej Dach
ddfa877b12
Fix code quality
2024-10-03 13:08:04 +02:00
Dean Herbert
0a0e31163b
Merge branch 'master' into editor/setup-screen
2024-10-03 20:05:08 +09:00
Dean Herbert
7f6f9e0de2
Merge pull request #30098 from bdach/editor/setup-screen-palette
...
Implement "form" colour palette control
2024-10-03 19:43:40 +09:00
Dean Herbert
19356d0487
Match corner radius of "new" button
2024-10-03 19:33:48 +09:00
Bartłomiej Dach
a567c6369d
Autoselect contents of "form" number box
2024-10-03 11:49:05 +02:00
Bartłomiej Dach
cde348bfb8
Fix "form" textbox not dropping border if disabled when hovered
2024-10-03 11:49:05 +02:00
Bartłomiej Dach
09441a53c2
Fix "form" file selector displaying commit animation on initial show
2024-10-03 11:49:05 +02:00
Bartłomiej Dach
b15608343b
Replace setup screen controls with new "form" controls
2024-10-03 11:49:03 +02:00
Bartłomiej Dach
df730e6b6f
Implement "form" colour palette control
2024-10-03 11:20:47 +02:00
Bartłomiej Dach
4f823a3078
Merge pull request #30095 from peppy/increase-chat-font-size
...
Increase chat font size again
2024-10-03 10:28:17 +02:00
Dean Herbert
1039d4e45d
Increase chat font size again
2024-10-03 16:23:17 +09:00
Dean Herbert
54e68005ef
Merge pull request #29691 from bdach/hotkeys-in-context-menus
...
Add hotkey hints to editor menus
2024-10-01 19:29:05 +09:00
Dean Herbert
8ea1ff5de6
Merge pull request #30069 from peppy/grid-to-current-object
...
Add button to centre editor grid to current hit object
2024-10-01 19:24:46 +09:00
Bartłomiej Dach
afc34b2614
Merge pull request #30074 from peppy/lock-because
...
Fix usage of locked context without locking
2024-10-01 12:08:38 +02:00
Dean Herbert
598bc74614
Merge pull request #30058 from bdach/disabled-beatmap-comment-box
...
Properly disable comment box on things that cannot be commented on
2024-10-01 18:52:40 +09:00
Dean Herbert
162558e0b8
Use record struct
...
See
https://www.jetbrains.com/help/rider/UsageOfDefaultStructEquality.html .
2024-10-01 18:48:34 +09:00
Dean Herbert
24d534929d
Less var please
2024-10-01 18:44:27 +09:00
Dean Herbert
ae75bfd966
Rename keyboard mapping methods to make more sense now that everything's on the left
2024-10-01 18:41:53 +09:00
Bartłomiej Dach
9dad38c457
Fix button being interactable when collapsed
...
Did not match the expandable button in distance snap toolbox.
2024-10-01 11:35:43 +02:00
Dean Herbert
f08ace7522
Merge pull request #29917 from bdach/shuffle
...
Shuffle playback order in global playlist by default
2024-10-01 18:29:39 +09:00
Bartłomiej Dach
44b982864c
Fix test failures
2024-10-01 11:12:56 +02:00
Dean Herbert
307cc5581d
Fix usage of locked context without locking
...
Raised in the latest Rider EAP, seems valid enough.
2024-10-01 18:01:06 +09:00
Bartłomiej Dach
2a214f7c9f
Fix incorrect implementation of next track choice
...
`SkipWhile()` in this context does not correctly ensure that
`ElementAtOrDefault(1)` is not a protected track. An explicit `Where()`
does.
Spotted accidentally when I noticed that skipping to next track can
select a protected track, but skipping to previous cannot.
2024-10-01 10:19:59 +02:00
Bartłomiej Dach
a2d9302f4a
Move shuffle button to left side
2024-10-01 10:12:38 +02:00
Bartłomiej Dach
8eb5e6b1d5
Merge branch 'master' into shuffle
2024-10-01 10:07:54 +02:00
Bartłomiej Dach
8d2f2517a3
Specify type explicitly
2024-10-01 10:01:31 +02:00
Bartłomiej Dach
a9818854f4
Merge pull request #30024 from peppy/edit-url-decode
...
Fix editor timestamp URLs not working when they contain a space
2024-10-01 09:44:18 +02:00
Dean Herbert
87ab953935
Merge pull request #30062 from bdach/distance-snap-weirdness
...
Fix various distance snap grid weirdness around unsnapped objects
2024-10-01 16:16:22 +09:00
Dean Herbert
0bff7e8697
Merge pull request #30063 from bdach/snap-sliders-on-path-type-change
...
Ensure sliders are snapped when changing path types
2024-10-01 16:03:12 +09:00
Dean Herbert
590f27e0a0
Merge branch 'master' into hotkeys-in-context-menus
2024-10-01 15:50:19 +09:00
Dean Herbert
0409edccce
Add button to centre editor grid to current hit object
2024-10-01 15:22:05 +09:00
Bartłomiej Dach
493dcc7a1c
Fix test being dodgy
...
Hitobjects are in an indeterminate state until defaults are applied.
Adding the object to the beatmap will do this.
2024-09-30 14:38:21 +02:00
Bartłomiej Dach
48b03a328b
Ensure sliders are snapped when changing path types
...
Closes https://github.com/ppy/osu/issues/29915 .
Uses behaviour suggested in
https://github.com/ppy/osu/issues/29915#issuecomment-2361843011 .
2024-09-30 14:38:20 +02:00
Bartłomiej Dach
74a9899fc0
Fix doubled-up enabled state management of commit button
2024-09-30 14:05:26 +02:00
