45041 Commits

This Branch

This Branch

All Branches

• Merge pull request #13499 from ekrctb/fix-mania-editor-crash

  Rewrite mania selection blueprint to use only `HitObject` (no `DrawableHitObject`) for layout

  Dan Balasescu · 2021-06-18 15:10:28 +09:00
  2cd72a92e8
• Animate circles undimming
  Henry Lin · 2021-06-18 13:18:44 +08:00
  dca2d8af4f
• Merge pull request #13544 from smoogipoo/split-files

  Move IApplicableToDrawableHitObjects to its own file

  Dean Herbert · 2021-06-18 13:54:03 +09:00
  93eec009f8
• Merge branch 'master' into fix-mania-editor-crash
  Dan Balasescu · 2021-06-18 13:49:25 +09:00
  cdc1c60fab
• Mark all mods which adjust approach circle as incompatible with each other

  Closes https://github.com/ppy/osu/issues/13543.

  Dean Herbert · 2021-06-18 13:21:53 +09:00
  860626152a
• Change ModSelectOverlay to never deselect the user triggered selection
  Dean Herbert · 2021-06-18 13:17:55 +09:00
  4de27429bc
• Change CheckCompatibleSet to never deselect the current candidat when checking incompatibility
  Dean Herbert · 2021-06-18 13:17:32 +09:00
  5933e0d2d9
• Move IApplicableToDrawableHitObjects to its own file
  smoogipoo · 2021-06-18 13:06:13 +09:00
  97cd1217a4
• Hide spinner approach circle in "Hidden" mod
  Salman Ahmed · 2021-06-18 06:23:54 +03:00
  c9458fd9ce
• Make circles light up 1 beat length before start time
  Henry Lin · 2021-06-18 11:20:04 +08:00
  639e8b62b9
• Merge pull request #13541 from peppy/player-completion-refactoring
  Dean Herbert · 2021-06-18 10:47:50 +09:00
  d238c7ff9c
• xmldoc and refactoring
  emu1337 · 2021-06-17 21:41:06 +02:00
  8c4e60e5cc
• Move score preparations back below ShowResults check
  Bartłomiej Dach · 2021-06-17 19:04:52 +02:00
  f282326f9a
• Fix malformed xmldoc tag

  Oops. Made a typo in the PR suggestion.

  Bartłomiej Dach · 2021-06-17 19:02:56 +02:00
  3a1444e75d
• Apply suggestions from code review

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2021-06-18 01:07:54 +09:00
  9facfe8964
• Merge branch 'master' into player-completion-refactoring
  Dean Herbert · 2021-06-17 23:51:42 +09:00
  e0a3696145
• Merge pull request #13540 from peppy/player-pause-exit-results-flow-refactoring
  Bartłomiej Dach · 2021-06-17 16:42:18 +02:00
  880a008e01
• Merge branch 'master' into player-pause-exit-results-flow-refactoring
  Bartłomiej Dach · 2021-06-17 16:05:09 +02:00
  aae2923e14
• Reword comments slightly
  Bartłomiej Dach · 2021-06-17 16:04:58 +02:00
  10b0d066be
• Dim circles instead of fade; improved hit samples; changed jump distance to be closer to cuttingedge
  Henry Lin · 2021-06-17 22:01:58 +08:00
  b7f43405fc
• Use xmldoc-specific syntax for nicer formatting
  Bartłomiej Dach · 2021-06-17 15:26:50 +02:00
  561dbea9e1
• Merge pull request #13523 from ekrctb/applicable-to-dho

  Reduce boilerplate of `IApplicableToDrawableHitObjects` by taking a single DHO instead of an enumerable

  Dan Balasescu · 2021-06-17 19:59:06 +09:00
  6cec1145e3
• Merge pull request #13539 from peppy/improve-updateable-avatar-tooltip-handling

  Fix edges of participant tiles showing incorrect tooltip

  Dan Balasescu · 2021-06-17 19:14:40 +09:00
  77a0e9145d
• Refactor and redocument updateCompletionState() and surrounding methods
  Dean Herbert · 2021-06-17 19:13:53 +09:00
  d03c6da60c
• Remove special casing for user exit during storyboard outro
  Dean Herbert · 2021-06-17 18:11:15 +09:00
  246ab41cc6
• Rewrite xmldoc and inline comments for PerformExit
  Dean Herbert · 2021-06-17 18:10:59 +09:00
  7cbebe6d11
• Merge pull request #13535 from peppy/fix-hitcircle-approach-circle-early-hit

  Fix approach circle fade not running early on an early user hit

  Dan Balasescu · 2021-06-17 16:37:11 +09:00
  a72151d4e1
• Merge pull request #13537 from peppy/fix-author-info

  Improve code quality of `AuthorInfo`

  Dan Balasescu · 2021-06-17 16:34:45 +09:00
  79af80833f
• Merge pull request #13538 from peppy/remove-redundant-not-null

  Remove redundant `NotNull` attributes in `nullable` classes

  Dan Balasescu · 2021-06-17 16:34:32 +09:00
  b043f63fe4
• Update usages of showGuestOnNull
  Dean Herbert · 2021-06-17 16:33:43 +09:00
  a0e5301c9f
• Consume new behaviour to fix UserTile discrepancy

  Closes https://github.com/ppy/osu/issues/13522.

  Dean Herbert · 2021-06-17 16:31:12 +09:00
  808b2baa41
• Allow UpdateableAvatar to handle displaying username as tooltip
  Dean Herbert · 2021-06-17 16:31:12 +09:00
  d9cc1c227b
• Fix test failures
  smoogipoo · 2021-06-17 16:13:47 +09:00
  ccba6b5ac2
• Remove redundant NotNull attributes in nullable classes
  Dean Herbert · 2021-06-17 16:07:32 +09:00
  9495f87f04
• Improve code quality of AuthorInfo
  Dean Herbert · 2021-06-17 16:05:50 +09:00
  8da0431fa0
• Increase distance between combos; pull circles closer to center
  Henry Lin · 2021-06-17 14:30:59 +08:00
  f22beaeb5b
• Merge branch 'master' into applicable-to-dho
  Dean Herbert · 2021-06-17 15:23:56 +09:00
  8e45f26617
• Fix approach circle fade not running early on an early user hit

  Regressed in https://github.com/ppy/osu/pull/12153.
  Closes https://github.com/ppy/osu/issues/13531.

  Dean Herbert · 2021-06-17 15:09:05 +09:00
  a46f730a69
• Reorganise existing tests into hits and misses
  Dean Herbert · 2021-06-17 15:08:09 +09:00
  6d0b3efa23
• Add early/late tests for hit circles
  Dean Herbert · 2021-06-17 15:06:56 +09:00
  249ae3141e
• Improved guesstimations; fixed hit samples
  Henry Lin · 2021-06-17 10:20:50 +08:00
  14622f4734
• Add legacy spinner approach circle implementation
  Salman Ahmed · 2021-06-17 04:58:18 +03:00
  9d9892e99e
• Use property instead of backing field consistently
  ekrctb · 2021-06-17 10:31:20 +09:00
  e7954ecb60
• Remove lifetime override of DrawableManiaHitObject

  The `AlwaysAlive` logic is now in all DHOs and it is now not necessary (and potentially conflicting).

  ekrctb · 2021-06-17 10:15:24 +09:00
  a4f362dca6
• Remove IPlayfieldProvider by caching Playfield
  ekrctb · 2021-06-17 10:15:24 +09:00
  9dcd0bf311
• Fix incorrect return value
  Salman Ahmed · 2021-06-17 03:48:29 +03:00
  780388d174
• fixed an error with extremely short maps
  emu1337 · 2021-06-16 19:55:19 +02:00
  2665a873f8
• refactored for clarity
  emu1337 · 2021-06-16 19:54:22 +02:00
  41662a1643
• Merge branch 'master' into fix-mania-editor-crash
  Bartłomiej Dach · 2021-06-16 18:26:33 +02:00
  418dbf3f3e
• Merge pull request #13516 from smoogipoo/beatmap-listing-enum-localisation
  Bartłomiej Dach · 2021-06-16 18:26:02 +02:00
  044ff9d1d2