448 Commits

Author	SHA1	Message	Date
Dean Herbert	25af091409	Fix storyboard animations of very old beatmaps playing too slow ... Closes https://github.com/ppy/osu/issues/10772.	2020-11-12 17:03:43 +09:00
Dean Herbert	c5b6908e71	Always write [HitObjects] to file ... I think this is expected. If not, there's an alternative solution.	2020-11-08 00:18:27 +09:00
Bartłomiej Dach	3090b6ccb5	Resolve CA2249 inspections ... "Use `string.Contains` instead of `string.IndexOf` to improve readability"	2020-11-01 18:54:44 +01:00
Bartłomiej Dach	ca5de22ca5	Resolve CA1834 inspection ... "Use `StringBuilder.Append(char)` instead of `StringBuilder.Append(string)` when the input is a constant unit string"	2020-11-01 18:50:13 +01:00
Bartłomiej Dach	e2552d4c36	Merge branch 'master' into storyboard-skin-sprites	2020-10-20 23:01:54 +02:00
Bartłomiej Dach	cdd56ece87	Read UseSkinSprites when decoding storyboards	2020-10-20 22:49:56 +02:00
Bartłomiej Dach	fd4bab85cf	Merge branch 'master' into epilepsy-warning	2020-10-20 01:06:46 +02:00
Bartłomiej Dach	a9f27a71a2	Fix code formatting issues	2020-10-19 23:53:41 +02:00
Dean Herbert	cc41845f56	Add missing string function ordinal specifications	2020-10-16 12:49:31 +09:00
smoogipoo	d536a1f75e	Fix breaks being culled too early	2020-10-09 21:04:56 +09:00
Craftplacer	c2ade44656	Change types back	2020-09-01 17:58:06 +02:00
Craftplacer	fb37a14d57	Update LegacyBeatmapEncoder.cs	2020-08-31 17:24:03 +02:00
Craftplacer	eafa97af17	Revert changes done to SkinConfiguration and IHasCustomColours	2020-08-31 17:23:42 +02:00
Craftplacer	7e668fc31a	Update osu.Game/Beatmaps/Formats/LegacyBeatmapEncoder.cs ... Co-authored-by: Salman Ahmed <email@iisalman.me>	2020-08-30 16:11:49 +02:00
Craftplacer	1fdf8e6200	Fix xmldoc in LegacyBeatmapEncoder	2020-08-30 16:07:58 +02:00
Craftplacer	e428144f73	Use IBeatmapSkin	2020-08-30 11:34:50 +02:00
Craftplacer	00b68b050c	Merge remote-tracking branch 'upstream/master' into combo-colors	2020-08-30 10:16:38 +02:00
Craftplacer	e6646b9877	Resolve review comments	2020-08-23 15:08:02 +02:00
smoogipoo	88d50b6c47	Remove alpha mangling from LegacyDecoder	2020-08-22 00:15:37 +09:00
Craftplacer	c4a7fac760	Add required parameters and other various changes	2020-08-15 22:03:24 +02:00
Craftplacer	8ffaa49839	Handle additional null case	2020-08-12 06:40:21 +02:00
Craftplacer	139c0c75f8	Add documentation for constructor	2020-08-12 06:40:21 +02:00
Craftplacer	78692dc684	Initial commit	2020-08-10 05:21:10 +02:00
Gagah Pangeran	acbf13ddc4	add epilepsy warning field	2020-07-20 17:36:42 +07:00
smoogipoo	0ea13dea55	Introduce legacy timing point fp errors	2020-07-13 17:06:00 +09:00
ekrctb	3278a1d7d8	Standardize osu!catch coordinate system ... There were two coordinate systems used: - 0..512 (used in osu!stable) - 0..1 (relative coordinate) This commit replaces the usage of the relative coordinate system to the coordinate system of 0..512.	2020-07-02 00:21:45 +09:00
Dean Herbert	d0787ddf99	Merge pull request #9369 from smoogipoo/fix-hyperdash-alpha	2020-06-26 14:46:46 +09:00
smoogipoo	4ff9a91012	Adjust at parse time instead	2020-06-25 14:15:26 +09:00
smoogipoo	6bc507d49e	Increase coordinate parsing limits	2020-06-24 18:53:52 +09:00
smoogipoo	f3b5149648	Move some suggestions to warnings, resolve issues	2020-06-03 16:48:44 +09:00
Dan Balasescu	64d1b4b11b	Merge branch 'master' into move-setter-to-duration	2020-06-01 15:55:48 +09:00
Dean Herbert	81b8898272	Fix incorrect type cast in encoder	2020-05-31 22:30:55 +09:00
Dean Herbert	cbd563e80b	Rename to IHasDuration	2020-05-27 12:38:39 +09:00
Dean Herbert	6b5b215299	Split out IHasPath from IHasCurve to better define hitobjects	2020-05-26 17:44:47 +09:00
Tim Oliver	c1c930c472	Fixed linting warnings	2020-04-25 13:47:20 +08:00
smoogipoo	3b805daa0b	Fix hold note end time being written incorrectly	2020-04-22 16:40:07 +09:00
smoogipoo	7cdc9a599c	Fix mania holds written as spinners	2020-04-22 16:27:07 +09:00
smoogipoo	d8fdd73e17	Implement IHasCurve on DrumRoll	2020-04-22 09:06:04 +09:00
smoogipoo	ea0ebc8527	Implement beatmap encoding for all legacy rulesets	2020-04-22 09:06:04 +09:00
smoogipoo	516e6a4bb1	Fix overlapping control points not written correctly	2020-04-22 09:04:44 +09:00
smoogipoo	1421e876b1	Remove implicit new combo from spinners	2020-04-22 09:04:44 +09:00
smoogipoo	d8d85e5b08	Don't output certain properties if they don't exist	2020-04-22 09:04:44 +09:00
smoogipoo	3093c3e185	Fix custom sample set not being written correctly	2020-04-22 09:04:44 +09:00
smoogipoo	72fb34f82c	Fix overriding control points incorrectly	2020-04-21 14:19:05 +09:00
Dan Balasescu	367c3e69c4	Merge pull request #8788 from peppy/fix-editor-hard-crash ... Fix hard crash in editor on legacy modes without encoder implementation	2020-04-20 15:25:48 +09:00
Dean Herbert	48cf7becd1	Merge branch 'master' into catch-hyperdash-fruit-colouring	2020-04-19 21:48:41 +09:00
Dean Herbert	6b16908c05	Move todo to appease dotnet-format	2020-04-18 21:51:37 +09:00
Dean Herbert	c00a386ff6	Remove exceptions instead	2020-04-18 21:46:04 +09:00
Dan Balasescu	4e22e569f5	Merge branch 'master' into timing-equivalence	2020-04-17 17:12:38 +09:00
smoogipoo	9aac98664c	Remove unnecessary time property	2020-04-17 17:06:12 +09:00
smoogipoo	69fb984e71	Remove EquivalentTo() and Equals()	2020-04-17 17:04:09 +09:00
smoogipoo	6935221463	Improve logic for CSB transfer	2020-04-14 21:05:07 +09:00
Dean Herbert	081a02f748	Merge branch 'master' into catch-hyperdash-fruit-colouring	2020-04-14 10:01:15 +09:00
smoogipoo	cee4b005e6	Fix custom sample set 0 not falling back to default samples	2020-04-13 20:00:06 +09:00
smoogipoo	b900f229e7	Fix possible legacy beatmap encoder nullref	2020-04-09 20:21:42 +09:00
Salman Ahmed	1b76a53d32	Move CatchTheBeat section handling to LegacySkinDecoder ... Best place to reside at	2020-04-05 22:10:35 +03:00
Salman Ahmed	0eaea8ef9d	Create a constructor for break period ... For simple construction of break periods (e.g. filling a method with an array of break periods inside a test case)	2020-04-05 21:29:03 +03:00
Salman Ahmed	10e65c4f53	Add handling for legacy CatchTheBeat section in LegacyDecoder	2020-04-05 00:10:12 +03:00
Will Kennedy	57944bd335	fix(?) InspectCode warnings	2020-04-02 21:36:31 -04:00
Will Kennedy	c042e709a5	Fix GetDecoder getting fallback decoder too often	2020-04-02 20:43:54 -04:00
smoogipoo	a77933f5e0	Add support for parsing mania skin colours	2020-04-02 17:56:12 +09:00
smoogipoo	4719aac235	Add basic mania skin parsing	2020-03-30 17:18:09 +09:00
voidedWarranties	b8f20831a1	Video no longer modifies storyboard resolution	2020-03-24 20:04:09 -07:00
Dean Herbert	729e006c3a	Merge branch 'master' into video-offset	2020-03-21 20:03:46 +09:00
voidedWarranties	c27751050b	Switch back to strings and update setting labels	2020-03-12 23:29:11 -07:00
smoogipoo	40ab860ab5	Remove unused using	2020-03-11 18:23:30 +09:00
smoogipoo	9667934ed9	Remove unlimited timing points in difficulty calculation	2020-03-11 18:17:32 +09:00
Dan Balasescu	1d556bfc5f	Merge branch 'master' into video-offset	2020-03-11 15:13:18 +09:00
smoogipoo	e6858bf130	Fix crashes on some storyboards	2020-03-10 11:58:33 +09:00
voidedWarranties	4624582703	Revert position offset change for separate pull	2020-03-08 14:40:36 -07:00
voidedWarranties	22dd93a4f6	Code quality, read position offsets	2020-03-08 14:02:39 -07:00
voidedWarranties	76c832518f	Render video as a part of the storyboard	2020-03-07 21:32:03 -08:00
voidedWarranties	d68d7edea3	Start background video playback based on provided offset	2020-03-07 14:08:13 -08:00
Berkan Diler	5b452293d6	Minor cleanups for legacy beatmap decoders ... Replaces some string.StartsWith(string, StringComparison.Ordinal) calls with ring.StartsWith(char) , when only one char is compared. Possible since .NET-Standard 2.1 And another LegacyStoryboardDecoder.handleEvents() cleanup, saves some MB of allocations.	2020-02-08 18:05:27 +01:00
Dean Herbert	eabb5a8701	Use ToString instead of Substring	2020-01-26 17:40:38 +09:00
Dean Herbert	50ab5a7d07	Merge remote-tracking branch 'upstream/master' into LegacyDecoder_changes	2020-01-26 17:38:44 +09:00
Berkan Diler	219e14baa2	Address review and fix InspectCode	2020-01-24 17:05:27 +01:00
Berkan Diler	6658bdb223	Fix CodeFactor issues	2020-01-23 16:34:43 +01:00
Berkan Diler	316a764f6f	Minor cleanups for Legacy Storyboard/Beatmap decoder	2020-01-23 16:23:53 +01:00
smoogipoo	681a43a318	Refactor to support beatmap updates	2020-01-14 19:24:53 +09:00
Berkan Diler	34d8740ec4	Remove remaining usage of osuTK.MathHelper	2020-01-08 20:21:13 +01:00
Dean Herbert	145ac8e0b5	Remove redundant setter	2019-12-25 14:55:05 +09:00
Salman Ahmed	55be4478aa	Merge remote-tracking branch 'upstream/master' into fallback-to-skin-combo-colours	2019-12-21 12:36:09 +03:00
smoogipoo	1802e0ff11	Fix storyboard incorrectly re-ordering elements	2019-12-20 16:04:05 +09:00
Dean Herbert	5cdc7d3b18	Merge pull request #7183 from smoogipoo/legacy-beatmap-saving ... Add initial implementation of a legacy beatmap encoder	2019-12-18 18:43:14 +09:00
Dean Herbert	1f3e1b3085	Remove unused using	2019-12-18 17:59:07 +09:00
Dean Herbert	4befabc257	Split out complex method	2019-12-18 17:35:51 +09:00
smoogipoo	602ce698d5	Fix storyboard vectorscale and scale cross-pollution	2019-12-18 17:21:38 +09:00
Dean Herbert	fa067b8799	Merge branch 'master' into legacy-beatmap-saving	2019-12-18 17:17:03 +09:00
Dean Herbert	272d7d0ca9	Merge branch 'master' into fallback-to-skin-combo-colours	2019-12-17 12:36:20 +09:00
smoogipoo	be7b00cc34	Fix potentially incorrect custom sample bank	2019-12-16 17:12:31 +09:00
smoogipoo	3c9884456f	Use writeline	2019-12-16 17:08:46 +09:00
smoogipoo	5278236458	Use invariant ToLower()	2019-12-16 17:07:30 +09:00
smoogipoo	27150d6bbc	Use char concatenation for performance	2019-12-16 17:06:52 +09:00
smoogipoo	9fa6954ac2	Refactor getSampleBank a bit	2019-12-16 17:05:24 +09:00
smoogipoo	98dd1c2590	Use SingleOrDefault() where possible	2019-12-16 17:03:58 +09:00
smoogipoo	d56e99865c	Throw not implemented exceptions	2019-12-16 16:57:49 +09:00
smoogipoo	596fda3c1f	Refactor switch	2019-12-16 16:57:40 +09:00
smoogipoo	58e3fb0d0f	Coalesce to -1	2019-12-16 16:43:20 +09:00
Huo Yaoyuan	c457571da6	Use index and range expressions	2019-12-15 20:17:35 +08:00