61225 Commits

This Branch

This Branch

All Branches

• Update test assumptions
  Dean Herbert · 2023-07-05 18:44:27 +09:00
  8f6b06fe40
• Remove outdated TODO
  Dean Herbert · 2023-07-05 18:44:27 +09:00
  289f916cd7
• Merge branch 'fix-judged-fallback' into taiko-hitsounding-final-attempt
  Dean Herbert · 2023-07-05 18:44:27 +09:00
  c5b949154c
• Fix weird test assertion output
  Dean Herbert · 2023-07-05 18:44:27 +09:00
  51b0d18c04
• Add test coverage of Judged state
  Dean Herbert · 2023-07-05 18:44:27 +09:00
  7355a6a66b
• Update resources
  Dean Herbert · 2023-07-05 18:44:27 +09:00
  168b6c70a9
• Fix fallback for Judged to be more correct

  Without this change, when the `Judged` value is checked on an
  `HitObjectLifetimeEntry` it would return `true` if a `DrawableHitObject`
  has not yet been associated with the entry. Which is completely wrong.
  
  Of note, the usage in `DrawableHitObject` will have never fallen through
  to this incorrect value as they always have a result populated:
  
  https://github.com/ppy/osu/blob/f26f001e1d01ca6bb53225da7bf06c0ad21153c5/osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs#L721-L726

  Dean Herbert · 2023-07-05 18:44:27 +09:00
  4364736ccd
• Fix failing test
  Dean Herbert · 2023-07-05 18:44:27 +09:00
  8413247773
• Merge pull request #24071 from peppy/availability-fixes

  Add handling of "unknown" beatmap availability in multiplayer flow

  Bartłomiej Dach · 2023-07-05 18:44:27 +09:00
  72e44d20e4
• Consume nested object states in HitObjectLifetimeEntry
  Dean Herbert · 2023-07-05 18:44:27 +09:00
  561fff801a
• Merge branch 'master' into availability-fixes
  Bartłomiej Dach · 2023-07-05 18:44:27 +09:00
  4d9c3091a1
• Warm up pool with argon-specific drum samples
  Dean Herbert · 2023-07-05 18:44:27 +09:00
  759cd5aec7
• Don't attempt to play drum samples when rewinding
  Dean Herbert · 2023-07-05 18:44:27 +09:00
  f086908831
• Add time-based flourish support
  Dean Herbert · 2023-07-05 18:44:27 +09:00
  16f1a7694d
• Fix skin fallback not working as expected
  Dean Herbert · 2023-07-05 18:44:27 +09:00
  c72ebcfd53
• Change strong hit sample handling to be user input based, not hit object based
  Dean Herbert · 2023-07-05 18:44:27 +09:00
  010262c764
• Move strong hit handling to DrumSamplePlayer and separte trigger sources
  Dean Herbert · 2023-07-05 18:44:27 +09:00
  a9587fd1aa
• Add basic implementation of argon osu!taiko hitsounds (volume / flourish / strong)
  Dean Herbert · 2023-07-05 18:44:27 +09:00
  27af07b74b
• Add balance adjust to base implementation of DrumSampleTriggerSource
  Dean Herbert · 2023-07-05 18:44:27 +09:00
  beed390031
• Add argon-specific DrumSamplePlayer
  Dean Herbert · 2023-07-05 18:44:27 +09:00
  ae86fc736a
• Add back required pieces to GameplaySampleTriggerSource from old PR
  Dean Herbert · 2023-07-05 18:44:27 +09:00
  6d4fa6569f
• Move DrumSamplePlayer to be a skinnable component
  Dean Herbert · 2023-07-05 18:44:27 +09:00
  f54eb8d7fa
• Merge branch 'master' into taiko-hitsounding-drum-sample-player
  Dean Herbert · 2023-07-05 18:44:24 +09:00
  4bb65a54b8
• Fix reversed order of sample return
  Dean Herbert · 2023-07-05 18:44:01 +09:00
  9a7bf1bedd
• Merge pull request #24118 from bdach/nested-entries

  Add links to nested objects' lifetime entries to `HitObjectLifetimeEntry`

  Dean Herbert · 2023-07-05 14:10:14 +09:00
  674ade0c24
• Add assertions covering correctness of judged flags on entry
  Bartłomiej Dach · 2023-07-04 23:48:46 +02:00
  b0f6b22fa7
• Redirect judgement-related flags from DHO to HOLE
  Bartłomiej Dach · 2023-07-04 23:45:08 +02:00
  6c4e52821d
• Ensure synthetic entries from non-pooled DHO are linked to parents
  Bartłomiej Dach · 2023-07-04 23:45:08 +02:00
  0ceaf3c451
• Redirect HitObjectEntryManager child mapping to HOLE
  Bartłomiej Dach · 2023-07-04 23:41:06 +02:00
  bae7670855
• Add test coverage for mixed pooled/non-pooled usages
  Bartłomiej Dach · 2023-07-04 23:41:06 +02:00
  2b098bdf61
• Add HitObjectLifetimeEntry.NestedEntries
  Bartłomiej Dach · 2023-07-04 23:39:56 +02:00
  6dc8c7b617
• Merge pull request #24115 from peppy/fix-progress-cancelled

  Fix cancelled progress notifications requiring exit confirmation

  Bartłomiej Dach · 2023-07-04 21:48:56 +02:00
  b13e2c5d87
• Fix cancelled progress notifications requiring exit confirmation
  Dean Herbert · 2023-07-04 18:39:19 +09:00
  664294cef4
• Merge pull request #24071 from peppy/availability-fixes

  Add handling of "unknown" beatmap availability in multiplayer flow

  Bartłomiej Dach · 2023-07-02 21:32:40 +02:00
  f6939223b3
• Merge branch 'master' into availability-fixes
  Bartłomiej Dach · 2023-07-02 20:38:37 +02:00
  21f758947d
• Merge pull request #24068 from peppy/fix-sign-out-string

  Use more correct localised string source for "sign out" text

  Bartłomiej Dach · 2023-07-02 19:20:24 +02:00
  7b3cb5b410
• Duplicate sign out string for now
  Dean Herbert · 2023-07-03 00:14:26 +09:00
  95c30fe12a
• Merge pull request #24099 from bdach/fix-oob-selection-box-again

  Fix edge cases where selection buttons go outside playfield bounds

  Dean Herbert · 2023-07-02 09:37:50 +09:00
  b3c874fdc5
• Merge pull request #24081 from Cootz/restore-scores-after-bearmap-reinstallation

  Reattach any orphaned scores when a beatmap is imported

  Bartłomiej Dach · 2023-07-01 22:33:38 +02:00
  d017be50f1
• Use slightly different condition for better UX
  Bartłomiej Dach · 2023-07-01 21:39:08 +02:00
  9eec1337b3
• Fix edge cases where selection buttons go outside playfield bounds

  Addresses
  https://github.com/ppy/osu/discussions/23599#discussioncomment-6300885.

  Bartłomiej Dach · 2023-07-01 21:27:17 +02:00
  183777f8df
• Remove weird .Run(r => r.Write(...)) construction
  Bartłomiej Dach · 2023-07-01 20:42:34 +02:00
  746212be7b
• Fix typo in test name
  Bartłomiej Dach · 2023-07-01 20:38:00 +02:00
  b6e9422aa4
• Rewrite comments further
  Bartłomiej Dach · 2023-07-01 20:37:33 +02:00
  1ce60378be
• Merge pull request #24087 from peppy/less-tablet-error-spam

  Ensure "tablet support disabled" notification is only shown once

  Bartłomiej Dach · 2023-07-01 18:46:27 +02:00
  fe2ca5cfef
• Merge pull request #24097 from peppy/scrollbar-clickability

  Increase the minimum size of the scroll bar

  Bartłomiej Dach · 2023-07-01 18:17:48 +02:00
  c3667aaa0b
• Increase the minimum size of the scroll bar

  Allows easier targetting when there is a lot of content in the scroll view
  
  As discussed in https://github.com/ppy/osu/discussions/24095#discussioncomment-6332398.

  Dean Herbert · 2023-07-02 00:04:56 +09:00
  5f880397a9
• Tidy up comments and code
  Dean Herbert · 2023-07-01 23:37:22 +09:00
  5bd91a531d
• Move score re-attach to PostImport
  Dean Herbert · 2023-07-01 23:12:04 +09:00
  a4a9223726
• Add importer update test
  Cootz · 2023-07-01 09:49:06 +03:00
  8d25e2c3e1