1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-27 07:53:06 +08:00
Commit Graph

69219 Commits

Author SHA1 Message Date
Dean Herbert
f9fd1b957f
Merge pull request #28186 from bdach/revert-wide-columns-on-mobile 2024-05-16 19:15:35 +08:00
Bartłomiej Dach
97de73b99c
Do not change mania column width on mobile platforms
- Closes https://github.com/ppy/osu/issues/25852
- Reverts https://github.com/ppy/osu/pull/25336 /
  https://github.com/ppy/osu/pull/25777

With the columns not being directly touchable anymore after
https://github.com/ppy/osu/pull/28173 I see very little point to this
continuing to exist.
2024-05-16 08:21:52 +02:00
Salman Ahmed
8b285f5b1e Add dummy SongSelectV2 screen to house new footer buttons (and new components going forward) 2024-05-16 07:48:58 +03:00
Salman Ahmed
2b5818a4d7 Fix DI crash in beatmap options popover 2024-05-16 07:48:58 +03:00
Salman Ahmed
03220598b8 Move screen footer to OsuGame 2024-05-16 07:48:58 +03:00
Salman Ahmed
921be3ca01 Add back receptor, logo tracking, and own colour provider to screen footer 2024-05-16 07:48:58 +03:00
Salman Ahmed
95840672cb Clean up screen footer test scene 2024-05-16 07:48:10 +03:00
Salman Ahmed
d0e8632fbf Refactor ScreenFooter to prepare for global usage and add transitions 2024-05-16 07:48:10 +03:00
Salman Ahmed
a2794922d5 Add TopLevelContent layer for applying external transforms on footer buttons 2024-05-16 07:48:10 +03:00
Salman Ahmed
820cfbcb00 Remove unused using directives 2024-05-16 07:47:57 +03:00
Salman Ahmed
310b4d90cc Move SHEAR constant to OsuGame and revert back to 0.2x (i.e. master)
Discussed in [discord](https://discord.com/channels/188630481301012481/188630652340404224/1240490608934653984).
2024-05-16 07:28:02 +03:00
Salman Ahmed
9265290acf Change shear factor everywhere to 0.15x 2024-05-16 05:33:01 +03:00
Salman Ahmed
7fce4cc494 Make ScreenFooterButtonMods share shear factor with base class 2024-05-16 05:30:28 +03:00
Salman Ahmed
9446f45acf Fix shear factor of ScreenFooterButtons not matching anything else
When shear factors differ between components that are close to each other (`BackButtonV2` and `ScreenFooterButton` in this case), they look completely ugly.
2024-05-16 05:30:28 +03:00
Salman Ahmed
7e8d5a5b0a Add new footer back button 2024-05-16 05:30:28 +03:00
Salman Ahmed
266f080362 Allow customising content of ShearedButtons 2024-05-16 05:02:56 +03:00
Salman Ahmed
e3afd89dc8 Allow specifying height of ShearedButtons
Also includes a test case in `TestSceneShearedButton`s to ensure the buttons' shear factors don't change on different heights (I've encountered issues with that previously).
2024-05-16 05:02:56 +03:00
Salman Ahmed
21f5d891bb Rename and move footer classes to appropriate places 2024-05-16 04:41:16 +03:00
OliBomby
c4ac6d20a0 fix code quality 2024-05-15 23:40:51 +02:00
OliBomby
8df5f22b4e Merge remote-tracking branch 'upstream/master' into scaling 2024-05-15 23:05:19 +02:00
Dean Herbert
a3960bf715
Add inline comment explaining LifetimeEnd set for future visitors 2024-05-15 14:17:28 +08:00
Bartłomiej Dach
d52dffefbc
Merge pull request #28173 from peppy/mania-touch-input-revised
Add more usable osu!mania touch input system
2024-05-14 19:28:48 +02:00
Bartłomiej Dach
7c1640e124
Merge pull request #28170 from peppy/fix-catch-dho-performance
Set a rudimentary lifetime end to improve seek performance in scrolling rulesets
2024-05-14 19:27:40 +02:00
Bartłomiej Dach
3d190f7e88
Remove redundant cast 2024-05-14 18:41:15 +02:00
Bartłomiej Dach
dae1686e7b
Merge pull request #28174 from peppy/load-while-logo-drag
Continue loading even when osu! logo is being dragged at loading screen
2024-05-14 18:39:03 +02:00
Dean Herbert
cff865b556
Continue loading even when osu! logo is being dragged at loading screen
Closes https://github.com/ppy/osu/issues/28130.
2024-05-14 23:54:07 +08:00
Dean Herbert
c31b503f2a
Merge pull request #28171 from bdach/present-score-different-hashes
Use hash rather than online ID as primary lookup key when presenting score
2024-05-14 23:39:54 +08:00
Dean Herbert
d74be8b920
Merge pull request #28172 from bdach/nrt-results-classes
Apply NRT to results-related components
2024-05-14 23:01:24 +08:00
Dean Herbert
f781dc3300
Remove touch mod addition to mania
Feels a bit pointless? I dunno.
2024-05-14 22:38:31 +08:00
Dean Herbert
636e200471
Update tests in line with new structure 2024-05-14 22:34:05 +08:00
Dean Herbert
5c9a90cb40
Tidy class and change to be a VisibilityContainer similar to taiko implementation 2024-05-14 22:34:05 +08:00
Dean Herbert
390557634a
Rename touch area class to match existing usage (see taiko) 2024-05-14 22:34:05 +08:00
Dean Herbert
12e98fe55d
Move out of playfield so touch overlay is not affected by playfield position 2024-05-14 22:34:05 +08:00
Bartłomiej Dach
ee9144c3bd
Apply NRT to results statistics displays 2024-05-14 15:21:12 +02:00
Bartłomiej Dach
414f023817
Apply NRT to RankText 2024-05-14 15:21:05 +02:00
Bartłomiej Dach
b937b94bd2
Apply NRT to RankBadge 2024-05-14 15:20:56 +02:00
Bartłomiej Dach
ced1c79490
Apply NRT to AccuracyCircle 2024-05-14 15:20:47 +02:00
Bartłomiej Dach
e7721b073c
Apply NRT to ContractedPanelTopContent 2024-05-14 15:20:36 +02:00
Bartłomiej Dach
8e16b57d09
Apply NRT to SimpleStatisticTable 2024-05-14 15:20:26 +02:00
Bartłomiej Dach
237ae8b46a
Apply NRT to SimpleStatisticsItem 2024-05-14 15:20:17 +02:00
Bartłomiej Dach
2f2257f6ce
Apply NRT to PerformanceBreakdownChart 2024-05-14 15:20:07 +02:00
Bartłomiej Dach
77a7f475ee
Apply NRT to ScorePanel 2024-05-14 15:19:58 +02:00
Bartłomiej Dach
10a8e84046
Apply NRT to StatisticsPanel 2024-05-14 15:19:46 +02:00
Bartłomiej Dach
cb49147d1e
Apply NRT to ScorePanelList 2024-05-14 15:19:43 +02:00
Dan Balasescu
a761a7bced
Hook up touch device mod 2024-05-14 19:14:58 +08:00
Dan Balasescu
e3f2e1ba08
Add opacity setting 2024-05-14 19:14:50 +08:00
Dan Balasescu
39337f5189
Hook up input manager 2024-05-14 19:14:50 +08:00
Dan Balasescu
ef40197713
Add mania touch overlay
Adjust default anchor/origin
2024-05-14 19:14:50 +08:00
Dan Balasescu
4f6777a0a1
Remove existing per-column touch input 2024-05-14 19:10:14 +08:00
Bartłomiej Dach
03a279a48d
Use hash rather than online ID as primary lookup key when presenting score
Something I ran into when investigating
https://github.com/ppy/osu/issues/28169.

If there are two scores with the same online ID available in the
database - for instance, one being recorded locally, and one recorded by
spectator server, of one single play - the lookup code would use online
ID first to find the score and pick any first one that matched. This
could lead to the wrong replay being refetched and presented / exported.

(In the case of the aforementioned issue, I was confused as to whether
after restarting spectator server midway through a play and importing
the replay saved by spectator server after the restart, I was seeing a
complete replay with no dropped frames, even though there was nothing in
the code that prevented the frame drop. It turns out that I was getting
presented the locally recorded replay instead all along.)

Instead, jiggle the fallback preference to use hash first.
2024-05-14 11:16:50 +02:00