osu-lazer

Cancel previous initial state computations

smoogipoo · 2020-07-24 19:31:08 +09:00

8f841b47e6

Rename to IHasDuration

Dean Herbert · 2020-05-27 12:38:39 +09:00

cbd563e80b

Rename function for consistency

Dean Herbert · 2020-05-26 10:17:56 +09:00

417e31d77f

Fix spelling of breadth

Dean Herbert · 2020-05-26 10:17:34 +09:00

d69111c665

Add back comments

Dean Herbert · 2020-05-25 22:09:09 +09:00

8fc60d12c9

Move time to position conversion to ScrollingHitObjectContainer

Dean Herbert · 2020-05-25 19:32:39 +09:00

2c16619ecd

Apply suggestions from code review

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

Dan Balasescu · 2020-05-10 13:49:08 +09:00

2f12c4126a

Fix potentially skipping hitobject updates

smoogipoo · 2020-05-08 20:09:59 +09:00

be3b77cf25

Make ScrollingHitObjectContainer respond to defaults applied events

smoogipoo · 2020-05-08 18:49:58 +09:00

22dda3fe02

Implement HitObjectContainer.Clear()

smoogipoo · 2020-04-23 11:16:59 +09:00

86ef73aa27

osu-side changes

smoogipoo · 2020-02-24 20:52:15 +09:00

6c28fd21c7

Fix lifetime calculation in overlapping algorithm

Changes to lifetime calculation in scrolling rulesets introduced in
#7367, which aimed to account for the distance between hit objects'
origin and its edge entering the scrolling area, fixed some issues with
hitobjects appearing abruptly, but also regressed some other scenarios.

Upon investigation, the regression was localised to the overlapping
scroll algorithm. The reason for this was two-fold:

* The previous code used TimeAt() to calculate the time of travel from
  the hit object's edge to its origin. For other algorithms, that time
  can be accurately reconstructed, because they don't have periods of
  time where there are multiple hit objects scrolling at different
  velocities.

  That invariant does not hold for the overlapping algorithm, therefore
  it is possible for different values to be technically correct for
  TimeAt(). However, the only value that matters for the adjustment
  is the one that's indicated by the control point that applies to the
  hit object origin, which can be uniquely identified.

* Additionally, the offset returned (even if correct) was applied
  externally to the hit object's start time and passed to
  GetDisplayStartTime(). In the overlapping algorithm, the choice of
  control point used in GetDisplayStartTime() is important, since
  the value of the speed multiplier is read within.

  Externally rewinding the hit object's start time meant that in some
  cases the speed multiplier of the *previous* control point is applied,
  which led to hit objects appearing too late if the scrolling rate
  decreased.

Because of the above, modify GetDisplayStartTime() to take the offset
into account in all algorithms, and apply the adjustment correctly
inside of them. The constant and sequential algorithms needed no
adjustment from the previous logic, since:

* the constant algorithm disregarded control points, and
* the sequential algorithm would effectively rewind to time = 0,
  calculate the absolute distance from time = 0 to the hit object start,
  apply the origin offset *to the absolute distance*, and then convert
  back to time, applying all control points in sequence. Due to this
  it was impossible for control points to get mixed up while
  calculating.

As for the overlapping algorithm, the high-level logic is as follows:

* The distance that the origin has to travel is the length of the scroll
  plus the distance from the origin to the object edge.
* The above distance divided by the scroll length gives the relative
  scroll lengths that the object has to travel.
* As one relative scroll length takes one time range, the relative
  travel length multiplied by the time range gives the absolute travel
  time of the object origin.
* Finally, the control point multiplier applicable at origin time is
  applied to the whole travel time.

Correctness of the above is demonstrated by visual tests added before
and headless unit tests of the algorithms themselves. The sequential
scroll algorithm was not covered by unit tests, and remains uncovered
due to floating-point inaccuracies that should be addressed separately.

Bartłomiej Dach · 2020-02-06 23:13:28 +01:00

5fde4f2c0c

Add origin adjustment for hitobject lifetime

Visual inspection of taiko gameplay has shown that hitobjects appeared
on screen only when the origin of the hitobject came into the bounds
of the screen, instead of appearing when any visible part of the
hitobject came into the screen bounds.

This behaviour was due to lifetime calculation being based on the origin
of the hitobject and not taking into account the actual object
dimensions. Adjust the lifetime start of the hitobject by subtracting
the time needed to show the part of the hitobject that should already
be visible on screen when the origin comes into frame.

Bartłomiej Dach · 2019-12-26 20:37:29 +01:00

193e41f878

Fix scrolling hitobjects expiring too soon

smoogipoo · 2019-11-01 12:10:03 +09:00

0171b2ae7c

Fix initial hitobject states not being recomputed correctly

smoogipoo · 2019-09-24 16:48:39 +09:00

af0c15a93c

Remove from dictionary on Remove()

smoogipoo · 2019-09-02 15:06:43 +09:00

d74e1b9b64

Delay initial hitobject state computation

smoogipoo · 2019-09-02 15:06:34 +09:00

8f8d35bd15

Group lifetime setters together

Dean Herbert · 2019-08-26 19:06:23 +09:00

0422c19c2f

Add a sane default lifetime end for scrolling hitobjects

smoogipoo · 2019-08-26 16:47:23 +09:00

fb1cd9e5e7

Update cached usage in line with framework changes

Dean Herbert · 2019-08-09 19:12:29 +09:00

90b1fe81f3

Apply more missed cases

Dean Herbert · 2019-04-01 12:44:46 +09:00

c39c37a18d

Adjust namespaces

smoogipoo · 2019-02-21 19:05:52 +09:00

d8c55bc729

Update licence header (and remove year)

Dean Herbert · 2019-01-24 17:43:03 +09:00

8617aaa2a7

Move rest of ScrollingPlayfield into ScrollingRulesetContainer

smoogipoo · 2018-11-12 17:34:35 +09:00

10543cf1b6

Move ScrollAlgorithm inside IScrollingInfo

smoogipoo · 2018-11-12 17:34:35 +09:00

e7969ecec7

Move scroll direction to scrollinginfo

smoogipoo · 2018-11-12 17:34:35 +09:00

ad45bc7666

Remove unused code

smoogipoo · 2018-11-12 17:34:35 +09:00

48486895ba

Move IScrollAlgorithm to ScrollingRulesetContainer + use DI

smoogipoo · 2018-11-12 17:34:35 +09:00

7f0f143a1b

ScrollAlgorithm -> ScrollVisualisationMethod

smoogipoo · 2018-11-12 17:26:37 +09:00

aee7a80e71

Adjust namespaces

smoogipoo · 2018-11-08 14:04:21 +09:00

33056b8098

Rename IScrollChangeVisualiser -> IScrollAlgorithm

smoogipoo · 2018-11-08 14:04:21 +09:00

f66a9f4f1e

Fix height being set instead of width