1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-18 05:06:14 +08:00
Commit Graph

140 Commits

Author SHA1 Message Date
Salman Ahmed
1e6119da0b Update code inspection settings to hide "merge into pattern" again 2021-08-20 05:36:39 +03:00
kj415j45
3f434c8474
Resolve code quality issue 2021-08-12 13:42:16 +08:00
Dean Herbert
0a950a5da7 Disable auto property get-only inspection 2021-07-21 17:59:50 +09:00
Bartłomiej Dach
af02a1efcb Bump redundant argument default value inspection severity to warning 2021-07-05 21:02:40 +02:00
Bartłomiej Dach
30a7b034be Add HSV abbreviation to team-shared collection 2021-07-01 00:30:43 +02:00
smoogipoo
6f155fbd08 Make inspection a hint 2021-05-24 21:54:55 +09:00
Dean Herbert
447371478e Switch null assignment to non-nullable warnings on 2021-05-14 12:03:06 +09:00
Bartłomiej Dach
18ac97ca56 Disable "merge sequential patterns" suggestions
As they were considered to be detrimental to code readability.
2021-01-02 12:21:53 +01:00
Bartłomiej Dach
c5a218f7c9 Add "strongable" to user dictionary 2020-12-14 21:46:28 +01:00
Dean Herbert
39a74536f2 Update inspections 2020-10-16 12:48:31 +09:00
Dean Herbert
eff6af3111 Add "bindables" to dictionary 2020-09-25 12:45:13 +09:00
Dean Herbert
6a3b2ca7cf Ensure nUnit runs with correct CurrentDirectory 2020-07-17 11:39:51 +09:00
smoogipoo
6133c7d747 Change suggestion to warning 2020-06-03 18:51:02 +09:00
smoogipoo
c0881e14ab Add "struct can be made readonly" inspection 2020-06-03 17:44:14 +09:00
smoogipoo
f3b5149648 Move some suggestions to warnings, resolve issues 2020-06-03 16:48:44 +09:00
Dean Herbert
46689a2fbc Tidy up and complete xmldoc for HitObjectComposer 2020-05-29 11:46:32 +09:00
Dean Herbert
a6cac072ee Change default method style for better IDE autocompletion 2020-01-28 15:32:48 +09:00
Dean Herbert
834e82d543 Add comprehensive tests for changelog overlay
Includes failing case
2020-01-27 14:50:41 +09:00
Dean Herbert
cd5290b030 Enforce using get-only auto property where possible 2020-01-20 13:50:27 +09:00
Huo Yaoyuan
c457571da6 Use index and range expressions 2019-12-15 20:17:35 +08:00
Huo Yaoyuan
ab70abe8bd Turn off unexpected new warnings. 2019-12-15 20:07:56 +08:00
Huo Yaoyuan
d60493a961 Use discards. 2019-11-12 20:03:21 +08:00
Huo Yaoyuan
5f3e9a791c Disable suggestions not applicable for this PR. 2019-11-12 19:56:56 +08:00
Huo Yaoyuan
bbeab6fa76 Use auto property. 2019-11-12 19:53:25 +08:00
Huo Yaoyuan
3d1c31f2ae Copy configs from framework repo. 2019-11-11 20:13:12 +08:00
Huo Yaoyuan
9ed8b3a125 Use original dotsettings, with word IOS added to dictionary. 2019-11-08 21:15:24 +08:00
Huo Yaoyuan
b0414c105f Copy parts of DotSettings from framework. 2019-10-30 23:16:57 +08:00
HoLLy-HaCKeR
43760bdfcd Specify Rider analysis rules explicitly 2019-09-15 18:29:14 +02:00
smoogipoo
d7c09e7dbd Merge remote-tracking branch 'origin/master' into fix-new-inspections
# Conflicts:
#	osu.Game.Rulesets.Catch/Judgements/CatchDropletJudgement.cs
#	osu.Game.Rulesets.Catch/Judgements/CatchJudgement.cs
#	osu.Game.Rulesets.Mania/Scoring/ManiaScoreProcessor.cs
#	osu.Game.Rulesets.Osu/Replays/OsuAutoGenerator.cs
#	osu.Game.Rulesets.Osu/UI/Cursor/CursorTrail.cs
#	osu.Game.Tests/Visual/SongSelect/TestCaseBeatmapScoresContainer.cs
#	osu.Game/Graphics/OsuFont.cs
#	osu.Game/Online/API/Requests/Responses/APILegacyScoreInfo.cs
#	osu.Game/Overlays/Profile/Header/BadgeContainer.cs
#	osu.Game/Overlays/Profile/ProfileHeader.cs
#	osu.Game/Screens/Select/PlaySongSelect.cs
#	osu.Game/Skinning/LegacySkinDecoder.cs
2019-05-07 13:20:17 +09:00
jorolf
5bc6042309 Merge branch 'master' of git://github.com/ppy/osu into profile-header-update 2019-04-03 22:59:27 +02:00
Dean Herbert
612db31c38 Apply newline additions 2019-04-01 12:16:32 +09:00
Dean Herbert
7d6a08d6da Fix a few new inspections in latest Rider EAP 2019-04-01 11:39:02 +09:00
Jamie Taylor
144b8761d4
Change "Redundant argument with default value" inspection from warning to hint. 2019-03-14 19:17:28 +09:00
jorolf
bb6e57169f Merge branch 'screen-title-class' of github.com:Jorolf/osu into profile-header-update 2019-03-09 20:22:33 +01:00
Dean Herbert
57204b4361 Add JIT as abbreviation 2019-03-07 16:03:24 +09:00
smoogipoo
ee1f9d4981 Merge remote-tracking branch 'origin/master' into profile-header-update
# Conflicts:
#	osu-resources
#	osu.Game/Overlays/Profile/Components/GradeBadge.cs
#	osu.Game/Overlays/Profile/Header/BadgeContainer.cs
#	osu.Game/Overlays/Profile/Header/RankGraph.cs
#	osu.Game/Overlays/Profile/Header/SupporterIcon.cs
#	osu.Game/Overlays/Profile/ProfileHeader.cs
2019-03-06 15:53:30 +09:00
Dean Herbert
b076ac95f0 Enforce max consecutive blank lines 2019-03-04 13:20:26 +09:00
smoogipoo
02fb41a312 Use style heuristics 2019-03-01 20:17:39 +09:00
Dean Herbert
2dbf7d122c
Merge branch 'master' into use-pattern-matching 2019-02-28 14:53:07 +09:00
Dean Herbert
e2c6a8bc07 Use pattern matching wherever possible 2019-02-28 14:35:00 +09:00
Dean Herbert
0788a7e9f1
Merge branch 'master' into more-inspections 2019-02-28 14:32:57 +09:00
Dean Herbert
42be7857d1 Use expression body for property get/set where possible 2019-02-28 13:58:19 +09:00
Dean Herbert
c8793911a8 Enable more stringent inspectcode style inspections 2019-02-27 21:25:40 +09:00
jorolf
2784df3b68 Disable auto detected rules 2019-02-26 15:36:07 +01:00
Dean Herbert
ca5c8d37d1 Use leased bindables 2019-02-01 16:44:06 +09:00
jorolf
54d8e4043f Merge branch 'master' of git://github.com/ppy/osu into profile-header-update 2019-01-27 23:32:48 +01:00
Dean Herbert
ee40ca85e1 Add dotsettings whitespace ban 2019-01-24 19:12:37 +09:00
Dean Herbert
398171afd8 Standardise remaining cases 2019-01-24 18:24:30 +09:00
Dean Herbert
01f6199c49
Merge branch 'master' into profile-header-update 2019-01-04 16:38:42 +09:00
Dean Herbert
3370de3c2e Add rider live templates 2018-12-26 11:53:24 +09:00
jorolf
15ae0cd70a Merge branch 'master' of git://github.com/ppy/osu into profile-header-update 2018-12-22 16:54:39 +01:00
jorolf
b4fa2d9049 WIP 2018-12-22 16:51:24 +01:00
Dean Herbert
eec5afa382 Change inspection and add redundant parenthesis to appease codefactor 2018-12-15 16:37:37 +09:00
Dean Herbert
bbb36198a4 Change for-loop inspection to match framework 2018-11-22 10:26:05 +09:00
Dean Herbert
4a64cb7f85 Remove nuget includes im props 2018-10-12 18:56:18 +09:00
Dean Herbert
7cd547a760 Update chat to work with new API version 2018-09-25 20:53:24 +09:00
Dean Herbert
1d6609d9f3 Add common custom words to dotsettings dictionary
Also fixes some typos and reduces spelling suggestions to hints.
2018-07-05 15:54:41 +09:00
Dean Herbert
0e669c9a3f Fix many warnings 2018-03-24 18:23:22 +09:00
Dean Herbert
b66d089400 Always put attributes on a separate line to their target 2018-02-07 17:12:12 +09:00
Dean Herbert
f660eff4d4 FIx incorrect licence header template 2018-01-07 12:02:42 +09:00
Dean Herbert
3c1654e5e4 Fix many instances of non-osu-prefixed text classes being used
Results in incorrect default formatting.
2017-12-26 00:44:35 +09:00
Dean Herbert
f58c554d19 Add per-difficulty filtering support
Filters based on selected ruleset
2017-12-11 20:22:10 +09:00
smoogipoo
edb9b19079 Make JoinNullCheckWithAssignment a hint 2017-12-01 13:53:18 +09:00
smoogipoo
7451bdaa0e Update DotSettings 2017-11-30 02:06:24 +09:00
Dean Herbert
845c5ef39a Update framework 2017-10-16 12:59:59 +09:00
Dean Herbert
e7c7ebdd9d Ignore migrations directory for inspections 2017-10-16 02:15:05 +09:00
Dean Herbert
cd722e4abb Fix beatmap author being stored in two different places 2017-10-14 11:39:55 +09:00
Dean Herbert
fe90570d0f Lower inheritdoc code suggestions to hint level 2017-09-14 13:10:24 +09:00
Dean Herbert
b1145272d1 Update code to support new inspectcode analysis rules 2017-09-14 12:58:32 +09:00
smoogipooo
19db7a8f72 Update in line with framework changes. 2017-09-07 22:46:21 +09:00
Dean Herbert
3b1166d1e6 Optimise file lookups and other database operations
FirstOrDefault when called on a TableQuery with a predicate doesn't use table indices
2017-08-01 17:37:21 +09:00
Dean Herbert
996e5e8b4a Use SHA2 for hashing 2017-07-27 17:40:08 +09:00
Huo Yaoyuan
6cf36da389 Merge branch 'master' into profile 2017-07-14 22:52:19 +08:00
Dean Herbert
de46f3ab07 Remove all unnecessary parenthesis where object initialisers are used
Enforces at CI.
2017-07-13 15:11:33 +09:00
Huo Yaoyuan
f00ee92143 Add more acronyms. 2017-06-16 16:48:35 +08:00
Huo Yaoyuan
1e0653eff9 Add SS as an acronym. 2017-06-15 09:10:23 +08:00
Dean Herbert
696c53646d Change severity of unaccessed private collections to hint 2017-05-16 12:59:42 +09:00
Dean Herbert
c9ba1ac4f6 Adjust namespaces.
Also adds transition, uses IHasCurrentValue, combines Mod TestCases and more.
2017-05-05 13:00:05 +09:00
Dan Balasescu
c67f23a81d Fix unneeded key. 2017-04-07 12:02:30 +09:00
Dean Herbert
6d001d8517
Don't recommend property code style changes for now. 2017-04-07 09:41:10 +09:00
Dean Herbert
c52ad6c6ee
Attempt to speed up CI by excluding some file types from analysis. 2017-03-23 20:34:24 +09:00
Dean Herbert
681ed38941
Use const whenever possible. 2017-03-23 13:52:38 +09:00
Dean Herbert
54e1b24fe9
Enforce readonly private members where possible. 2017-03-23 13:50:08 +09:00
Dean Herbert
a048e666d7
Fix autoproperty which doesn't work on mono. 2017-03-09 14:26:09 +09:00
Dean Herbert
149bf7b5fc
Bring dotsettings up-to-date. 2017-03-09 14:03:26 +09:00
Dean Herbert
0cad5d7d41
Fix most warnings. 2017-03-07 13:05:57 +09:00
Dean Herbert
c24a4f57d9
Raise errors on unnecessary using statements. 2017-03-06 19:15:47 +09:00
Dean Herbert
f8e1006fcd
Change inspection settings.
UnusedMember_002ELocal: Warning -> Hint
VirtualMemberCallInConstructor: Warning -> Hint
2017-02-15 16:24:39 +09:00
Dean Herbert
6b011a50d2
Naming standardisation and enforcing. 2017-02-07 16:20:36 +09:00
Dean Herbert
56bdfae852 Add back DotSettings file. 2016-09-01 22:47:48 +09:00