Dan Balasescu
c78e203df5
Fix infinite health processor loop when no top-level objects
...
This is unlikely to occur in actual gameplay, but occurs in the
follow-up test.
2024-03-20 17:30:37 +09:00
Bartłomiej Dach
1f343b7545
Add extended logging when discarding online metadata lookup results
...
Related to: https://github.com/ppy/osu/issues/27674
Relevant log output for that particular case:
[network] 2024-03-20 07:25:30 [verbose]: Performing request osu.Game.Online.API.Requests.GetBeatmapRequest
[network] 2024-03-20 07:25:30 [verbose]: Request to https://dev.ppy.sh/api/v2/beatmaps/lookup successfully completed!
[network] 2024-03-20 07:25:30 [verbose]: GetBeatmapRequest finished with response size of 3,170 bytes
[database] 2024-03-20 07:25:30 [verbose]: [4fe02] [APIBeatmapMetadataSource] Online retrieval mapped Tsukiyama Sae - Hana Saku Iro wa Koi no Gotoshi (Log Off Now) [Destiny] to 744883 / 1613507.
[database] 2024-03-20 07:25:30 [verbose]: Discarding metadata lookup result due to mismatching online ID (expected: 1570982 actual: 1613507)
[network] 2024-03-20 07:25:30 [verbose]: Performing request osu.Game.Online.API.Requests.GetBeatmapRequest
[network] 2024-03-20 07:25:30 [verbose]: Request to https://dev.ppy.sh/api/v2/beatmaps/lookup successfully completed!
[network] 2024-03-20 07:25:30 [verbose]: GetBeatmapRequest finished with response size of 2,924 bytes
[database] 2024-03-20 07:25:30 [verbose]: [4fe02] [APIBeatmapMetadataSource] Online retrieval mapped Tsukiyama Sae - Hana Saku Iro wa Koi no Gotoshi (Log Off Now) [Easy] to 744883 / 1570982.
[database] 2024-03-20 07:25:30 [verbose]: Discarding metadata lookup result due to mismatching online ID (expected: 1613507 actual: 1570982)
Note that the online IDs are swapped.
2024-03-20 08:28:11 +01:00
Bartłomiej Dach
8ee391530f
Merge pull request #27675 from peppy/remove-breadcrumb-control
...
Remove unused `ScreenBreadcrumbControl`
2024-03-20 08:02:36 +01:00
Dean Herbert
1f70019009
Merge pull request #27630 from EVAST9919/editor-performance
...
Improve editor performance for maps with many control points
2024-03-20 13:20:21 +08:00
Salman Ahmed
0d6daef42b
Merge branch 'master' into remove-breadcrumb-control
2024-03-20 08:11:03 +03:00
Salman Ahmed
773daee50b
Merge pull request #27443 from jvyden/discord-rpc-invites
...
Support Discord game invites in multiplayer lobbies
2024-03-20 08:05:53 +03:00
Dean Herbert
fd509c82f5
Adjust code structure slightly
2024-03-20 12:52:54 +08:00
Salman Ahmed
5f86b5a2fa
Use DI correctly
2024-03-20 07:36:15 +03:00
Salman Ahmed
b11ae1c571
Organise code, still hook up to RoomChanged to update room privacy mode, and use SkipIdenticalPresence + scheduling to avoid potential rate-limits
2024-03-20 07:28:01 +03:00
Dean Herbert
d83a53fc94
Remove unused ScreenBreadcrumbControl
...
See https://github.com/ppy/osu-framework/pull/6218#discussion_r1529932798 .
2024-03-20 12:10:05 +08:00
jvyden
1a08dbaa2b
Fix code style
2024-03-19 17:03:30 -04:00
jvyden
4305c3db5b
Show login overlay when joining room while not logged in
2024-03-19 16:15:22 -04:00
jvyden
c71daba4f6
Improve logging of RPC
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2024-03-19 16:05:13 -04:00
jvyden
0ecfa580d7
Move room code from activity code, prevent duplicate RPC updates
2024-03-19 16:03:37 -04:00
jvyden
808d6e0943
Prevent potential threading issues
2024-03-19 16:02:06 -04:00
jvyden
f851716a47
Merge branch 'master' into discord-rpc-invites
2024-03-19 15:29:52 -04:00
Bartłomiej Dach
e4418547fe
Document GetLastObjectTime() exception on empty beatmap
2024-03-19 19:19:07 +01:00
Bartłomiej Dach
2b83e6bc4c
Fix check crash on empty beatmap
2024-03-19 19:17:22 +01:00
Bartłomiej Dach
0211ae12ad
Add failing test case for crash on empty beatmap
2024-03-19 19:16:33 +01:00
Bartłomiej Dach
af3f7dcbbf
Retouch update criteria method
2024-03-19 18:33:35 +01:00
Bartłomiej Dach
320373e3e0
Rename method to match convention better
2024-03-19 18:28:13 +01:00
Bartłomiej Dach
feaf59e15f
Use HashSet instead of SortedSet
...
No need for it to be sorted.
2024-03-19 18:26:58 +01:00
Dean Herbert
0de5ca8d2d
Update incorrect xmldoc
2024-03-20 01:26:39 +08:00
Dean Herbert
35df381717
Merge branch 'master' into tcm-resume
2024-03-20 01:25:40 +08:00
Bartłomiej Dach
0180b25546
Merge pull request #27064 from smoogipoo/heatmap-misses
...
Display misses in the hit accuracy heatmap
2024-03-19 16:20:25 +01:00
Bartłomiej Dach
08ed494a07
Merge pull request #27668 from smoogipoo/fix-perfect-score-encoding
...
Fix incorrectly encoded score IsPerfect value
2024-03-19 10:23:30 +01:00
Dan Balasescu
f6069d8d93
Compare against MaxCombo instead
2024-03-19 17:46:18 +09:00
Dan Balasescu
6e33509417
Remove added property, use local decoding instead
2024-03-19 17:44:37 +09:00
Dan Balasescu
af713a7869
Fix incorrectly encoded score IsPerfect value
2024-03-19 17:20:59 +09:00
Salman Ahmed
bbdcb38f5d
Merge branch 'master' into convert-path-string-new
2024-03-19 02:51:24 +03:00
Salman Ahmed
a8ce6a0bba
Use Slice method instead of index range operators for readability
2024-03-19 02:43:36 +03:00
Arthur Araujo
5241c999c1
Add different warning to maps with storyboard/video
2024-03-18 16:08:41 -03:00
Arthur Araujo
f6d7f18f25
Remove unused localisation file
2024-03-18 15:59:19 -03:00
Andrei Zavatski
7ca45c75b3
Don't iterate backwards on children without a reason
2024-03-18 20:46:38 +03:00
Andrei Zavatski
0edc249637
Make Timeline non-nullable
2024-03-18 20:38:19 +03:00
Andrei Zavatski
57399e9899
Merge branch 'master' into editor-performance
2024-03-18 20:34:48 +03:00
Arthur Araujo
c23212f4ef
Use GetLastObjectTime to calculate mapped length
2024-03-18 14:02:33 -03:00
Arthur Araujo
915a9682b5
Fix issue type and display percentage left
2024-03-18 13:51:36 -03:00
Arthur Araujo
a3f3dcf853
Inline percentage calculation
2024-03-18 13:27:43 -03:00
Vlad Frangu
77119b2cdb
chore: correct doc string
2024-03-18 16:44:42 +02:00
Bartłomiej Dach
c9bbeeb49a
Merge branch 'master' into heatmap-misses
2024-03-18 14:43:24 +01:00
Vlad Frangu
d0678bfbee
chore: requested changes
2024-03-18 15:30:43 +02:00
Dean Herbert
498948f17d
Merge pull request #27607 from Joehuu/fix-beatmap-card-lime-artifact
...
Fix noticeable masking artifact of beatmap cards when already downloaded
2024-03-18 00:38:56 +08:00
Dean Herbert
01d5a46f3e
Merge pull request #27632 from EVAST9919/editor-tick-display
...
Improve editor performance with many timeline ticks present
2024-03-18 00:34:43 +08:00
Arthur Araujo
80f24a0791
Fix test class name not matching file name
2024-03-16 23:30:59 -03:00
Arthur Araujo
f7aff76592
Fix codefactor issues
2024-03-16 23:03:06 -03:00
Arthur Araujo
63816adbc0
Add verify checks to unused audio at the end
2024-03-16 21:20:12 -03:00
Vlad Frangu
e1c1609271
chore: correct equal logic
2024-03-16 21:48:44 +02:00
Vlad Frangu
0a6960296e
feat: Support filtering for multiple statuses
2024-03-16 21:32:55 +02:00
Andrei Zavatski
34a5e2d606
Don't update subtree masking in TimelineTickDisplay
2024-03-16 15:20:37 +03:00
