51598 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Dan Balasescu	ab2e30d625	Merge pull request #18101 from peppy/cache-at-interface ... Move caching specification to interface for several editor interfaces	2022-05-05 19:36:08 +09:00
Dean Herbert	97221d2ef1	Tidy up initialisation	2022-05-05 19:24:18 +09:00
Dean Herbert	e54f5e2d92	Adjust value change variables to avoid e usage	2022-05-05 19:22:20 +09:00
Dean Herbert	74505ba166	Remove ! usage (also seems to fix height saving/loading)	2022-05-05 19:22:12 +09:00
Dean Herbert	25ea660b0b	Replace HandlePositionalInput override with simple hover effect	2022-05-05 19:13:48 +09:00
Dean Herbert	e7205d8593	Reset all test data before each test method to avoid channels stuck in joined state	2022-05-05 19:09:56 +09:00
Dean Herbert	2ff900fd22	Merge pull request #18102 from frenzibyte/fix-inspection ... Wrap `BeatmapOnlineLookupQueue` cache request in a task	2022-05-05 19:06:58 +09:00
Dean Herbert	4efaa41670	Merge branch 'master' into new-chat-overlay	2022-05-05 18:57:00 +09:00
Dean Herbert	e83604a1fc	Merge branch 'master' into cache-at-interface	2022-05-05 18:54:24 +09:00
Dean Herbert	9fd98b8060	Also add test coverage of adjsuting the distance spacing multiplier	2022-05-05 18:49:12 +09:00
Dean Herbert	4fe23bced2	Update tests with new assumptions and a better snap implementation	2022-05-05 18:49:12 +09:00
Dean Herbert	b9d8b7e413	Fix end time extent not being accounted for in new snap implementation	2022-05-05 18:49:12 +09:00
Dean Herbert	7b71fb860b	Expose DistanceSpacingMultiplier for test usage	2022-05-05 18:49:12 +09:00
Salman Ahmed	269e15c167	Add test coverage of distance spacing multiplier working with distance snap grid	2022-05-05 18:49:12 +09:00
Salman Ahmed	67341db0e7	Wrap BeatmapOnlineLookupQueue cache request in a task	2022-05-05 12:40:02 +03:00
Dean Herbert	b2e9be70a5	Rewrite CircularDistanceSnapGrid snapping implementation to use snap provider	2022-05-05 17:52:36 +09:00
Dean Herbert	947a68006a	Add note about IDistanceSnapProvider not multiplying DistanceSpacing itself	2022-05-05 17:50:17 +09:00
Bartłomiej Dach	2822ae0981	Merge pull request #18099 from peppy/snapping-tidy ... Add xmldoc and rename methods in `IPositionSnapProvider` for legibility	2022-05-05 10:39:32 +02:00
Bartłomiej Dach	5e4d07760d	Merge branch 'master' into snapping-tidy	2022-05-05 10:17:48 +02:00
Dean Herbert	4c884aea5d	Fix CircularDistanceSnapGrid returning an incorrect time value when distance spacing is not 1.0	2022-05-05 17:09:14 +09:00
Dean Herbert	786c7f14d3	Expose DistanceSpacingMultiplier to distance	2022-05-05 17:08:53 +09:00
Dean Herbert	de9b3d33eb	Rename misleading DistanceSpacing variable	2022-05-05 17:08:09 +09:00
Dean Herbert	c3d2648f85	Reword weird xmldoc ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2022-05-05 17:07:05 +09:00
Dean Herbert	4226583afd	Merge branch 'cache-at-interface'	2022-05-05 16:52:03 +09:00
Dean Herbert	19cf9dc20b	Merge branch 'snapping-tidy-distance'	2022-05-05 16:51:32 +09:00
Dean Herbert	225fc65068	Merge branch 'snapping-tidy'	2022-05-05 16:51:31 +09:00
Dean Herbert	5a1ac71d90	Remove unnecessary type specification in HitObjectComposer's caching	2022-05-05 16:44:37 +09:00
Dean Herbert	1c6a233cc0	Move snap provider caching to interfaces	2022-05-05 16:44:37 +09:00
Dean Herbert	b411b59006	Move IPlacementHandler caching to interface	2022-05-05 16:43:02 +09:00
Dean Herbert	977e6d8a80	Add xmldoc for IDistanceSnapProvider and related properties	2022-05-05 16:25:45 +09:00
Dean Herbert	6227e3f876	Add comprehensive documentation of BeatmapInfo.DistanceSpacing	2022-05-05 16:25:45 +09:00
Salman Ahmed	ac6342ff8d	Add workaround for item scrolling issue	2022-05-05 10:16:16 +03:00
Dean Herbert	1fce0da331	Reword slightly, to allow better conformity with IDistanceSnapProvider	2022-05-05 16:04:34 +09:00
Bartłomiej Dach	0c2d280443	Merge pull request #18098 from peppy/strict-tracking-description ... Remove weird strict tracking icon and reword description to explain what the mod does	2022-05-05 09:02:59 +02:00
Dean Herbert	f6fc926f1a	Add xmldoc and rename methods in IPositionSnapProvider for legibility	2022-05-05 15:58:21 +09:00
Bartłomiej Dach	79ecf5dd5d	Merge branch 'master' into strict-tracking-description	2022-05-05 08:41:27 +02:00
Bartłomiej Dach	93deb3cf20	Merge pull request #18097 from Supersonicboss1/fix-alternate-mod-display ... Fix Autoplay and Cinema not showing incompatibility with Alternate on hover, and made Alternate incompatible with Relax	2022-05-05 08:37:48 +02:00
Dean Herbert	cbc58c67bf	Remove weird strict tracking icon and reword description to explain what the mod does	2022-05-05 15:16:01 +09:00
Dean Herbert	f6a6a11391	Remove DialogOverlay local fades (is already managed by PopupDialogs themselves)	2022-05-05 15:02:23 +09:00
Dean Herbert	326ff3b6e9	Fix CurrentDialog being updated twice, unsafe variable access	2022-05-05 14:55:05 +09:00
Salman Ahmed	86aa2125fe	Add test coverage for multiplayer mod validity methods	2022-05-05 08:13:29 +03:00
Salman Ahmed	e3c7c5d0b9	Improve validity methods to include system, non-implemented, and multi mods	2022-05-05 08:13:06 +03:00
Salman Ahmed	a26793cd65	Add missing Test prefix	2022-05-05 06:12:24 +03:00
Salman Ahmed	f28978b856	Handle against playlists which disallow selection ... `SelectedItem.Disabled` is also not checked against in the select-via-click flow inside `DrawableRoomPlaylistItem` (only `AllowSelection` is checked).	2022-05-05 05:48:35 +03:00
Salman Ahmed	464b3af5f3	Rename local correctly	2022-05-05 05:42:20 +03:00
Supersonicboss1	81b4622620	fixed autoplay not showing compat, + relax compat	2022-05-04 22:25:34 +01:00
Dean Herbert	a27fcda9f1	Fix failing tests due to CurrentDialog being unexpectedly not set after Push	2022-05-05 01:52:39 +09:00
Salman Ahmed	d0df9e8051	Inline CheckCompatibleSet method to avoid ugly boolean flag	2022-05-04 18:56:30 +03:00
Salman Ahmed	8488a29e9e	Renew obsoletion date	2022-05-04 17:22:11 +03:00
Salman Ahmed	8f04db5df5	Bring back behaviour of checking incompatibility on gameplay validity	2022-05-04 17:21:19 +03:00