173 Commits

• Remove unused using statements
  Dean Herbert · 2022-04-25 18:55:12 +09:00
  7ac3ba132c
• Merge branch 'master' into scene-library-incompatible-mods
  Dean Herbert · 2022-04-25 18:54:40 +09:00
  a0e80cf901
• Add failing test cases
  Salman Ahmed · 2022-04-23 23:16:06 +03:00
  60e76d62c1
• Split skin editor scene library test to own file

  Rather than stuffing more random cases to `TestSceneScreenNavigation`.

  Salman Ahmed · 2022-04-23 23:15:45 +03:00
  6ab188f8f9
• Simplfiy and share notification dimsiss method across test scenes

  Might as well inline, but I feel like it will require adding the same
  comment across all usages, because just `State.Value = Hidden` in an
  until step feels off, dunno.

  Salman Ahmed · 2022-04-23 23:14:19 +03:00
  daadc3fc21
• Add full OsuGame tests

  These tests ensure the expected behaviour is not broken in the future.

  Susko3 · 2022-04-23 19:01:55 +02:00
  684d88ba75
• Update screen transition events to use new event args
  Dean Herbert · 2022-04-22 00:52:44 +09:00
  832d37b2c2
• Split out INotificationOverlay to allow for easier testing
  Dean Herbert · 2022-04-18 20:14:01 +09:00
  043599081b
• Split out step for dialog overlay load wait
  Dean Herbert · 2022-04-18 20:06:08 +09:00
  72a33c0926
• Split out IDialogOverlay to allow for easier testing
  Dean Herbert · 2022-04-18 18:36:26 +09:00
  e315313266
• Remove unused using statement
  Dean Herbert · 2022-04-14 16:37:59 +09:00
  58d5cf4560
• Add test coverage of nested screen stacks not handling dialog dismissal properly
  Dean Herbert · 2022-04-14 16:19:34 +09:00
  f48a9ba90a
• Ignore EF-to-realm migration tests on ARM architectures
  Salman Ahmed · 2022-03-30 01:24:37 +03:00
  7495a04990
• Merge pull request #17400 from nagilson/screen-mod-retention

  Fix mods from single player carrying over to multiplayer

  Dan Balasescu · 2022-03-23 08:36:15 +09:00
  1ffa1e1219
• Remove unnecessary local
  Bartłomiej Dach · 2022-03-22 19:13:22 +01:00
  c8d48f89e8
• Fix test not actually testing desired scenario anymore

  The test was checking the test scene's own `SelectedMods` bindable
  rather than the multiplayer screen's, and the former was never actually
  being mutated by anything. Therefore the case would pass even on
  `master` with the fix reverted.

  Bartłomiej Dach · 2022-03-22 19:04:32 +01:00
  94c5207f36
• Move and refactor test in line with functionality changes
  Dean Herbert · 2022-03-22 17:38:43 +09:00
  804e856160
• Add test coverage of skin editor settings slider not working via keyboard adjustments
  Dean Herbert · 2022-03-21 17:33:56 +09:00
  3643f879e4
• Fix potential test failures due to slow realm refresh in TestSceneScreenNavigation

  As seen at https://github.com/ppy/osu/runs/5492345983?check_suite_focus=true.

  Dean Herbert · 2022-03-10 18:10:08 +09:00
  d5eca16b69
• Add test coverage of beatmap set overlay actually showing requested beatmap
  Dean Herbert · 2022-02-22 17:08:09 +09:00
  5efffa208a
• Add handling of beatmap links on startup
  Dean Herbert · 2022-02-18 16:14:37 +09:00
  29c5683ba3
• Add test coverage of EF to Realm migration process
  Dean Herbert · 2022-02-15 17:00:17 +09:00
  b1cf014dc2
• Merge branch 'master' into spectator-state-rework
  Dan Balasescu · 2022-02-03 19:59:07 +09:00
  483977d5c8
• Wait for DialogOverlay load in more tests

  Apparently the previous fix was not enough as this can still be seen
  failing
  (https://github.com/ppy/osu/runs/5046718623?check_suite_focus=true).
  
  This change is copying from what other tests use seemingly reliably,
  such as `TestScenePerformFromScreen`)

  Dean Herbert · 2022-02-03 15:10:08 +09:00
  6355ac6663
• Move HasPassed/HasFailed into GameplayState
  Dan Balasescu · 2022-02-01 14:46:24 +09:00
  781cb9f18d
• Fix test failures if DialogOverlay is not loaded in time

  As seen at https://github.com/ppy/osu/runs/4999391205?check_suite_focus=true, where `DialogOverlay` hasn't loaded in single file yet.

  Dean Herbert · 2022-01-31 15:17:07 +09:00
  9001c3a396
• Fix score presentation tests not correctly entering song select before running
  Dean Herbert · 2022-01-29 14:46:24 +09:00
  4c97ed676f
• Add test coverage of the same thing but via "clear all scores" button
  Dean Herbert · 2022-01-28 15:54:53 +09:00
  2453bf5ed0
• Add test coverage of local score import and deletion
  Dean Herbert · 2022-01-28 15:50:36 +09:00
  778eebc94d
• Ensure gameplay starts by dismissing any notifications in TestSceneChangeAndUseGameplayBindings
  Dean Herbert · 2022-01-26 03:39:01 +09:00
  5085eb6801
• In gameplay bindings test, ensure a selection is made before attempting to enter gameplay
  Dean Herbert · 2022-01-25 17:55:33 +09:00
  90a7dd7711
• Remove Task from the inner-most Import method in RealmArchiveModelImporter

  One of my pending work items for post-realm merge.
  
  The lowest-level import task is no longer asynchronous, as we don't want
  it to span multiple threads to allow easier interaction with realm.
  Removing the `Task` spec simplifies a heap of usages.
  
  Individual usages should decide whether they want to run the import
  asynchronously, by either using an alternative override or spooling up a
  thread themselves.

  Dean Herbert · 2022-01-25 15:30:29 +09:00
  778d2a71b4
• Update terminology to realm "instance" rather than "context"

  This matches the terminology used by realm themselves, which feels
  better.

  Dean Herbert · 2022-01-24 20:38:38 +09:00
  f30894840c
• Rename RealmContextFactory to RealmAccess
  Dean Herbert · 2022-01-24 20:38:07 +09:00
  6eb2c28e41
• Merge pull request #16505 from peppy/remove-base-difficulty-usage

  Remove all usage of `BaseDifficulty` (and access `Difficulty` instead)

  Dan Balasescu · 2022-01-19 13:53:55 +09:00
  3e5d29ed00
• Remove all usage of AuthorString
  Dean Herbert · 2022-01-18 23:30:40 +09:00
  67bf95bc91
• Remove all usage of BaseDifficulty (and access Difficulty instead)
  Dean Herbert · 2022-01-18 22:57:39 +09:00
  7f65f3a47f
• Merge branch 'master' into global-bindable-thread-safety
  Dean Herbert · 2022-01-18 18:12:00 +09:00
  02baad30d7
• Add test coverage of startup ruleset being non-default
  Dean Herbert · 2022-01-18 16:22:15 +09:00
  8978b88f69
• Merge branch 'master' into realm-integration/score-and-beatmaps
  Dean Herbert · 2022-01-18 15:07:59 +09:00
  1b62a685f3
• Remove unused using
  Dan Balasescu · 2022-01-17 17:06:04 +09:00
  f6b9d36acf
• Add test to check full flow of rebinding gameplay key bindings

  Addresses a regression found in realm PR that was not covered by tests.

  Dean Herbert · 2022-01-17 16:00:17 +09:00
  12fd279b7d
• Merge branch 'master' into realm-integration/score-and-beatmaps
  Dean Herbert · 2022-01-13 18:25:09 +09:00
  4f8d29c1c0
• Fix intermitten screen navigation tests
  Dan Balasescu · 2022-01-13 05:52:04 +09:00
  672c1d36dc
• Localise EF context factory usage to migration only
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  e0c59f4b3c
• Remove unnecessary DI dependencies from cache test
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  4b690703b3
• Fix TestScenePresentScore sharing metadata/difficulty across multiple beatmaps
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  fa7dddcf3c
• Fix multiple tests via null checks and changing ToLive to Detach

  flow

  Dean Herbert · 2022-01-12 17:00:17 +09:00
  e74a5022c9
• Make tests compile again
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  31a3161189
• Remove EF FileStore
  Dean Herbert · 2022-01-12 16:39:36 +09:00
  116f35c52a