Dean Herbert
84b2f9a848
Make token private
2021-03-24 13:20:44 +09:00
Dean Herbert
a0c6c4da35
Rename and refactor token request process to be easier to understand
2021-03-24 13:17:29 +09:00
Dean Herbert
e372e355ef
Reorder overrides in SoloPlayer to better follow chronological request order
2021-03-24 13:12:51 +09:00
Dean Herbert
8bed7748d6
Rename token request method to avoid double Request terminology
2021-03-24 13:02:37 +09:00
Dean Herbert
a1c35677ef
Add more xmldoc
2021-03-24 13:02:17 +09:00
Dean Herbert
217f6083ca
Merge branch 'master' into solo-score-submission
2021-03-23 21:12:52 +09:00
Dan Balasescu
bb6e50eb27
Merge pull request #12151 from peppy/fail-dummy-api-requests
...
Fail all API requests sent to DummyAPIAccess
2021-03-23 20:54:04 +09:00
Dan Balasescu
578128f803
Merge branch 'master' into fail-dummy-api-requests
2021-03-23 20:14:56 +09:00
Dan Balasescu
ade542191a
Merge pull request #12154 from peppy/fix-hitcircle-glow-fade-out
...
Fix default skin's glow resetting fade on miss
2021-03-23 20:14:51 +09:00
Dan Balasescu
5f956971cc
Merge pull request #12153 from peppy/fix-appproach-circle-fade-out
...
Always fade out approach circles at a HitObject's start time to better match stable
2021-03-23 20:04:38 +09:00
Dean Herbert
d10ff615fe
Fix default skin's glow resetting fade on miss
2021-03-23 19:28:08 +09:00
Dean Herbert
64e85ba995
Always fade out approach circles at a HitObject's start time to better match stable
2021-03-23 19:19:07 +09:00
Dean Herbert
e649a330a4
Implement SoloPlayer's request construction
2021-03-23 18:23:25 +09:00
Dean Herbert
242b847516
Add flow for allowing gameplay to continue even when an error occurs with token retrieval
2021-03-23 18:23:25 +09:00
Dean Herbert
3cd8bf2d7f
Move token request construction to LoadAsyncComplete to better allow DI usage
2021-03-23 18:20:55 +09:00
Dean Herbert
571124669d
Remove all references to "score submission" from Player
2021-03-23 18:20:55 +09:00
Dean Herbert
194b2d05d3
Update SoloPlayer to derive SubmittingPlayer
2021-03-23 18:20:55 +09:00
Dean Herbert
12f050264a
Further split out a player class which submits to "rooms"
2021-03-23 18:20:55 +09:00
Dean Herbert
7045fce555
Move score submission logic in general out to its own Player type
2021-03-23 18:20:55 +09:00
Dean Herbert
6cb14e91c9
Make Player abstract and introduce SoloPlayer
2021-03-23 18:18:49 +09:00
Dean Herbert
5267fb74c4
Add submission requests
2021-03-23 18:18:49 +09:00
Dean Herbert
aeff9bd853
Add return bool to HandleRequest to better trigger failures
2021-03-23 18:17:29 +09:00
Dean Herbert
ce452565f4
Avoid firing any kind of failures after success
2021-03-23 17:50:31 +09:00
Dan Balasescu
9e38d580ca
Merge pull request #12139 from peppy/fix-editor-spinner-looping-too-long
...
Fix spinners playing looping sound too long in the editor
2021-03-23 17:44:07 +09:00
Dean Herbert
f5ba746ae5
Fail all API requests sent to DummyAPIAccess
...
Until now, API requests sent to dummy API were just lost in the void. In most cases this somehow worked as expected, but any logic which is waiting on a request to finish will potentially never get a response.
Going forward, I'm not 100% sure that every `Wait` on a web response will have local timeout logic (I think there is a certain amount of assumption that this is being managed for us by `APIAccess`), so I've made this change to better handle such cases going forward. Now, rather than nothing happening, requests will trigger a failure via the existing exception logic rather than silently pretending the request never arrived.
2021-03-23 17:37:45 +09:00
Dean Herbert
3594c42b79
Merge pull request #12141 from smoogipoo/perfect-curve-failure-testcase
2021-03-23 17:23:00 +09:00
Dan Balasescu
3ec3624ac5
Merge branch 'master' into fix-editor-spinner-looping-too-long
2021-03-23 16:45:41 +09:00
Dan Balasescu
f6ed3c1b1e
Merge branch 'master' into perfect-curve-failure-testcase
2021-03-23 16:44:58 +09:00
Dan Balasescu
17a28f4f65
Merge pull request #12136 from peppy/remove-skin-sample-workarounds
...
Remove local workarounds to attempt to avoid crashes on skin change
2021-03-23 16:44:29 +09:00
Dean Herbert
08fcdc8ee4
Update difficulty calculator tests with floating point differences
2021-03-23 15:38:01 +09:00
Dan Balasescu
d758343a45
Merge pull request #12149 from peppy/fix-score-token-data-type
...
Fix APIScoreToken's data type not matching server side
2021-03-23 14:54:02 +09:00
Dean Herbert
1171214541
Update framework
2021-03-23 14:51:22 +09:00
Dean Herbert
a5842a5485
Merge branch 'master' into remove-skin-sample-workarounds
2021-03-23 14:51:14 +09:00
Dan Balasescu
5f2c6b8d59
Merge pull request #12145 from bdach/mania-auto-hold-note-release
...
Remove release delay for hold notes when generating autoplay
2021-03-23 14:24:56 +09:00
Dean Herbert
9c690f9545
Fix second usage
2021-03-23 14:08:00 +09:00
Dean Herbert
58c60100b4
Fix APIScoreToken's data type not matching server side
2021-03-23 14:04:47 +09:00
Dean Herbert
c89199b38b
Merge pull request #12148 from Joehuu/fix-deleted-comments-trash-icon
...
Fix incorrect trash icon being used on deleted comments counter
2021-03-23 11:53:14 +09:00
Joehu
16b3f22caf
Fix incorrect trash icon being used on deleted comments counter
2021-03-22 19:32:17 -07:00
Dean Herbert
098005393e
Remove unnecessary null checks and debug code
2021-03-23 10:38:37 +09:00
Dean Herbert
d612964ac8
Merge pull request #12144 from bdach/remove-osutk-run-config
...
Remove osuTK desktop rider run config
2021-03-23 10:19:47 +09:00
Bartłomiej Dach
29d4162e4e
Remove release delay for hold notes when generating autoplay
...
It was more intended for normal notes anyway (as they would be released
pretty much instantaneously, if it weren't for the delay).
2021-03-22 22:45:21 +01:00
Bartłomiej Dach
d85929d721
Adjust autoplay generation tests to match expected behaviour
2021-03-22 22:45:21 +01:00
Bartłomiej Dach
a65e491768
Remove osuTK desktop rider run config
...
No longer operational since 6eadae8
2021-03-22 20:00:36 +01:00
Bartłomiej Dach
779d2ed5d9
Merge pull request #12138 from smoogipoo/mania-legacy-key-fade-delay
2021-03-22 19:09:00 +01:00
smoogipoo
e60ff45b73
Add another test for colinear perfect curves
2021-03-22 16:57:40 +09:00
Dean Herbert
5b1d9f4cf0
Fix constant case
2021-03-22 16:19:29 +09:00
Dean Herbert
690fb9224a
Combine constants for readability
2021-03-22 16:18:31 +09:00
Dean Herbert
c4d08463ad
Fix spinners playing looping sound too long in the editor
...
The `OnComplete` event was never being run due to the transform playing
out longer than the spinner's lifetime. I've matched the durations, but
also moved the `Stop()` call to what I deem a safer place to run it (I
did notice that without this it would still potentially never fire).
Note that this is more noticeable in the editor because of lifetime
extension. In gameplay, the returning of a spinner to the pool will
clean things up (but in the editor that can take longer, depending on
timeline zoom level).
Another thing worth mentioning is that the fade doesn't actually work.
This is due to https://github.com/ppy/osu-framework/pull/4212 .
Closes #12119 .
2021-03-22 16:04:51 +09:00
smoogipoo
db64fac824
Delay key fade in legacy mania skins
2021-03-22 15:26:22 +09:00
Dean Herbert
7034289763
Merge pull request #12133 from bdach/hold-note-freezing-regression
2021-03-22 14:11:53 +09:00
