54 Commits

• Do not show timing distribution graph in offset control if there's not enough timed hits

  Intended to address concerns raised in
  https://github.com/ppy/osu/pull/30620#issuecomment-2475744164.

  Bartłomiej Dach · 2024-11-14 13:17:03 +01:00
  bd1d3cad49
• Fix offset adjust control not correctly applying changes after song select quit

  This is an interesting scenario where we arrive at a fresh
  `BeatmapOffsetControl` but with a reference score (from the last play).
  
  Our best assumption here is that the beatmap's offset hasn't changed
  since the last play, so we want to use it for the `lastPlayBeatmapOffset`.
  But due to unfortunate order of execution, `Current.Value` was not yet
  initialised.

  Dean Herbert · 2024-09-05 19:04:52 +09:00
  37f61b26ea
• Inline enabled setting
  Dean Herbert · 2024-06-15 17:34:04 +08:00
  ff2d721029
• Set to enable or disable at load time
  Shiumano · 2024-06-14 21:43:17 +09:00
  6c82f1de9b
• Show tooltip on global offset adjust slider bar
  Dean Herbert · 2024-01-17 17:57:49 +09:00
  cc7be137bc
• Change display text for beatmap audio offset adjust to make more sense
  Dean Herbert · 2024-01-17 17:51:46 +09:00
  123e36a999
• Fix code quality inspection
  Bartłomiej Dach · 2023-12-28 14:12:28 +01:00
  619b0cc69b
• Expose the ability to update global offset from the player loader screen
  Dean Herbert · 2023-12-28 20:01:34 +09:00
  b7f3c83514
• Migrate BeatmapOffsetControl to use session static directly
  Bartłomiej Dach · 2023-12-27 19:19:27 +01:00
  1b7af989ec
• Add conditions to match stable offset adjust limitations
  Dean Herbert · 2023-12-24 02:36:27 +09:00
  72bec527fd
• Don't bother with alt support for now
  Dean Herbert · 2023-12-24 01:59:48 +09:00
  92b490f2e7
• Allow external use of offset text explanation
  Dean Herbert · 2023-12-23 20:46:12 +09:00
  7e9522a722
• Add basic hotkey offset adjust support (via existing offset control)
  Dean Herbert · 2023-12-23 19:55:05 +09:00
  27a9dcc5a1
• Change offset calibration control to adjust for all difficulties of the current beatmap set
  Dean Herbert · 2023-07-19 17:13:19 +09:00
  5ec9cd84b2
• Add IHasNoTimedInputs interface to scope change further
  Dean Herbert · 2023-06-06 22:22:42 +09:00
  247fa088db
• Don't show offset calibration controls when "relax" mod is active

  Closes https://github.com/ppy/osu/issues/22892.

  Dean Herbert · 2023-03-22 15:45:04 +09:00
  c65a79614d
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Apply changes in line with framework NRT updates
  Dean Herbert · 2022-11-18 18:13:15 +09:00
  06ce8130c2
• Cleanup all other leftover binding instantiation
  o-dasher · 2022-09-25 16:02:40 -04:00
  feadac1f79
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Use LocalisableString.Interpolate instead of invalid TranslatableStrings
  Salman Ahmed · 2022-04-28 11:38:40 +03:00
  691bec6f16
• Only null the realm write task if it actually completed
  Dean Herbert · 2022-03-09 13:52:58 +09:00
  6bf436cd62
• Ensure the value used during realm async write is the same as whe compared for equality
  Dean Herbert · 2022-03-08 19:36:23 +09:00
  960b6528ca
• Fix feedback from realm writes causing offset slider to jump around
  Dean Herbert · 2022-03-08 19:36:08 +09:00
  daa42584f4
• Merge branch 'master' into realm-property-watching
  Dean Herbert · 2022-03-07 13:53:17 +09:00
  31d6c75f40
• Merge branch 'master' into offset-ui-improvements
  Bartłomiej Dach · 2022-03-05 16:10:18 +01:00
  e4b4c3c5c4
• Revert changes to GetTooltipText and use TooltipText override directly
  Dean Herbert · 2022-03-05 22:46:13 +09:00
  ce51ce49cf
• Merge branch 'master' into add-offset-adjust-tooltip-text
  Dean Herbert · 2022-03-05 22:37:04 +09:00
  bbc2b36117
• Reorder math to be easier to pass

  Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>

  Dean Herbert · 2022-03-04 17:54:04 +09:00
  1c40fcb79e
• Fix calibrating offset from previous non-zero offset not applying adjustment correctly
  Dean Herbert · 2022-03-04 15:09:44 +09:00
  e9e92b991e
• Allow an offset to be shown on the timing distribution graph
  Dean Herbert · 2022-03-04 14:05:42 +09:00
  010fa7ed01
• Fix calibrating offset from previous non-zero offset not applying adjustment correctly
  Dean Herbert · 2022-03-04 13:25:14 +09:00
  e09dd7d8fe
• Add tooltip text for offset adjustment slider
  Dean Herbert · 2022-03-04 12:44:02 +09:00
  cc4f89eef4
• Rename lambda param to avoid name shadowing
  Bartłomiej Dach · 2022-03-03 20:28:19 +01:00
  15f65c7897
• Use property expression rather than block
  Bartłomiej Dach · 2022-03-03 20:28:00 +01:00
  2e24e7ef56
• Trim unused using directives
  Bartłomiej Dach · 2022-03-03 20:21:48 +01:00
  edd361d256
• Update existing usages to use SubscribeToPropertyChanged
  Dean Herbert · 2022-03-03 17:42:50 +09:00
  cecc746f9e
• Add tooltip text for offset adjustment slider
  Dean Herbert · 2022-03-03 17:07:46 +09:00
  3848964faa
• Use more correct mod check to encompass more than just autoplay
  Dean Herbert · 2022-03-02 14:42:10 +09:00
  763f881d4a
• Remove Precision call for database write shortcutting

  Shouldn't be required.

  Dean Herbert · 2022-03-02 14:39:29 +09:00
  e184b26cdd
• Fix incorrect precision specification for button disable check
  Dean Herbert · 2022-03-02 14:36:49 +09:00
  8bd66f1ed7
• Fix calibration button disabled state not checking in corrrect direction
  Dean Herbert · 2022-03-02 14:36:15 +09:00
  3cbcb702f6
• Enable nullable on BeatmapOffsetControl
  Dean Herbert · 2022-03-02 14:34:24 +09:00
  c07f754565
• Fix calibration being back-to-front
  Dean Herbert · 2022-03-01 20:41:54 +09:00
  222f50d211
• Reorder fields in BeatmapOffsetControl and MasterGameplayClockContainer
  Dean Herbert · 2022-03-01 20:16:55 +09:00
  6c09237956
• Don't show calibration controls for autoplay
  Dean Herbert · 2022-03-01 20:12:59 +09:00
  9792f0653a
• Add localisation of all beatmap offset strings
  Dean Herbert · 2022-03-01 20:12:59 +09:00
  4aee57c9c1
• Don't display calibration options when the previous play was too short to be useful
  Dean Herbert · 2022-03-01 20:12:59 +09:00
  4d9efe771b
• Handle cases of beatmaps not existing in realm for tests
  Dean Herbert · 2022-03-01 20:12:59 +09:00
  bc2a15db96
• Allow BeatmapOffsetControl to react to external changes to offset
  Dean Herbert · 2022-03-01 20:12:59 +09:00
  99c1ba19aa