63459 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Dean Herbert	7bedf7cf16	Move static method to end of file	2023-11-07 21:08:49 +09:00
Dean Herbert	38c9a98e67	Add failing test coverage	2023-11-07 19:54:21 +09:00
Salman Ahmed	073249dafb	Allow tinkering with cursor-related settings in resume overlay test scene	2023-11-06 18:35:46 +03:00
Salman Ahmed	e12ee29a94	Update existing test coverage	2023-11-06 18:35:30 +03:00
Salman Ahmed	75fbbb35ad	Move cursor scale application within OsuCursor ... Doing so takes down two birds with one stone. 1. `ResumeOverlay` having to manually apply cursor scale to its "resume cursor". 2. Resume cursor input handling scaling up with the gameplay setting. Now, only the sprite itself gets scaled.	2023-11-06 18:30:55 +03:00
Salman Ahmed	915feeffb0	Revert gameplay cursor scale changes	2023-11-06 17:37:32 +03:00
Salman Ahmed	9cb331641c	Rename container	2023-11-05 06:34:09 +03:00
Salman Ahmed	99405a2bbd	Tidy up resume overlay test scene	2023-11-05 06:28:51 +03:00
Salman Ahmed	48a75f6152	Fix resume cursor following gameplay cursor scale setting	2023-11-05 06:28:10 +03:00
Dan Balasescu	bc9cdb4ce0	Merge pull request #25341 from peppy/slider-combo-matching ... Rename and invert flags for slider classic behaviours	2023-11-03 11:27:22 +09:00
Bartłomiej Dach	a0757ce13f	Update xmldoc to match flipped flag semantics	2023-11-02 18:58:14 +01:00
Bartłomiej Dach	86ede717cb	Clean up comment	2023-11-02 18:52:47 +01:00
Dean Herbert	ac6fb386d1	Remove nested ternary	2023-11-02 23:42:52 +09:00
Bartłomiej Dach	efb4458061	Merge pull request #25336 from peppy/mania-key-expand-mobile ... Add support for "argon" default skin to expand columns when on mobile devices	2023-11-02 12:40:57 +01:00
Bartłomiej Dach	998d709331	Merge branch 'master' into mania-key-expand-mobile	2023-11-02 11:59:01 +01:00
Dean Herbert	704f5a6de3	Adjust sizing slightly to ensure we stay within 1366 limits	2023-11-02 11:44:36 +01:00
Bartłomiej Dach	e18d0b64de	Merge pull request #25338 from peppy/mania-mod-ordering ... Change osu!mania conversion mod ordering to be more appeasing	2023-11-02 10:46:32 +01:00
Dean Herbert	bf9f20705f	Simplify classic behaviour flag to only need to be specified on the slider itself	2023-11-02 18:31:29 +09:00
Dean Herbert	a7705284e7	Add better commenting around DrawableSliderHead logic	2023-11-02 18:31:28 +09:00
Dean Herbert	9af2a5930c	Remove redundant passing of Scale to nested objects	2023-11-02 17:52:10 +09:00
Dean Herbert	9c1f4b552e	Rename and invert flags for slider classic behaviours	2023-11-02 17:43:21 +09:00
Bartłomiej Dach	64feea80db	Merge pull request #25334 from peppy/fix-bubble-crash-again ... Fix another potential crash in bubbles mod	2023-11-02 09:32:09 +01:00
Bartłomiej Dach	b7ab886848	Merge pull request #25333 from peppy/fix-spinner-performance ... Fix all spinner ticks being alive and causing performance degradation	2023-11-02 09:07:44 +01:00
Bartłomiej Dach	ad82ada030	Trim redundant comments	2023-11-02 08:18:37 +01:00
Dean Herbert	c83589cb74	Change osu!mania conversion mod ordering to be more appeasing	2023-11-02 15:49:10 +09:00
Dean Herbert	6dab5ee4cf	Add support for "argon" default skin to expand columns when on mobile device ... Should ease those looking to play the game on mobile until we (potentially) have a better solution in the future. If this works out well, we can consider rolling it out to other skins. Closes https://github.com/ppy/osu/issues/23377.	2023-11-02 15:13:44 +09:00
Dean Herbert	48bdeaeff1	Fix another potential crash in bubbles mod ... Storing `DrawableHitObject` for later use is not safe – especially when accessing `HitObject` – as it's a pooled class. In the case here, it's important to note that `PrepareForUse` can be called a frame or more later in execution, which made this unsafe. Closes https://github.com/ppy/osu/issues/24444.	2023-11-02 02:43:51 +09:00
Dean Herbert	c2de03aa44	Fix all spinner ticks being alive and causing performance degradation ... Regressed in https://github.com/ppy/osu/pull/25216. The new logic will ensure at least one tick is ready for judgement. There shouldn't be a case where more than one is needed in a single frame.	2023-11-01 18:28:07 +09:00
Dean Herbert	57d8b5ddc9	Merge pull request #25328 from bdach/mod-cleanups-docs ... Clean up mod usability flags	2023-11-01 15:48:47 +09:00
Bartłomiej Dach	a90f8dd4f6	Seal a few more multiplayer playability flags of rate-changing mods ... Not really changing anything, just tightening things down to curb possible funny business.	2023-10-31 16:20:33 +01:00
Bartłomiej Dach	955e2ed051	Seal UnknownMod ... Not a class for extension.	2023-10-31 16:18:09 +01:00
Bartłomiej Dach	a644c75957	Mark ModScoreV2 as invalid for multiplayer ... Doesn't do much for the client; mostly a safety for osu-web's sake, as without the change it could theoretically fail to validate the mod properly in multiplayer contexts.	2023-10-31 16:16:59 +01:00
Bartłomiej Dach	456f4ebba2	Seal ModScoreV2 ... Nobody should ever need to extend it.	2023-10-31 16:16:14 +01:00
Bartłomiej Dach	3a2645efb1	Seal ModAutoplay playability flags ... Can't do much more than that due to the unfortunate fact of Cinema inheriting from Autoplay.	2023-10-31 16:15:10 +01:00
Bartłomiej Dach	7ea298a1b6	Add xmldoc to Mod playability flags	2023-10-31 16:13:44 +01:00
Dean Herbert	95d8ee8e9b	Merge pull request #25323 from bdach/fix-key-binding-test-failures ... Fix key binding row fire-and-forgetting writes	2023-10-31 22:13:42 +09:00
Bartłomiej Dach	9f5a280bc2	Fix key binding row fire-and-forgetting writes ... Intends to fix test failures as seen in https://github.com/ppy/osu/actions/runs/6692350567/job/18181352642#step:5:129 This is what happens if you carelessly fire and forget. The working theory (that I'm not sure I have the tools to conclusively confirm) is that the async write from the key binding changing could fire _after_ the section is reset. I briefly considered having the test wait for the change, but given that the entirety of the surrounding flow is using sync operations, this just looks like a bug to me. And there's no real sane way to inject async into that flow due to dependence on `OsuButton.Action`.	2023-10-31 12:25:09 +01:00
Bartłomiej Dach	bc2acc3e93	Merge pull request #25318 from peppy/fix-follow-point-scrathces ... Fix potential texture corruption when cropping gameplay textures of weird aspect ratios	2023-10-31 11:02:59 +01:00
Bartłomiej Dach	850866e7f4	Merge pull request #25316 from peppy/metronome-always-play-tick ... Decouple metronome tick playback from pendulum movement	2023-10-31 09:37:29 +01:00
Dean Herbert	0d44b5af90	Fix potential texture corruption when cropping gameplay textures of weird aspet ratios ... Closes https://github.com/ppy/osu/issues/25273.	2023-10-31 17:36:23 +09:00
Bartłomiej Dach	84fb0c63e5	Merge pull request #23823 from peppy/beat-divisor-select-text-on-click ... Select text in beat divisor popover automatically	2023-10-31 09:34:44 +01:00
Bartłomiej Dach	144006fbe8	Update autoselect implementation to work correctly with framework changes	2023-10-31 08:38:22 +01:00
Bartłomiej Dach	8a68333425	Merge branch 'master' into beat-divisor-select-text-on-click	2023-10-31 08:36:53 +01:00
Bartłomiej Dach	af84704076	Merge pull request #25315 from peppy/fix-flaky-tests ... Address some flaky tests from recent times	2023-10-31 08:30:19 +01:00
Dean Herbert	64efc3d251	Decouple metronome tick playback from pendulum movement ... Not super happy about doing this, but it seems like it's in the best interest of editor usability.	2023-10-31 15:33:46 +09:00
Dean Herbert	8c067dc584	Fix mod tests not waiting for presets to finish loading ... See https://github.com/ppy/osu/actions/runs/6692350567/job/18181352850.	2023-10-31 14:53:07 +09:00
Dean Herbert	7ceced7012	Scope TestPauseWithLargeOffset to focus on what matters ... See https://github.com/ppy/osu/actions/runs/6693917410/job/18186111009 This test is to make sure we don't seek before the original pause time, so I've exposed that value precisely to avoid CI woes.	2023-10-31 14:47:04 +09:00
Dean Herbert	d379e553da	Fix back-to-front logging	2023-10-31 14:31:26 +09:00
Dean Herbert	bdd3f2847b	Add an extra storyboard sample to avoid intermittent failures in TestStoryboardSamplesStopOnSkip ... Probably CI running slow timing balls. The point of failure is `waitUntilStoryboardSamplesPlay()` after already testing the important part of the test (that the samples stop on skip) so let's give it another possible point to recover. See https://github.com/ppy/osu/actions/runs/6698399814/job/18201753701.	2023-10-31 14:28:40 +09:00
Dean Herbert	66b84d02cb	Add note about TestGameplayExitFlow failure, and ignore for now ... See: https://github.com/ppy/osu/actions/runs/6695995685/job/18194110641 https://github.com/ppy/osu/actions/runs/6700910613/job/18208272419	2023-10-31 14:27:55 +09:00