1
0
mirror of https://github.com/ppy/osu.git synced 2025-01-18 10:53:21 +08:00
Commit Graph

44909 Commits

Author SHA1 Message Date
smallketchup82
7a5e613cf6
Disallow opening settings menu when external edit ovelay is open
Also disallows using the random skin keybind when the external edit
overlay is open. SkinEditor should already be disabling it, but I
figured we might as well add this in for redundancy
2024-12-16 11:33:51 -05:00
Bartłomiej Dach
09d55ed306
Merge branch 'master' into skin-mounting 2024-12-12 12:16:22 +09:00
smallketchup82
165afe357f
Rename SkinInfo when it is changed in skin.ini
Peppy spoke about using a shortcut and/or hashes to determine if the
skin.ini is changed, and if so, then to rename the skin.

In my opinion, hashing and doing numerous comparisons is probably less
efficient than just syncing the SkinInfo's name during the update.

This is an easy solution that does what it needs to.
2024-12-11 10:19:10 -05:00
Bartłomiej Dach
4e4a99decc
Merge pull request #31076 from peppy/beatmap-store-interface
Access beatmap store via abstract base class
2024-12-11 17:48:32 +09:00
Dean Herbert
2a4f596f90
Merge branch 'master' into ios-beatmap-export 2024-12-10 23:59:15 -08:00
Dean Herbert
02c52e41bd
Merge pull request #31039 from frenzibyte/ios-temporary-export-storage
Use temporary storage for file exports on iOS
2024-12-10 23:53:40 -08:00
Dean Herbert
a868c33380
Remove BeatmapCarousel testing backdoor 2024-12-11 16:28:51 +09:00
Dean Herbert
c94b393e30
Access beatmap store via abstract base class
The intention here is to make things more testable going forward.
Specifically, to remove the "back-door" entrance into `BeatmapCarousel`
where `BeatmapSets` can be set by tests and bypas/block realm retrieval.
2024-12-11 16:28:51 +09:00
Dean Herbert
bab9b9c937
Remove no-longer-correct comment 2024-12-11 16:28:50 +09:00
Dean Herbert
de31a48beb
Some Carousel classes can be abstract 2024-12-11 16:28:50 +09:00
Bartłomiej Dach
c4374c7315
Merge branch 'master' into medal-display-fix 2024-12-11 15:52:38 +09:00
Salman Alshamrani
e0aec6f907 Revert unnecessary complexity 2024-12-11 01:03:55 -05:00
Bartłomiej Dach
89e3c551ff
Merge pull request #30860 from frenzibyte/editor-multiple-background-audio-files
Allow choosing different background/audio files for individual difficulties
2024-12-11 14:12:58 +09:00
Salman Alshamrani
e6e79cbd11
Merge branch 'master' into silly-thing 2024-12-10 03:00:53 -05:00
Dean Herbert
bbaa542d4a
Add note about expensive operation 2024-12-10 16:45:26 +09:00
Dean Herbert
3cac583754
Rewrite resource changing code to be more legible (to my eye) 2024-12-10 16:45:26 +09:00
Dean Herbert
48bf2fa001
Merge pull request #30960 from bdach/bookmarks
Implement basic bookmark support in editor
2024-12-09 23:42:04 -08:00
Bartłomiej Dach
7fcfebf4b4
Use Alt-{Left,Right} as default bindings for bookmark navigation 2024-12-10 14:59:19 +09:00
Dean Herbert
d69f5fd4cf
Avoid beatmap lookup per bar in logo visualisation
Just noticed in passing.
2024-12-10 14:45:36 +09:00
Dean Herbert
92dfcae6eb
Adjust bad grammar 2024-12-10 14:35:09 +09:00
Dean Herbert
7ec2d91e14
Merge branch 'master' into editor-multiple-background-audio-files 2024-12-10 14:19:55 +09:00
Bartłomiej Dach
1febed66cf
Fix top score statistics section total score display being terminally broken
Closes https://github.com/ppy/osu/issues/31038.

If you don't realise why this does anything, realise this: the drawable
creation callback runs for every created sprite text in the text flow.
ANd the created sprite texts are split by whitespace. And Russian /
Ukrainian / Polish etc. use spaces as thousands separators.
So on those languages the first encountered part of the score would
duplicate itself to the remaining parts.

I'm actively convinced it was _more difficult_ to produce what was in
place in `master` than to do it properly. Why did `TextColumn` even have
`LocalisableString Text` and `Bindable<string> Current` next to each
other?????
2024-12-09 23:51:57 +09:00
Salman Alshamrani
0c0dcb1e15 Use temporary storage for exported files on iOS 2024-12-09 08:16:37 -05:00
Salman Alshamrani
e9868c6318 Enable exporting beatmaps in iOS 2024-12-09 07:47:28 -05:00
Dan Balasescu
1b8d9370aa
Merge pull request #30973 from frenzibyte/copy-effect-points
Preserve effect point specifications when creating blank difficulties
2024-12-09 16:13:52 +09:00
Bartłomiej Dach
459533aba6
Merge branch 'master' into bookmarks 2024-12-07 22:22:04 +09:00
Endrik Tombak
b04f5ab6e4 Fix IPC not working in release 2024-12-07 14:13:14 +02:00
Dean Herbert
b9f1fef250
Update framework 2024-12-07 10:46:03 +09:00
Dean Herbert
e22f3b7d05
Merge branch 'master' into named-pipe 2024-12-07 10:42:55 +09:00
Dean Herbert
5849a69a86
Merge pull request #30921 from huoyaoyuan/netcore-analyzer
Set up-to-date .NET code quality analyzers
2024-12-06 17:29:09 -08:00
Salman Alshamrani
5cb6b86b1c Fix reference effect point getting mutated 2024-12-06 05:47:41 -05:00
Dean Herbert
69014550b5
Remove unnecessary null checks 2024-12-06 12:48:06 +09:00
Dean Herbert
49f4b0e6ef
Update resources 2024-12-05 21:07:13 +09:00
Dean Herbert
84a85000af
Update framework 2024-12-05 21:07:08 +09:00
Dean Herbert
8d0e1f9d18
Merge branch 'master' into improve-menu-sample-playback 2024-12-05 21:07:03 +09:00
Huo Yaoyuan
d92ea910cf Merge branch 'master' into netcore-analyzer 2024-12-05 17:18:56 +08:00
Dean Herbert
3d6e766b32
Merge pull request #30976 from frenzibyte/hide-some-settings
Hide debug settings in release builds
2024-12-05 00:24:26 -08:00
Salman Alshamrani
1b1e7b63e9 Clean up code slightly 2024-12-05 02:48:51 -05:00
Dean Herbert
791416c8f1
Merge pull request #30937 from frenzibyte/fix-quick-restart-not-saving-score
Fix score no longer being saved when quick-restarting after pass
2024-12-04 23:48:18 -08:00
Salman Alshamrani
7c1be5eca2 Remove unnecessary localisations 2024-12-05 02:45:43 -05:00
Salman Alshamrani
7ab16a55e5 Make debug section only visible on debug builds 2024-12-05 02:42:08 -05:00
Salman Alshamrani
f83ec721fb Move latency certifier and import files button outside debug section 2024-12-05 02:42:08 -05:00
Dean Herbert
72aa65206d
Merge pull request #30965 from Susko3/use-GetLocalisedString
Use `LocalisationManager.GetLocalisedString()` instead of bindable hack
2024-12-04 23:34:32 -08:00
Salman Alshamrani
a7586c52d0
Merge branch 'master' into results-screen-quick-retry-transition 2024-12-04 06:31:14 -05:00
Salman Alshamrani
fa87df6c6a Move non-current handling to PerformExit
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-12-04 04:55:55 -05:00
Salman Alshamrani
8e0f6fc12d Re-encode difficulties on resource change 2024-12-04 04:36:00 -05:00
Salman Alshamrani
60d91bada8 Merge branch 'master' into editor-multiple-background-audio-files 2024-12-04 04:31:15 -05:00
Salman Alshamrani
e3abbf1177 Copy effect points across on blank difficulty creation 2024-12-04 02:32:00 -05:00
Dan Balasescu
ad4df82593
Improve multiplayer listing search by making it fuzzy 2024-12-04 16:26:36 +09:00
Dean Herbert
a4d58648e2
Fix quick retry transition from results screen 2024-12-04 14:31:39 +09:00