Dean Herbert
f4ef841972
Add fallback for cases where beatmap has no author/title/artist specified
2021-11-10 18:29:05 +09:00
Dan Balasescu
9404eac227
Merge pull request #15552 from Naxesss/dispose-background-after-check
...
Use disposal in `CheckBackgroundQuality`
2021-11-10 15:05:46 +09:00
Dan Balasescu
e566b8a3d4
Merge pull request #15551 from peppy/fix-team-display-not-displaying
...
Fix `TeamDisplay` not showing after changing to team versus
2021-11-10 15:04:33 +09:00
Naxesss
72ee2b1556
Refactor to avoid duplicate code
2021-11-10 06:18:40 +01:00
Dean Herbert
328c72c358
Fix TeamDisplay not showing after changing to team versus
2021-11-10 13:44:31 +09:00
Dean Herbert
52c740b377
Add failing test showing team display display failure
2021-11-10 13:44:31 +09:00
Naxesss
b888185799
Properly dispose of Stream in bg quality check
2021-11-10 05:06:11 +01:00
Naxesss
5dc6a9ed21
Add background stream closed test
2021-11-10 05:04:30 +01:00
apollo-dw
2d2a6d8a18
Swap to a harsher formula for slider dropped nerf
2021-11-10 04:00:54 +00:00
Semyon Rozhkov
577bdade5b
Hide catcher during banana shower
2021-11-10 04:10:05 +03:00
apollo-dw
fe2f143e8a
Nerf slider aim for plays with dropped slider ends
2021-11-10 00:59:28 +00:00
Semyon Rozhkov
41f4f0ab5e
Different setting slider description in each mod
2021-11-10 03:57:22 +03:00
Semyon Rozhkov
ce0eb0b26f
Using IUpdatableByPlayfield
2021-11-10 03:53:30 +03:00
Darius Wattimena
4e092fed0f
Removed accidentally added Rider legacy UserContentModel
2021-11-10 00:35:09 +01:00
Darius Wattimena
bd5caceeb1
Fixed typo in banana shower gap check message
2021-11-10 00:23:14 +01:00
Darius Wattimena
5d8f35f3c9
Code cleanup and added tests for the spinner check
2021-11-10 00:16:29 +01:00
Darius Wattimena
fbfed16756
Started on implementing a spinner gap check for catch
2021-11-09 23:05:25 +01:00
Bartłomiej Dach
410e9159d1
Fix test failures due to missing dependencies
2021-11-09 19:54:38 +01:00
Bartłomiej Dach
042b05a250
Move clipboard action availability logic down to editor screens
2021-11-09 19:54:37 +01:00
Bartłomiej Dach
286754f6f7
Move clipboard operation implementation down to current screen
2021-11-09 19:54:37 +01:00
Semyon Rozhkov
64bc8da14c
Add "No Scope" mod implementation for Catch
2021-11-09 17:11:19 +03:00
Bartłomiej Dach
03a315b9f5
Fix missing beatmap in replay download test scene
...
Was causing nullrefs in `GetDisplayTitle()`.
2021-11-09 14:33:06 +01:00
Bartłomiej Dach
3d148aea40
Fix GetDisplayTitle() implementations relying on ToString() themselves
2021-11-09 13:53:08 +01:00
Bartłomiej Dach
9686bf507d
Add failing tests for coverage of GetDisplayString()
2021-11-09 13:53:08 +01:00
Bartłomiej Dach
5ec8288508
Add GetDisplayString() extension to handle all model interface types globally
2021-11-09 13:53:07 +01:00
Dan Balasescu
baa5285b59
Merge pull request #15535 from peppy/remove-bass-track-ctor-usage
...
Rewrite `PreviewTrackManager` to avoid constructing `TrackBass` locally
2021-11-09 21:36:49 +09:00
Bartłomiej Dach
a1b55d6490
Add failing test case
2021-11-09 13:34:36 +01:00
Bartłomiej Dach
eba3cfc96e
Move ScoreInfo string representation to extension method
2021-11-09 13:23:57 +01:00
Bartłomiej Dach
4aee2844f6
Merge pull request #15533 from peppy/fix-realm-migration-crash
...
Fix realm migration potentially failing for users that haven't run osu! in a long time
2021-11-09 11:21:56 +01:00
Bartłomiej Dach
31b0acde85
Merge branch 'master' into fix-realm-migration-crash
2021-11-09 10:54:17 +01:00
Dean Herbert
dfbc1f3394
Fix "conflicting" variable name
2021-11-09 17:42:03 +09:00
Dean Herbert
3b485b5f37
Rewrite PreviewTrackManager to avoid constructing TrackBass locally
...
This paves the way for the framework code quality change
(https://github.com/ppy/osu-framework/pull/4873 ) which stops exposing
the constructor.
Most of the restructuring here is required to give `PreviewTrackManager`
an adjustable target to apply the global mute.
2021-11-09 17:38:12 +09:00
Bartłomiej Dach
0cb5113601
Merge pull request #15470 from M0RGaming/master
...
Add unstable rate counter to HUD
2021-11-09 09:07:20 +01:00
Bartłomiej Dach
74c37e248d
Merge branch 'master' into master
2021-11-09 08:40:52 +01:00
Dean Herbert
999d625e76
Fix realm migration potentially failing for users that haven't run osu! in a long time
...
As reported at https://github.com/ppy/osu/discussions/15530 .
2021-11-09 14:51:10 +09:00
Dean Herbert
0f129b2cfb
Disable dependabot for now
2021-11-09 12:45:00 +09:00
Chinmay Patil
1b11a034a7
Reverted Default Skin Changes
2021-11-08 07:25:02 -07:00
Dean Herbert
423b1397fc
Merge pull request #15526 from Susko3/move-HoverClickSounds
...
Move `HoverClickSounds` to cover only the clickable button in `KeyBindingRow`
2021-11-08 23:01:05 +09:00
Dean Herbert
2b518035da
Merge pull request #15522 from bdach/taiko-slider-multiplier-saving
...
Fix taiko beatmap scroll speed increasing after every save in editor
2021-11-08 22:51:43 +09:00
Dean Herbert
694df5dd54
Merge pull request #15520 from bdach/beatmap-card/favourite-button
...
Add favourite button to beatmap card
2021-11-08 22:34:56 +09:00
Susko3
8a23b648fe
Move HoverClickSounds to the clickable button
2021-11-08 14:32:00 +01:00
Chinmay Patil
d5ad776c33
Remove decimal part of UR Counter and rename methods
2021-11-08 06:27:25 -07:00
Bartłomiej Dach
74603253d2
Store full model rather than online ID only
2021-11-08 13:42:56 +01:00
Dean Herbert
72489b32f9
Move toggle code into own method for readability
2021-11-08 21:39:16 +09:00
Dean Herbert
9a2425f316
Remove unused field for now to appease inspectcode
2021-11-08 21:36:28 +09:00
Bartłomiej Dach
540b7e1b38
Fix taiko editor not unapplying slider multiplier changes on save
2021-11-08 13:28:42 +01:00
Bartłomiej Dach
d88fd1bfd7
Add failing test case
2021-11-08 13:23:24 +01:00
Bartłomiej Dach
f4b8dee2d0
Update favourite statistic value on favourite button clicks
2021-11-08 11:53:54 +01:00
Bartłomiej Dach
b5cbdcf981
Implement basic behaviour of favourite button
2021-11-08 11:53:54 +01:00
Bartłomiej Dach
5cb533004d
Add test coverage for favourite button
2021-11-08 11:53:53 +01:00
