osu-lazer

Move BeatmapVersion from BeatmapInfo to IBeatmap

Closes https://github.com/ppy/osu/issues/32420.

The failure cause here is that in editor the beatmap version for the
beatmap affected (or... any beatmap, really), is 0 (ZERO). That is
probably a regression from https://github.com/ppy/osu/pull/32315, but
like... can we universally agree that calling that change "a regression"
in any capacity is dumb? Like what was that code *doing* playing dumb
reference games and copying stuff into an arbitrary instance that could
get or not get used later on? And now you have a 50/50 chance of
accessing the *correct* model's field, depending on whether you go via
`BeatmapInfo` or `Beatmap.BeatmapInfo`?

Moving the field to `IBeatmap`, i.e. what is by now - by consensus,
since https://github.com/ppy/osu/pull/28473 - supposed to be the "decoded
and materialised" beatmap, fixes this issue.

I probably should have done this as part of
https://github.com/ppy/osu/pull/28473 but it slipped my mind. Probably
for the better too because this change has rather large chances of
breaking stuff so maybe better to examine it in isolation (via diffcalc
runs or whatever).

For added humour points, you'd say that the field on `BeatmapInfo` was
not `[Ignore]`d, so this is a realm schema change, right? No. As far as
I can tell, it's not. I opened realm studio and `BeatmapVersion` *is not
a listed column` on `Beatmap` models.

I'm also not gonna get into the fact that I think `EditorBeatmap` doing
dumb games with juggling two `BeatmapInfo` references since
https://github.com/ppy/osu/pull/15075 is bad, because I don't think I
have the mental capacity to hotfix this by going down that train of
thought.

Bartłomiej Dach · 2025-03-17 15:04:48 +01:00

91f3be5fea

Add explanation of why the logic is in such a bad place

Dean Herbert · 2025-03-12 16:56:16 +09:00

c2de43f677

Fix new combo being toggled when selection is made

Dean Herbert · 2025-03-12 16:52:51 +09:00

6a7a834151

Merge branch 'master' into editor-right-click-as-people-expect

Dean Herbert · 2025-03-12 14:51:28 +09:00

083979e299

Fix edge case allowing almost-zero-length sliders to be placed during distance snapping

Dean Herbert · 2025-03-11 16:17:44 +09:00

23891b1994

Allow grid spacing setting up to 256 pixels

Addresses https://github.com/ppy/osu/discussions/29713.

I think there's valid uses of this apart from just hiding (ie values
between 128 and 256) so let's just get this in.

Dean Herbert · 2025-03-10 14:45:36 +09:00

bbd2c33934

Fix precise movement popover crashing if selection bounding box exceeds playfield size

Closes https://github.com/ppy/osu/issues/32252.

Bartłomiej Dach · 2025-03-07 09:38:14 +01:00

6d22502739

Bump difficulty calculator versions in preparation for release

Dean Herbert · 2025-03-06 16:05:51 +09:00

bdd2808fb5

Merge pull request #32158 from bdach/scaling-crash

Fix possible crash when scaling objects in editor

Dean Herbert · 2025-03-04 13:40:41 +09:00

3fe92fb83c

Mark MathHelper.Clamp() as banned API

See previous commit for partial rationale.

There's an argument to be made about the `NaN`-spreading semantics being
desirable because at least something will loudly fail in that case, but
I'm not so sure about that these days. It feels like either way if
`NaN`s are produced, then things are outside of any control, and chances
are the game can probably continue without crashing. And, this move
reduces our dependence on osuTK, which has already been living on
borrowed time for years now and is only awaiting someone brave to go
excise it.

Bartłomiej Dach · 2025-02-28 13:48:22 +01:00

35b0ff80bb

Fix possible crash when scaling objects in editor

The specific fail case here is when `s.{X,Y}` is 0, and
`s{Lower,Upper}Bound` is `Infinity`. Because IEEE math is IEEE math,
`0 * Infinity` is `NaN`.

`MathHelper.Clamp()` is written the following way:

	https://github.com/ppy/osuTK/blob/af742f1afd01828efc7bc9fe77536b54aab8b419/src/osuTK/Math/MathHelper.cs#L284-L306

`Math.{Min,Max}` are both documented as reporting `NaN` when any of
their operands are `NaN`:

	https://learn.microsoft.com/en-us/dotnet/api/system.math.min?view=net-8.0#system-math-min(system-single-system-single)
	https://learn.microsoft.com/en-us/dotnet/api/system.math.max?view=net-8.0#system-math-max(system-single-system-single)

which means that if a `NaN` happens to sneak into the bounds, it will
start spreading outwards in an uncontrolled manner, and likely crash
things.

In contrast, the standard library provided `Math.Clamp()` is written
like so:

	https://github.com/dotnet/runtime/blob/577c36cee56480dec4d4610b35605b5d5836888b/src/libraries/System.Private.CoreLib/src/System/Math.cs#L711-L729

With this implementation, if either bound is `NaN`, it will essentially
not be checked (because any and all comparisons involving `NaN` return
false). This prevents the spread of `NaN`s, all the way to positions
of hitobjects, and thus fixes the crash.

Bartłomiej Dach · 2025-02-28 13:34:00 +01:00

ffef6ae185

Fix sliders not being selectable if the body is hidden but the head is still visible

Closes https://github.com/ppy/osu/issues/31998.

Previously: https://github.com/ppy/osu/commit/1648f2efa306f587714178f113e69d8ad8c4ac02,
https://github.com/ppy/osu/pull/31923.

Oh input handling, how I love ya.

Bartłomiej Dach · 2025-02-27 15:00:29 +01:00

5b318edbfb

Merge branch 'master' into pp-dev

Dean Herbert · 2025-02-27 00:08:43 +09:00

87b6dddd11

Add back right-click-for-new-combo and right-click-delete when in compose mode

Requested too many times to count.

I'm not sure what to do about the code quality of this. It's a bit weird
that there's no way to check the current composition tool from a higher
level.

Also it was discussed IRL that there should be some kind of hinting that
existing notes will be deleted when they are hovered, but I'm not sure
how well this will work in normal mapping flows, since it will display
even in cases that users aren't intending to delete an object. Still
willing to explore this direction though (it's just non-trivial to
implement so I haven't yet).

Dean Herbert · 2025-02-26 17:52:33 +09:00

2738c1a807

Merge pull request #32077 from bdach/double-click-difficulty-slider-nub

Fix double-clicking difficulty adjust sliders not resetting the value to default correctly

Dean Herbert · 2025-02-25 21:08:46 +09:00

b3965f0dd0

Fix double-clicking difficulty adjust sliders not resetting the value to default correctly

- Closes https://github.com/ppy/osu/issues/31888
- Supersedes / closes https://github.com/ppy/osu/pull/32060

Bartłomiej Dach · 2025-02-25 07:40:55 +01:00

1f562ab47d

Fix "use current distance snap" button incorrectly factoring in last object with velocity

Closes https://github.com/ppy/osu/issues/32003.

Bartłomiej Dach · 2025-02-21 12:52:59 +01:00

de78518fea

Merge pull request #31923 from peppy/fix-editor-slider-selection

Fix selected sliders sometimes not being clickable in editor

Dan Balasescu · 2025-02-18 14:31:44 +09:00

cef1d02f3d

Merge pull request #31232 from Plextora/sudden-death-feat

Add "Fail when missing on a slider end" option in Sudden Death mod

Dean Herbert · 2025-02-18 14:25:46 +09:00

f5bdbb91d6

Fix selected sliders sometimes not being clickable in editor

Closes https://github.com/ppy/osu/issues/31918.
Regressed with
https://github.com/ppy/osu/commit/1648f2efa306f587714178f113e69d8ad8c4ac02
for obvious reasons.

Dean Herbert · 2025-02-18 13:41:30 +09:00

77e40140e5

Refactor slightly

Dean Herbert · 2025-02-18 13:04:38 +09:00

20dbe096e0

Fix nudge operations incurring FP error from coordinate space conversions

Closes https://github.com/ppy/osu/issues/31915.

Reproduction of aforementioned issue requires 1280x720 resolution, which
should also be a good way to confirm that this does anything.

To me this is also equal-parts-bugfix, equal-parts-code-quality PR,
because tell me: what on earth was this code ever doing at
`ComposeBlueprintContainer` level? Nudging by one playfield-space-unit
doesn't even *make sense* in something like taiko or mania.

Bartłomiej Dach · 2025-02-17 15:21:07 +01:00

f37a56c307

Merge branch 'master' into pp-dev

Dean Herbert · 2025-02-17 11:59:14 +09:00

ab88ccb081

Merge branch 'master' into sudden-death-feat

Plextora · 2025-02-16 19:43:55 -05:00

cb012123ab

Fix failed scores with no hits on beatmaps with ridiculous mod combinations showing hundreds of pp points awarded (#31741 )

See
https://discord.com/channels/188630481301012481/1097318920991559880/1334716356582572074.

On `master` this is actually worse and shows thousands of pp points, so
I guess `pp-dev` is a comparable improvement, but still flagrantly
wrong. The reason why `pp-dev` is better is the `speedDeviation == null`
guard at the start of `computeSpeedValue()` which turns off the rest of
the calculation, therefore not exposing the bug where
`relevantTotalDiff` can go negative. I still guarded it in this commit
just for safety's sake given it is clear it can do very wrong stuff.

Bartłomiej Dach · 2025-02-14 14:52:05 +00:00

4e66536ae8

Fix weird follow circle display when rewinding through sliders in editor

Closes https://github.com/ppy/osu/issues/31812.

Dean Herbert · 2025-02-12 16:33:23 +09:00

84b5ea3dbf

Avoid binding directly to DHO's bindable

Dean Herbert · 2025-02-12 16:28:14 +09:00

f97708e6b3

Rename ParentObject to DrawableObject

It's not a parent. The follow circle is directly part of the slider
itself.

Dean Herbert · 2025-02-12 16:14:12 +09:00

ffd8bd7bf4

Merge branch 'master' into pp-dev

Dean Herbert · 2025-02-10 18:07:07 +09:00

afdcf40d7e

Calculate hit windows in performance calculator instead of databased difficulty attributes (#31735 )

* Calculate hit windows in performance calculator instead of databased difficulty attributes

* Apply mods to beatmap difficulty in osu! performance calculator

* Remove `GreatHitWindow` difficulty attribute for osu!mania

* Remove use of approach rate and overall difficulty attributes for osu!

* Remove use of hit window difficulty attributes in osu!taiko

* Remove use of approach rate attribute in osu!catch

* Remove unused attribute IDs

* Code quality

* Fix `computeDeviationUpperBound` being called before `greatHitWindow` is set

James Wilson · 2025-02-07 19:21:12 +09:00

9f90ebb2f7

Fix slider ball rotation not being updated when rewinding to a slider

Dean Herbert · 2025-02-07 18:57:26 +09:00

fab5cfd275

Merge branch 'master' into pp-dev

Dean Herbert · 2025-02-07 14:09:25 +09:00

6c069b3373

Fix code quality

Bartłomiej Dach · 2025-02-03 15:18:03 +01:00

2d6f64e891

Refactor IDistanceSnapProvider to accept slider velocity objects as a reference

Method signatures are also changed to be a lot more explicit as to what
inputs they expect.

Bartłomiej Dach · 2025-02-03 14:00:57 +01:00

a1185df2eb

Avoid moving already placed objects temporally when "limit distance snap to current time" is active

Bartłomiej Dach · 2025-01-31 09:51:13 +01:00

8718483c70

Clamp estimateImproperlyFollowedDifficultSliders between 0 and attributes.AimDifficultSliderCount (#31736 )

James Wilson · 2025-01-30 13:58:38 +00:00

2ee480c442

Fix distance snap time part ceasing to work when grid snap is also active

As pointed out in
https://github.com/ppy/osu/pull/31655#discussion_r1935536934.

Bartłomiej Dach · 2025-01-30 14:42:44 +01:00

261a7e537b

Change mirror mod direction setting tooltip to hopefully be less confusing

See https://github.com/ppy/osu/issues/29720,
https://discord.com/channels/188630481301012481/188630652340404224/1334294048541904906.

This removes the tooltip due to being zero or negative information, and
also changes the description of the setting to not contain the word
"mirror", which will hopefully quash the "this is where I would place a
mirror to my screen to achieve what I want" interpretation which seems
to be a minority interpretation.

The first time this was complained about I figured this was probably a
one guy issue, but now it's happened twice, and I never want to see this
conversation again.

Bartłomiej Dach · 2025-01-30 08:59:33 +01:00

bad2959d5b

Remove unnecessary strain sorting in difficult slider count (#31724 )

Rian (Reza Mouna Hendrian) · 2025-01-29 19:06:05 +00:00

46144960e5

Refactor further to avoid weird non-virtual common method

Bartłomiej Dach · 2025-01-24 13:14:31 +01:00

daec91f61d

Fix behavioural change in interaction between grid & distance snap

Bartłomiej Dach · 2025-01-24 13:14:26 +01:00

b04144df54

Simplify code

Bartłomiej Dach · 2025-01-24 13:14:06 +01:00

589035c534

Fix tests

Bartłomiej Dach · 2025-01-24 11:59:07 +01:00

269ade178e

Remove dependence of placement blueprints on IPositionSnapProvider

Bartłomiej Dach · 2025-01-24 11:59:07 +01:00

a6987f5c95

Remove dependence of blueprint containers on IPositionSnapProvider

Bartłomiej Dach · 2025-01-24 11:59:05 +01:00

15b6e28ebe

Merge pull request #31527 from bdach/spectator-list-ready

Show spectating users during gameplay

Dan Balasescu · 2025-01-21 18:54:11 +09:00

8f8246278a

Merge branch 'master' into pp-dev

Dean Herbert · 2025-01-21 13:19:01 +09:00

aeca37c230

Merge pull request #31547 from bdach/editor/precise-move

Add precise movement tool to osu! editor

Dean Herbert · 2025-01-20 19:29:22 +09:00

cf032e5e7f

Replace indexed skill access with skills.OfType<...>().Single() (#30034 )

* Replace indexed skill access with `skills.First(s is ...)`

* Fix comment

* Further refactoring to remove casts

---------

Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

StanR · 2025-01-20 09:39:35 +00:00

22e839d62b

Always select text when an editor slider-textbox is focused

Dean Herbert · 2025-01-20 16:17:39 +09:00

dcdb8d13a9

6260 Commits