h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-22 10:30:00 +08:00
Code Issues Releases Wiki Activity

Add explanation of why the logic is in such a bad place

Browse Source
This commit is contained in:
Dean Herbert
2025-03-12 16:56:16 +09:00
Unverified
parent 6a7a834151
commit c2de43f677
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game.Rulesets.Osu/Edit/OsuHitObjectComposer.cs
+12
View File
@@ -354,6 +354,18 @@ namespace osu.Game.Rulesets.Osu.Edit
protected override bool OnMouseDown(MouseDownEvent e)
{
// Why is this logic here and not in `OsuSelectionHandler`?
// Because we only want to handle this toggle after all other right-click handling completes.
//
// Consider that input is handled from the most nested child first:
//
// ComposeScreen
// |- OsuContextMenuContainer // right click for context
// |- TimelineBlueprintContainer
// |- TimelineSelectionHandler
// |- (Osu)HitObjectComposer // right click for toggle new combo
// |- (Osu)EditorBlueprintContainer // right click for select
// |- (Osu)EditorSelectionHandler // right click for delete
if (e.Button == MouseButton.Right)
{
var osuSelectionHandler = (OsuSelectionHandler)BlueprintContainer.SelectionHandler;