1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 10:52:53 +08:00
Commit Graph

58923 Commits

Author SHA1 Message Date
Bartłomiej Dach
75e19bb89f
Merge branch 'master' into fix-clickable-avatar-bloat 2023-02-10 21:30:40 +01:00
Bartłomiej Dach
11296c4ffe
Use better exception type 2023-02-10 21:25:19 +01:00
Dean Herbert
ad8b01b478
Merge pull request #22589 from sw1tchbl4d3r/file_hitsample_additions
Always add to additions soundbank in `convertSoundType`
2023-02-10 17:14:29 +09:00
Dean Herbert
eccde923e5
Merge pull request #22554 from Walavouchey/ranking-accuracycircle-readability
Improve readability of `AccuracyCircle`
2023-02-10 17:03:46 +09:00
Dean Herbert
1df6fc6311 Use if statements rather than conditional case 2023-02-10 17:03:27 +09:00
Dean Herbert
f70614aa8b
Merge pull request #22587 from sw1tchbl4d3r/taiko_large_bonus
Make `LargeBonus` a valid `HitResult` in taiko
2023-02-10 17:00:53 +09:00
Dean Herbert
199fb0fd85 Apply NRT to ClickableAvatar and UpdateableAvatar 2023-02-10 16:32:58 +09:00
Dean Herbert
5866b67a5b Simplify tooltip implementation 2023-02-10 16:24:44 +09:00
Dean Herbert
68c37585e5 Use string.Empty instead of default 2023-02-10 16:22:06 +09:00
Joseph Madamba
a86f06df96 Add back Enabled checks to TooltipText and OnClick to fix guest case 2023-02-09 17:00:32 -08:00
Bartłomiej Dach
96c1832af4
Fix grammar in xmldoc
Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>
2023-02-10 00:07:24 +01:00
sw1tchbl4d3
51816b92c6 Add conversion tests 2023-02-09 23:23:58 +01:00
sw1tchbl4d3
f0d11f44fc Always add to additions soundbank in convertSoundType 2023-02-09 22:27:52 +01:00
Joseph Madamba
0b41dbf579 Remove code bloat from ClickableAvatar 2023-02-09 12:59:26 -08:00
sw1tchbl4d3
2e2ab4081b Make LargeBonus a valid HitResult in taiko 2023-02-09 21:22:34 +01:00
Dean Herbert
ab81397119
Merge pull request #22553 from OpenSauce04/taiko-stable-snapping
Snap Taiko hit objects to match Stable
2023-02-09 23:28:21 +09:00
Dean Herbert
34d1890f1c Change snapping to only apply to classic mod 2023-02-09 18:22:14 +09:00
Dean Herbert
28897b6e18
Merge pull request #22566 from Joehuu/profile-tournament-banner
Display tournament banner on user profile
2023-02-09 16:06:36 +09:00
Dean Herbert
92eb6b6717 Simplify TestSceneAccuracyCircle test specifications 2023-02-09 15:42:03 +09:00
Dean Herbert
cf009432cc Centralise accuracy cutoff constants and add lookup helper methods 2023-02-09 15:41:58 +09:00
Dean Herbert
240a5f9c85
Merge pull request #22568 from Joehuu/address-init-only-todo
Address todos relating to init-only usages
2023-02-09 12:17:54 +09:00
Joseph Madamba
f1decb667e Address todos relating to init-only usages 2023-02-08 17:51:28 -08:00
Walavouchey
57312279f0 adjust RankNotch gap size to match original value 2023-02-09 02:20:05 +01:00
Joseph Madamba
3b5d573db1 Display tournament banner on user profile 2023-02-08 17:16:09 -08:00
Walavouchey
fd93bd3f50 move rank accuracy requirements to class-local constants 2023-02-09 00:46:24 +01:00
Walavouchey
9544a1d26d use values closer to the extremities for test cases 2023-02-09 00:02:32 +01:00
Walavouchey
ee40444fd3 use Precision.AlmostEquals for bounds check 2023-02-08 23:59:19 +01:00
Bartłomiej Dach
2873905cc6
Merge pull request #22506 from peppy/skin-editor-undo-support
Add very basic skin editor undo / redo support
2023-02-08 19:19:25 +01:00
Bartłomiej Dach
0a5c4e04bf
Merge branch 'master' into skin-editor-undo-support 2023-02-08 18:43:59 +01:00
Walavouchey
0531c010eb display RankBadges on on their sector centres
the D `RankBadge` does this anyway. the A and S badges are slightly off
centre to prevent overlap with the SS badge
2023-02-08 14:01:40 +01:00
Walavouchey
6ace6bfee1 ensure AccuracyCircle doesn't land in gaps created by RankNotches 2023-02-08 13:20:53 +01:00
OpenSauce
df1355ea4b Taiko hit objects now snap to hit target 2023-02-08 10:59:08 +00:00
Dean Herbert
21fa29f47f
Merge pull request #22545 from Joehuu/fix-user-profile-context-menu
Fix beatmap cards not showing context menu on user profile
2023-02-08 17:07:28 +09:00
Joseph Madamba
0156ff732f Fix beatmap cards not showing context menu on user profile 2023-02-07 22:56:09 -08:00
Dean Herbert
b0131db1dc Update test assertions in line with new state saving logic 2023-02-08 15:55:17 +09:00
Dean Herbert
17ca26ebee Remove unnecessary null check on targetScreen 2023-02-08 15:44:24 +09:00
Dean Herbert
3a3c2e78a1 Merge branch 'master' into skin-editor-undo-support 2023-02-08 15:41:58 +09:00
Dean Herbert
78eae171ed
Merge pull request #22507 from Joehuu/fix-comment-padding
Fix comments having too much padding at the bottom
2023-02-08 15:01:05 +09:00
Dean Herbert
b6809e156b
Merge pull request #22432 from mk56-spn/sheared_slider_implementation_clean_ii
Implement a sheared slider for the updated design
2023-02-08 15:01:00 +09:00
Dean Herbert
5cd111e6f1 Fix ordering of methods in OsuSliderBar 2023-02-08 14:01:50 +09:00
Dean Herbert
cec1f77e6c Fix glow flash occurring after releasing mouse and adjust transition slightly 2023-02-08 13:59:09 +09:00
Joseph Madamba
277f71d36a Expire reply editor instead of clearing container 2023-02-07 15:15:51 -08:00
Dean Herbert
0320ba770f Handle component changes via ISkinnableTarget.Components rather than inside SkinEditor directly
Seems saner? Maybe?
2023-02-07 16:23:25 +09:00
Dean Herbert
e162fd56da Change the way initial state saving works in EditorChangeHandler to be closer to first change 2023-02-07 16:22:51 +09:00
Dean Herbert
dad348111d Fix holding a selection while changing screens causing a crash 2023-02-07 16:07:33 +09:00
Dean Herbert
71eef238c4 Make OnStateChange non-implemented rather than wrong 2023-02-07 16:04:31 +09:00
Bartłomiej Dach
12f6d461b9
Merge pull request #22532 from peppy/fix-long-storyboard-outro
Fix storyboard outro time potentially running too long
2023-02-06 20:30:36 +01:00
Bartłomiej Dach
179db09075
Merge pull request #22531 from peppy/apply-future-rider-inspection
Apply single inspection from newer inspectcode versions
2023-02-06 20:05:49 +01:00
Bartłomiej Dach
3ee771cbef
Merge pull request #22535 from peppy/forcefully-stop-pause-sample
Ensure pause sample loop is stopped on exiting player
2023-02-06 19:51:51 +01:00
Dean Herbert
aaf3ad805c Fix potential nullref in tests 2023-02-06 19:31:45 +09:00