1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 08:33:21 +08:00
Commit Graph

66126 Commits

Author SHA1 Message Date
Dean Herbert
86e3b597b4
Fix LegacyApproachCircle incorrectly applying scaling factor 2024-02-21 13:18:51 +08:00
Andrei Zavatski
2543a48ac8 Apply padding to GridContainers directly 2024-02-20 23:18:37 +03:00
Andrei Zavatski
b92cff9a8e Reduce allocations in ManiaSelectionBlueprint 2024-02-20 20:47:41 +03:00
Andrei Zavatski
871bdb9cf7 Reduce string allocations in TimeInfoContainer 2024-02-20 20:31:18 +03:00
Andrei Zavatski
6678c4783b Fix PlaybackControl string allocations 2024-02-20 19:31:28 +03:00
Andrei Zavatski
e9aca9226a Reduce allocations in ManiaPlayfield.TotalColumns 2024-02-20 19:10:03 +03:00
Dean Herbert
ef413c08f1
Merge pull request #27249 from EVAST9919/editor-alloc
Reduce osu editor allocations with many objects selected
2024-02-20 15:06:25 +08:00
Dan Balasescu
40d6e8ce85
Remove legacy OpenGL renderer option, it's now just OpenGL 2024-02-20 15:14:30 +09:00
Dean Herbert
3ea47e64f0
Merge pull request #27258 from Loreos7/storage-error-localisation
Localise storage error popup dialog
2024-02-20 13:37:10 +08:00
Joseph Madamba
2ff8667dd2 Revert "Centralise global rank display logic to new class"
Also don't show on `LoginOverlay` usage for now.
2024-02-19 12:11:12 -08:00
Andrei Zavatski
3791ab30c4 Reduce allocations in HitCircleOverlapMarker 2024-02-19 20:55:43 +03:00
Andrei Zavatski
c758640311 Reduce allocations in ComposerDistanceSnapProvider 2024-02-19 20:49:56 +03:00
Andrei Zavatski
29900353d9 Reduce allocations in SliderSelectionBlueprint 2024-02-19 20:26:15 +03:00
Dean Herbert
fc34c5a505
Merge pull request #27243 from myQwil/beatmap_offset_virtual
Change `userBeatmapOffsetClock` to a `FramedOffsetClock`
2024-02-20 01:06:01 +08:00
Mike Will
012d6b7fe1 Change userBeatmapOffsetClock to a FramedOffsetClock
Assuming that the global audio offset is set perfectly, such that
any audio latency is fully accounted for, if a specific beatmap
still sounds out of sync, that would no longer be a latency issue.

Instead, it would indicate a misalignment between the beatmap's
track and time codes, the correction for which should be a
virtual-time offset, not a real-time offset.
2024-02-19 09:14:49 -05:00
Dean Herbert
c87bc8b597
Merge pull request #27180 from bdach/better-submission-failure-messaging
Add better submission failure messaging
2024-02-19 21:38:23 +08:00
Bartłomiej Dach
ec26ab51d1
Use different wording 2024-02-19 13:56:21 +01:00
Bartłomiej Dach
d7b1e3ba50
Merge pull request #27226 from peppy/no-audio-filter-funny-business
Ensure audio filters can't be attached before load (or post-disposal)
2024-02-19 13:01:34 +01:00
Dean Herbert
398eaee5d0
Merge pull request #27238 from bdach/disable-nested-managers-when-skin-editor-open
Disable nested input managers on edited screen when skin editor is open
2024-02-19 19:27:26 +08:00
Bartłomiej Dach
f5666185ab
Merge pull request #27239 from peppy/fix-cached-beatmap
Fix `WorkingBeatmapCache` caching beatmap in wrong state leading to crash
2024-02-19 12:06:45 +01:00
Bartłomiej Dach
1ca566c6b0
Disable nested input managers on edited screen when skin editor is open 2024-02-19 10:19:25 +01:00
Dean Herbert
7f82f10317
Fix beatmap potentially loading in a bad state
Over-caching could mean that a beatmap could load and cause a late
crash. Let's catch it early to avoid such a crash occurring.
2024-02-19 17:18:07 +08:00
Bartłomiej Dach
444ac5ed4d
Add failing test coverage 2024-02-19 09:59:25 +01:00
Brandon
413b7aab60 Switch to const string 2024-02-18 22:12:03 -08:00
Brandon
c6ca812ea0 Add feedback to delete button even when no-op 2024-02-18 21:52:23 -08:00
maromalo
5a448ce02f Turn BPMDisplay to RollingCounter<int> 2024-02-18 19:59:56 -03:00
Salman Ahmed
bdf91209b6
Merge pull request #27224 from peppy/fix-logo-tracking-single-thread
Fix logo tracking container being behind by one frame
2024-02-19 01:20:53 +03:00
Andrei Zavatski
3059ddf3b2 Fix allocations in SliderInputManager 2024-02-19 01:08:40 +03:00
Dean Herbert
998d820666
Ensure audio filters can't be attached before load (or post-disposal)
Will probably fix https://github.com/ppy/osu/issues/27225?
2024-02-19 00:25:01 +08:00
Dean Herbert
6b6a6aea54
Apply NRT to LogoTrackingContainer 2024-02-18 23:35:26 +08:00
Dean Herbert
882f11bf79
Fix logo tracking container being off by one frame
This was especially visible at the main menu when running in single thread mode.
2024-02-18 23:19:57 +08:00
Dean Herbert
415a65bf59
Add failing tests for beatmap inconsistencies 2024-02-18 19:32:21 +08:00
Dean Herbert
4d4d69521f
Merge pull request #27114 from EVAST9919/judgements-rework
Cache created judgement in `HitObject`
2024-02-18 18:07:58 +08:00
Dean Herbert
9655e8c48a
Adjust xmldoc slightly 2024-02-18 17:54:29 +08:00
Dean Herbert
715236765a
Merge pull request #27206 from EVAST9919/selection-enumerators
Reduce allocations during beatmap selection
2024-02-18 10:02:35 +08:00
Salman Ahmed
91675e0970 Update markdown code block implementation in line with framework changes 2024-02-18 02:00:55 +03:00
Salman Ahmed
414e55c90e Add visual test case 2024-02-18 01:38:51 +03:00
Andrei Zavatski
572f693eec Fix failing tests related to slider ticks 2024-02-17 23:28:35 +03:00
Dean Herbert
6960f87509
Merge pull request #26895 from vmfunc/ordinal-sorting
Consider case sensitivity when sorting beatmaps in song select
2024-02-18 04:05:22 +08:00
Dean Herbert
71afb8881a
Merge pull request #27199 from EVAST9919/link-compiler-alloc
Fix `DrawableLinkCompiler` allocations
2024-02-18 04:04:34 +08:00
Dean Herbert
520576a0fd
Merge pull request #27193 from bdach/fix-not-working-metadata-hub-cleanup
Fix a few issues in metadata hub's disconnection requested flow
2024-02-18 03:46:02 +08:00
Andrei Zavatski
dd82de473a Revert BeatmapCarousel changes 2024-02-17 22:42:47 +03:00
Dean Herbert
0df6e8f595
Remove list allocations in UpdateNestedSamples 2024-02-18 03:23:34 +08:00
Dean Herbert
0714a4fc1e
Revert sample lookup logic that was not allocating anything 2024-02-18 03:18:50 +08:00
Dean Herbert
62a7e315bf
Update framework 2024-02-18 03:11:29 +08:00
Andrei Zavatski
22f5a66c02 Reduce allocations during beatmap selection 2024-02-17 15:46:38 +03:00
Dean Herbert
2adc8b15e7
Merge pull request #27205 from Joehuu/fix-star-counter-animation-above-10
Fix star counter decrease animation being delayed when current is over displayed star count
2024-02-17 18:16:48 +08:00
Joseph Madamba
7a74eaa2de Fix star counter decrease animation being delayed when current is over displayed star count 2024-02-16 22:47:38 -08:00
Joseph Madamba
6e8d8b977e Move ternary inside Math.Max() 2024-02-16 22:47:38 -08:00
Joseph Madamba
8169d1ac80 Add twenty star counter in visual test 2024-02-16 22:47:38 -08:00