Bartłomiej Dach
6a1387191a
Merge branch 'master' into fix-skin-dropdown-update-crash
2021-01-30 13:01:52 +01:00
Bartłomiej Dach
44e88f09e5
Merge pull request #11625 from peppy/fix-beatmap-cache-lookup-null-failure
...
Fix SQLite exception thrown is a beatmap lookup is attempted without an OnlineBeatmapID present
2021-01-29 18:58:00 +01:00
Dean Herbert
16f3d1815f
Fix SQLite exception thrown is a beatmap lookup is attempted without an OnlineBeatmapID present
...
It turns out the SQLite API isn't smart enough to handle nullables
directly, so we need to help it out a bit.
Stops the following from being thrown:
```
System.InvalidOperationException: Value must be set.
at Microsoft.Data.Sqlite.SqliteParameter.Bind(sqlite3_stmt stmt) = 3
at
at Microsoft.Data.Sqlite.SqliteParameterCollection.Bind(sqlite3_stmt
stmt) = 3 at
at Microsoft.Data.Sqlite.SqliteCommand.ExecuteReader(CommandBehavior
behavior)
at Microsoft.Data.Sqlite.SqliteCommand.ExecuteReader()
at
osu.Game.Beatmaps.BeatmapManager.BeatmapOnlineLookupQueue.checkLocalCache(BeatmapSetInfo
set, BeatmapInfo beatmap) in
/Users/dean/Projects/osu/osu.Game/Beatmaps/BeatmapManager_BeatmapOnlineLookupQueue.cs:line
166 = 166
```
2021-01-29 19:53:57 +09:00
Dan Balasescu
cd8ef5373d
Merge pull request #11622 from peppy/remove-unobserved-exception-handling
...
Remove all usage of CatchUnobservedExceptions
2021-01-29 19:31:07 +09:00
Dean Herbert
d52376cc17
Merge pull request #11623 from Firmatorenio/apply-sv-to-taiko-diffadjust
...
Add scroll speed adjustment to taiko's DifficultyAdjust mod
2021-01-29 19:25:17 +09:00
Dean Herbert
18e6afbec0
Ensure the item is present before trying to select it
2021-01-29 19:17:12 +09:00
Dean Herbert
1ce383fc20
Merge branch 'master' into fix-skin-dropdown-update-crash
2021-01-29 19:16:20 +09:00
Firmatorenio
37ef5c7072
rename SliderVelocity to ScrollSpeed
2021-01-29 15:04:55 +06:00
Dean Herbert
a61444690e
Remove all usage of CatchUnobservedExceptions
...
This should no longer be required with the recent framework side change
that stops a game from crashing on unobserved exceptions
(https://github.com/ppy/osu-framework/pull/4171 ).
2021-01-29 16:32:29 +09:00
Firmatorenio
449f883be1
add SV multiplier adjustment to TaikoModDifficultyAdjust
2021-01-29 11:48:51 +06:00
Dan Balasescu
4c4770bf4b
Merge pull request #11618 from vltspr/catch-auto-fix
...
Fix Catch autoplay rewinding on instantaneous hits
2021-01-29 12:17:46 +09:00
Corentin PALLARD
d168de0ae3
Formatting
2021-01-29 03:03:23 +01:00
Corentin PALLARD
da4c207a73
Fix the ctb auto mod speedup in some occasions
2021-01-29 02:53:26 +01:00
Bartłomiej Dach
1d76cfe585
Merge pull request #11615 from peppy/ios-signalr-use-json
2021-01-29 00:04:16 +01:00
Bartłomiej Dach
0f1d72e073
Merge branch 'master' into ios-signalr-use-json
2021-01-28 23:28:49 +01:00
Bartłomiej Dach
c592c80a07
Merge pull request #11616 from peppy/fix-ios-beatmap-cache-lookups
...
Avoid using Dapper to fix iOS compatibility of beatmap lookup cache
2021-01-28 23:17:54 +01:00
Bartłomiej Dach
386f9f7842
Fix typos in comments
2021-01-28 22:36:07 +01:00
Bartłomiej Dach
8afd1bce21
Merge branch 'master' into fix-ios-beatmap-cache-lookups
2021-01-28 22:33:58 +01:00
Dean Herbert
34f8e4b672
Merge pull request #11613 from bdach/order-attribute-move
...
Remove game-local enum `[Order]` attribute
2021-01-29 00:41:43 +09:00
Dean Herbert
87e23d22cf
Merge pull request #11611 from frenzibyte/fix-package-downgrade
...
Fix dotnet run/publish with runtime specified not working again
2021-01-29 00:18:27 +09:00
Dean Herbert
a616688a47
Update framework
2021-01-28 23:55:03 +09:00
Dean Herbert
c3d4044017
Avoid using Dapper to fix iOS compatibility of beatmap lookup cache
2021-01-28 16:53:56 +09:00
Dean Herbert
90a82f986b
Fallback to using json for signalr communication if JIT is unavailable
2021-01-28 16:20:19 +09:00
Bartłomiej Dach
2c08ce05fa
Remove game-local enum [Order] attribute
...
In favour of the newly-added framework one.
2021-01-27 22:29:52 +01:00
Salman Ahmed
63f057a525
Fix dotnet run/publish with runtime specified not working again
2021-01-27 20:45:52 +03:00
Dean Herbert
15e455231e
Merge pull request #11610 from peppy/update-framework
...
Update framework
2021-01-27 23:56:08 +09:00
Dean Herbert
45395cb5e8
Update framework
2021-01-27 23:00:14 +09:00
Dean Herbert
3b6c82bb03
Merge pull request #11607 from peppy/add-messagepack
...
Switch spectator and multiplayer to use more efficient MessagePack protocol
2021-01-27 13:50:45 +09:00
Dan Balasescu
7d06af916c
Merge branch 'master' into add-messagepack
2021-01-27 13:00:46 +09:00
Dean Herbert
67014018fc
Merge pull request #11589 from MiraiSubject/osu-mod-icon-fallbacks
...
Allow tournament client to use default mod icons if custom icons are not present
2021-01-26 19:57:21 +09:00
Dean Herbert
81ab82fafe
Tidy up nesting
2021-01-26 19:16:38 +09:00
Dean Herbert
64a3c712aa
Rename class and add xmldoc
2021-01-26 19:15:19 +09:00
Dean Herbert
a5f3418e56
Avoid tooltip display
2021-01-26 19:11:19 +09:00
Dean Herbert
fedcbf79fa
Merge pull request #11572 from EVAST9919/comment-pill
...
Make VotePill background transparent for own comments
2021-01-26 18:57:00 +09:00
Dean Herbert
bd86b535db
Merge pull request #11605 from frenzibyte/fix-beatmap-listing-2
...
Fix beatmap listing placeholder disappearing on second time display
2021-01-26 18:28:42 +09:00
Dean Herbert
15885c17af
Remove unused usings
2021-01-26 18:07:43 +09:00
Dean Herbert
468dfbecbe
Merge branch 'master' into fix-beatmap-listing-2
2021-01-26 17:56:37 +09:00
Dean Herbert
fcf4d4ee18
Merge pull request #11604 from frenzibyte/fix-beatmap-listing
...
Fix beatmap listing placeholder potentially getting disposed
2021-01-26 17:56:19 +09:00
Dean Herbert
20cfa991bf
Switch clients to MessagePack mode
2021-01-26 17:41:21 +09:00
Dean Herbert
9537090d28
Setup all spectator model classes for MessagePack
2021-01-26 16:39:35 +09:00
Dean Herbert
e4fc604163
Setup all multiplayer model classes for MessagePack support
2021-01-26 16:26:03 +09:00
Dean Herbert
60ae87ec38
Add MessagePack package
2021-01-26 16:25:49 +09:00
Salman Ahmed
93bb2611d6
Merge branch 'fix-beatmap-listing' into fix-beatmap-listing-2
2021-01-26 09:43:49 +03:00
Dean Herbert
ca0242debe
Tidy up logic to correctly expire in cases where expiry is expected
2021-01-26 15:42:48 +09:00
Salman Ahmed
0d8d0d6852
Apply alternative way of fixing
2021-01-26 01:03:29 +03:00
Salman Ahmed
c317d60169
Add offline test scene for beatmap listing overlay
2021-01-26 00:03:20 +03:00
Salman Ahmed
75d6dbdbb7
Fix beatmap listing placeholder potentially getting disposed
2021-01-26 00:03:20 +03:00
Salman Ahmed
9312de7c23
Move online beatmap listing overlay to separate test scene
2021-01-26 00:03:20 +03:00
Salman Ahmed
9efce5717f
Fix beatmap listing placeholder disappearing on second time display
2021-01-26 00:03:20 +03:00
Bartłomiej Dach
4c01cf6664
Merge pull request #11596 from peppy/fix-timeline-parts-working-beatmap
2021-01-25 18:36:34 +01:00
