OliBomby
5d1ccc2601
Ensure invariant of monotone time
2023-08-11 23:39:28 +02:00
OliBomby
d2f5e696e7
Fix DrawableHitObject state not synchronizing with hitobject edits
2023-08-11 22:34:04 +02:00
Dean Herbert
896cbb0ba0
Update framework
2023-08-11 21:34:59 +09:00
Dean Herbert
5b44124ecf
Merge pull request #24409 from cdwcgt/tournament-nullable
...
Remove #nullable disable in tournament
2023-08-10 19:38:16 +09:00
Bartłomiej Dach
3501b7c22b
Fix some more nullability inspections
2023-08-09 21:32:46 +02:00
Dean Herbert
4e83245acf
Apply nullability to all remaining tests where it wasn't applied
2023-08-10 00:24:57 +09:00
Dean Herbert
6549ca5304
Revert some usages of AsNonNull() in tests
...
We generally prefer `!` when it is unambiguous usage (ie. direct access).
2023-08-10 00:20:37 +09:00
cdwcgt
5ad80879b7
let MatchIPCInfo .Beatmap be nullable
2023-08-09 19:13:49 +09:00
cdwcgt
5898a9986b
Revert "use no null when true"
...
This reverts commit 6ad8339c66
2023-08-09 19:11:36 +09:00
Dean Herbert
c88045dfc7
Fix weird usage of Cast
2023-08-09 18:21:57 +09:00
Bartłomiej Dach
66e404f289
Merge pull request #24467 from Joehuu/block-exit-if-save-failed
...
Block beatmap editor from testing/exiting/exporting when saving fails
2023-08-09 00:14:23 +02:00
Bartłomiej Dach
2698ec9206
Merge branch 'master' into block-exit-if-save-failed
2023-08-08 23:41:03 +02:00
Bartłomiej Dach
c56ca40635
Merge pull request #24406 from Joehuu/fix-break-info-decimal-separator
...
Fix accuracy break info decimal separator being incorrect in certain languages
2023-08-08 23:20:00 +02:00
Bartłomiej Dach
500a1363ec
Merge branch 'master' into fix-break-info-decimal-separator
2023-08-08 22:49:00 +02:00
Bartłomiej Dach
d91798271d
Add test case covering exit block
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2023-08-08 22:06:49 +02:00
Joseph Madamba
49f5d6813e
Block beatmap editor from testing/exiting/exporting when saving fails
2023-08-04 22:08:25 -07:00
Dean Herbert
e13eb7588d
Merge pull request #24461 from Joehuu/changelog-entry-links
2023-08-04 19:45:07 +08:00
Joseph Madamba
d179fe3d96
Add support for changelog entries with url attached
2023-08-03 23:24:37 -07:00
Bartłomiej Dach
270c03235d
Merge pull request #24448 from peppy/multi-spectator-better-start-time
...
Improve choice of where to start playback of multiplayer spectator
2023-08-03 22:42:09 +02:00
Bartłomiej Dach
785d2ed9b1
Merge branch 'master' into multi-spectator-better-start-time
2023-08-03 22:07:47 +02:00
Bartłomiej Dach
bd8b9c8e63
Merge pull request #24387 from peppy/playfield-skin-layer
...
Add new skin layer to allow components anchored to the playfield
2023-08-03 22:06:17 +02:00
Bartłomiej Dach
52b1073d93
Fix playfield skin layer not rotating correctly with barrel roll mod
2023-08-03 21:08:00 +02:00
Bartłomiej Dach
dde03b7d46
Merge branch 'master' into playfield-skin-layer
2023-08-03 20:42:15 +02:00
Dean Herbert
d39ef48b71
Return null intead of FileNotFoundException on missing file in ZipArchiveReader
2023-08-03 09:01:11 +09:00
Dean Herbert
71f6e5731d
Fix potential null reference if no frames found
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-08-03 08:58:19 +09:00
Dean Herbert
f38b21110f
Add missing parenthesis to comment
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-08-03 08:57:43 +09:00
Bartłomiej Dach
e475a74a3a
Merge pull request #24443 from peppy/fix-transparent-player-background
...
Fix storyboard being see-through in some contexts
2023-08-03 01:20:28 +02:00
Bartłomiej Dach
f48b1ebdbf
Merge branch 'master' into fix-transparent-player-background
2023-08-03 00:41:42 +02:00
Bartłomiej Dach
9da1de84b5
Merge pull request #24449 from peppy/fix-fucked-everything-fucking-clock-fuckkkkkkkkkkkk
...
Fix global beatmap clock potentially getting into bad state
2023-08-02 22:39:41 +02:00
Joseph Madamba
aab462fd95
Fix valueText being replaced even if current is not binding to anything
2023-08-02 09:40:22 -07:00
Dean Herbert
75c1d5ad7f
Add lenience to FramedBeatmapClock workaround
2023-08-02 18:49:24 +09:00
Dean Herbert
14d87e49c7
Improve choice of where to start playback of multiplayer spectator
2023-08-02 18:46:35 +09:00
Dean Herbert
0e510088f9
Ensure background of gameplay is black when storyboard is overriding background display
2023-08-02 15:50:15 +09:00
Dean Herbert
a618ed140e
Move StoryboardReplacesBackground bindable more local to usage
2023-08-02 15:29:18 +09:00
Bartłomiej Dach
dc9c68b642
Merge pull request #24438 from peppy/multi-spectator-flow-fixes
...
Fix issues switching to new beatmap in multiplayer spectator
2023-08-01 19:38:37 +02:00
Bartłomiej Dach
5b6c3321cf
Merge branch 'master' into multi-spectator-flow-fixes
2023-08-01 19:03:48 +02:00
Bartłomiej Dach
cecb3845e7
Merge pull request #24439 from peppy/multi-spectator-extended-results
...
Show extended statistics in multiplayer spectator automatically
2023-08-01 19:00:28 +02:00
Bartłomiej Dach
a75f42f5a9
Merge branch 'master' into multi-spectator-extended-results
2023-08-01 18:25:41 +02:00
Bartłomiej Dach
d65f08a048
Merge pull request #24427 from peppy/fix-skin-editor-crash-multi-spectator
...
Fix game crashing when entering skin editor in multiplayer spectator
2023-08-01 18:25:11 +02:00
Bartłomiej Dach
e591c7273b
Merge pull request #24440 from peppy/multi-spectator-animation-fix
...
Fix centred player not animating correctly
2023-08-01 18:19:15 +02:00
Bartłomiej Dach
f7d5ac9f92
Privatise setter
2023-08-01 18:09:48 +02:00
Bartłomiej Dach
bcfc76b469
Add visual-only test coverage for centred player case
2023-08-01 17:41:07 +02:00
Dean Herbert
70bd1d3cf4
Fix centred player not animating correctly
2023-08-01 20:18:21 +09:00
Dean Herbert
df504e1fc2
Show extended statistics in multiplayer spectator automatically
2023-08-01 20:02:36 +09:00
Dean Herbert
fe47dc291b
Fix onLoadRequested getting early-exited too early in spectator scenarios
...
In some scenarios, multiplayer spectator would not tick over to the next
beatmap.
Here's an example:
- Room has two items queued
- Local user starts download of both
- First beatmap starts and download is complete
- First beatmap ends (spectating is active)
- Second beatmap starts but download is not complete
In this scenario, the local client will get stuck at the spectator
screen due to the `onLoadRequested`-invoked screen change being early
exited.
It would require manual recovery (clicking back button) to return to a
sane state.
2023-08-01 19:22:41 +09:00
Dean Herbert
9fe9ea2c90
Fix potential crash on multiple StartGameplay calls in multiplayer spectator
2023-08-01 19:22:41 +09:00
Dean Herbert
ed0c7e8880
Add failing test coverage showing crash on multiple StartGameplay invocations
2023-08-01 19:21:58 +09:00
Bartłomiej Dach
52730f7cd6
Merge pull request #24430 from peppy/update-framework
...
Update framework
2023-08-01 01:05:49 +02:00
Dean Herbert
528298bc39
Update test in line with framework changes
2023-08-01 07:17:12 +09:00
Dean Herbert
d78cc60851
Update framework
2023-08-01 07:12:40 +09:00
