61534 Commits

This Branch

This Branch

All Branches

• Add test covering blocking of second hit on same frame
  Bartłomiej Dach · 2023-07-25 20:05:37 +02:00
  5cedd428bb
• fix alive hitobjects blocking hits in taiko with hd
  chayleaf · 2023-07-20 23:20:35 +07:00
  970ea50269
• Merge pull request #24290 from peppy/beatmap-offset-all-difficulties

  Change offset calibration control to adjust for all difficulties of the current beatmap set

  Bartłomiej Dach · 2023-07-19 22:31:38 +02:00
  285a232cc2
• Merge pull request #24295 from peppy/fix-multiplayer-deadlock

  Fix deadlock when logging out while at the create match screen

  Bartłomiej Dach · 2023-07-19 20:04:13 +02:00
  7800ea9841
• Fix nullability inspection
  Bartłomiej Dach · 2023-07-19 19:23:08 +02:00
  764029bde1
• Clarify guard condition in RoomSubScreen
  Dean Herbert · 2023-07-19 19:39:10 +09:00
  e47722565a
• Fix deadlock when logging out while at the create match screen

  Closes https://github.com/ppy/osu/issues/24275.

  Dean Herbert · 2023-07-19 19:37:38 +09:00
  18aace177a
• Change offset calibration control to adjust for all difficulties of the current beatmap set
  Dean Herbert · 2023-07-19 17:13:19 +09:00
  5ec9cd84b2
• Merge pull request #24236 from Joehuu/remove-android-manifest-overlay

  Remove android manifest overlay

  Bartłomiej Dach · 2023-07-17 22:12:11 +02:00
  88ac53557a
• Merge pull request #24189 from peppy/discord-rpc-reconnect-fix

  Re-enable connection retrying on discord connector

  Bartłomiej Dach · 2023-07-17 19:58:37 +02:00
  551c243945
• Re-enable connection retrying on discord connector
  Bartłomiej Dach · 2023-07-17 19:19:03 +02:00
  17aac0694e
• Merge pull request #24256 from tybug/update-download-icon

  Use `FontAwesome.Download` for updates instead of `FontAwesome.Upload`

  Dean Herbert · 2023-07-17 12:25:04 +09:00
  66269be189
• use fa_download for updates instead of fa_upload
  Liam DeVoe · 2023-07-16 15:21:15 -04:00
  6200e207d2
• Merge pull request #24255 from bdach/multiplayer-disconnection-schedule-bomb

  Fix several issues in multiplayer exit-on-disconnection flow

  Dean Herbert · 2023-07-17 04:04:38 +09:00
  2023.717.0 a472fe6789
• Fix MultiplayerMatchSubScreen erroneously pushing exit dialog on API failure

  If `IAPIProvider.State` changes from `Online` at any point when being on
  an `OnlinePlayScreen`, it will be forcefully exited from. However,
  `MultiplayerMatchSubScreen` had local logic that suppressed the exit in
  order to show a confirmation dialog.
  
  The problem is, that in the suppression logic,
  `MultiplayerMatchSubScreen` was checking
  `MultiplayerClient.IsConnected`, which is a SignalR flag, and was not
  checking `IAPIAccess.State`, which is maintained separately. Due to
  differing timeouts and failure thresholds, it is not impossible to have
  `MultiplayerClient.IsConnected == true` but `IAPIAccess.State !=
  APIState.Online`.
  
  In such a case, the match subscreen would wrongly consider itself to be
  still online and due to that, push useless confirmation dialogs, while
  being in the process of being forcefully exited. This then caused the
  dialog to cause a crash, as it was calling `.Exit()` on the screen which
  would already have been exited by that point, by the force-exit flow.

  Bartłomiej Dach · 2023-07-16 19:56:22 +02:00
  7fbd47e9ee
• Fix PopupDialog potentially accumulating schedules during load
  Bartłomiej Dach · 2023-07-16 19:43:37 +02:00
  cd02a8a9ca
• Update DiscordRichPresence to pull in performance fix

  See https://github.com/Lachee/discord-rpc-csharp/pull/237

  Dean Herbert · 2023-07-17 02:24:51 +09:00
  a6b1559e1f
• Merge pull request #24246 from bdach/fix-exit-dialog-crash

  Fix potential crash in confirm exit dialog while attempting to exit game

  Dean Herbert · 2023-07-17 01:11:07 +09:00
  acb51dfca3
• Update framework
  Dean Herbert · 2023-07-17 00:55:25 +09:00
  e25cd03e4b
• Remove unused local variable
  Bartłomiej Dach · 2023-07-16 17:10:26 +02:00
  a42992d3fd
• Fix PerformAction<T>() potentially crashing when no matching button is found
  Bartłomiej Dach · 2023-07-16 16:55:20 +02:00
  d25a03984b
• Add failing test covering exit dialog crash
  Bartłomiej Dach · 2023-07-16 16:55:20 +02:00
  72bf43e297
• Remove android manifest overlay
  Joseph Madamba · 2023-07-15 23:38:06 -07:00
  ce12afde70
• Merge pull request #24233 from chayleaf/fix-taiko-maps-not-finishing

  Fix taiko maps sporadically not completing with Hidden mod active

  Dean Herbert · 2023-07-16 13:32:38 +09:00
  2023.716.0 50e6f0aee9
• Fix covariant array spec in new test
  Dean Herbert · 2023-07-16 12:48:58 +09:00
  416ee0d99c
• Merge pull request #24235 from AkiSakurai/toplocalrank

  Compute the top local rank directly without an expensive detach call

  Dean Herbert · 2023-07-16 12:14:56 +09:00
  2d51aa21b7
• Merge pull request #24219 from peppy/fix-mania-everything

  Fix osu!mania scores failing to convert to new standardised score due to cast failure

  Dean Herbert · 2023-07-16 11:54:42 +09:00
  cf70f5e04d
• simplify code
  Aki · 2023-07-16 10:21:32 +08:00
  cb354685ca
• Fix nested hits not being hittable if cut off by parent object ending
  Bartłomiej Dach · 2023-07-15 18:44:47 +02:00
  041e818892
• Add failing test case for hitting nested hit past parent end time
  Bartłomiej Dach · 2023-07-15 18:43:31 +02:00
  955aa70e46
• Add inline commentary about OnKilled() override
  Bartłomiej Dach · 2023-07-15 18:22:04 +02:00
  9e960894c2
• Add test coverage for failing hit judgement with HD active
  Bartłomiej Dach · 2023-07-15 18:17:45 +02:00
  24d63a4d96
• Bring back test coverage for fail case from #16475

  It was inadvertently dropped during refactoring in
  b185194d07.

  Bartłomiej Dach · 2023-07-15 18:15:42 +02:00
  542916f857
• move StrongNestedHit OnKilled to DrawableStrongNestedHit
  chayleaf · 2023-07-15 22:33:16 +07:00
  3e91d30825
• Compute the top local rank directly without an expensive detach call
  Aki · 2023-07-15 23:00:13 +08:00
  309c852222
• Fix some taiko maps not finishing in some conditions

  I don't know how to reproduce this issue in a test, so no tests for now.
  Nonetheless, this fixes the issue for me at least on one map:
  https://osu.ppy.sh/beatmapsets/1899665#taiko/3915653
  
  This workaround is similar to #16475 (the test from that commit got
  eventually removed for some reason).

  chayleaf · 2023-07-15 20:24:40 +07:00
  7f957d3fbe
• Flag decoded scores more correctly
  Dean Herbert · 2023-07-15 12:19:18 +09:00
  eb81eac635
• Fix incorrect comparer implementation
  Dean Herbert · 2023-07-15 11:19:34 +09:00
  e58488d04a
• Update framework
  Dean Herbert · 2023-07-15 01:12:10 +09:00
  1868826d69
• Ensure migration is never run on scores with new-enough TotalScoreVersions
  Dean Herbert · 2023-07-14 20:02:25 +09:00
  480259b8d2
• Fix osu!mania scores failing to convert to new standardised score due to cast failure

  Regressed in https://github.com/ppy/osu/pull/23917.
  Closes #24217.

  Dean Herbert · 2023-07-14 19:38:10 +09:00
  d4fb0bef95
• Merge pull request #24199 from peppy/revert-to-default-design-change

  Update design of "revert to default" button

  Bartłomiej Dach · 2023-07-13 23:44:24 +02:00
  cdbb6f90be
• Merge pull request #24197 from peppy/allow-autoplay-failure

  Allow autoplay to fail

  Bartłomiej Dach · 2023-07-13 23:44:07 +02:00
  ff56e35093
• Fix broken test
  Bartłomiej Dach · 2023-07-13 22:28:26 +02:00
  e7dbe3c938
• Merge pull request #24190 from novialriptide/emoji-fix

  Replace emoji unicode with `[emoji]`

  Bartłomiej Dach · 2023-07-13 22:05:12 +02:00
  cef0dd1d61
• Merge pull request #24204 from peppy/results-screen-component-metrics

  Touch up various results screen component's metrics

  Bartłomiej Dach · 2023-07-13 22:03:49 +02:00
  96e4b8d792
• Merge pull request #24183 from Susko3/framework-clipboard

  Resolve `Clipboard` via DI

  Dean Herbert · 2023-07-14 05:01:50 +09:00
  34e3276d23
• Fix mixed [cC]urrent usage
  Bartłomiej Dach · 2023-07-13 22:00:21 +02:00
  9cc2150b5a
• Remove outdated comment
  Bartłomiej Dach · 2023-07-13 21:58:55 +02:00
  3ca767b7a2
• Rewrite test scene to show non-themed and themed variants
  Bartłomiej Dach · 2023-07-13 21:54:30 +02:00
  6b9dabbd3c