69848 Commits

This Branch

This Branch

All Branches

• Add test coverage
  Bartłomiej Dach · 2024-10-21 12:44:01 +02:00
  59e9ed7bac
• Add blank line to TopScoreStatisticsSection.cs:238
  Wezwery · 2024-10-19 13:41:36 +03:00
  47936c7b02
• Add highlight to combo and accuracy when max.
  Wezwery · 2024-10-19 03:08:08 +03:00
  df90b726b9
• Merge pull request #30334 from SupDos/argonsongprogress-absolute-size

  Add "Use relative size" setting to argon & default song progress

  Bartłomiej Dach · 2024-10-18 13:35:26 +02:00
  2024.1018.0 00b2bdd0af
• Merge pull request #30320 from smoogipoo/refactor-bat-component

  Refactor `BeatmapAttributeText` to compute values on the fly

  Bartłomiej Dach · 2024-10-18 11:56:53 +02:00
  6576131d58
• Add relative size toggle to DefaultSongProgress too
  Bartłomiej Dach · 2024-10-18 11:43:03 +02:00
  47f10693c4
• Add localisation support for "use relative size" setting label
  Bartłomiej Dach · 2024-10-18 11:39:55 +02:00
  bb4f3c71e0
• Merge branch 'master' into refactor-bat-component
  Bartłomiej Dach · 2024-10-18 10:50:21 +02:00
  8e01020f3e
• Merge pull request #30337 from peppy/update-dependencies

  Update dependencies

  Bartłomiej Dach · 2024-10-18 10:50:03 +02:00
  2ef5fa367b
• Return empty strings rather than erroring

  Preventing malicious actors from permanently destroying games via skins.

  Dan Balasescu · 2024-10-18 17:18:01 +09:00
  e27aa0c761
• Only add as many values as are replaced
  Dan Balasescu · 2024-10-18 17:16:42 +09:00
  2de5e3392e
• Silence nullref inspection in test
  Bartłomiej Dach · 2024-10-18 09:42:08 +02:00
  8b4565b3d9
• Update signalr exceptions in line with deprecated ctor
  Dean Herbert · 2024-10-18 16:20:07 +09:00
  7ca5f91c15
• Update all dependencies (except realm, nunit, moq and deepclone)
  Dean Herbert · 2024-10-18 16:20:07 +09:00
  ca2bd640b4
• Use better exception messaging
  Bartłomiej Dach · 2024-10-18 08:51:01 +02:00
  8804769da1
• Discard unused argument
  Bartłomiej Dach · 2024-10-18 08:39:23 +02:00
  b455b9ad09
• Merge pull request #30335 from peppy/expose-noop-ctors

  Expose no-op constructors as `protected`

  Bartłomiej Dach · 2024-10-18 08:34:59 +02:00
  7ba17b9ca0
• Expose no-op constructors as protected
  Dean Herbert · 2024-10-18 13:30:29 +09:00
  8193038986
• Add Use relative size setting to ArgonSongProgress
  SupDos · 2024-10-18 01:47:54 +02:00
  7d0da79db7
• Add test scene
  Dan Balasescu · 2024-10-17 21:18:44 +09:00
  f3178b1fef
• Merge pull request #30319 from smoogipoo/improve-diffcalc-workflow

  Fix argument order in diffcalc workflow

  Dean Herbert · 2024-10-17 17:02:11 +09:00
  3bcd6b9af5
• Fix argument order in diffcalc workflow
  Dan Balasescu · 2024-10-17 16:57:00 +09:00
  1536a9886c
• Refactor BeatmapAttributeText to compute values on the fly
  Dan Balasescu · 2024-10-17 16:10:06 +09:00
  102f55a213
• Merge pull request #30281 from bdach/remove-irrelevant-hacks

  Fix slider ticks and repeats incorrectly moved to position of head when strict tracking and any conversion mod that moves objects is active

  Dan Balasescu · 2024-10-17 14:10:36 +09:00
  80c77e6e05
• Merge pull request #30318 from smoogipoo/improve-diffcalc-workflow

  Improve diffcalc workflow with explicit wait + logs

  Dean Herbert · 2024-10-17 13:56:57 +09:00
  87aa3be376
• Improve diffcalc workflow with explicit wait + logs
  Dan Balasescu · 2024-10-17 13:44:00 +09:00
  135b85a55a
• Merge pull request #30145 from WitherFlower/ranked-date-filtering

  Add ranked date and submitted date filtering to song select

  Dean Herbert · 2024-10-17 02:38:36 +09:00
  dafe8d6448
• Merge pull request #30309 from peppy/no-delay-on-pause

  Remove hold-to-confirm delay when pausing using keyboard shortcuts

  Bartłomiej Dach · 2024-10-16 15:04:29 +02:00
  719a81575a
• Remove hold-to-confirm delay when pausing using keyboard shortcuts
  Dean Herbert · 2024-10-16 20:41:24 +09:00
  b29a17364d
• Merge pull request #26303 from OliBomby/grids

  Add keybind for cycling grid type

  Bartłomiej Dach · 2024-10-16 13:12:23 +02:00
  4fa101d935
• Remove unused field

  Not sure why inspectcode is quiet about this?

  Bartłomiej Dach · 2024-10-16 09:59:05 +02:00
  882df6b828
• Merge branch 'master' into grids
  Bartłomiej Dach · 2024-10-16 09:55:27 +02:00
  dcf78a6e2c
• Merge pull request #30245 from 424ever/group-slider-ends

  Group `HitResult`s with the same name into one column in beatmap ranking

  Bartłomiej Dach · 2024-10-16 09:40:45 +02:00
  8ed0554b91
• Merge pull request #30264 from LBlend/change-fps-toggle-keybind

  Remove default keybind for "Toggle FPS counter"

  Dean Herbert · 2024-10-16 16:35:02 +09:00
  c9519dc90b
• Merge pull request #30231 from SchiavoAnto/skin-editor-ui-localisation

  Allow more localisation in skin editor

  Bartłomiej Dach · 2024-10-16 09:17:45 +02:00
  5fff632c9f
• Fix migration not checking combination properly
  Bartłomiej Dach · 2024-10-16 08:17:22 +02:00
  f8a13b0beb
• Merge pull request #30219 from bdach/scale-with-no-axes-should-do-nothing

  Ensure at least one scale popover axis is active at any time

  Dean Herbert · 2024-10-16 04:31:45 +09:00
  8e76dd553e
• Merge branch 'master' into scale-with-no-axes-should-do-nothing
  Bartłomiej Dach · 2024-10-15 14:20:24 +02:00
  b92cbff81d
• Ensure at least scale popover axis toggle is active at any time

  As in, toggling off an axis if it is the only one enabled will enable
  the other one in turn.
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2024-10-15 14:12:17 +02:00
  634f20e8de
• Only keep track of the names of hit results to display in a ScoreTable
  Jonas Brandstötter · 2024-10-14 16:55:07 +02:00
  a007a81fe8
• Sum up totals for hit results with the same name
  Jonas Brandstötter · 2024-10-14 16:33:30 +02:00
  285756802c
• Correct typo
  Jonas Brandstötter · 2024-10-14 16:16:00 +02:00
  511f0e99b3
• Correct reference to hit result and link to them
  Jonas Brandstötter · 2024-10-14 16:14:29 +02:00
  25c0ff4168
• Revert 9cd7f2b and fc1ebfd
  schiavoanto · 2024-10-14 16:14:23 +02:00
  d7021f989b
• Use ChildrenOfType<> to get ScoreTable to test
  Jonas Brandstötter · 2024-10-14 16:11:58 +02:00
  750e0b29ca
• Merge pull request #30277 from bdach/fix-shuffle-more

  Fix shuffle not actually changing the track sometimes

  Dean Herbert · 2024-10-14 23:09:13 +09:00
  790f863e06
• migrate clearance of conflicting ToggleFPSDisplay keybind
  Leander Furumo · 2024-10-14 16:03:29 +02:00
  035e5a9613
• Loop track even if shuffling if there is only one available

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2024-10-14 15:28:32 +02:00
  8cec318c1f
• Remove no longer required nested object reposition hacks

  As touched on in
  https://github.com/ppy/osu/issues/30237#issuecomment-2408557766, these
  types of maneouvers are no longer required after
  https://github.com/ppy/osu/pull/30021 - although as it turns out on
  closer inspection, these things being there still *did not actually
  break anything*, because the `slider.Path` mutation at the end of
  `modifySlider()` causes `updateNestedPositions()` to be called
  eventually anyway. So this is at mostly a code quality upgrade.

  Bartłomiej Dach · 2024-10-14 14:26:27 +02:00
  1f1a174c50
• Fix strict tracking mod not populating path progress for ticks/repeats

  Closes https://github.com/ppy/osu/issues/30237.
  
  This is the root failure in the issue, and one that *only* presents when
  another conversion mod that repositions the objects is also active. That
  makes the `PathProgress` of the nesteds to be zero, therefore making
  them occupy the position of the slider head after any mutation to the
  path.

  Bartłomiej Dach · 2024-10-14 14:26:27 +02:00
  275b86cd3c