28 Commits

• Do not send replay frames to spectator server if initial begin play invocation failed (#37159)

  RFC
  
  Until now, if the initial `BeginPlaySession()` call failed, the client
  would continue operating as if it didn't - it would still continue to
  send frames and call `EndPlaySession()` at the end of a session.
  
  Server-side, two things generally can happen after this:
  
  - The sent frames and the `EndPlaySession()` call are
  [completely](https://github.com/ppy/osu-server-spectator/blob/7bab117e9d161455485368f63a0607a9e53f9f8a/osu.Server.Spectator/Hubs/Spectator/SpectatorHub.cs#L122-L125)
  [ignored](https://github.com/ppy/osu-server-spectator/blob/7bab117e9d161455485368f63a0607a9e53f9f8a/osu.Server.Spectator/Hubs/Spectator/SpectatorHub.cs#L153-L157)
  as no-ops, or
  - A hub filter (like `ClientVersionChecker`) that failed the initial
  `BeginPlaySession()` call continues to fail the calls to
  `SendFrameData()` and `EndPlaySession()`, all the while creating a storm
  in logs, because it needs to throw `HubException`s to communicate to
  users that they need to update their game, and the exceptions can't be
  silenced from logs because they look like every other failure.
  
  To that end, this has two goals: reduce useless network traffic, and
  reduce noise in spectator server logs after the client version checks
  were recently reactivated.
  
  Probably needs tests, but unsure if everyone's going to be on board with
  this to begin with to be quite frank, so I'm leaving tests for when I'm
  told this needs tests.

  Bartłomiej Dach · 2026-04-09 03:40:32 +09:00
  ca44d8233d
• Apply minor performance rules
  Huo Yaoyuan · 2024-11-28 20:41:44 +08:00
  f5a7716509
• Add test coverage of judgements not being synced when resuming a replay
  Dean Herbert · 2024-09-18 15:28:10 +09:00
  2d993645af
• Centralise and improve messaging around online state

  When the server requests a disconnect due to a user connecting
  via a second device, the client will now log the user out on the first
  device and show a notification informing them of the cause of
  disconnection.

  Bartłomiej Dach · 2023-11-21 15:15:46 +09:00
  42fada578e
• Implement client-side disconnection flow
  Bartłomiej Dach · 2023-11-21 15:15:45 +09:00
  1c612e2e0c
• Change TestSpectatorClient to provide some better fake data for score / acc
  Dean Herbert · 2023-08-16 17:14:42 +09:00
  56eb44d15b
• Add score processor statistics to replay header
  Dan Balasescu · 2023-05-19 16:29:24 +09:00
  6c6f8621c1
• Move score token to BeginPlaying
  Dan Balasescu · 2022-12-12 13:59:27 +09:00
  caa0b7c290
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix mods not being set on BeginPlayingInternal
  Dean Herbert · 2022-09-08 13:17:27 +09:00
  3b116a1a47
• Add test coverage of track rate adjusting during multi spectator
  Dean Herbert · 2022-09-07 20:00:24 +09:00
  770c1ade2f
• Fix incorrect string interpolation

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2022-06-28 01:43:09 +09:00
  54fe6b7df3
• Add messages to all InvalidOperationExceptions

  Without this, they can be very non-descript and hard to track down

  Dean Herbert · 2022-06-28 01:34:25 +09:00
  569fde4b47
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Add test coverage of SpectatorPlayer failing to seek on inopportune frame arrival time
  Dean Herbert · 2022-03-19 15:06:22 +09:00
  63998ad9f1
• Add test coverage of more advanced frame delivery scenarios to TestSceneSpectatorPlayback
  Dean Herbert · 2022-02-24 02:28:13 +09:00
  260cf793fe
• Add ability to simulate network failures to TestSpectatorClient
  Dean Herbert · 2022-02-24 02:23:48 +09:00
  c94e7e2abe
• Prefix all test send methods in TestSpectatorClient with Send
  Dean Herbert · 2022-02-24 02:23:48 +09:00
  14c8ce50a0
• Unify namings across the board
  Dan Balasescu · 2022-02-09 12:10:07 +09:00
  ffc4c64f7e
• Fix up TestSpectatorClient implementation

  Rather than using a list which is supposed to be updated "client"-side,
  now uses the "server"-side list.

  Dan Balasescu · 2022-02-02 23:05:09 +09:00
  9d1d13c715
• Remove PlayingUsers list from SpectatorClient
  Dan Balasescu · 2022-02-01 14:42:30 +09:00
  502e6af008
• Rename dictionary and make private for added safety
  Dean Herbert · 2022-01-31 15:12:08 +09:00
  57f793aff0
• Purge final spectator frames before ending play
  Dan Balasescu · 2022-01-28 22:26:05 +09:00
  3037a3a769
• Remove local "next frame" storage
  smoogipoo · 2021-06-10 22:41:38 +09:00
  58d71e4aea
• Fix test failure in TestSceneMultiplayerGameplayLeaderboard

  The transfer of users was not accounting for the fact that the
  `StartPlay` calls are now scheduled and not necessarily run in time.

  Dean Herbert · 2021-05-27 19:57:21 +09:00
  121dd175e6
• Improve implementation of TestSpectatorClient

  There was a lot of weirdness here, such as storing the playing users,
  clearing the playing users from test scenes (!!), and storing the users
  being wathed.
  This was all a thing because the previous implementation overrode the
  base method implementations, which is no longer a thing.

  smoogipoo · 2021-05-20 17:41:46 +09:00
  9d07749959
• Fix test compilation error
  smoogipoo · 2021-05-20 17:20:30 +09:00
  750a5c3ea9
• Rename SpectatorStreamingClient -> SpectatorClient
  smoogipoo · 2021-05-20 15:55:07 +09:00
  6beeb7f7c4