Dean Herbert
54e5f1c9f0
Merge pull request #29556 from frenzibyte/kiai-star-bursts
...
Add star fountains/bursts when entering kiai mode in gameplay
2024-08-22 14:14:25 +09:00
Dean Herbert
502192ff6f
Merge pull request #29529 from frenzibyte/fix-mania-stuff
...
Fix mania combo counter positioning break on centre anchor
2024-08-22 11:08:18 +09:00
Dean Herbert
a943000579
Merge pull request #29435 from OliBomby/improve-snaps
...
Fix timeline snapping ignoring nearby timing points
2024-08-22 01:36:30 +09:00
Dean Herbert
2876cb73bd
Merge pull request #28991 from Layendan/master
...
Add collection and favourite buttons to results screen
2024-08-21 23:59:26 +09:00
Bartłomiej Dach
28d0a24555
Fix the fix
...
The more proper way to do this would be to address the underlying issue,
which is https://github.com/ppy/osu/issues/29546 , but let's do this
locally for now.
2024-08-21 12:27:56 +02:00
Salman Ahmed
c92af71029
Add in-gameplay version of kiai star fountains/burst
2024-08-21 17:34:38 +09:00
Dan Balasescu
4ee5a1225e
Merge pull request #29540 from frenzibyte/fix-resume-overlay
...
Fix resume overlay appearing behind HUD/skip overlays
2024-08-21 08:56:01 +09:00
OliBomby
8d72ec8bd6
move timing point binary search back inline
2024-08-21 01:50:52 +02:00
Salman Ahmed
0d358a1dae
Fix resume overlay appearing behind HUD/skip overlays
2024-08-21 02:53:11 +09:00
Dan Balasescu
f4b8fc6165
Merge pull request #29536 from frenzibyte/fix-legacy-key-counter-position
...
Fix legacy key counter position not matching stable
2024-08-21 01:05:46 +09:00
Salman Ahmed
20658ef4ee
Fix legacy key counter position not matching stable
2024-08-21 00:10:16 +09:00
Dan Balasescu
2011d5525f
Add flaky test attribute to some tests
...
See occurences like https://github.com/ppy/osu/actions/runs/10471058714 .
2024-08-20 22:21:10 +09:00
Dan Balasescu
5bb94000d3
Merge pull request #29534 from bdach/fix-divisor-crash
...
Fix crash on attempting to edit particular beatmaps
2024-08-20 22:06:32 +09:00
Dan Balasescu
44213a34ae
Merge pull request #29508 from peppy/hold-for-menu-sometimes
...
Change "hold for menu" button to only show for touch by default
2024-08-20 21:45:50 +09:00
Bartłomiej Dach
c2dd2ad978
Clamp beat divisor to sane range when decoding
...
In my view this is a nice change, but do note that on its own it does
nothing to fix https://github.com/ppy/osu/issues/29492 , because of
`BeatmapInfo` reference management foibles when opening the editor. See
also: https://github.com/ppy/osu/issues/20883#issuecomment-1288149271 ,
https://github.com/ppy/osu/pull/28473 .
2024-08-20 13:52:29 +02:00
Bartłomiej Dach
bb964e32fa
Fix crash on attempting to edit particular beatmaps
...
Closes https://github.com/ppy/osu/issues/29492 .
I'm not immediately sure why this happened, but some old locally
modified beatmaps in my local realm database have a `BeatDivisor` of 0
stored, which is then passed to
`BindableBeatDivisor.SetArbitraryDivisor()`, which then blows up.
To stop this from happening, just refuse to use values outside of a sane
range.
2024-08-20 13:51:58 +02:00
Dean Herbert
ebff2ebf01
Merge pull request #29528 from smoogipoo/invert-snapping-binds
...
Make grid/distance snap binds T/Y respectively
2024-08-20 19:23:42 +09:00
Bartłomiej Dach
f0ddb6daa4
Merge pull request #29445 from OliBomby/transparent-break
...
Make break periods in bottom timeline transparent
2024-08-20 11:46:02 +02:00
Dean Herbert
28f1ea9911
Merge pull request #29531 from bdach/remove-dead-classes
...
Remove dead row attribute classes
2024-08-20 18:36:14 +09:00
Dean Herbert
73f2f5cb12
Fix more tests
2024-08-20 17:59:55 +09:00
Dean Herbert
bccc797bcb
Move break display to background of summary timeline
2024-08-20 17:45:44 +09:00
Dean Herbert
c85b04bca5
Add more test coverage to better show overlapping break / kiai sections
2024-08-20 17:45:44 +09:00
Bartłomiej Dach
373ff47a94
Remove dead row attribute classes
...
These aren't shown on the control point table since difficulty and
sample control points were moved into objects.
2024-08-20 09:53:40 +02:00
Dan Balasescu
95a3dcfdae
Merge pull request #29515 from TheOmyNomy/add-cursor-trail-expanding-behaviour
...
Apply current cursor expansion scale to trail parts
2024-08-20 16:14:58 +09:00
Dan Balasescu
2e67ff1d92
Fix tests
2024-08-20 16:14:05 +09:00
Dan Balasescu
4a19ed7472
Add test
2024-08-20 15:20:48 +09:00
Dan Balasescu
180c4a0248
Fix tests by removing assumption
2024-08-20 14:20:52 +09:00
Salman Ahmed
4d74625bc7
Fix mania combo counter positioning break on centre anchor
2024-08-20 12:39:51 +09:00
Salman Ahmed
a3234e2cde
Add failing test case
2024-08-20 12:39:41 +09:00
Dan Balasescu
86c3c115f6
Make grid/distance snap binds T/Y respectively
2024-08-20 12:15:33 +09:00
Dean Herbert
5ba1b4fe3d
Update test coverage
2024-08-20 01:13:00 +09:00
Layendan
59ba48bc81
Fix crash if favourite button api request fails
2024-08-19 07:58:20 -07:00
TheOmyNomy
67de43213c
Apply current cursor expansion scale to trail parts
2024-08-19 23:21:06 +10:00
Bartłomiej Dach
7693d4c039
Merge branch 'master' into master
2024-08-19 14:30:20 +02:00
Dean Herbert
6985e2e657
Increase default visibility on touch platforms
2024-08-19 20:32:05 +09:00
Dean Herbert
005b1038a3
Change "hold for menu" button to only show for touch by default
2024-08-19 20:23:25 +09:00
Bartłomiej Dach
24a0a3c47f
Merge pull request #29476 from EVAST9919/buffered-editor-grid
...
Improve draw performance of editor grids
2024-08-19 12:44:08 +02:00
Dan Balasescu
03188e40ee
Merge pull request #29504 from peppy/skin-editor-fix-sidebar-reload
...
Fix skin editor components sidebar not reloading when changing skins
2024-08-19 18:13:52 +09:00
Dan Balasescu
bb723a466b
Merge pull request #29503 from peppy/catcher-trail-fix
...
Fix osu!catch trail spacing not matching osu!stable expectations
2024-08-19 18:12:56 +09:00
Dan Balasescu
c18f7a239c
Merge pull request #29474 from peppy/fix-legacy-combo-counter-animation-dead
...
Fix legacy combo counter bounce animation not always playing
2024-08-19 18:09:57 +09:00
Dan Balasescu
4351de7abf
Merge pull request #29502 from peppy/no-duck-when-zero-sample-volume
...
Don't duck music when effect volume is set to zero
2024-08-19 16:13:57 +09:00
Dean Herbert
1bd2f4c6a2
Fix skin editor components sidebar not reloading when changing skins
...
Closes https://github.com/ppy/osu/issues/29098 .
2024-08-19 15:45:18 +09:00
Dean Herbert
ca92c116b5
Fix osu!catch trail spacing not matching osu!stable expectations
...
Closes https://github.com/ppy/osu/issues/28997 .
2024-08-19 15:01:16 +09:00
Dean Herbert
4a3f4c3a55
Don't duck music when effect volume is set to zero
...
Addresses https://github.com/ppy/osu/discussions/28984 .
2024-08-19 14:46:50 +09:00
Dean Herbert
510f2c8ce2
Merge pull request #28538 from bdach/polygon-tool
...
Reimplement stable polygon tool
2024-08-19 14:34:02 +09:00
Dean Herbert
7248c04ba4
Merge branch 'master' into polygon-tool
2024-08-19 13:54:02 +09:00
Dean Herbert
95d06333c1
Fix typo in editor field
2024-08-19 13:49:59 +09:00
Dean Herbert
f34132fd6b
Merge branch 'master' into polygon-tool
2024-08-19 13:00:02 +09:00
Dean Herbert
e75ae4a37b
More hardening of TestMultiplayerClient to attempt to fix test failures
2024-08-19 04:04:24 +09:00
Dean Herbert
07929b440a
Merge pull request #29485 from Joehuu/fix-carousel-panel-hover
...
Fix beatmap carousel panels not blocking hover of other panels in song select
2024-08-19 03:46:28 +09:00
