48 Commits

• Update lots of packages (#36996)

  It's been a while.
  
  Notes:
  
  - `SharpCompress` usages changed a bit. Manually adjusted these, mostly
  just renames or adjusted parameters.
  - nUnit 3 -> 4 migrated using
  https://gist.github.com/peppy/07994386d793a117350cb5f24b156585. there's
  a mode in this script to update to the newer `Assert.That` syntax but it
  requires fixes and couldn't really be bothered.
  - DeepEqual nuked as the only usage was on a disabled test. The reason
  it's disabled has been merged upstream, but it's failing for other
  (realm) reasons which I don't think is worthwhile to investigate for
  now.
  - This bumps Moq. I think the author is back in a sensible headspace and
  the new version has the stupid shit removed, so probably okay? Nice to
  be on a level playing field with packages for once in a long time.
  - Automapper is silly, but we've discussed this elsewhere.
  - `TestRealmKeyBindingStore` failures are a wildcard, but fixed by using
  a more standardised testing method. Dunno why, don't care.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-03-17 03:58:02 +09:00
  a996261304
• add util for getting storyboard video of a difficulty
  Hivie · 2025-08-13 20:26:26 +01:00
  79fcd045b3
• initial pass on updated verifier context usage across most checks
  Hivie · 2025-08-11 14:57:14 +01:00
  fd6cf680b9
• move storyboard presence check to shared utils
  Hivie · 2025-08-06 14:55:20 +01:00
  9b53d340af
• Merge pull request #34465 from Hiviexd/verify/check-inconsistent-timing

  Add verify check for inconsistent timing control points

  Bartłomiej Dach · 2025-08-05 10:34:47 +02:00
  427dc2b31e
• Bring back localisations
  Bartłomiej Dach · 2025-08-05 08:23:47 +02:00
  c1c43fab17
• Use casing of "beatmap set" consistent with the rest of the code base
  Bartłomiej Dach · 2025-08-05 08:18:30 +02:00
  ee5a5cda11
• remove unnecessary localisations
  Hivie · 2025-08-04 22:07:41 +01:00
  2c5aa73ccb
• apply review

  - improve timing tolerance const name and documentation
  - simplify matching logic in `FindMatchingTimingPoint`

  Hivie · 2025-08-04 15:21:43 +01:00
  a7f0ae09bb
• define general checks with a bool in CheckMetadata instead of an interface
  Hivie · 2025-08-04 14:12:59 +01:00
  ed301ec114
• rename scopes
  Hivie · 2025-08-04 14:02:40 +01:00
  8a2053bf61
• add VerifyChecksScope enum
  Hivie · 2025-08-01 21:40:33 +01:00
  8e73c57470
• add class for general checks
  Hivie · 2025-08-01 21:39:46 +01:00
  7f8b6981b2
• move methods to TimingCheckUtils

  so they can be reused for future timing-related checks

  Hivie · 2025-08-01 18:37:54 +01:00
  0fcef7b0ee
• Minor cleanups

  Using `ChannelType.Unknown` instead of `0`, adds missing disposal.

  Dan Balasescu · 2025-07-14 15:10:04 +09:00
  8e0ed85ad2
• move audio format checks to reusable audio check utils
  Hivie · 2025-07-13 04:05:46 +01:00
  fccfdbf393
• Use null coalesce wherever possible

  Rider EAP being noisy about this one now.

  Dean Herbert · 2025-05-26 17:15:35 +09:00
  5450298468
• Remove redundant public specfications in interfaces

  Rider EAP being noisy about this now (smoogi will be happy :D).

  Dean Herbert · 2025-05-26 17:14:41 +09:00
  cb0592d711
• Centralise supported file extensions to one helper class

  As proposed in
  https://github.com/ppy/osu-server-beatmap-submission/pull/5#discussion_r1861680837.

  Bartłomiej Dach · 2024-11-29 08:42:45 +01:00
  110e4fbb30
• fix(AudioCheckUtils): use Path.GetExtension()

  To avoid filename escaping

  tsrk · 2023-09-01 20:56:54 +02:00
  2e2dcd99a6
• fix(AudioCheckUtils): add license header
  tsrk · 2023-08-29 23:27:15 +02:00
  5ecd5142d8
• style: move common audio utils to separate static class
  tsrk · 2023-08-29 20:10:35 +02:00
  c1a7ad09b4
• Remove nullable disable annotation in the issue and issue template-related class.
  andy840119 · 2022-10-30 16:25:15 +08:00
  24c27e62f6
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Move IBeatmap arg into context
  Naxess · 2021-05-13 11:24:22 +02:00
  19800f5f7f
• Rename "playableBeatmap" check arg to "beatmap"

  The working beatmap is now in the context, so it's easier to distinguish beatmap type, hence no need for this prefix.

  Naxess · 2021-05-12 02:34:16 +02:00
  b7bc42e0d3
• Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks

  This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.
  
  See next commit for example.

  Naxess · 2021-05-12 02:29:18 +02:00
  c13b93e6f1
• Remove negligible default hidden TODO
  Naxess · 2021-05-12 01:31:16 +02:00
  75adec57eb
• Add the playable beatmap as check argument

  This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor.
  
  So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`.
  
  This should be preferred over `workingBeatmap.Beatmap`.

  Naxess · 2021-04-20 01:31:51 +02:00
  8656176ab8
• Take IWorkingBeatmap instead of WorkingBeatmap

  This makes testing much easier, and allows for checking of any class deriving from that interface, including `WorkingBeatmap`.

  Naxess · 2021-04-18 01:21:20 +02:00
  56bf49c85c
• Use WorkingBeatmap instead of IBeatmap

  This lets us access things like the background, track, etc. which are necessary for quality and filesize checks.
  
  Also improves the structure of the `CheckBackgroundTest` class in the process.

  Naxess · 2021-04-17 17:33:53 +02:00
  448574e7e6
• Add xmldoc to interfaces
  Dean Herbert · 2021-04-13 23:30:20 +09:00
  cb4f64133e
• Use is class instead of Equals with template index

  Ensures ordering of `PossibleTemplates` does not affect tests.

  Naxess · 2021-04-13 02:29:25 +02:00
  6d3f9fa9ce
• Add Equals method to IssueTemplate

  This will be useful in tests.

  Naxess · 2021-04-13 01:21:34 +02:00
  d8088777ea
• Make IssueTemplate.Check readonly
  Naxess · 2021-04-12 16:23:05 +02:00
  6d50d01186
• Rename Check -> ICheck
  Naxess · 2021-04-12 16:20:53 +02:00
  caaaba5950
• Reverse IssueType ordering

  Reversed both in the enum and where it's displayed, so ends up the same in the end.

  Naxess · 2021-04-12 15:49:13 +02:00
  008dbc7dd6
• Rework template usage

  Includes moving the origin check back to templates, constructing nested template classes in each check, and making parameterized template usage.

  Naxess · 2021-04-12 15:47:26 +02:00
  7c4f6d2b62
• Move check origin from IssueTemplate to Issue

  As a result we can also make check an interface, and need to provide the check itself when constructing an issue.

  Naxess · 2021-04-12 10:08:08 +02:00
  65ebdd8f7a
• Change Metadata into a get property
  Dean Herbert · 2021-04-12 15:52:29 +09:00
  8bf85d737c
• Tidy some remaining code
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  78bbc8f5c8
• Change some methods to get properties
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  8c31e96cdf
• Move enums out of nesting
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  f78239c7f2
• Fix formatting of colour getter
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  3551322f1d
• Colour constants to private
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  257acf9cd8
• Wrap xmldoc less and make a few fixes
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  136627b9ac
• Merge Check and BeatmapCheck

  We're probably not going to need GeneralChecks or BeatmapsetChecks.
  
  The verify tab is only available to a single difficulty at a time, and we already have access to the rest of the set through `IBeatmap`.

  Naxess · 2021-04-10 14:56:30 +02:00
  3289bb0379
• Move components to more appropriate spot
  Naxess · 2021-04-10 13:02:22 +02:00
  d1007ff26a