39 Commits

• Adjust multiplayer logic to accommodate for referees spectating in-game (#37152)

  - Last part of / closes
  https://github.com/ppy/osu-server-spectator/issues/406.
  - Remaining work on slots will be tracked in
  https://github.com/ppy/osu-server-spectator/issues/405.
  
  This PR is a corollary of
  https://github.com/ppy/osu-server-spectator/pull/453 and all of the
  dispensations referee users in a multiplayer have received therein. The
  goal here is to allow access to all relevant room management functions
  even if the referee in question isn't host, as well as to disallow
  access to all non-relevant functions to do with the actual match
  gameplay.
  
  I'm not going to lie, this logic *is* ugly. I would argue that it
  already *was* ugly on `master` and my goal was to operate with as light
  a touch as possible myself. But you could see this as copping out and
  that I should try to refactor some of this. I will try - but only after
  someone else's seen the initial approach and deemed it unsuitable.
  
  The logic in `MatchStartControl` is awful - there are so many moving
  pieces of state that dictate what can happen when with all the buttons,
  and yes, I am making it worse here.
  
  This time there is some test coverage. Not everything is covered, but
  the coverage should be on par in all components and pieces of relevant
  logic I touched that already had tests covering them. On that note,
  please forgive the diffstat size, but the tests *are* most of that size.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2026-04-03 19:38:44 +09:00
  31c1168d76
• Merge pull request #32460 from smoogipoo/refactor-match-footer

  Refactor multiplayer match footer

  Bartłomiej Dach · 2025-03-24 12:14:57 +01:00
  fdcf40d4a6
• Refactor ready button to remove selected item bindable
  Dan Balasescu · 2025-03-19 15:48:25 +09:00
  ca2c48bbd6
• Replace superfluous method with concrete implementation
  Dan Balasescu · 2025-03-19 15:32:29 +09:00
  23fa3060b2
• Remove CachedModelDependencyContainer usages from online play
  Dan Balasescu · 2024-11-15 15:59:28 +09:00
  1a656d0ec3
• Make Room.Playlist non-bindable
  Dan Balasescu · 2024-11-15 15:51:01 +09:00
  34c0f72dd6
• Make CurrentPlaylistItem not a bindable
  Dan Balasescu · 2024-11-12 18:17:24 +09:00
  72564b5c98
• Fix up tests
  Dan Balasescu · 2024-11-06 16:35:11 +09:00
  9f08b37792
• Fix countdown button being enabled
  Dan Balasescu · 2023-12-04 11:00:11 +09:00
  8587652869
• Add comments to test
  Dan Balasescu · 2023-12-04 10:20:53 +09:00
  9ccd33a1ec
• Correctly implement button enabled state
  Dan Balasescu · 2023-12-04 10:18:37 +09:00
  c2644a5d5e
• Add test
  Dan Balasescu · 2023-12-01 21:34:20 +09:00
  f3530a79b1
• Remove constructor from MultiplayerPlaylistItem which is only used in tests
  Dean Herbert · 2023-05-25 20:09:40 +09:00
  7a5349d747
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Rewrite rooms to store multiple active countdowns

  Update test to the new structure

  Dan Balasescu · 2022-09-05 19:03:26 +09:00
  2923c10cd8
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Tidy things up
  Dean Herbert · 2022-04-13 21:12:35 +09:00
  c77a7b75d3
• Fix remaining autostart and gameplay tests
  Dean Herbert · 2022-04-13 21:04:15 +09:00
  8b1fd051c6
• Fix gameplay start flow
  Dean Herbert · 2022-04-13 20:57:40 +09:00
  c0ad91796d
• Implement IsHost to return correct value for current state
  Dean Herbert · 2022-04-13 20:51:05 +09:00
  8a7b37856c
• Reimplement beatmap availability test
  Dean Herbert · 2022-04-13 20:41:56 +09:00
  4b6a9fbf47
• Update transfer host logic and simplify local user checks
  Dean Herbert · 2022-04-13 20:38:39 +09:00
  331242d585
• Setup host switching and avoid starting gameplay
  Dean Herbert · 2022-04-13 20:28:53 +09:00
  0a5a3415f8
• Setup start/stop requests
  Dean Herbert · 2022-04-13 17:36:27 +09:00
  ca44d2c4dc
• Apply initial structural changes to TestSceneMatchStartControl
  Dean Herbert · 2022-04-13 17:36:27 +09:00
  1f01714ec2
• Update tests in line with new button behaviour
  Dean Herbert · 2022-03-26 14:43:41 +09:00
  c3a0f0d6b8
• Adjust test button sizing to better match actual usage
  Dean Herbert · 2022-03-26 14:29:31 +09:00
  0146717fcb
• Add missing wait calls on async test steps
  Dean Herbert · 2022-03-25 18:38:26 +09:00
  76abce4867
• Add a few more ready button tests
  Dan Balasescu · 2022-03-25 17:12:00 +09:00
  c1649714f4
• Remove irrelevant test
  Dan Balasescu · 2022-03-25 17:06:04 +09:00
  d5a37c2237
• Rename FinishCountdown() -> SkipToEndOfCountdown()
  Dan Balasescu · 2022-03-24 15:21:46 +09:00
  f0d132b16e
• Rename Multiplayer prefix to button classes
  Dan Balasescu · 2022-03-24 14:28:38 +09:00
  96a447f68b
• Re-remove PopoverButton class with better test fix
  Dan Balasescu · 2022-03-24 14:26:31 +09:00
  90c7945bca
• Revert "Remove PopoverButton class"

  This reverts commit 6b712be97d.

  Dan Balasescu · 2022-03-24 11:15:51 +09:00
  547418e47e
• Merge branch 'master' into multiplayer-countdown-timers-2
  Dan Balasescu · 2022-03-23 15:40:50 +09:00
  34a367b369
• Rename countdown Delay -> Duration
  Dan Balasescu · 2022-03-23 15:21:16 +09:00
  a83a90e675
• Remove PopoverButton class
  Dan Balasescu · 2022-03-23 10:40:38 +09:00
  6b712be97d
• Split MultiplayerReadyButton
  Dan Balasescu · 2022-03-23 10:38:56 +09:00
  9138aaf780