1087 Commits

• Fix non-default mod settings allowing for duplicate freestyle mod selection in multiplayer (#37646)

  Fixes a bug that allowed for selecting the same mod twice in multiplayer
  if the playlist entry has non-default settings for a required mod.
  This happens due to a strict equality mod check in the mod set
  compatibility check function, which only considers mods duplicates if
  their settings are exactly the same. Replacing with a more lenient
  `Type` check fixes this.
  
  Adds a regression test for this behavior
  
  Fixes https://github.com/ppy/osu/issues/37625.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  triacontakai · 2026-05-07 08:59:54 +02:00
  3f5c113394
• Turn tests green, for a short while, maybe (#37218)

  ## [Rewrite `BackgroundMusicManager` to not run into framework
  breakage](https://github.com/ppy/osu/commit/622216d8911832c39fa4e126b2810e4e0f46cbf7)
  
  The attempted proper fix to this was
  https://github.com/ppy/osu-framework/pull/6727. Unfortunately when
  presented with [the framework
  bump](https://github.com/ppy/osu/pull/37217) with that change, CI says
  "you're stupid" and fails on some disposal idiocy that of course is
  undebuggable and irreproducible:
  
  The active test run was aborted. Reason: Test host process crashed :
  Unhandled exception. System.AggregateException: One or more errors
  occurred. (Object reference not set to an instance of an object.)
  ---> System.NullReferenceException: Object reference not set to an
  instance of an object.
  at osu.Framework.Audio.Sample.SampleChannelBass.Dispose(Boolean
  disposing)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  	--- End of stack trace from previous location ---
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task&
  currentTaskSlot, Thread threadPoolThread)
  	   --- End of inner exception stack trace ---
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Threading.AudioThread.OnExit()
  at osu.Framework.Threading.GameThread.setExitState(GameThreadState
  exitState)
  	   at osu.Framework.Threading.GameThread.RunSingleFrame()
  at osu.Framework.Threading.GameThread.<createThread>g__runWork|70_0()
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  	--- End of stack trace from previous location ---
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  
  
  (https://github.com/ppy/osu/actions/runs/24019928154/job/70046733058?pr=37217#step:5:119)
  
  I no longer have the energy for any of this shit.
  
  @nekodex would appreciate if you could check that I actually haven't
  broken anything with the bgm here. Seems okay to me in test scenes at
  least.
  
  ## [Apply lowest-effort maybe-fixing changes to a bunch of flaking
  tests](https://github.com/ppy/osu/commit/7bd3ca4adfcce5b90add11565a13f3fe9177ad5e)
  
  None of the failures are reproducible locally, of course. I'm tired of
  this. If anyone else wants to subject themselves to actually
  investigating any of these, by all means, godspeed and good luck.

  Bartłomiej Dach · 2026-04-06 17:59:39 +09:00
  809298ddeb
• Assorted test deflaking (#37191)

  A few quick ones from https://github.com/ppy/osu/issues/37190.
  
  ## [Rewrite `TestSceneDeleteLocalScore` to have less context menu
  containers (and hopefully no longer
  flake)](https://github.com/ppy/osu/commit/ea0bc5b72374056d1749f8058f4874b7ef66a241)
  
  As seen in
  https://github.com/ppy/osu/actions/runs/23890777748#user-content-r3s3.
  
  This is a speculative fix but I'm feeling somewhat confident about this
  one.
  
  `BeatmapLeaderboardWedge` has TWO separate `ContextMenuContainer`s
  itself, and the test mentioned here was bringing a third. I have a
  feeling that the test flaking may have something to do with the fact
  that the test logic would attempt to click a menu item on specifically
  ONE of the three context menus. My bet is that when it fails, it's
  because it's trying the wrong one, but I don't have reproduction.
  
  ## [Wait for text to appear in flaking
  `TestSceneDrawableRoomPlaylist.TestSelectableMouseHandling`
  test](https://github.com/ppy/osu/commit/9d62eea8b56a0eb013e8116db0d38424b500876f)
  
  As seen in
  https://github.com/ppy/osu/actions/runs/23888446400#user-content-r1s1.
  
  Speculative. Banking on the fact that it takes time to load the sprite
  texts.
  
  ## [Remove all tests from `TestSceneWikiMarkdownContainer` dependent on
  existence of wiki on
  dev](https://github.com/ppy/osu/commit/8f319f91c98510b84e915bb61ec147618a584ce1)
  
  Deletes a flaky as seen in
  https://github.com/ppy/osu/actions/runs/23878899702#user-content-r2s2.
  
  The year is 2026 and LLM scrapers hammer [the
  entire](https://sourcehut.org/blog/2025-04-15-you-cannot-have-our-users-data/)
  [internet](https://blog.metabrainz.org/2025/12/11/we-cant-have-nice-things-because-of-ai-scrapers/)
  all over to scrape whatever ounce of Human Content there is left to feed
  the Moloch so that it can regurgitate it back in the form of The Most
  Average Speech You've Ever Read. We are not immune to this, and as such
  the LLM homunculi have hit the dev.ppy.sh wiki instance enough times for
  it to just completely [be banished to the
  blagole](https://www.youtube.com/watch?v=AfA_2Ku1aJY).
  
  Which means I get to freely delete flaky tests that should never have
  been running as part of CI because they're completely useless now and
  it's not like we're ever turning them back on again.
  
  ## [Use equality check in
  `TestSceneBeatmapCarouselScrolling.TestScrollPositionMaintainedOnRemove_SecondSelected`
  that's less sensitive to floating
  point](https://github.com/ppy/osu/commit/6f2a1de58f7e816830c430e89117ee4c594f529d)
  
  As seen in
  https://github.com/ppy/osu/actions/runs/23826420794#user-content-r0s1.

  Bartłomiej Dach · 2026-04-04 00:17:31 +09:00
  090fe44f86
• Adjust multiplayer logic to accommodate for referees spectating in-game (#37152)

  - Last part of / closes
  https://github.com/ppy/osu-server-spectator/issues/406.
  - Remaining work on slots will be tracked in
  https://github.com/ppy/osu-server-spectator/issues/405.
  
  This PR is a corollary of
  https://github.com/ppy/osu-server-spectator/pull/453 and all of the
  dispensations referee users in a multiplayer have received therein. The
  goal here is to allow access to all relevant room management functions
  even if the referee in question isn't host, as well as to disallow
  access to all non-relevant functions to do with the actual match
  gameplay.
  
  I'm not going to lie, this logic *is* ugly. I would argue that it
  already *was* ugly on `master` and my goal was to operate with as light
  a touch as possible myself. But you could see this as copping out and
  that I should try to refactor some of this. I will try - but only after
  someone else's seen the initial approach and deemed it unsuitable.
  
  The logic in `MatchStartControl` is awful - there are so many moving
  pieces of state that dictate what can happen when with all the buttons,
  and yes, I am making it worse here.
  
  This time there is some test coverage. Not everything is covered, but
  the coverage should be on par in all components and pieces of relevant
  logic I touched that already had tests covering them. On that note,
  please forgive the diffstat size, but the tests *are* most of that size.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2026-04-03 19:38:44 +09:00
  31c1168d76
• Fix replay/spectator scroll text not toggling with Ctrl+H (#37027)

  Intended to add toggle but forgot.
  
  This also fixes https://github.com/ppy/osu/issues/37012 via a convoluted
  refactor of a lot of stuff. The basic overview is:
  
  - Moved all replay overlay concerns out of `HUDOverlay`. We can display
  this above everything confidently (i think).
  - Split out `ReplayOverlay` and `ReplaySettingsOverlay` so the base
  class can handle the visibility, hotkeys and everything that should be
  shared with *all* replay overlay components going forward. `Ctrl+H` is
  supposed to hide any of these kinds of details, and I'm sure we'll add
  more in the future.
  - Reorganised some things in `Player` so the new structure would work.
  Mainly the overlays which add a black layer during fade out.

  Dean Herbert · 2026-04-01 11:29:25 +02:00
  279effe23c
• Various tournament-minded improvements for multiplayer (#37000)

  https://github.com/user-attachments/assets/042311f1-b8c3-479b-a173-13b93fe2c5cc
  
  - `/roll` command is now supported in multiplayer chat for all players
  (don't need to be a referee).
  - Referees are shown in the room with a special status.
  - Tournament mode rooms can be locked, which prevents users from
  changing team (and slot, whenever those get brought back). When the room
  is locked, the user team indicator shows a padlock icon on top to
  indicate the lock state.
  
  ---
  
  - Related: https://github.com/ppy/osu-server-spectator/issues/406
  
  Grab-bag because I really don't think splitting this into 3 PRs is very
  helpful.
  
  I was going to add an animation for rolling but I had a go on Friday and
  my attempt got more or less the same reception as a wet fart so I'm not
  trying again. Someone else can if so inclined. I have completely lost
  trust in my design senses.
  
  Contrary to stable the roll results are completely ephemeral and go away
  when the room is re-entered. This could be both considered good and bad.
  Not for me to say.

  Bartłomiej Dach · 2026-03-20 18:56:45 +09:00
  43c53b5a8d
• Move v2 files to final location

  This contains only renames and namespace updates.

  Dean Herbert · 2026-03-03 16:45:15 +09:00
  c28c64940a
• Remove all song select v1 files

  This contains no code changes (that would need review), only file
  deletion and extraction where required in a few odd cases.

  Dean Herbert · 2026-03-03 16:45:14 +09:00
  1a8d2855d4
• Move leaderboards classes to gameplay namespace for now
  Dean Herbert · 2026-03-03 16:45:13 +09:00
  54a1417dd8
• Switch multiplayer to use song select v2 (#36747)

  Tests pass and seems to work. Need to do a bit more self-testing for
  higher confidence, but in theory..
  
  Closes https://github.com/ppy/osu/issues/34035.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-03-03 13:41:48 +09:00
  d27d0f40c1
• Migrate sheared overlay tests to ScreenTestScene (#36736)

  Part of the screen footer refactor.
  
  Once footer content is being managed by `OsuScreen`, the current tests
  which simply create the tested overlay and `ScreenFooter` in a container
  will no longer work.
  
  This PR refactors them to use `ScreenTestScene` with the setup being
  creating a dedicated testing `OsuScreen` which does the bare minimum to
  create the tested overlay and necessary components (eg.
  `FooterButtonFreeModsV2` for `TestSceneFreeModsOverlay`).
  
  Most of the changes here can be described as
  `%s/<...>Overlay/screen.Overlay/g`, with some minor touchups as
  necessary, given that we're now testing a more complete flow which
  checks more things that were previously not handled by the tests.
  
  ## [Move footer to front in
  ScreenTestScene](https://github.com/ppy/osu/commit/f8740e0403b3c0badd60d394c737f2aa912a9ed6)
  
  Self-explanatory. Without it the footer would show below the actual
  overlay, breaking tests depending on manual input. For the sake of tests
  not breaking in CI, both #36718 and this have this included - would
  prefer the former to be merged first since it was already reviewed
  there.
  
  ## `TestSceneModSelectOverlay`
  
  There were a few tests (`TestColumnHidingOnIsValidChange`,
  `TestColumnHidingOnTextFilterChange`, and
  `TestHidingOverlayClearsTextSearch`) that would create a custom overlay
  instance instead of the globally provided one. I've tested both and the
  tests run fine with the default overlay, so they're now using that
  instead.
  
  ## `TestSceneFreeModSelectOverlay`
  
  Updated to use footer v2.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Krzysztof Gutkowski · 2026-02-28 04:22:58 +09:00
  105342e5bf
• Rename one more missed song select v2 class
  Dean Herbert · 2026-02-25 02:18:18 +09:00
  ee8d99034c
• Remove V2 suffix from migrated classes
  Dean Herbert · 2026-02-24 20:23:29 +09:00
  fabce18552
• Migrate multiplayer freestyle select screen to use SongSelectV2
  Dean Herbert · 2026-02-18 20:50:17 +09:00
  48544733c3
• Fix/remove tests broken by screen behaviour change
  Dean Herbert · 2026-01-01 00:29:04 +09:00
  0a2fc12061
• Merge branch 'master' into new-playlists-song-select
  Dan Balasescu · 2025-12-17 13:33:34 +09:00
  67e0348fa8
• Add test coverage for players leaving during intro
  Salman Alshamrani · 2025-12-04 13:38:30 -05:00
  fef8117b5c
• Add simple "Add to playlist" button in the footer
  Dan Balasescu · 2025-11-18 16:21:08 +09:00
  96dd95940f
• Merge branch 'master' into new-playlists-song-select
  Dan Balasescu · 2025-11-18 14:08:12 +09:00
  a30f08be80
• Suffix introp methods with "Intro"
  Dan Balasescu · 2025-11-04 11:05:41 +09:00
  f4049c7ec1
• Add simple multiplayer skip overlay
  Dan Balasescu · 2025-10-31 21:39:41 +09:00
  b20a41c1e8
• Fix tests
  Dan Balasescu · 2025-10-17 09:18:04 +09:00
  b663fe17ab
• Fix test scene leaks through RealmRulesetStore/RealmAccess
  Dan Balasescu · 2025-10-09 15:28:15 +09:00
  79c367d208
• Add failing test
  Bartłomiej Dach · 2025-09-02 12:23:38 +02:00
  a799720232
• Fix test
  Bartłomiej Dach · 2025-09-01 13:50:42 +02:00
  a008a66fb2
• Add more panel types to TestSceneRoomPanel
  Dean Herbert · 2025-09-01 19:37:35 +09:00
  5079a53cca
• Merge branch 'master' into pinned-rooms
  Dean Herbert · 2025-09-01 16:01:50 +09:00
  4e976cff6a
• Update tests
  Bartłomiej Dach · 2025-08-22 12:44:08 +02:00
  03e7e2b0d8
• Add indicator for pinned rooms in upper right of room panel
  Bartłomiej Dach · 2025-08-22 10:17:15 +02:00
  20b316d32d
• Show pinned rooms on top of listing
  Bartłomiej Dach · 2025-08-21 14:18:13 +02:00
  a6f823e5bc
• Add failing test case
  Bartłomiej Dach · 2025-08-19 12:03:12 +02:00
  62b4999184
• Adjust test to match expected behaviour
  Bartłomiej Dach · 2025-08-13 09:27:01 +02:00
  447858ee5e
• Merge branch 'master' into game-leaderboard-redesign
  Dean Herbert · 2025-08-11 19:20:13 +09:00
  2ff8393603
• Expand test coverage to cover off unexpected complication
  Bartłomiej Dach · 2025-08-01 14:52:30 +02:00
  a886aaf835
• Add failing test
  Bartłomiej Dach · 2025-08-01 13:20:58 +02:00
  acbd6de06f
• Rewrite gameplay leaderboard test scene to be usable

  At some point during the leaderboard data refactor, this test scene
  became completely unusable. This change rewrites it to use
  `SoloGameplayLeaderboardProvider` to be able to witness the user score
  being resorted and advancing through the leaderboard.

  Salman Alshamrani · 2025-07-22 23:58:06 +03:00
  84a36b1bfa
• Re-privatise PlaylistItem.Beatmap, adjust tests
  Dan Balasescu · 2025-07-14 21:19:20 +09:00
  13fc37b2de
• Change failing test to use until step instead
  Bartłomiej Dach · 2025-07-14 13:51:46 +02:00
  fc44301713
• Add failing tests
  Dan Balasescu · 2025-07-14 17:57:41 +09:00
  e36c590315
• Add test coverage
  Salman Alshamrani · 2025-06-26 03:03:22 +03:00
  3ac557907e
• Fix tests
  Dean Herbert · 2025-06-20 20:37:58 +09:00
  3af0ce7e5e
• Combine two similar flags into one
  Dean Herbert · 2025-06-12 17:27:23 +09:00
  ebfc3c9ccf
• Fix intermittent online play mod select tests
  Dan Balasescu · 2025-06-09 23:15:48 +09:00
  55a3ec5026
• Mark some more recent flaky tests
  Dean Herbert · 2025-06-03 16:23:31 +09:00
  ef29eda3e0
• Add extra test coverage for multiplayer participants list in team versus
  Bartłomiej Dach · 2025-05-23 10:47:50 +02:00
  fea50ee432
• Fix tests post-pooling implementation
  Bartłomiej Dach · 2025-05-23 10:47:23 +02:00
  231afbf463
• Implement pooling in multiplayer participants list
  Bartłomiej Dach · 2025-05-23 10:47:07 +02:00
  61e8c25a92
• Modify many users tests to stress it & demonstrate transform overhead
  Bartłomiej Dach · 2025-05-23 10:46:50 +02:00
  40a4129776
• Fix multiplayer position display looking wrong when player count is low

  Spotted when watching video in #33173's opening post.

  Dean Herbert · 2025-05-19 16:58:01 +09:00
  beb77176b6
• Add bar display
  Dean Herbert · 2025-05-13 16:30:38 +09:00
  91b9b41d58