387 Commits

• Fix failing test
  Dan Balasescu · 2026-04-17 17:06:24 +09:00
  9bea31986c
• Add support for grouping by keys in song select for osu!mania (#37285)

  https://github.com/user-attachments/assets/edfc8d06-4f04-4876-84a5-dfc83a18f160
  
  Of note:
  
  - Supports both native beatmaps and converts
  - Supports key mods (changing key mods will trigger song select refilter
  when key count grouping is engaged)
  - The option to group by keys is only visible when mania ruleset is
  active
  - If the user selects key count grouping and then switches to another
  ruleset, song select will fall back to no grouping, but this change will
  not be written back to config. Only the user changing the grouping mode
  manually will reflect in config changes. This is done so that key
  grouping persists across ruleset changes, and this even survives game
  restarts.
  
  ---
  
  I've only done some light behaviour testing on this because this feature
  needs a lot of subjective shot calls and I don't want to commit too deep
  before I get a temperature check on the shot calls I made here.
  
  In particular some performance profiling of
  https://github.com/ppy/osu/commit/7de8f70b1dbbdf2e3f13ba10faf25329abf6468d
  may be warranted.

  Bartłomiej Dach · 2026-04-15 19:01:20 +09:00
  8050ee36ce
• Fix song select search not matching results when punctuation marks surround the searched double-quoted phrase (#37034)

  Fixes #36645
  
  The IsolatedPhrase match mode in FilterCriteria used \s (whitespace) as
  word boundaries, meaning a search term had to be surrounded by spaces
  (or start/end of string) to match.
  
  This caused songs with titles like
  'Music Theme "Some Artist"' to not appear when searching for "Some
  Artist", since the phrase was bounded by quote characters rather than
  spaces.
  
  This change extends the boundary pattern to also accept Unicode
  punctuation (\p{P}) alongside whitespace, so terms surrounded by quotes,
  commas are correctly matched as isolated phrases.
  
  Tests have been added to cover searching for terms adjacent to
  punctuation boundaries
  (TestCriteriaMatchingTermsAdjacentToPunctuation).
  
  Tests cover the example mentioned above.
  Code inspector with no errors and tests passing.

  Simão Caixas · 2026-03-23 08:12:46 +01:00
  f3c9dd7f3b
• Update lots of packages (#36996)

  It's been a while.
  
  Notes:
  
  - `SharpCompress` usages changed a bit. Manually adjusted these, mostly
  just renames or adjusted parameters.
  - nUnit 3 -> 4 migrated using
  https://gist.github.com/peppy/07994386d793a117350cb5f24b156585. there's
  a mode in this script to update to the newer `Assert.That` syntax but it
  requires fixes and couldn't really be bothered.
  - DeepEqual nuked as the only usage was on a disabled test. The reason
  it's disabled has been merged upstream, but it's failing for other
  (realm) reasons which I don't think is worthwhile to investigate for
  now.
  - This bumps Moq. I think the author is back in a sensible headspace and
  the new version has the stupid shit removed, so probably okay? Nice to
  be on a level playing field with packages for once in a long time.
  - Automapper is silly, but we've discussed this elsewhere.
  - `TestRealmKeyBindingStore` failures are a wildcard, but fixed by using
  a more standardised testing method. Dunno why, don't care.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-03-17 03:58:02 +09:00
  a996261304
• Fix Simplified Rhythm mod breaking diffcalc when applied to some maps (#36947)

  - closes https://github.com/ppy/osu/issues/36942
  - fixes https://osu.ppy.sh/community/forums/topics/2187041?n=1
  
  ## [Ensure Simplified Rhythm mod does not produce beatmaps with objects
  out of
  order](https://github.com/ppy/osu/commit/f4807b3a42dbf46ea0e669b0ba658feaef9baca5)
  
  This is a last ditch safety.
  
  This mod has more apparent issues (see below) but this is a first step
  of restoring sanity.
  
  Aside than the other fix described below I have not attempted to figure
  out further why this is happening because the conversion logic is in
  over my head. I just want hard breakage to not be possible. Why this
  extra sort is necessary can be investigated by @Hiviexd if he's so
  inclined.
  
  ## [Fix `GetClosestBeatDivisor()` not working correctly with negative
  time
  instants](https://github.com/ppy/osu/commit/88dc0d8a73c712a040635af262d7519fe6d772a0)
  
  This was causing the 1/3 -> 1/2 conversion in Simplified Rhythm to
  engage on some maps that weren't even mapped in waltz time. Those maps
  had the common trait of having a timing point with a negative start
  time.
  
  Notably this could feasibly affect other places as well, like mania beat
  snap colouring, or the Synesthesia osu! mod.
  
  <details>
  
  <summary>testing</summary>
  
  Tested with Simplified Rhythm engaged, with 1/6 -> 1/4 and 1/3 -> 1/2
  conversion enabled
  
  [BULANOVA - NE PLACH'
  [oni]](https://osu.ppy.sh/beatmapsets/1740291#taiko/3664995) (1/8 snap):
  - No mods: 5.18*
  - Simplified Rhythm @ master: 0.00*
  - Simplified Rhythm @ f4807b3a: 3.48*
  - Simplified Rhythm @ 933de7ab: 5.18*
  
  [BULANOVA - NE PLACH' [inner
  oni]](https://osu.ppy.sh/beatmapsets/1740291#taiko/3648625) (1/8 snap):
  - No mods: 5.84*
  - Simplified Rhythm @ master: 0.00*
  - Simplified Rhythm @ f4807b3a: 4.13*
  - Simplified Rhythm @ 933de7ab: 5.84*
  
  [BULANOVA - NE PLACH' [don't
  cry]](https://osu.ppy.sh/beatmapsets/1740291#taiko/3557681) (1/8 snap):
  - No mods: 6.91*
  - Simplified Rhythm @ master: 0.00*
  - Simplified Rhythm @ f4807b3a: 4.84*
  - Simplified Rhythm @ 933de7ab: 6.91*
  
  [Mili - Peach Pit and Cyanide [nik's
  Normal]](https://osu.ppy.sh/beatmapsets/2468654#osu/5405909) (1/6 snap):
  - No mods: 1.63*
  - Simplified Rhythm @ master: 0.00*
  - Simplified Rhythm @ f4807b3a: 1.10*
  - Simplified Rhythm @ 933de7ab: 1.10*
  
  [Mili - Peach Pit and Cyanide [Ix's
  Hard]](https://osu.ppy.sh/beatmapsets/2468654#osu/5405906) (1/3 snap):
  - No mods: 2.50*
  - Simplified Rhythm @ master: 0.00*
  - Simplified Rhythm @ f4807b3a: 1.71*
  - Simplified Rhythm @ 933de7ab: 1.71*
  
  [Mili - Peach Pit and Cyanide [nomi's Hidden
  Insane]](https://osu.ppy.sh/beatmapsets/2468654#osu/5405910) (1/3 snap):
  - No mods: 3.93*
  - Simplified Rhythm @ master: 0.00*
  - Simplified Rhythm @ f4807b3a: 2.59*
  - Simplified Rhythm @ 933de7ab: 2.59*
  
  [Within Temptation - The Unforgiving [Stairway To The
  Skies]](https://osu.ppy.sh/beatmapsets/29157#osu/172617) (1/3 snap in
  editor):
  - No mods: 1.53*
  - Simplified Rhythm @ master: 0.00*
  - Simplified Rhythm @ f4807b3a: 1.48*
  - Simplified Rhythm @ 933de7ab: 1.48*
  
  [Within Temptation - The Unforgiving
  [Iron]](https://osu.ppy.sh/beatmapsets/29157#osu/172612) (1/6 snap in
  editor):
  - No mods: 2.76*
  - Simplified Rhythm @ master: 0.00*
  - Simplified Rhythm @ f4807b3a: 1.75*
  - Simplified Rhythm @ 933de7ab: 1.75*
  
  [Within Temptation - The Unforgiving
  [Marathon]](https://osu.ppy.sh/beatmapsets/29157#osu/156352) (1/4 snap
  in editor, but has 1/3 / 1/6 sections for sure):
  - No mods: 2.96*
  - Simplified Rhythm @ master: 0.00*
  - Simplified Rhythm @ f4807b3a: 2.75*
  - Simplified Rhythm @ 933de7ab: 2.75*
  	
  [Halozy - Genryuu Kaiko [Higan
  Torrent]](https://osu.ppy.sh/beatmapsets/180138#osu/433005) (1/4 snap):
  - No mods: 5.37*
  - Simplified Rhythm @ master: 0.00*
  - Simplified Rhythm @ f4807b3a: 3.95*
  - Simplified Rhythm @ 933de7ab: 5.37*
  
  </details>

  Bartłomiej Dach · 2026-03-12 22:05:39 +09:00
  28fbb83cc6
• Move v2 files to final location

  This contains only renames and namespace updates.

  Dean Herbert · 2026-03-03 16:45:15 +09:00
  c28c64940a
• Update filter matching tests to be independent of old song select classes
  Dean Herbert · 2026-03-03 16:45:12 +09:00
  f20d182775
• Add created alias for submitted song select filter

  Symmetrical change to https://github.com/ppy/osu-web/pull/12561 (can
  probably wait until that one is reviewed to be legitimate).

  Bartłomiej Dach · 2025-11-20 11:51:28 +01:00
  094454499c
• Add failing test coverage for artist text filters also not working correct
  Bartłomiej Dach · 2025-10-13 11:22:29 +02:00
  f8d3285ab4
• Add failing test coverage for not-equals user tag filter
  Bartłomiej Dach · 2025-10-10 09:55:59 +02:00
  4132a7cd53
• Adjust BPM filtering at song select to be less precise

  Closes https://github.com/ppy/osu/issues/34942.

  Dean Herbert · 2025-09-09 15:02:57 +09:00
  f94d5004ea
• Merge branch 'master' into notequaloperator
  Salman Alshamrani · 2025-08-15 14:30:55 +03:00
  1741142673
• Merge pull request #34657 from peppy/audio-hotfix-aaaaaaaaaaaa

  Ignore more potentially incorrect data from BASS

  Bartłomiej Dach · 2025-08-15 11:05:52 +02:00
  6f733fd3fc
• Ignore more potentially incorrect data from BASS

  This is still a workaround but arguably it's something we could leave in
  place without much loss. I think this at least feels better than the
  previous code.
  
  Notably, you could argue the test coverage of the fail case is lower
  since made it implicit that all tests will avoid the "backwards seek"
  detections.  But we never really had tests correctly- fail on the original
  so I don't see any loss of value.

  Dean Herbert · 2025-08-14 19:20:30 +09:00
  82906300b4
• Simplify multi-valued not-equal enum filter implementation (and cover with tests)
  Bartłomiej Dach · 2025-08-13 11:54:52 +02:00
  0475fe3215
• Remove redundant test
  Bartłomiej Dach · 2025-08-13 11:47:12 +02:00
  bab696f744
• Fix code quality
  Bartłomiej Dach · 2025-08-13 11:45:24 +02:00
  8be6b1ad20
• Fix tests

  - Move them to the correct class. They were exercising filter matching,
    not parsing.
  - Remove a bunch of unreadable tuple stuff that was mostly obfuscating
    the readability without actually improving test coverage.
  - Make tests fail everywhere rather than on CI only. They were failing
    because they were written in a way that was implicitly dependent on
    the local computer's timezone.

  Bartłomiej Dach · 2025-08-13 11:35:05 +02:00
  e31b2c08fd
• Add failing test coverage for applying multiple concurrent tag filters
  Bartłomiej Dach · 2025-08-13 10:21:23 +02:00
  a8b827782e
• Add failing test coverage for parsing multiple concurrent tag filters
  Bartłomiej Dach · 2025-08-13 10:07:50 +02:00
  6ddb2d3305
• Fix code quality

  Fix code quality 2
  
  code quality fix 3
  
  Fix code quality 4
  
  Add empty line

  Valerus9 · 2025-08-13 14:59:29 +09:00
  bd90ef1bf4
• Add tests coverage for filters with not equal
  Valerus9 · 2025-08-13 14:59:20 +09:00
  997b8a0bba
• Added FilterMatchTest for InvertRange
  Valerus9 · 2025-08-13 14:59:20 +09:00
  02f835dbc3
• Add test coverage
  Valerus9 · 2025-08-13 14:59:19 +09:00
  1a18aac515
• Fix intemittent update manager test
  Dan Balasescu · 2025-08-03 03:49:45 +09:00
  f5b3990b36
• Merge pull request #34231 from bdach/user-tag-search-wip

  Add initial support for filtering by user tags in song select

  Dean Herbert · 2025-07-21 14:52:47 +09:00
  b4466aa7a2
• Add initial support for filtering by user tags in song select

  The way that this works is that it plugs into the online request to
  retrieve the beatmap set that the client is already performing, and
  stores user tag data to the local realm database.
  
  This means that for now user tags will only populate for beatmaps that
  the user has displayed on song select which is obviously subpar. I plan
  to follow this change up by adding user tag state dumps to `online.db`
  and using that data for initial tag population to make the majority case
  (ranked beatmaps) work.
  
  Note that several decisions were made here that are potential discussion
  points:
  
  - `RealmPopulatingOnlineLookupSource` is set up such that it can be the
    middle man / redirection point for similar flows that we need and we
    are currently missing, such as storing guest difficulty information,
    or storing the user's current best score on a beatmap (handy for rank
    achieved sorting / filtering / etc.)
  
  - The user tags are stored in `BeatmapMetadata` which breaks the
    longstanding assumption that you can arbitrarily pull out a metadata
    instance from any of the beatmaps in a set and get essentially the
    same object back.
  
    I've attempted to constrain this some by not adding user tags to
    the `IBeatmapMetadataInfo` interface through which `BeatmapSetInfo`
    exposes metadata further, but I warn in advance that this is
    a temporary state of affairs and I will make it worse in the future
    when `BeatmapMetadata.Author` becomes `Authors` plural in order to
    support guest mapper display (and direct guest difficulty submission).
  
  - The syntax for searching via user tags is chosen to mostly match web -
    it's `tag=`, with support for all of the string matching modes song
    select already has (bare word for substring, `""` quotes for phrase
    isolated by whitespace, `""!` for exact full match).

  Bartłomiej Dach · 2025-07-15 11:09:40 +02:00
  8cb81974eb
• Add failing test
  Dan Balasescu · 2025-07-15 13:03:35 +09:00
  27f93d56a0
• Refactor hit windows class structure to reduce rigidity

  This change pulls back a significant degree of overspecialisation and
  rigidity in the class structure of `HitWindows` to make subsequent
  changes to hit windows, whose purpose is to improve replay playback
  accuracy, possible to do cleanly.
  
  Notably:
  
  - `HitWindows` is full abstract now. In a few use cases, and as a
    reference for ruleset implementors, `DefaultHitWindows` is provided as
    a separate class instead.
  
    This fixes the weirdness wherein `HitWindows` always declared 6 fields
    for result types but some of them would never be set to a non-zero
    value or read.
  
  - `HitWindow.GetRanges()` is deleted because it is overspecialised and
    prevents being able to adjust hitwindows by ±0.5ms cleanly which will
    be required later.
  
    The fallout of this is that the assertion that used `GetRanges()` in
    the `HitWindows` ctor must use something else now, and the closest
    thing to it was `GetAllAvailableWindows()`, which didn't return
    the miss window - so I made it return the miss window and fixed the
    one consumer that didn't want it (bar hit error meter) to skip it.
  
  - Diff also contains some clean-up around `DifficultyRange` to unify
    handling of it.

  Bartłomiej Dach · 2025-06-25 08:40:12 +02:00
  8b542e5442
• Merge pull request #33679 from bdach/truncate-sr

  Floor star rating to 2 decimal places rather than rounding

  Dan Balasescu · 2025-06-24 19:04:56 +09:00
  6057c6c4d4
• Resolve warnings in tests
  Dan Balasescu · 2025-06-13 22:36:32 +09:00
  4f5c9f9713
• Rewrite UpdateManager to handle cancellations
  Dan Balasescu · 2025-06-13 20:34:31 +09:00
  addd10f4c6
• Fix code quality
  Bartłomiej Dach · 2025-06-13 10:06:44 +02:00
  dc38c190df
• Adjust implementation of star rating filtering in song select to new star rating flooring behaviour

  Required for things to not be broken after the previous change.

  Bartłomiej Dach · 2025-06-13 09:13:20 +02:00
  eda489b911
• Floor star rating to 2 decimal places rather than rounding

  Rounding semi-regularly confuses users who aim for star rating pass / FC
  medals and then feel they have been cheated out of a medal because they
  passed an "X-star beatmap", but the actual star rating of the beatmap is
  slightly under X.
  
  The latest instance of this can be found at
  https://osu.ppy.sh/community/forums/topics/2091333?n=2. The relevant
  beatmap there is https://osu.ppy.sh/beatmapsets/2162554#osu/4746232,
  whose raw star rating is 6.9976070253117344.
  
  The other direction would be to fix the star rating medals instead, but
  I think this is more reasonable given we already do similar things to
  accuracy displays.

  Bartłomiej Dach · 2025-06-13 09:11:06 +02:00
  4fd2a488b7
• Expand tests to perform a second check

  To ensure it doesn't get stuck in a state where new checks aren't
  performed.

  Dan Balasescu · 2025-06-11 16:47:05 +09:00
  359e3ac8a5
• Partial classes
  Dan Balasescu · 2025-06-11 16:43:32 +09:00
  981cf62c23
• Add tests
  Dan Balasescu · 2025-06-11 16:37:31 +09:00
  41d4d55f22
• Fix replays being misrecorded if an action is pressed and released in one update frame

  Closes https://github.com/ppy/osu/issues/33465 probably.
  
  This reverts the replay frame de-duplication logic to what it was before
  https://github.com/ppy/osu/pull/33148#discussion_r2091549388.
  
  I don't have good reproduction steps. I tried to write a test case for
  this that isn't just "press and release a key in the same frame",
  thinking that maybe there was some loophole in the osu! touch input
  mapper that may produce this situation artificially, but I could not in
  many configurations. So I have to assume that this just *can happen*
  organically.

  Bartłomiej Dach · 2025-06-06 09:10:51 +02:00
  12cc8e38da
• Split out methods so retrieving the room is not a callback function
  Dean Herbert · 2025-03-04 19:19:53 +09:00
  918315aa65
• Merge branch 'master' into remove-selectedroom
  Dan Balasescu · 2025-03-04 17:00:43 +09:00
  cf3664349d
• Fix broken test
  Dan Balasescu · 2025-03-04 14:14:42 +09:00
  b73a872b94
• Merge pull request #31637 from smoogipoo/room-management-lio

  Create, join, and part multiplayer rooms only via the multiplayer server

  Dean Herbert · 2025-03-04 13:13:55 +09:00
  58a671decb
• Add failing test
  Dan Balasescu · 2025-03-04 12:34:11 +09:00
  963df165df
• Remove SelectedRoom abstraction from OnlinePlayTestScene
  Dan Balasescu · 2025-02-12 22:55:19 +09:00
  205d6ecffb
• Merge branch 'master' into room-management-lio
  Dan Balasescu · 2025-02-11 21:19:32 +09:00
  38cd4fa56a
• Add fail cases to unstable rate incremental testing
  Dean Herbert · 2025-01-29 17:10:05 +09:00
  6c4b4166ac
• Adjust + fix tests
  Dan Balasescu · 2025-01-23 16:27:38 +09:00
  9a623257f5
• Add incremental processing
  Dean Herbert · 2024-11-25 21:13:17 +09:00
  5668258182
• Address unstable rate calculations as a list for marginal gains
  Dean Herbert · 2024-11-25 19:44:11 +09:00
  33d725e889