h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-19 10:40:33 +08:00
Code Issues Releases Wiki Activity

Adjust BPM filtering at song select to be less precise

Browse Source 
Closes https://github.com/ppy/osu/issues/34942.
This commit is contained in:
Dean Herbert
2025-09-09 15:02:57 +09:00
Unverified
parent 335bc6cdf6
commit f94d5004ea
2 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game.Tests/NonVisual/Filtering/FilterQueryParserTest.cs
+11 -2
View File
@@ -178,6 +178,16 @@ namespace osu.Game.Tests.NonVisual.Filtering
[Test]
public void TestApplyBPMQueries()
{
const string query = "bpm=200";
var filterCriteria = new FilterCriteria();
FilterQueryParser.ApplyQueries(filterCriteria, query);
Assert.AreEqual(filterCriteria.BPM.Min, 199.5d);
Assert.AreEqual(filterCriteria.BPM.Max, 200.5d);
}
[Test]
public void TestApplyBPMRangeQueries()
{
const string query = "bpm>:200 gotta go fast";
var filterCriteria = new FilterCriteria();
@@ -185,8 +195,7 @@ namespace osu.Game.Tests.NonVisual.Filtering
Assert.AreEqual("gotta go fast", filterCriteria.SearchText.Trim());
Assert.AreEqual(3, filterCriteria.SearchTerms.Length);
Assert.IsNotNull(filterCriteria.BPM.Min);
Assert.Greater(filterCriteria.BPM.Min, 199.99d);
Assert.Less(filterCriteria.BPM.Min, 200.00d);
Assert.AreEqual(filterCriteria.BPM.Min, 199.5d);
Assert.IsNull(filterCriteria.BPM.Max);
}
osu.Game/Screens/Select/FilterQueryParser.cs
+1 -1
View File
@@ -57,7 +57,7 @@ namespace osu.Game.Screens.Select
return TryUpdateCriteriaRange(ref criteria.OverallDifficulty, op, value);
case "bpm":
return TryUpdateCriteriaRange(ref criteria.BPM, op, value, 0.01d / 2);
return TryUpdateCriteriaRange(ref criteria.BPM, op, value, 0.5f);
case "length":
return tryUpdateLengthRange(criteria, op, value);