156 Commits

• Fix mania hold notes dimming unexpectedly (#37008)

  Fixes https://github.com/ppy/osu/issues/29223
  
  This fixes several issues around hold note dimming.
  
  Notice in the following video:
  - The tail piece of the first note not getting dimmed.
  - The body of the second note not responding to dimming at all.
  
  
  https://github.com/user-attachments/assets/8e51053d-8d88-4e48-909b-79218d65917b
  
  Then, notice in the following video:
  - The body piece of the second note is dimmed from the very beginning.
  
  
  https://github.com/user-attachments/assets/a514c630-5c72-4ba5-96d5-472bae1058b3
  
  This requires a specific setup whereby the hold note and its components
  must be reused from the pool. In particular:
  1. The hold note must be long. So long that by the time the tail becomes
  on screen, the body will already have dimmed.
  2. The hold note must be re-used from the pool. We can induce this by
  setting the pool sizes to 1 in
  [`Column.cs`](https://github.com/ppy/osu/blob/780ce2666099c22d1e0673cafab544418b5d14b0/osu.Game.Rulesets.Mania/UI/Column.cs#L121-L123).
  3. The second hold note should be placed far enough in the timeline that
  the first hold note dies by the time it becomes visible.
    4. Scroll speed should be adjusted to fit the above constraints.
  
  I haven't done a full deep dive into exactly _why_ this is happening, so
  the fix here is hand-wavy. That said, just by looking at the old code in
  `LegacyBodyPiece` you'll get a feeling that something's bound to go
  wrong;
  - It never resets the `missingFadeTime` state.
  - It never resets the colours back to `Color4.White`.
  - It applies transforms onto external components.
  - It jumps through hoops to figure out how to set `missingFadeTime`.
  
  My hope is that these changes first bring some sanity in the process,
  and if it breaks again I'll consider doing a more proper root cause
  (I've had this issue in the back of my mind for about 1 year).
  
  With this PR, they now behave as expected:
  
  
  https://github.com/user-attachments/assets/140b37c5-cf84-44ba-b797-86ac6d8130c8
  
  
  https://github.com/user-attachments/assets/6f2342a4-6a9a-4941-a55a-24a357f27c25

  Dan Balasescu · 2026-03-23 08:33:23 +01:00
  d4a4acd3f4
• Only play hold note sliding samples when beatmap is converted
  Salman Alshamrani · 2025-08-04 12:27:55 +03:00
  4171c3a241
• Fix drawable hold notes continuing to show hit lighting with No Release mod and classic skin

  Closes https://github.com/ppy/osu/issues/33751.

  Bartłomiej Dach · 2025-06-18 17:59:54 +02:00
  176a85763c
• Fix incorrect translation of note freezing logic
  Bartłomiej Dach · 2025-05-20 08:58:11 +02:00
  bd703b60f9
• Fix hold notes being missed after rewinding gameplay

  Closes https://github.com/ppy/osu/issues/27589.
  
  Follows osu! spinner precedent in storing the holding state to the
  judgement result rather than attempting to keep it in the DHO (which is
  prone to getting dropped on pool re-use).

  Bartłomiej Dach · 2025-05-19 12:23:47 +02:00
  59490054db
• Fix hold note light lingering with No Release

  Turns out endHold() is not called in the Tail.IsHit branch of the
  hold notes' CheckForResult method.

  Nathan Du · 2024-07-18 16:08:30 +08:00
  00ed7a7a2f
• Refactor result application around again to remove requirement for fields

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2024-02-05 13:21:01 +01:00
  efe6bb25b1
• update DrawableHitCircle.ApplyResult to pass this to its callback
  Chandler Stowell · 2024-01-25 11:25:41 -05:00
  93bd3ce5ae
• use stack to pass action state when applying hit results

  this removes closure allocations

  Chandler Stowell · 2024-01-24 13:13:45 -05:00
  d2775680e6
• Enforce minimum gameplay sample volume of 5%
  Bartłomiej Dach · 2023-10-20 15:50:13 +02:00
  b321d556b6
• Apply some xmldoc and structural changes
  Dean Herbert · 2023-10-10 16:59:25 +09:00
  8dc9453d8d
• Add mania hold note body + combo break judgement
  Dan Balasescu · 2023-10-09 09:47:00 +09:00
  9415fe4446
• Remove mania hold note ticks
  Dan Balasescu · 2023-08-31 17:30:27 +09:00
  c60f13dd92
• Use IsRewinding in a few more places
  Bartłomiej Dach · 2023-07-08 13:32:24 +02:00
  9dae806734
• Replace various local implementations of rewinding checks with new property
  Dean Herbert · 2023-07-07 15:21:24 +09:00
  e0fc97bb93
• Fix fix logic causing further regression on release
  Dean Herbert · 2023-06-17 01:37:09 +09:00
  3b1f92d8b8
• Fix osu!mania hold notes sometimes looking incorrect after rewind
  Dean Herbert · 2023-06-16 14:54:19 +09:00
  b5de109cb3
• Fix osu!mania hold notes snapping to judgement area too early on early hits

  Closes https://github.com/ppy/osu/issues/23515.

  Dean Herbert · 2023-06-01 16:06:35 +09:00
  98f35f7481
• Remove no-longer-correct remark
  Bartłomiej Dach · 2023-05-08 22:35:41 +02:00
  1ff1730948
• Merge branch 'master' into fix-mania-head-note-animation
  Bartłomiej Dach · 2023-05-08 22:23:01 +02:00
  3f45948664
• Remove clamping of sizingContainer in DrawableHoldNote to fix head note alignment
  Dean Herbert · 2023-05-08 18:14:07 +09:00
  27c10cbdb7
• Add back early return in OnReleased for safety
  Dean Herbert · 2023-05-08 15:43:11 +09:00
  814f0b3fed
• Move logic to Update instead
  Dean Herbert · 2023-05-03 15:18:37 +09:00
  6a59ded1ba
• Merge branch 'master' into mania-fix-hold-note-rewind
  Dean Herbert · 2023-05-03 15:04:59 +09:00
  4013cdcfa8
• remove all non-test usage of SampleControlPoint
  OliBomby · 2023-04-26 13:55:39 +02:00
  d97daee96b
• Fix osu!mania hold note animations not correctly re-applying after rewind

  There's early exit logic in `OnPressed`/`OnReleased` for the sake of
  keeping order correct, but this doesn't account for the fact that
  `DrawableHitObject` resets all animations when the hit state changes.
  
  A bit of an ugly workaround, but seems to work as expected.

  Dean Herbert · 2023-03-14 18:15:19 +09:00
  5aebbac6c5
• Add note about why bodyPiece sizing is done as it is

  I think we're going to have to change this as it's quite limiting in
  what you can do with osu!mania skin implementation, but for now I want
  to leave a note as to why this is done, because each time I have to
  trial and error check what breaks when adjusting it.

  Dean Herbert · 2023-03-09 20:26:49 +09:00
  ed3ff62e4f
• Merge branch 'master' into maximum-judgement-offset-in-hit-object
  Dean Herbert · 2023-02-15 14:48:15 +09:00
  da8ab7143b
• Refactor SkinnableSound.Samples to be non-nullable
  Dean Herbert · 2023-01-27 19:32:30 +09:00
  74ab036f3e
• Move MaximumJudgementOffset to HitObject

  We want to access this property for computing lifetime

  ekrctb · 2023-01-19 21:23:55 +09:00
  11e1b22bf5
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix osu!mania hold notes occasionally getting in a visually incorrect hit state

  To correctly end a mania hold note, `endHold()` needs to be called. This
  was not happening in a very specific scenario:
  
  - The hold note's head is not hit
  - The user pressed the column's key within the hold note's tail's window,
    but does so to hit the next object (a note in proximity to the hold note's tail).
  - The hit policy forces a miss on the hold note, but `endHold()` is not called
  - `CheckForResult` is not called after this point due to `Judged` being `true`.
  
  Closes #21311.

  Dean Herbert · 2022-11-22 16:15:34 +09:00
  57723107dd
• Add "Component" prefix to lookup naming
  Dean Herbert · 2022-11-09 17:46:43 +09:00
  1aa0e40f2f
• Rename ISkinComponent to ISkinLookup
  Dean Herbert · 2022-11-09 17:46:43 +09:00
  c908969d9b
• Fix hold note disappear instantly
  ekrctb · 2022-10-25 19:16:23 +09:00
  92ab39f5c2
• Implement hold "sliding" samples in osu!mania
  Dean Herbert · 2022-10-11 16:31:37 +09:00
  f060e6a780
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Update with keybinding changes
  smoogipoo · 2021-09-16 18:26:12 +09:00
  f9d5abff8a
• Fix hold notes handling all input ever
  Dean Herbert · 2021-08-24 19:08:04 +09:00
  6252b8aa42
• Fix DrawableHoldNote retaining hit states through applications
  smoogipoo · 2021-05-12 17:07:42 +09:00
  f992b59b4f
• Initial implementation of DHO pooling
  smoogipoo · 2021-05-12 16:35:05 +09:00
  5692cecaa4
• Fix hold note crashing with 0 length
  smoogipoo · 2021-04-22 19:51:33 +09:00
  4148d473e3
• Miss all ticks when hold note is hit
  smoogipoo · 2021-03-31 12:21:14 +09:00
  43e48406ca
• Adjust namespace
  ekrctb · 2020-12-07 12:32:52 +09:00
  e3c035fe9c
• Store time of hold note break
  Bartłomiej Dach · 2020-11-13 21:14:34 +01:00
  b62bf5798d
• Disable pressed/released action logic when rewinding
  Bartłomiej Dach · 2020-11-13 20:49:06 +01:00
  7a89e58483
• Update existing implementations
  Dean Herbert · 2020-11-04 17:14:23 +09:00
  a3dc1d5730
• Replace comparison references to HitResult.Miss with IsHit
  Bartłomiej Dach · 2020-10-02 23:31:24 +02:00
  2b1ef16f89
• Use new hit results in mania
  smoogipoo · 2020-09-29 16:33:38 +09:00
  b1877b649b
• Merge branch 'master' into mania-notelock
  smoogipoo · 2020-08-31 13:31:41 +09:00
  aa151e4cd7