278 Commits

Author	SHA1	Message	Date
Dean Herbert	04dbb5d3c6	Disallow setting "NoScores" externally as it is handled internally	2022-01-30 16:18:19 +09:00
Dean Herbert	acc1199add	Consolidate flows of Set operations, either result or error	2022-01-30 16:16:00 +09:00
Dean Herbert	c401629dd8	Also refactor placeholder logic to make more sense	2022-01-30 10:50:32 +09:00
Dean Herbert	b434e29a7c	Move loading hide operation inside early return to ensure not hidden too early ... It should only be hidden after the async load completes.	2022-01-30 03:10:15 +09:00
Dean Herbert	dad9cc9315	Ensure Reset/Scores_Set run inline where possible	2022-01-30 03:06:29 +09:00
Dean Herbert	9b573fbc2b	Add missing entries to switch statement and guard against out of range	2022-01-30 02:58:53 +09:00
Dean Herbert	d21464ea61	Fix assertions to work in both directions	2022-01-30 02:54:51 +09:00
Dean Herbert	d3cb910cf8	Convert inline math to not so inline to make operation more explicit	2022-01-30 02:37:01 +09:00
Dean Herbert	3d771c0fc7	Remove unnecessary loading hide call from PlaceholderState_Set and add more assertiveness	2022-01-30 02:34:31 +09:00
Dean Herbert	6f54f8ad78	Add more safety around CancellationToken usage	2022-01-29 23:58:57 +09:00
Dean Herbert	d0b74a91fb	Fix edge cases with score drawable loading	2022-01-29 23:58:57 +09:00
Dean Herbert	0293d95f82	Simplify IsOnlineScope usage	2022-01-29 23:58:57 +09:00
Dean Herbert	daea13f491	Simplify flow of cancellation token	2022-01-29 23:58:57 +09:00
Dean Herbert	3d59bab7c6	Remove fetch callback logic completely	2022-01-29 23:58:57 +09:00
Dean Herbert	13f445ddd5	Move score update code into own method	2022-01-29 23:58:57 +09:00
Dean Herbert	c48e9f2bbd	Remove more unnecessary schedule/cancel logic	2022-01-29 23:58:57 +09:00
Dean Herbert	a700ad3849	Remove scoresLoadedOnce weirdness	2022-01-29 23:58:57 +09:00
Dean Herbert	661fec7c8a	Make score setter private	2022-01-29 23:58:57 +09:00
Dean Herbert	b85b2c01fb	Reorder based on accessibility and add regions	2022-01-29 23:58:57 +09:00
Dean Herbert	c548658662	Remove move unused pieces	2022-01-29 23:58:57 +09:00
Dean Herbert	17aa9f3040	Remove pointless level of schedule/cancel logic	2022-01-29 23:58:57 +09:00
Dean Herbert	64925b3fea	Remove unused Content override	2022-01-29 23:58:57 +09:00
Dean Herbert	b9dac6c3b2	Reorder and tidy up bindable flows	2022-01-29 23:58:57 +09:00
Dean Herbert	aee93934d5	Rename methods to make more sense (and always run through AddOnce)	2022-01-29 23:58:57 +09:00
Dean Herbert	c6d303a5b4	Add xmldoc to Leaderboard class	2022-01-29 23:58:57 +09:00
Dan Balasescu	73a1f27ce5	Merge branch 'master' into realm-integration/score-and-beatmaps	2022-01-18 17:31:37 +09:00
Dean Herbert	d26f4d50bd	Add test coverage of aggregate room scores displaying correctly	2022-01-18 14:00:12 +09:00
Dean Herbert	f4a1fa85a1	Fix incorrect conditional for deciding whether scores can be deleted from UI	2022-01-12 17:49:10 +09:00
Dean Herbert	53792811b2	more fixes (almost compiles, except ruleset and manager)	2022-01-12 16:57:27 +09:00
Dean Herbert	bf1418bafc	Use OnlineID instead of legacy IDs for equality and lookups	2021-12-10 16:11:48 +09:00
Dean Herbert	1eed2436e6	Clean up unused resolved properties	2021-12-03 18:49:49 +09:00
Dean Herbert	e2ebcf7a26	Remove unnecessary manager parameter ... Confused why I added this in the first place..	2021-11-25 18:36:03 +09:00
Dean Herbert	cc1b91e4bd	Split out legacy model export logic into LegacyModelExporter classes	2021-11-25 16:41:12 +09:00
Dean Herbert	99a139dc98	Initialise all file lists at construction time (and remove setter)	2021-11-24 13:56:21 +09:00
Dean Herbert	6944151486	Apply batch fixing of built-in types using var	2021-10-27 13:04:41 +09:00
Dean Herbert	3803f2f462	Fix leaderboard potentially displaying the wrong scores ... Closes #14762. This class is ugly. I think the whole process should be clened up once we have correctly-scheduled `SynchronizationContext`s. There's not much saving it as long as all these interdispersed `Schedule`s around required.	2021-10-06 16:07:29 +09:00
Dean Herbert	92f59c10f5	Remove redundant this. in assignment	2021-09-07 17:45:39 +09:00
Dean Herbert	d922210d2f	Fix TestSceneDeleteLocalScore not properly comparing post-delete scores	2021-09-07 16:46:27 +09:00
smoogipoo	999386da29	Cleanup	2021-08-31 21:47:49 +09:00
smoogipoo	bfcadcc4ac	Revert some changes	2021-08-31 19:18:01 +09:00
smoogipoo	4ebb11472d	Update Leaderboard to reorder scores based on scoring mode	2021-08-30 19:34:34 +09:00
Lucas A	ff3d38de6f	Localise accuracy display.	2021-07-23 22:37:08 +02:00
PercyDan54	e1c646b9b2	Remove redundant arguments	2021-07-05 23:52:39 +08:00
Bartłomiej Dach	50c27d2635	Update usages of IHasTooltip in line with framework localisation changes	2021-06-25 19:10:04 +02:00
Dean Herbert	fc442713bb	Debounce schedule at base class	2021-06-14 14:26:40 +09:00
Dean Herbert	8dd48d48f6	Add support for song select leaderboard to handle newly imported scores	2021-06-14 14:20:23 +09:00
PercyDan54	d4724f4494	Fix crash	2021-04-04 09:44:45 +08:00
smoogipoo	e1aa927827	Add dropdown option to export score	2021-04-02 13:20:15 +09:00
Bartłomiej Dach	0b42b4b955	Rename {Drawable -> Clickable}Avatar	2020-12-26 14:35:11 +01:00
Bartłomiej Dach	d392e0f27e	Extract shared rank-formatting helper	2020-12-19 15:04:22 +01:00
Bartłomiej Dach	610ed99ae3	Add null checks to unguarded resolved-as-null fields	2020-11-14 14:52:58 +01:00
Dean Herbert	9753dab93b	Remove IOnlineComponent and change existing components to use bindable flow	2020-10-22 14:19:12 +09:00
Dean Herbert	d6efa3069a	Merge branch 'master' into fix-login-placeholder-inheritance	2020-10-19 16:25:44 +09:00
Dean Herbert	ef44c7d063	Merge branch 'master' into score-recalc	2020-09-10 18:30:41 +09:00
smoogipoo	bbef7ff720	Fix leaderboard loading spinner disappearing too early	2020-09-09 20:19:07 +09:00
smoogipoo	37a659b2af	Refactor/add xmldocs	2020-09-09 17:36:47 +09:00
smoogipoo	117c7ec6b2	Merge branch 'master' into score-recalc	2020-09-09 14:38:36 +09:00
smoogipoo	bff652a26f	Persist nulls to the top score bindable	2020-09-02 14:29:46 +09:00
smoogipoo	d22de26afb	Add whitespace	2020-08-31 20:08:36 +09:00
smoogipoo	ed74c39b55	Move UserTopScoreContainer into base leaderboard	2020-08-31 19:54:22 +09:00
smoogipoo	d7bbb362bf	Separate bindables	2020-08-28 22:51:19 +09:00
smoogipoo	1e5e5cae0c	Add support for standardised -> classic changes	2020-08-28 21:34:34 +09:00
smoogipoo	4d15f0fe52	Implement basic score recalculation	2020-08-28 19:16:46 +09:00
Joseph Madamba	4d6b52a0d6	Simply condition ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2020-08-17 23:08:51 -07:00
Joehu	e0383f6100	Change format of rank tooltip	2020-08-17 22:07:04 -07:00
Joehu	848f3bbf51	Show tooltip of leaderboard score rank when 1000 or higher	2020-08-17 21:09:55 -07:00
Joehu	db6a9c9717	Move null check to menu item addition	2020-07-12 22:06:17 -07:00
Joehu	ac7252e152	Fix context menu not masking outside of leaderboard area	2020-07-12 22:04:00 -07:00
Joehu	9c039848bc	Simplify and add null check	2020-07-12 12:04:53 -07:00
Joehu	25d2d9ba5c	Convert getMods reference to method group	2020-07-11 16:24:57 -07:00
Joehu	0d26ad9ddb	Fix user top score not having a context menu	2020-07-11 16:22:01 -07:00
Joehu	9b4bed2ab2	Add ability to select mods from a specific score	2020-07-11 16:02:47 -07:00
Lucas A	e136ecec5f	Create ClickablePlaceholder and make of use it where applicable.	2020-04-23 14:01:47 +02:00
smoogipoo	ed3e0a01e1	Re-namespace into song select	2020-04-07 15:31:22 +09:00
smoogipoo	ed17a1c990	Improve visual display	2020-04-07 15:30:06 +09:00
smoogipoo	933314d724	Remove unnecessary method	2020-04-07 14:50:11 +09:00
smoogipoo	c46ea7bdef	Add disposal, prevent memory leaks	2020-04-07 14:49:24 +09:00
Santeri Nogelainen	da59baa779	Add line break	2020-04-04 22:42:13 +03:00
Santeri Nogelainen	1e8badb14a	Move all logic to TopLocalRank and remove CarouselBeatmapRank	2020-04-04 22:28:36 +03:00
Santeri Nogelainen	faa2b49be4	Fix namespace for CarouselBeatmapRank, make UpdateableRank in TopLocalRank readonly	2020-03-28 18:13:39 +02:00
Santeri Nogelainen	1c711147f3	Move all carousel rank logic into separate classes (TopLocalRank and CarouselBeatmapRank)	2020-03-28 17:22:01 +02:00
smoogipoo	e586249db7	Expose GetRankName from DrawableRank	2020-03-17 16:25:51 +09:00
smoogipoo	d77b0acd90	Move rank colour to OsuColour	2020-03-17 16:25:41 +09:00
Dean Herbert	ed837d3115	Use framework extension method for FromHex	2020-03-11 10:18:41 +09:00
Dean Herbert	4294ed4b64	Better align fonts to weights	2020-03-04 11:45:19 +09:00
Dean Herbert	92f6f0207c	Rename LoadingAnimation to LoadingSpinner	2020-02-21 15:33:31 +09:00
smoogipoo	1a689231c2	Support null leaderboard position	2020-02-20 14:51:25 +09:00
recapitalverb	c753cb46c5	Use [Resolved] wherever possible	2020-02-14 20:14:00 +07:00
Dean Herbert	76cfe1f42c	Merge branch 'master' into online-container	2020-02-14 15:18:27 +09:00
smoogipoo	bc1c4f6b58	Add missing null-allowance	2020-02-13 19:04:23 +09:00
recapitalverb	9898a926b2	Use ScoreInfo.DisplayAccuracy everywhere	2020-02-03 22:11:36 +07:00
smoogipoo	76af8bea5d	Fix percentage-formatted displays containing a space	2020-01-29 19:51:24 +09:00
smoogipoo	bfb056c612	Apply input method signature refactorings	2020-01-20 18:17:21 +09:00
Lucas A	e9a5298484	Allow setting the displayed text on LoginPlaceholder	2020-01-12 15:50:35 +01:00
Dean Herbert	ab9603b06a	Merge remote-tracking branch 'upstream/master' into #7146	2020-01-09 17:08:12 +08:00
Dean Herbert	6dd45e52ef	Move text definition inside class	2020-01-08 17:22:51 +09:00
Lucas A	7f92cefe10	Apply review suggestions	2020-01-07 19:06:47 +01:00
smoogipoo	4a7f5f98df	Cleanup methods/events	2020-01-06 17:20:09 +09:00
Lucas A	5fd5665467	Use implementation on song select leaderboards.	2020-01-04 19:59:25 +01:00
Lucas A	3bd3ebad49	Move placeholders to a dedicated namespace	2020-01-04 19:56:34 +01:00
Willy Tu	e23c71be80	Update Resolved and Cached attribute issues	2020-01-03 11:34:26 -08:00
Willy Tu	6abbd33b51	Fixed CI issues	2019-12-19 21:57:14 -08:00
Willy Tu	8ab26e8889	Update Tests with dependencies on LeaderboardScore. Added its dependency on DialogOverlay for the tests. Added test for deleting individual local score	2019-12-19 21:29:54 -08:00
Willy Tu	d4d4ddc624	Remove new line for CodeFactor	2019-12-18 22:42:26 -08:00
Willy Tu	643911ada9	Fix code format for CI	2019-12-18 22:41:07 -08:00
Willy Tu	ed07b779b1	Update to use score.ID identify local scores	2019-12-18 21:54:02 -08:00
Willy Tu	27163a5133	Removed unnecessary code for deleting individual local score.	2019-12-18 21:04:10 -08:00
Willy Tu	531ac16743	Update Scoreboard Refresh Method for deleting individual scores	2019-12-18 19:22:42 -08:00
wltu	8aeef3f59a	Added refresh scoreboard upon deleting local score and formatted the code	2019-12-17 12:56:30 -08:00
wltu	bb2b1475cd	Merge branch 'master' of https://github.com/ppy/osu into #7146	2019-12-17 12:54:47 -08:00
Huo Yaoyuan	40b43b85f1	CA1715: use prefix for generic parameters.	2019-12-17 13:00:25 +08:00
Willy Tu	bef9637fdf	Implemented delete local score individually. Currently does not refresh the score screen after the delete is compelete.	2019-12-16 19:25:28 -08:00
Willy Tu	ad077042ba	Created ContextMenu for scores by adding OsuContextMenuContainer as a child of LeaderboardScore and a Drawable that extended the IHasContextMenu interface to the MenuContainer. Tried to the LeaderboardScore extend IHASContextMenu itself, but it is not working yet.	2019-12-15 02:18:12 -08:00
Huo Yaoyuan	374ef6ff83	Merge branch 'master' into sharpen	2019-11-20 17:30:58 +08:00
Huo Yaoyuan	87d40cf8d0	Resolve equals usages.	2019-11-13 22:35:50 +08:00
Huo Yaoyuan	bbeab6fa76	Use auto property.	2019-11-12 19:53:25 +08:00
Huo Yaoyuan	ccc8aa6fa4	Apply brace style.	2019-11-11 20:13:13 +08:00
Dean Herbert	1a7b803d4d	Change colour to green to match web implementation	2019-11-04 08:39:51 +09:00
Ganendra Afrasya	ce3b34a768	Fix UserTopScoreContainer is also tinted	2019-11-01 23:00:55 +07:00
Ganendra Afrasya	d9a91100fb	Add tint to user's score container background	2019-11-01 22:47:23 +07:00
Dean Herbert	e2f7d4bc62	Remove unnecessary ToMetric avoidance	2019-09-19 15:45:43 +09:00
Dean Herbert	098e89cb66	Improve state reset flow	2019-09-19 15:23:33 +09:00
Dean Herbert	4967ffd8e5	Move inside leaderboard	2019-09-19 14:52:31 +09:00
Dean Herbert	2e0a85c2f6	Merge remote-tracking branch 'upstream/master' into songselect-best-user-score	2019-09-19 12:57:30 +09:00
Joehu	77ac186cf8	Add spacing to mod icons on leaderboards	2019-09-11 16:08:01 -07:00
iiSaLMaN	a1c580f27e	Create "none selected" placeholder state	2019-09-05 05:56:21 +03:00
Dean Herbert	7b7e4f924d	Merge branch 'master' into songselect-best-user-score	2019-07-26 13:06:14 +09:00
Dean Herbert	8c54708582	Merge branch 'master' into songselect-best-user-score	2019-07-22 22:34:11 +09:00
iiSaLMaN	ed0ef90613	Separate glowing sprite text into it's own class	2019-07-21 12:14:55 +03:00
Dean Herbert	e76b3e2b40	User property instead of method	2019-07-21 10:42:40 +09:00
iiSaLMaN	842417cf42	Check if selected scope requires API	2019-07-21 03:07:27 +03:00
Dean Herbert	66036508b6	Fix potential crash when displaying leaderbaords	2019-07-17 17:39:04 +09:00
Andrei Zavatski	922c3c89ae	Make leaderboard score use metric system	2019-07-14 12:47:35 +03:00
Joehu	b9be4080d3	Update beatmap leaderboard to placeholder when signing out	2019-07-09 07:59:38 -07:00
Joehu	5f6544eebf	Fix beatmap leaderboards requiring supporter when signed out	2019-07-04 12:05:07 -07:00
Dean Herbert	1189092e20	Remove redundant scale specification	2019-07-03 12:49:16 +09:00
iiSaLMaN	c5b3572c28	Add missing details	2019-06-30 08:05:45 +03:00
iiSaLMaN	9498fc2426	Use proper colours for rank background and text	2019-06-30 05:47:52 +03:00
iiSaLMaN	20ad486d53	Scale adjustments	2019-06-30 04:59:33 +03:00
iiSaLMaN	372d90de6a	Remove unnecessary assigns	2019-06-30 04:25:47 +03:00
iiSaLMaN	8c5397709b	Use drawables instead of textures	2019-06-30 04:20:42 +03:00
KingLuigi4932	97dd34e26c	Seperate updateable from drawable	2019-06-19 03:50:16 +03:00
KingLuigi4932	d6a39b8a2a	Fix CI issues + slight change	2019-06-17 22:33:27 +03:00
KingLuigi4932	fec0db8fe1	Merge UpdateableAvatar.cs and Avatar.cs + Rename Avatar to DrawableAvatar	2019-06-17 21:55:07 +03:00
KingLuigi4932	d665f1fe4b	Seperate drawable and updateable flag from Country + Use UpdateableFlag	2019-06-17 20:57:57 +03:00
KingLuigi4932	794ba17a2f	Seperate UpdateableRank from DrawableRank and use it	2019-06-17 20:04:09 +03:00
iiSaLMaN	0c299d651f	Merge branch 'master' into use-modelbackeddrawable	2019-06-17 17:06:10 +03:00
iiSaLMaN	3087099b32	Use ModelBackedDrawable in DrawableRank	2019-06-17 07:34:35 +03:00
Dean Herbert	bc574520bf	Update ScrollContainer usages in line with framework changes	2019-06-14 15:55:32 +09:00
smoogipoo	99f2ee0e48	Fix CI issues	2019-05-07 15:09:03 +09:00