osu-lazer

Mark some more recent flaky tests

Dean Herbert · 2025-06-03 16:23:31 +09:00

ef29eda3e0

Add extra test coverage for multiplayer participants list in team versus

Bartłomiej Dach · 2025-05-23 10:47:50 +02:00

fea50ee432

Fix tests post-pooling implementation

Bartłomiej Dach · 2025-05-23 10:47:23 +02:00

231afbf463

Implement pooling in multiplayer participants list

Bartłomiej Dach · 2025-05-23 10:47:07 +02:00

61e8c25a92

Modify many users tests to stress it & demonstrate transform overhead

Bartłomiej Dach · 2025-05-23 10:46:50 +02:00

40a4129776

Fix multiplayer position display looking wrong when player count is low

Spotted when watching video in #33173's opening post.

Dean Herbert · 2025-05-19 16:58:01 +09:00

beb77176b6

Add bar display

Dean Herbert · 2025-05-13 16:30:38 +09:00

91b9b41d58

Fix test not showing immediately useful state

Also standardises the testing leaderboard provider component for
(immediate) future use.

Dean Herbert · 2025-05-13 15:53:47 +09:00

1d7f922068

Merge branch 'master' into multiplayer-position-indicator

Bartłomiej Dach · 2025-05-09 10:02:18 +02:00

4d4f469fac

Fix gameplay leaderboard not always being expanded in gameplay leaderboard

I'd have preferred a `get; init;` property but tests were also attached
at the hip to the public bindable. Without some extra composition this
is the best that I can do.

Bartłomiej Dach · 2025-05-07 12:09:26 +02:00

8cc2af4060

Implement local user position display for multiplayer

Bartłomiej Dach · 2025-04-28 13:40:00 +02:00

52fbd9e796

Merge branch 'master' into gameplay-leaderboard-skinnable

Bartłomiej Dach · 2025-04-28 13:11:22 +02:00

4ad86685e0

Fix one more test failure

Bartłomiej Dach · 2025-04-25 08:14:12 +02:00

ae8fb2ce08

Update 404ing cover image URLs

Dean Herbert · 2025-04-24 21:27:30 +09:00

c149a6efd6

Add failing test

Dan Balasescu · 2025-04-23 16:04:38 +09:00

eafb52ffb4

Add failing test

Bartłomiej Dach · 2025-04-22 11:23:04 +02:00

57e693e0c7

Merge branch 'master' into leaderboards/gameplay-provider

Bartłomiej Dach · 2025-04-21 09:03:24 +02:00

6b0567e882

Attempt to fix tests

Bartłomiej Dach · 2025-04-17 14:26:34 +02:00

d546bbaf8f

Fix incorrect assertion message

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

Dan Balasescu · 2025-04-17 20:05:34 +09:00

47d943afd7

Add failing test

Dan Balasescu · 2025-04-17 03:30:55 +09:00

1a68edfa58

Separate gameplay leaderboard data management from display

This is a prerequisite for supporting skinning of leaderboards.

- New `IGameplayLeaderboardProvider` and `IGameplayLeaderboardScore`
  interfaces are introduced. They are strictly concerned with supplying
  leaderboard data.

- Logic of managing display, which was previously jammed into the
  inheritance hierarchy of `GameplayLeaderboard`, is now moved into
  `IGameplayLeaderboardProvider` implementations. Solo play,
  multiplayer, and multiplayer spectator get their own implementation of
  the interface.

- The inheritance hierarchy of `GameplayLeaderboard` and per-player
  overriding of the implementation of the gameplay leaderboard is gone.
  Only one drawable class (renamed to `DrawableGameplayLeaderboard`) is
  allowed to display the leaderboards, across all modes of play.

Bartłomiej Dach · 2025-04-16 14:46:55 +02:00

c231571f06

Add display to show completed playlist items

Dan Balasescu · 2025-04-10 18:07:10 +09:00

34180c62eb

Add failing countdown start test

Dan Balasescu · 2025-04-08 18:35:22 +09:00

968fe6e618

Rewrite match subscreen to use full online state

Dan Balasescu · 2025-04-04 10:48:55 +09:00

286b3d9f5b

Add failing test

Dan Balasescu · 2025-04-02 19:58:31 +09:00

56169d7ac4

Re-enable ignored playlist test

Dan Balasescu · 2025-03-28 22:01:23 +09:00

1a0432ce3a

Refactor MultiplayerPlaylist to not have a selected item bindable

Dan Balasescu · 2025-03-28 22:01:07 +09:00

b93e21c666

Add test for changing item in list

Brought forward from https://github.com/ppy/osu/pull/32250.

Dan Balasescu · 2025-03-28 21:49:36 +09:00

133a1bc1fa

Merge pull request #32596 from bdach/fix-bogus-daily-challenge-lookup

Fix daily challenge not querying beatmap properly

Dan Balasescu · 2025-03-27 21:25:47 +09:00

b414ed0e42

Fix tests

Bartłomiej Dach · 2025-03-27 12:39:19 +01:00

2ba621550c

Merge branch 'master' into refactor-room-panels

Dan Balasescu · 2025-03-27 19:46:07 +09:00

914c425fa7

Merge pull request #32604 from bdach/fix-multiplayer-join-logging

Fix several issues with multiplayer & playlists room join error logging

Dan Balasescu · 2025-03-27 18:30:52 +09:00

c69e0cbb73

Merge pull request #32573 from smoogipoo/refactor-mp-user-mod-display

Add multiplayer-specific implementation for user mod display

Bartłomiej Dach · 2025-03-27 10:08:30 +01:00

eeed29ce03

Fix test

Dan Balasescu · 2025-03-27 17:49:21 +09:00

2cfb06bcde

Fix several issues with multiplayer & playlists room join error logging

This is in response to
https://osu.ppy.sh/community/forums/topics/2058708?n=5, wherein the user
is having a problem with joining multiplayer, but I have basically no
diagnosing capabilities, because the logs are all

2025-03-26 18:57:57 [error]: Failed to join multiplayer room:
2025-03-26 18:58:40 [error]: Failed to join multiplayer room:
2025-03-26 18:58:41 [error]: Failed to join multiplayer room:
2025-03-26 18:58:41 [error]: Failed to join multiplayer room:

which appears to originate from

https://github.com/ppy/osu/blob/c82eaafe98d96b9f49a4a7f168ef5c484e67d76f/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerLoungeSubScreen.cs#L91

Now, as far as I can tell, there are two possibilities here:

1. The exception's `Message` is null or empty. That's not exactly great
or typical, but sure, this could possibly happen - in which case the
error logging is silently eating whatever little relevant detail
there is left to use.

2. The exception is *actually* `null` itself, and we're in the X Files.

This PR is intending to defend against (1).

In examining the logging further, I also spotted the following issues:

- In the single path that specifies a custom failure handler (which is
`DrawableLoungeRoom` which handles joining a passworded room), the
custom failure handler being present means that the error would be
presented to the user, but it would not be logged. At all.

- In playlists, if the exception for whatever reason had an empty
message, an empty notification would get posted. And in general to me
it feels a bit dodgy to be directly presenting exception notifications
to users without any preamble, hence the added "Failed to open
playlist" prefix.

Bartłomiej Dach · 2025-03-27 08:52:33 +01:00

1c4ecba950

Merge branch 'master' into refactor-room-panels

Bartłomiej Dach · 2025-03-26 11:58:20 +01:00

43d652bc3e

Add tests

Dan Balasescu · 2025-03-25 16:25:02 +09:00

3ff05b7330

Adjust tests to add tracker to hierarchy

Dan Balasescu · 2025-03-25 15:41:03 +09:00

bc2b7aae1c

Split tracker into per-system implementations

Dan Balasescu · 2025-03-25 14:56:12 +09:00

53ece9396a

Refactor tracker to be a bit more stateless

Removes storage of `selectedBeatmap` that was referenced through
multiple class-level methods.

To expound a bit, this structure felt better (or otherwise passing
`APIBeatmap` through methods) alongside removal of the `#nullable
disable`, otherwise each method would check `selectedBeatmap != null`.

Dan Balasescu · 2025-03-25 14:23:05 +09:00

72b56146ee