59241 Commits

This Branch

This Branch

All Branches

• Revert isDraggingBlueprint to field
  Dean Herbert · 2023-03-08 19:24:03 +09:00
  4f7be332f3
• Refactor endClickSelection to reduce nesting
  Dean Herbert · 2023-03-08 19:23:32 +09:00
  245c3c025c
• Add test coverage of cyclic selection in skin editor
  Dean Herbert · 2023-03-07 15:11:47 +09:00
  d2fcdf6e0e
• Add optional support for cyclic selection to BlueprintContainer
  Dean Herbert · 2023-03-07 14:22:12 +09:00
  21bdbb20e6
• Merge pull request #22775 from peppy/dont-filter-results-on-sort-mode

  Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes

  Bartłomiej Dach · 2023-03-06 18:47:41 +01:00
  ff59a236ae
• Merge branch 'master' into dont-filter-results-on-sort-mode
  Bartłomiej Dach · 2023-03-06 17:57:47 +01:00
  ec15e2b9cc
• Use nullable comparison helper method instead of manual implementation
  Dean Herbert · 2023-03-06 15:16:32 +09:00
  87d0bef313
• Merge pull request #22790 from Joehuu/fix-android-external-links

  Fix external links not working on Android

  Dean Herbert · 2023-03-05 22:12:57 +09:00
  2023.305.0 778cde8932
• Merge pull request #22787 from bdach/skin-editor-screen-transitions

  Fix several issues with skin editor behaviour on screen transitions

  Dean Herbert · 2023-03-05 22:00:14 +09:00
  77257398db
• Use manifest overlay and merger for intent query specs

  Co-authored-by: Susko3 <Susko3@protonmail.com>

  Bartłomiej Dach · 2023-03-05 13:17:46 +01:00
  d120638e68
• Add mailto scheme to intent queries
  Joseph Madamba · 2023-03-04 16:07:29 -08:00
  5d6ab5f465
• Fix external links not working on Android
  Joseph Madamba · 2023-03-04 13:35:34 -08:00
  92f94278c1
• Clear components sidebar unconditionally on every target change

  Fixes the working layer dropdown lingering after exiting from a
  skinnable screen to a non-skinnable one.

  Bartłomiej Dach · 2023-03-04 14:10:05 +01:00
  60cdd3c070
• Add failing test coverage for clearing sidebar contents
  Bartłomiej Dach · 2023-03-04 14:08:50 +01:00
  9d4bb2ecf7
• Show non-skinnable screen placeholder at higher level
  Bartłomiej Dach · 2023-03-04 13:49:10 +01:00
  d233f3a3ab
• Accept ISerialisableDrawableContainer directly in SkinBlueprintContainer

  An end result of #22674 is that `SkinBlueprintContainer`s are only ever
  created by supplying a `SkinComponentsContainer` to them. However,
  `SkinBlueprintContainer` still contained remnants of code that suggested
  it was designed to handle cases where more than the drawable supplied to
  it contained more than one `ISerialisableDrawableContainer`, or even
  zero.
  
  The zero path is totally dead right now (because every
  `SkinComponentsContainer` is *by necessity* an
  `ISerialisableDrawableContainer`), and the more-than-one path is dead
  *for now* (and potentially forever?). Therefore, just hard-couple
  `SkinBlueprintContainer` to receive a single target container.

  Bartłomiej Dach · 2023-03-04 13:33:21 +01:00
  49e298e304
• Move NonSkinnableScreenPlaceholder to outer scope
  Bartłomiej Dach · 2023-03-04 13:22:43 +01:00
  2f25fb4083
• Fix skin selection not clearing on exit to non-skinnable screen
  Bartłomiej Dach · 2023-03-04 13:18:34 +01:00
  15409b9c15
• Add failing test case
  Bartłomiej Dach · 2023-03-04 13:17:54 +01:00
  3dd3b5e77a
• Merge pull request #22776 from peppy/fix-mania-upscroll

  Fix upwards scroll direction not working with recent hold note display changes

  Bartłomiej Dach · 2023-03-03 21:37:51 +01:00
  866987d6e1
• Fix upwards scroll direction not working with recent hold note display changes
  Dean Herbert · 2023-03-03 18:03:06 +09:00
  36058b3da2
• Ensure TestBeatmapCarousel.Items only returns actually visible items (and in correct order)

  Turns out that items could be in an order that isn't the same as how
  things look on the carousel, so this change ensures that for testing
  purposes they are sorted by Y position.
  
  Also uses the `CarouselItem.Visible` flag to ensure that we don't have
  to wait for drawable fade transitions after a filter operation.

  Dean Herbert · 2023-03-03 17:18:34 +09:00
  a14dede036
• Add better coverage and more comments explaining the structure of test setup
  Dean Herbert · 2023-03-03 17:18:14 +09:00
  7a092ea995
• Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes

  From a user's perspective, changing a sort / order mode shouldn't filter
  away results, but we were doing this.
  
  In terms of UX expectations, in stable this kind of scenario would
  results in a group being added to the end of son select with "Not
  ranked" or "Unknown". I think we should aim to match this eventually.

  Dean Herbert · 2023-03-03 16:36:18 +09:00
  82293c0c86
• Merge pull request #22766 from Joehuu/fix-talking-with-text-overflow

  Fix "talking with" text overflowing when usernames are too long

  Dean Herbert · 2023-03-02 17:04:11 +09:00
  29be26b150
• Fix "talking with" text overflowing when usernames are too long
  Joseph Madamba · 2023-03-01 22:10:15 -08:00
  af540de69b
• Merge pull request #22743 from Joehuu/scroll-back-to-previous

  Add ability to scroll back to previous position after scrolling to top via button on overlays

  Dean Herbert · 2023-03-01 22:55:47 +09:00
  bd11d5d29a
• Merge pull request #22755 from EVAST9919/colour-info-framework

  Use `ColourInfo.Interpolate(Quad)` where possible

  Dean Herbert · 2023-03-01 12:05:54 +09:00
  21ebcdf5ed
• Merge pull request #22749 from peppy/rename-setting-source-tests

  Rename `SettingSource` tests to match attribute name

  Bartłomiej Dach · 2023-02-28 20:40:07 +01:00
  2023.301.0 24723ca873
• Use ColourInfo.Interpolate where possible
  Andrei Zavatski · 2023-02-28 18:47:27 +03:00
  31f58a33ac
• Merge pull request #22751 from peppy/update-framework

  Update framework

  Dean Herbert · 2023-02-28 16:40:18 +09:00
  3c45ab677a
• Update resources
  Dean Herbert · 2023-02-28 14:47:51 +09:00
  89e20a7962
• Update framework
  Dean Herbert · 2023-02-28 14:32:58 +09:00
  bd1460a8d5
• Rename SettingSource tests to match attribute name
  Dean Herbert · 2023-02-28 11:45:32 +09:00
  2615453b31
• Merge pull request #22748 from OpenSauce04/patch-1

  Fix grammar mistake in taiko relax mod description

  Bartłomiej Dach · 2023-02-27 20:17:14 +01:00
  ca47d55f10
• Merge pull request #22717 from peppy/skin-editor-depth-changing

  Add ability to send selected skin components to front or back

  Bartłomiej Dach · 2023-02-27 19:56:21 +01:00
  4e9d25957a
• Merge branch 'master' into skin-editor-depth-changing
  Bartłomiej Dach · 2023-02-27 19:24:53 +01:00
  92edb0f868
• Fixed grammar mistake in Taiko Relax mod description
  OpenSauce · 2023-02-27 16:06:33 +00:00
  8d747f2402
• Rename ScrollToTopButton to ScrollBackButton
  Joseph Madamba · 2023-02-26 14:39:34 -08:00
  fa710ae1b0
• Add ability to scroll back to previous position after scrolling to top via button on overlays
  Joseph Madamba · 2023-02-26 14:38:51 -08:00
  dc00905f8d
• Add expected behavior test for scroll back to previous position
  Joseph Madamba · 2023-02-26 14:30:46 -08:00
  d98d330da2
• Set better defaults for SkinBlueprint transforms
  Dean Herbert · 2023-02-23 21:10:15 +09:00
  dc3c1150b8
• Fix undo history not being batched correctly for depth change operations
  Dean Herbert · 2023-02-23 20:03:36 +09:00
  c48aceb055
• Merge pull request #22659 from peppy/fix-taiko-drum-nested-sample-detection

  Fix `GameplaySampleTriggerSource` not considering nested objects when determining the best sample to play

  Bartłomiej Dach · 2023-02-22 18:56:59 +01:00
  d679703fa2
• Merge pull request #22635 from peppy/use-overlays-container-more

  Use `Overlays` container rather than `KeyBindingInputManager` for flashlight

  Dean Herbert · 2023-02-22 18:30:21 +09:00
  a8c692a215
• Add test coverage of bring-to-front / send-to-back operations
  Dean Herbert · 2023-02-22 18:17:20 +09:00
  32a9c066df
• Fix weird nullability in TestSceneSkinEditor
  Dean Herbert · 2023-02-22 18:17:20 +09:00
  90ca635a17
• Add ability to send selected skin components to front or back
  Dean Herbert · 2023-02-22 18:17:20 +09:00
  16c8a392a1
• Update assertion to also check GameplayClockContainer's current time
  Dean Herbert · 2023-02-22 15:26:09 +09:00
  f61fbcf3fc
• Seek using GameplayClockContainer
  Dean Herbert · 2023-02-22 14:41:20 +09:00
  a511e64fa5