188 Commits

• Merge pull request #34371 from Hiviexd/verify/check-almost-concurrent-objects

  Account for almost concurrent case in concurrent objects check

  Bartłomiej Dach · 2025-07-28 15:03:26 +02:00
  34dfb2f9ea
• apply review
  Hivie · 2025-07-28 12:36:18 +01:00
  e781ad737b
• apply review
  Hivie · 2025-07-28 12:24:24 +01:00
  8466d64c69
• refactor issue templates to be more unified
  Hivie · 2025-07-24 13:25:15 +01:00
  c0ba8bc997
• Account for almost concurrent case in concurrent objects check
  Hivie · 2025-07-24 13:12:24 +01:00
  806d3160f8
• add verify check for inconsistent metadata
  Hivie · 2025-07-24 12:20:45 +01:00
  ee27be1868
• Merge pull request #34181 from Hiviexd/verify/check-lowest-diff-drain

  Add verify check for lowest diff drain/play time requirements

  Bartłomiej Dach · 2025-07-22 08:38:59 +02:00
  c408d60fbe
• oops
  Hivie · 2025-07-21 13:21:30 +01:00
  209a75c4df
• adjust wording
  Hivie · 2025-07-21 13:18:25 +01:00
  9bab2444ea
• fix one tiny miniscule english error i encountered by editing a beatmap
  Shin Morisawa · 2025-07-20 20:50:20 +09:00
  9572c2ba67
• address review

  - add TODO for refactoring verifier context ctor
  - call `GetPlayableBeatmap()` in verifier context ctor
  - filter diffs with relevant ruleset in check logic
  - fix tests

  Hivie · 2025-07-16 01:53:22 +01:00
  747bff1df9
• Minor cleanups

  Using `ChannelType.Unknown` instead of `0`, adds missing disposal.

  Dan Balasescu · 2025-07-14 15:10:04 +09:00
  8e0ed85ad2
• formatting
  Hivie · 2025-07-13 04:37:22 +01:00
  c36960a06e
• update audio quality check to account for ogg files
  Hivie · 2025-07-13 04:06:16 +01:00
  cf6641e241
• move audio format checks to reusable audio check utils
  Hivie · 2025-07-13 04:05:46 +01:00
  fccfdbf393
• Add verify check for lowest diff drain time requirement
  Hivie · 2025-07-13 02:00:50 +01:00
  ccf6d9c173
• Merge pull request #33259 from LumpBloom7/ruleset-agnostic-concurrent-check

  Make concurrent object check ruleset specific

  Bartłomiej Dach · 2025-05-26 14:33:41 +02:00
  f043a95dbd
• Make CheckConcurrentObjects.Run virtual

  And let implementers copy-paste common code.

  Derrick Timmermans · 2025-05-26 10:59:57 +02:00
  0495a03607
• Rename ConcurrentCondition to ConcurrencyPrecondition

  Better describes the intent of the method.

  Derrick Timmermans · 2025-05-26 10:59:17 +02:00
  257767b311
• Use null coalesce wherever possible

  Rider EAP being noisy about this one now.

  Dean Herbert · 2025-05-26 17:15:35 +09:00
  5450298468
• Remove redundant public specfications in interfaces

  Rider EAP being noisy about this now (smoogi will be happy :D).

  Dean Herbert · 2025-05-26 17:14:41 +09:00
  cb0592d711
• Make CheckConcurrentObject ruleset specific
  Derrick Timmermans · 2025-05-25 14:19:23 +02:00
  0065696248
• Simplify taglib interactions further
  Dean Herbert · 2025-04-28 15:52:31 +09:00
  40faa3fc99
• Add manual MIME type resolution for TagLib file creation
  Stedoss · 2025-04-28 13:38:38 +09:00
  c2efda20d7
• Reduce HitSampleInfo constants allocations
  Andrei Zavatski · 2025-01-07 00:36:58 +03:00
  e8dc09f5bc
• Centralise supported file extensions to one helper class

  As proposed in
  https://github.com/ppy/osu-server-beatmap-submission/pull/5#discussion_r1861680837.

  Bartłomiej Dach · 2024-11-29 08:42:45 +01:00
  110e4fbb30
• Fix typo
  Bartłomiej Dach · 2024-07-03 16:13:47 +02:00
  00a0058fc7
• Use one less regex
  Bartłomiej Dach · 2024-07-03 16:13:30 +02:00
  bcb479d4f7
• Adjust conditionals

  The fact that checking the unicode title was gated behind a
  `hasRomanisedTitle` guard was breaking my brain.

  Bartłomiej Dach · 2024-07-03 15:52:05 +02:00
  5696e85b68
• Compile regexes for speed
  Bartłomiej Dach · 2024-07-03 15:49:21 +02:00
  32b3d3d7df
• Address code quality issues
  Bartłomiej Dach · 2024-07-03 15:49:17 +02:00
  901fec65ef
• Make MarkerChecks and MarkerCheck class private
  Arthur Araujo · 2024-07-02 21:09:49 -03:00
  7143ff523f
• Fix explicit array type specification in MarkerChecks
  Arthur Araujo · 2024-07-02 20:55:52 -03:00
  7cdad20119
• Add verify checks for title markers
  Arthur Araujo · 2024-07-02 17:20:00 -03:00
  7cb3d7445c
• Implement automatic break period generation
  Bartłomiej Dach · 2024-06-19 10:22:06 +02:00
  4022a8b06c
• Do not attempt to pass files that don't look like audio to BASS
  Bartłomiej Dach · 2024-04-22 10:45:09 +02:00
  70a5288a68
• Use explicit reference equality check
  Bartłomiej Dach · 2024-04-22 10:27:30 +02:00
  ceeb9b0819
• Remove redundant array type specification
  Bartłomiej Dach · 2024-04-22 10:25:46 +02:00
  1bcf835d22
• Use bitwise to check hitsound formats
  Arthur Araujo · 2024-04-22 04:44:38 -03:00
  49563f4e5b
• Remove ChannelType from messages
  Arthur Araujo · 2024-04-19 08:01:23 -03:00
  92b85beff6
• Remove unsued import and add a blankline before yield break;
  Arthur Araujo · 2024-04-19 07:39:31 -03:00
  68e86b5105
• Use periods instead of semicolons

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Arthur Araujo · 2024-04-19 07:20:59 -03:00
  eac9dededf
• Fix test methods names
  Arthur Araujo · 2024-04-17 08:22:05 -03:00
  ac03856ebd
• Remove BassFlags.Prescan and free the decodeStream
  Arthur Araujo · 2024-04-17 08:14:19 -03:00
  8d94f8d995
• Deal with corrupt audio files

  This removes the corrupt file check from CheckTooShortAudioFiles and makes the audio formats checks deal with it instead to avoid redundant messages.

  Arthur Araujo · 2024-04-16 06:53:55 -03:00
  c32d99250f
• Add checks for audio formats
  Arthur Araujo · 2024-04-16 06:15:21 -03:00
  9ef27104ce
• Merge branch 'master' into verify-abnormal-difficulty-settings
  Bartłomiej Dach · 2024-03-26 11:13:16 +01:00
  b74f8dba41
• Refactor abstract check to reduce duplication
  Bartłomiej Dach · 2024-03-26 11:13:03 +01:00
  1866b4b6b1
• Fix formatting issue
  Arthur Araujo · 2024-03-23 23:28:55 -03:00
  8a05fecad5
• Add video resolution check
  Arthur Araujo · 2024-03-23 19:22:47 -03:00
  6fbe1a5b8d