74579 Commits

This Branch

This Branch

All Branches

• Fix missing disposal of Realm subscription
  Dan Balasescu · 2025-08-03 01:46:04 +09:00
  4e5dfb82ca
• Merge pull request #34450 from bdach/fix-song-select-dropping-sort-mode

  Ensure scores are re-fetched with correct criteria on re-entering song select

  Dean Herbert · 2025-08-02 02:05:47 +09:00
  98acd9ee11
• Merge pull request #34459 from peppy/collection-group-sane

  Add support for grouping beatmaps by collections

  Bartłomiej Dach · 2025-08-01 10:32:57 +02:00
  3875bd0cf6
• Merge branch 'master' into collection-group-sane
  Bartłomiej Dach · 2025-08-01 09:43:18 +02:00
  2298e891fc
• Merge pull request #34451 from peppy/fix-criteria-update-manage-collections

  Fix beatmap carousel refreshing when user selects "Manage Collections…" from dropdown

  Bartłomiej Dach · 2025-08-01 09:39:54 +02:00
  b2614103d7
• Move realm collection retrieval to exist beside beatmap retrieval for organisation
  Dean Herbert · 2025-08-01 16:27:07 +09:00
  2d748e24ec
• Add support for grouping beatmaps by collections

  Takes changes in https://github.com/ppy/osu/pull/34233 and removes *all*
  of the complexity.
  
  Supersedes and closes #34233.
  
  Contains same caveat that we can only display one beatmap once in the
  carousel; this will be addressed separately.

  Dean Herbert · 2025-08-01 16:23:26 +09:00
  c3396a93a6
• Merge pull request #34452 from diquoks/favourite-tooltip-state

  Add tooltip states for the `FavouriteButton` on SSV2

  Dean Herbert · 2025-08-01 13:40:21 +09:00
  94935fd34e
• Merge pull request #34432 from bdach/unified-beatmap-attribute-display

  Unify display logic of beatmap difficulty attributes across usages

  Dean Herbert · 2025-08-01 13:35:48 +09:00
  71644e4629
• Add tooltip states for the FavouriteButton on SSV2
  Denis Titovets · 2025-07-31 19:31:09 +03:00
  64332bccb1
• Fix beatmap carousel refreshing when user selects "Manage Collections" from dropdown

  Closes https://github.com/ppy/osu/issues/34434.

  Dean Herbert · 2025-07-31 22:23:08 +09:00
  b87fa13279
• Fix editor metadata section reload potentially confusing title and author

  Probably closes https://github.com/ppy/osu/issues/34449. I say probably
  because I couldn't break this myself without commenting out chunks of
  code that apply the metadata from the id3 tags, and the reporter of that
  issue did not provide mp3s to test with or a clear reproduction
  scenario. But chances are this is going to fix the problem anyhow.

  Bartłomiej Dach · 2025-07-31 10:58:43 +02:00
  d7a17d59e3
• Always fetch leaderboard with score sort mode in solo results

  This is borderline pedantic and mostly irrelevant but I think it makes
  some sense for a bit of extra safety. It definitely does not fix any
  bugs (that I'm aware of).

  Bartłomiej Dach · 2025-07-31 10:20:03 +02:00
  7a263efaa2
• Ensure scores are re-fetched with correct criteria on re-entering song select

  Closes https://github.com/ppy/osu/issues/34445.
  
  The primary issue is that song select is the only one that supports
  non-score sort mode, and therefore if any other component changes the
  sort mode in a way opaque to song select to score, then song select will
  lose the sort mode because it's using the global leaderboard manager's
  state which will contain scores sorted by total.
  
  Notably, the bug this is fixing requires specific circumstances. For
  instance, it is not enough to just *start gameplay* for the bug to
  manifest, because starting gameplay causes a working beatmap refetch:
  
  https://github.com/ppy/osu/blob/4b73afd1957a9161e2956fc4191c8114d9958372/osu.Game/Screens/SelectV2/SongSelect.cs#L456-L457
  
  which will trigger a *delayed schedule refetch* of the scores:
  
  https://github.com/ppy/osu/blob/d2d3d14f1572ff8fc68fd01ea43c2ef68b5882fa/osu.Game/Screens/SelectV2/BeatmapLeaderboardWedge.cs#L235-L253
  
  and because the refetch is thusly delayed, there's a very high chance it
  *will not run before the screen is resumed* because the wedge will not
  have its scheduler run until that point in time.
  
  This conundrum is also because there is no test coverage for this,
  because the above makes test coverage setup rather annoying.

  Bartłomiej Dach · 2025-07-31 10:09:07 +02:00
  d176ce7916
• Fix test
  Bartłomiej Dach · 2025-07-31 08:47:23 +02:00
  cf41a04a2e
• Merge pull request #34448 from nekodex/ssv2-leaderboard-sfx-fix
  Dean Herbert · 2025-07-31 14:37:37 +09:00
  24e1456d4f
• Fix leaderboard SFX delegates not being cleared in some cases where scores are hidden
  Jamie Taylor · 2025-07-31 13:30:27 +09:00
  d2d3d14f15
• Fix glitchy display of count statistics when changing rulesets

  This is due to the global betamap becoming `Default` momentarily. Rather
  than react to this by clearing the display in a single frame, let's
  transition so it's mostly hidden.

  Dean Herbert · 2025-07-31 01:19:55 +09:00
  7abe4fc93c
• Fix glitchy attribute display when switching between rulesets at song select
  Dean Herbert · 2025-07-31 01:18:59 +09:00
  e4e62c16d5
• Merge pull request #34346 from bdach/user-tag-population

  Backpopulate user tag data using `online.db`

  Dean Herbert · 2025-07-30 22:24:19 +09:00
  094f703c02
• Fix test
  Bartłomiej Dach · 2025-07-30 15:01:58 +02:00
  34292a75ee
• Fix code quality
  Bartłomiej Dach · 2025-07-30 15:00:55 +02:00
  640fe5752d
• Merge pull request #34430 from peppy/adjust-wedge-effect-stereo-shift

  Adjust stereo shift effects for UI sounds to be less extreme

  Dean Herbert · 2025-07-30 21:34:47 +09:00
  b7278495a4
• Update inline comment
  Bartłomiej Dach · 2025-07-30 14:27:35 +02:00
  d4794dbc9a
• Apply code review suggestion
  Bartłomiej Dach · 2025-07-30 14:20:13 +02:00
  d49c924709
• Rename property to reduce confusion

  Caused an actual bug in one of the replaced usages.

  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  cd2c5075df
• Fix test
  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  1319a5499b
• Migrate other usages of GetAdjustedDisplayDifficulty() to use GetBeatmapAttributesForDisplay() instead

  This ensures parity between all beatmap attribute displays that used the
  former method.

  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  a952e3704e
• Refactor beatmap attribute methods

  This change refactors `GetAdjustedDisplayDifficulty()` and
  `GetBeatmapAttributesToDisplay()` in two ways:
  
  - Both methods now accept `IBeatmapInfo` instead of
    `IBeatmapDifficultyInfo`. This is done in order to make mania key
    count display to work, wherein `IBeatmapDifficultyInfo` is not enough
    to calculate the final key count.
  
  - `GetAdjustedDisplayDifficulty()` now applies all
    `IApplicableToDifficulty` mods itself. I did this after noticing that
    every real consumer of this method had to do that themselves for very
    little reason.

  Bartłomiej Dach · 2025-07-30 14:06:34 +02:00
  7c4dd812b6
• Use new ruleset method in song select v2
  Bartłomiej Dach · 2025-07-30 13:43:03 +02:00
  0c7dcfdba3
• Add new ruleset method responsible for displaying beatmap attributes consistently everywhere

  The intention is to use this in every place that wishes to display
  beatmap attributes (and also remove a bunch of local hack-arounds for
  mania, etc.)

  Bartłomiej Dach · 2025-07-30 13:41:19 +02:00
  e2a454ae00
• Adjust stereo shift effects for UI sounds to be less extreme
  Dean Herbert · 2025-07-30 19:35:26 +09:00
  0b11953b24
• Merge pull request #34427 from peppy/fix-associations-trigger-update

  Avoid triggering a velopack update when handling associations or other custom arguments

  Bartłomiej Dach · 2025-07-30 09:49:58 +02:00
  30ba4b9ef7
• Change new mod name to title case
  Dean Herbert · 2025-07-30 15:54:13 +09:00
  31b5c9c2b8
• Avoid triggering a velopack update when handling associations or other custom arguments

  Closes #34330.

  Dean Herbert · 2025-07-30 14:50:41 +09:00
  8822b32d32
• Only perform user tag backpopulation after the local metadata cache updates
  Bartłomiej Dach · 2025-07-29 11:50:41 +02:00
  8307947a10
• Merge pull request #33688 from CloneWith/feature/catch-mod-h2w

  Add `Moving Fast` mod to osu!catch

  Dean Herbert · 2025-07-29 18:29:15 +09:00
  2025.729.0-tachyon 3dced34775
• Merge branch 'master' into feature/catch-mod-h2w
  Dean Herbert · 2025-07-29 17:59:13 +09:00
  049748bd69
• Fix localisation oversight
  Dean Herbert · 2025-07-29 17:58:53 +09:00
  3eb34d5de4
• Fix test failure due to stupid reasons

  I'm actually not sure why not resetting this fails, but I don't want to
  spend the time investigating either.

  Dean Herbert · 2025-07-29 17:51:15 +09:00
  54a7f7ee71
• Merge pull request #34418 from peppy/bbcolour

  Add divisor colour for 5,7,9 snaps

  Bartłomiej Dach · 2025-07-29 10:45:53 +02:00
  fb9acb7cd8
• Fix test method not being named correctly
  Dean Herbert · 2025-07-29 17:36:55 +09:00
  67a98292eb
• Rename mod and move back to fun
  Dean Herbert · 2025-07-29 17:11:41 +09:00
  92a5399b4a
• Merge branch 'master' into feature/catch-mod-h2w
  Dean Herbert · 2025-07-29 17:00:26 +09:00
  40f06af357
• Fix missed inspection
  Dean Herbert · 2025-07-29 16:48:39 +09:00
  584362efc3
• Merge pull request #33544 from NotStirred/master

  Always allow a map's user-tags to be read

  Dean Herbert · 2025-07-29 16:48:15 +09:00
  a967912ef5
• Add test coverage of read-only scenario
  Dean Herbert · 2025-07-29 16:46:07 +09:00
  988f1a4e76
• Merge branch 'master' into NotStirred/master
  Dean Herbert · 2025-07-29 16:36:37 +09:00
  2dde5b1eaf
• Merge pull request #34001 from frenzibyte/better-chat-notifications

  Display user avatar and content in chat notifications, also display avatar in friend presence notifications

  Dean Herbert · 2025-07-29 16:15:19 +09:00
  56af047058
• Adjust truncation and formatting to feel better
  Dean Herbert · 2025-07-29 15:41:43 +09:00
  898e051501