1
0
mirror of https://github.com/ppy/osu.git synced 2026-05-18 19:50:31 +08:00

Always fetch leaderboard with score sort mode in solo results

This is borderline pedantic and mostly irrelevant but I think it makes
some sense for a bit of extra safety. It definitely does not fix any
bugs (that I'm aware of).
This commit is contained in:
Bartłomiej Dach
2025-07-31 10:10:14 +02:00
Unverified
parent d176ce7916
commit 7a263efaa2
@@ -41,12 +41,12 @@ namespace osu.Game.Screens.Ranking
{
Debug.Assert(Score != null);
// sort mode intentionally omitted to default to score - results screen only supports sorting by score, so don't pass any other to avoid confusion
var criteria = new LeaderboardCriteria(
Score.BeatmapInfo!,
Score.Ruleset,
leaderboardManager.CurrentCriteria?.Scope ?? BeatmapLeaderboardScope.Global,
leaderboardManager.CurrentCriteria?.ExactMods,
leaderboardManager.CurrentCriteria?.Sorting ?? LeaderboardSortMode.Score
leaderboardManager.CurrentCriteria?.ExactMods
);
var requestTaskSource = new TaskCompletionSource<LeaderboardScores>();
globalScores.BindValueChanged(_ =>